[Differential] [Request, 15 lines] D3288: Add graphics reset to the OpenGL compositing safety checks

2016-11-06 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY If a graphics reset happens during compositing startup it is possible that the next try to

[Differential] [Commented On] D3262: Get .desktop file name for launcher URL and activities string from KWindowInfo.

2016-11-06 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > xwindowtasksmodel.cpp:490-499 > +if (!desktopFile.isEmpty()) { > +KService::Ptr service = KService::serviceByStorageId(desktopFile); > + > +if (service) { > +return QUrl::fromLocalFile(service->entryPath()); > +

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

2016-11-06 Thread mvourlakos (Michail Vourlakos)
mvourlakos added a comment. In https://phabricator.kde.org/D3282#61060, @broulik wrote: > I think NoBackground should just do this - this would also be consistent with Plasma Dialog where disabling the standard background turns off everything. do you know a way for panelview to

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

2016-11-06 Thread broulik (Kai Uwe Broulik)
broulik added a comment. I think NoBackground should just do this - this would also be consistent with Plasma Dialog where disabling the standard background turns off everything. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3282 EMAIL

[Differential] [Request, 2 lines] D3283: Hide Background for Panel when backgroundHints are used

2016-11-06 Thread mvourlakos (Michail Vourlakos)
mvourlakos created this revision. mvourlakos added reviewers: Plasma, davidedmundson. mvourlakos added a subscriber: Plasma. mvourlakos set the repository for this revision to rPLASMADESKTOP Plasma Desktop. mvourlakos added a project: Plasma. Restricted Application added a subscriber:

Re: Breakout: System Settings Improvements

2016-11-06 Thread Alessandro Longo
Il 17-10-2016 18:47 Jonathan Riddell ha scritto: We had a discussion on System Settings at the meeting today which merited its own thread: * system settings direction and improvements (alex-l, ...) the most complained part for me is System Settings: newbies don't like it I like some

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

2016-11-06 Thread mvourlakos (Michail Vourlakos)
mvourlakos added a comment. with that variable I can also disable the shadows for the panel by adding in panelview.cpp, . void PanelView::updateEnabledBorders() { Plasma::FrameSvg::EnabledBorders borders = Plasma::FrameSvg::AllBorders; if (!m_effects) {

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

2016-11-06 Thread mvourlakos (Michail Vourlakos)
mvourlakos added a comment. I just want to open the discussion if we can change things in panelview ... I have in my mind also a variable to disable borders(shadows) when a panel has set NoBackground as backgroundHint REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Request, 46 lines] D3282: Disable / Enable Effects for a Panel

2016-11-06 Thread mvourlakos (Michail Vourlakos)
mvourlakos created this revision. mvourlakos added reviewers: Plasma, davidedmundson. mvourlakos set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. mvourlakos added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch

[Differential] [Accepted] D3231: [Lock Screen] Show "Switch User" button only if allowed

2016-11-06 Thread subdiff (Roman Gilg)
subdiff accepted this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3231 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart, subdiff Cc: davidedmundson, plasma-devel, lesliezhai,

Re: Review Request 129315: Don't install plasmoid desktop files as services

2016-11-06 Thread David Faure
> On Nov. 3, 2016, 12:53 p.m., Marco Martin wrote: > > I'm in favor of this, let's wait to 5.29 tough 5.28 RC is tagged, you can now push commits for 5.29. - David --- This is an automatically generated e-mail. To reply, visit:

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-06 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta added a comment. In https://phabricator.kde.org/D3210#60962, @colomar wrote: > In https://phabricator.kde.org/D3210#60602, @mart wrote: > > > > > > in this latest version there are 2 checkboxes: "show scrollbar only on mouse over" and "small scrollbar" which

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-06 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D3210#60602, @mart wrote: > in this latest version there are 2 checkboxes: "show scrollbar only on mouse over" and "small scrollbar" which both defautls to true Why do we need both? What happens if one checks the first

Re: Review Request 129276: Make sure we're looking both for json and desktop metadata

2016-11-06 Thread Michael Stemle
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129276/#review100625 --- shell/scripting/scriptengine_v1.cpp (line 527)