[Differential] [Updated] D3302: RFC: [Task Manager] Indicate applications playing audio

hein added a comment. Love this (well I suggested it :) and would be a nice first for Plasma Desktop. Code actually looks pretty good. INLINE COMMENTS > Task.qml:288 > + > +/*width: (label.visible ? height > +: parent.width - icon.adjustMargin(true, parent.width,

[Differential] [Changed Subscribers] D3301: WIP: [libtaskmanager] Expose process ID of application

hein added inline comments. INLINE COMMENTS > graesslin wrote in xwindowtasksmodel.cpp:432 > I would prefer if we expose it through KWindowInfo. Creating an additional > NETWinInfo causes an additional x-server roundtrip here. > > Also a word of warning: just because you have a pid, does not

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

graesslin added a comment. In https://phabricator.kde.org/D3240#61517, @ivan wrote: > I've just had a crash in Cantata (on launch) with this patch. The cleanup() is called which deletes the _shadowHelper which is later used in polish(). @ivan can you run cantata through gdb and

[Differential] [Abandoned] D3288: Add graphics reset to the OpenGL compositing safety checks

graesslin abandoned this revision. graesslin added a comment. User tested the change and having the thread protection from 5.8.3 in place is sufficient to detect the freeze completely without this change. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3288 EMAIL

Re: Review Request 129329: Fix SVG icon ID prefix

> On 十一月 7, 2016, 4:28 p.m., Marco Martin wrote: > > Thanks for taking care of it! > > Aleix Pol Gonzalez wrote: > @Yunhe, do you have pushing rights or should we push it? No, I do not. Maybe you can push it. - Yunhe --- This is

Re: Review Request 129329: Fix SVG icon ID prefix

> On Nov. 7, 2016, 5:28 p.m., Marco Martin wrote: > > Thanks for taking care of it! @Yunhe, do you have pushing rights or should we push it? - Aleix --- This is an automatically generated e-mail. To reply, visit:

[Differential] [Request, 46 lines] D3306: Convert virtual backend to per screen rendering

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Output scaling can't ever work on a single buffer; especially if they're different scales

[Differential] [Commented On] D3210: make scrollbar size configurable

colomar added a comment. Whoa okay, that is complex... Given that I failed to understand what the proposed checkboxes were supposed to mean, I fear it will be the same for users. Therefore maybe not gibing the option at all is indeed the better solution, and your suggestion to turn the

[Differential] [Commented On] D3268: Applet: Show device icons and active port name

colomar added a comment. Great feature! I just fear that the naming scheme might make it look like the device name is the name for the port, like "A microphone called Audio Adapter". Maybe naming Port (device name) would make it more clear? REPOSITORY rPLASMAPA Plasma Audio Volume

[Differential] [Requested Changes To] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

ivan requested changes to this revision. ivan added a reviewer: ivan. This revision now requires changes to proceed. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3240 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin,

[Differential] [Reopened] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

ivan reopened this revision. ivan added a comment. This revision is now accepted and ready to land. I've just had a crash in Cantata (on launch) with this patch. The cleanup() is called which deletes the _shadowHelper which is later used in polish(). REPOSITORY rBREEZE Breeze REVISION

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

https://bugs.kde.org/show_bug.cgi?id=371276 somnium changed: What|Removed |Added Resolution|WONTFIX |DOWNSTREAM -- You are

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

https://bugs.kde.org/show_bug.cgi?id=371276 somnium changed: What|Removed |Added Resolution|DOWNSTREAM |WONTFIX -- You are receiving

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

https://bugs.kde.org/show_bug.cgi?id=371276 somnium changed: What|Removed |Added Resolution|WAITINGFORINFO |WONTFIX

[Differential] [Commented On] D3210: make scrollbar size configurable

hpereiradacosta added a comment. Hi Colomar, no usability problem no. (at worst some miswording, and misunderstanding) In https://phabricator.kde.org/D3210#61496, @colomar wrote: > In https://phabricator.kde.org/D3210#60963, @hpereiradacosta wrote: > > > > > > > >

[Differential] [Commented On] D3302: RFC: [Task Manager] Indicate applications playing audio

broulik added a comment. Note that the mute option is immediately available in the context menu and stays there even if the playback has finished (if the application keeps the stream open, e.g. a player that is just paused). The three seconds delay only applies to the icon but it could

[Differential] [Commented On] D3302: RFC: [Task Manager] Indicate applications playing audio

colomar added a comment. Very useful patch! The only thing I'm unsure of is the three-second delay. It might be a bit too long if some annoying applicaiton suddenly starts blaring sound and the option to mute it easily only becomes available after three seconds of torture. I think two

[Differential] [Commented On] D3210: make scrollbar size configurable

colomar added a comment. In https://phabricator.kde.org/D3210#60963, @hpereiradacosta wrote: > >> Why do we need both? What happens if one checks the first but not the second? > > You get a large scrollbar, visible only on mouse-over So that means it would be

[Differential] [Updated, 113 lines] D3159: Set wayland output scale

davidedmundson updated this revision to Diff 7989. davidedmundson marked 4 inline comments as done. davidedmundson added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Squash with input scaling - Squash with client size surface normal commit - hopefully

Re: Review Request 128626: silence contentHash deprecation warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128626/ --- (Updated Nov. 7, 2016, 4:30 p.m.) Status -- This change has been

Re: Review Request 129329: Fix SVG icon ID prefix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129329/#review100687 --- Ship it! Thanks for taking care of it! - Marco Martin

Re: Review Request 128626: silence contentHash deprecation warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128626/#review100686 --- Ship it! Ship It! - Marco Martin On Aug. 8, 2016,

[Differential] [Updated] D3302: RFC: [Task Manager] Indicate applications playing audio

broulik updated the test plan for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3302 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, hein, drosca Cc: plasma-devel,

[Differential] [Updated] D3302: RFC: [Task Manager] Indicate applications playing audio

broulik updated the summary for this revision. broulik updated the test plan for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3302 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Updated] D3300: [Stream] Expose "corked" property

broulik added a dependent revision: D3302: RFC: [Task Manager] Indicate applications playing audio. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3300 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 166 lines] D3302: RFC: [Task Manager] Indicate applications playing audio

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, hein, drosca. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added dependencies: D3301: WIP: [libtaskmanager] Expose process ID of application, D3300: [Stream] Expose "corked"

[Differential] [Request, 18 lines] D3301: WIP: [libtaskmanager] Expose process ID of application

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Works on X11 but not yet for

[Differential] [Request, 14 lines] D3300: [Stream] Expose "corked" property

broulik created this revision. broulik added reviewers: Plasma, drosca. broulik set the repository for this revision to rPLASMAPA Plasma Audio Volume Applet. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It denotes

[Differential] [Updated, 135 lines] D3290: Introduce a VirtualDesktop class

graesslin updated this revision to Diff 7986. graesslin added a comment. Update docs REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3290?vs=7955=7986 BRANCH virtual-desktop-refactoring REVISION DETAIL https://phabricator.kde.org/D3290 AFFECTED FILES

[Differential] [Commented On] D3249: Use our tooling for installing plasmoids

apol added a comment. @lbeltrame, see https://phabricator.kde.org/D3299 REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3249 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc: lbeltrame,

[Differential] [Updated] D3290: Introduce a VirtualDesktop class

graesslin marked an inline comment as done. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, hein Cc: hein, plasma-devel, kwin, lesliezhai,

[Differential] [Commented On] D3159: Set wayland output scale

davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in scene_qpainter.cpp:311-313 > ah so that's basically the "scale everything up" if output has a scale, but > not yet the "surface has a scale of 2"? What this code is doing is painting in output normalised space; no

[Differential] [Request, 8 lines] D3298: [libkwineffects] Delete EffectsHandler::deleteRootProperty

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The method is not used by any Effect and is X11 specific, thus

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

mvourlakos added a comment. In https://phabricator.kde.org/D3282#61326, @mart wrote: > even if not changing anything about the architecture, I think if even if not 100% technically correct, the api would sound better with the effects property actually replaced with backgroundhits like

[Differential] [Request, 15 lines] D3297: [libkwineffects] Remove EffectsHandler::registerPropertyType

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY There is no effect using this method. As it's X11 specific it

[Differential] [Commented On] D3283: Hide Background for Panel when backgroundHints are used

mvourlakos added a comment. In https://phabricator.kde.org/D3283#61170, @davidedmundson wrote: > Cool, but doesn't this also need the binding mentioned in https://phabricator.kde.org/D3282 ? yes it does, I can update the patch but I am waiting the discussion in

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

mvourlakos added a comment. a transparent Now Dock panel with Blur Effect enabled for Plasma F497972: transparent panel and blur effect.jpg REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3282 EMAIL

[Differential] [Updated, 110 lines] D3282: Disable / Enable Effects for a Panel

mvourlakos updated the summary for this revision. mvourlakos updated this revision to Diff 7976. mvourlakos added a comment. clean up a bit and comment more... - even though on startup the shadows are not shown correctly with disabled effects, when changing the plasma theme they are

[Differential] [Request, 33 lines] D3296: [effects] Improve interaction between Glide and SlidingPopups effect

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The glide effect tried to not animate any window the SlidingPopups

[Differential] [Commented On] D3292: Revamp Wayland application identification; align Wayland and X11 models

graesslin added inline comments. INLINE COMMENTS > waylandtasksmodel.cpp:233-241 > +if (!appDataCache.contains(window)) { > +const AppData = appDataFromAppId(window->appId()); > + > +appDataCache.insert(window, data); > + > +return data; > +} here you are

[Differential] [Request, 68 lines] D3294: [kioslave/desktop] Port away from kdelibs4support

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY All the targets now builds without linking to kdelibs4support TEST PLAN - desktop://

[Differential] [Commented On] D3159: Set wayland output scale

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in scene_qpainter.cpp:311-313 > I'm harnassing QPainter's internal scaling. > > The old code: > > painter->drawImage(toplevel->clientPos(), >pixmap->image(), >

[Differential] [Request, 147 lines] D3295: [server] Reduce overhead of pointersForSurface

graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY In SeatInterface we need to get all PointerInterfaces related to a given Surface

[Differential] [Updated] D3294: [kioslave/desktop] Port away from kdelibs4support

elvisangelaccio updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3294 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: plasma-devel, lesliezhai,

[Differential] [Request, 12 lines] D3293: [kioslave/applications] Port away from kdelibs4support

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The slave now builds without linking to kdelibs4support TEST PLAN applications:// still

[Differential] [Accepted] D3062: Hide "automatic login" button in UserAccounts since is does absolutely nothing

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. updates on that? could this just go in? REPOSITORY rUSERMANAGER User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D3062 EMAIL

[Differential] [Commented On] D3051: [applets/notification] Add nullptr check

mart added a comment. any news on this? i don't see issues with the patch, even if obviously kindof a workaround REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3051 EMAIL PREFERENCES

[Differential] [Abandoned] D3057: Fix drawing QtQuickControls ComboBox popups

drosca abandoned this revision. REPOSITORY rOXYGEN Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D3057 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, broulik, hpereiradacosta Cc: mart, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Accepted] D3033: Cancel the Switch-user-overlay by clicking on empty space

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3033 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D3057: Fix drawing QtQuickControls ComboBox popups

hpereiradacosta added a comment. In https://phabricator.kde.org/D3057#61334, @mart wrote: > any news on this? nope unfortunately busy with other stuff (but the patch is not satisfactory: just copying code from breeze is not the solution, most of the code should already be

[Differential] [Commented On] D3057: Fix drawing QtQuickControls ComboBox popups

mart added a comment. any news on this? REPOSITORY rOXYGEN Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D3057 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, broulik, hpereiradacosta Cc: mart, plasma-devel, lesliezhai,

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

mart added a comment. In https://phabricator.kde.org/D3282#61310, @davidedmundson wrote: > From a conusmer POV it'll be exactly the same. > > Code wise, it's much more awkward to do the first one as it needs to go through the property(_graphicsObject)() malarky. yeah, i kinda

[Differential] [Request, 137 lines] D3292: Revamp Wayland application identification; align Wayland and X11 models

hein created this revision. hein added reviewers: Plasma, graesslin, broulik. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY This adds support for app ids which are absolute paths to .desktop files to WaylandTasksModel, matching the

[Differential] [Accepted] D3269: kcm_keyboard: Change text of config action in tray icon to Configure Layouts

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3269 EMAIL PREFERENCES

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

davidedmundson added a comment. > so not having a background would remove the frame background *and* disable the effects That is the proposal here also. The difference is whether Panel.qml connects to AppletInterface *and* PanelView connects to AppletInterface. Or Panel.qml

[Differential] [Commented On] D3283: Hide Background for Panel when backgroundHints are used

mart added a comment. +1, tough https://phabricator.kde.org/D3282 should use containment.backgroundHints as well REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3283 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3282: Disable / Enable Effects for a Panel

mart added a comment. i prefer this to be based onto containment.backgroundhits as well, i don't like explicit api for this at all. so not having a background would remove the frame background *and* disable the effects REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Closed] D3264: [libinput] Load/store device configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINde89176cd2a9: [libinput] Load/store device configuration (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3264?vs=7906=7971 REVISION DETAIL

[Differential] [Closed] D3174: Forward pointer gestures to Wayland server

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINb6af777230ab: Forward pointer gestures to Wayland server (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3174?vs=7689=7970 REVISION DETAIL

Re: Review Request 129321: Don't redeclare signal and then not use it anyway

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129321/ --- (Updated Nov. 7, 2016, 12:45 p.m.) Status -- This change has been

Review Request 129358: Return SurfaceInterface::size in surface normal co-ordinates

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129358/ --- Review request for Plasma. Repository: kwayland Description ---

[Differential] [Closed] D3169: Implementation of PointerGestures protocol

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND75acb783fa09: Implementation of PointerGestures protocol (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3169?vs=7686=7969#toc REPOSITORY rKWAYLAND KWayland

[Differential] [Updated] D3169: Implementation of PointerGestures protocol

graesslin marked 2 inline comments as done. REPOSITORY rKWAYLAND KWayland BRANCH pointer-gestures REVISION DETAIL https://phabricator.kde.org/D3169 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas Cc: sebas,

[Differential] [Commented On] D3159: Set wayland output scale

davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in scene_qpainter.cpp:311-313 > I don't understand how the scaling comes in here? I'm harnassing QPainter's internal scaling. The old code: painter->drawImage(toplevel->clientPos(),

[Differential] [Accepted] D3174: Forward pointer gestures to Wayland server

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH pointer-gestures REVISION DETAIL https://phabricator.kde.org/D3174 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D3211: Ensure that all Effects honour the grab roles correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINfb69b791a16f: Ensure that all Effects honour the grab roles correctly (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3211?vs=7962=7968

[Differential] [Accepted] D3169: Implementation of PointerGestures protocol

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH pointer-gestures REVISION DETAIL https://phabricator.kde.org/D3169 EMAIL PREFERENCES

[Differential] [Commented On] D3169: Implementation of PointerGestures protocol

sebas added a comment. looks good aside from some minor doc polishing INLINE COMMENTS > pointergestures.h:165 > + * A gesture consists of three stages: begin, update (optional) and end. > + * There cannot be multiple simultaneous pinch or swipe gestures on a > + * same pointer/seat, how

[Differential] [Commented On] D3210: make scrollbar size configurable

mart added a comment. In https://phabricator.kde.org/D3210#60963, @hpereiradacosta wrote: > Which is why I think "no" option would actually be better. > In other word, either you have 2 checkboxes that cover all four possible combinations, or you start to make arbitrary (design based)

Re: Minutes Monday Plasma Meeting

Also, please add yourselves to the wiki page for the Plasma sprint: ‎https://community.kde.org/Plasma/Affenfels There's no sprints.kde.org page anymore, requesting reimbursement happens on reimbursements.kde.org linked on the wiki page

Minutes Monday Plasma Meeting

Minutes from today's noon meet. -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 7-11-2016 mgraesslin, Sho, notmart, kbroulik, bshah, d_ed, sebas mgraesslin: Merged changes: * Don't snap against auto-hiding panels (D3225) Diff 3225 "Don't snap to auto-hidden panels"

[Differential] [Updated, 106 lines] D3159: Set wayland output scale

davidedmundson updated this revision to Diff 7966. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. WIP: high DPI scaling support in kwin. Surface events are all normalised by surface_scale Output is normalised to output_scale From

[Differential] [Accepted] D3211: Ensure that all Effects honour the grab roles correctly

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH window-grab-add-close-honored-5.8 REVISION DETAIL https://phabricator.kde.org/D3211 EMAIL PREFERENCES

[Differential] [Closed] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

This revision was automatically updated to reflect the committed changes. Closed by commit rBREEZEa0433d089aa9: [kstyle] Implement application unpolish to delete ShadowHelper (authored by graesslin). REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3239: [kstyle] Delay init of Wayland setup till next event cycle

This revision was automatically updated to reflect the committed changes. Closed by commit rBREEZE088c7672981b: [kstyle] Delay init of Wayland setup till next event cycle (authored by graesslin). REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE

[Differential] [Updated, 99 lines] D3211: Ensure that all Effects honour the grab roles correctly

graesslin updated this revision to Diff 7962. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. - 5.8.4 - corrected docs REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3211?vs=7767=7962 BRANCH

[Differential] [Closed] D3121: Create KSelectionOwner in StartupFeedbackEffect only on X11

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN288cf06b90a2: Create KSelectionOwner in StartupFeedbackEffect only on X11 (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3121?vs=7563=7960

[Differential] [Closed] D3118: [effects] Support capture cursor image in Screenshot effect

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN8c163f2b935c: [effects] Support capture cursor image in Screenshot effect (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3118?vs=7559=7961

[Differential] [Closed] D3215: Simplify the window title passed in from the window system

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN2a155925719f: Simplify the window title passed in from the window system (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3215?vs=7782=7957

[Differential] [Closed] D3228: [helpers/killer] Force to platform XCB

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf3325a1cb801: [helpers/killer] Force to platform XCB (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3228?vs=7830=7958 REVISION DETAIL

[Differential] [Closed] D3241: Unpolish QStyle on QApp prior to destroying internal Wayland connection

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINee7da425cefc: Unpolish QStyle on QApp prior to destroying internal Wayland connection (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3262: Get .desktop file name for launcher URL and activities string from KWindowInfo.

This revision was automatically updated to reflect the committed changes. hein marked an inline comment as done. Closed by commit rPLASMAWORKSPACEbbbce3a55e01: Get .desktop file name for launcher URL and activities string from KWindowInfo. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Commented On] D3288: Add graphics reset to the OpenGL compositing safety checks

graesslin added a comment. In https://phabricator.kde.org/D3288#61183, @hein wrote: > Would it make sense to increase the number of test frames right now, if we're uncertain about whether there's enough? What's the trade-of there? no, the test frames have a real cost, so we want

[Differential] [Updated] D3262: Get .desktop file name for launcher URL and activities string from KWindowInfo.

hein marked an inline comment as done. hein added inline comments. INLINE COMMENTS > graesslin wrote in xwindowtasksmodel.cpp:490-499 > In KWin we had needed to add the .desktop - this is just passing on > experience. Do with this experience what you want. For my part I don't trust > our

[Differential] [Accepted] D3288: Add graphics reset to the OpenGL compositing safety checks

hein accepted this revision. hein added a reviewer: hein. hein added a comment. This revision is now accepted and ready to land. Aye, thx. REPOSITORY rKWIN KWin BRANCH safety-check-graphics-reset-5.8 REVISION DETAIL https://phabricator.kde.org/D3288 EMAIL PREFERENCES

[Differential] [Commented On] D3211: Ensure that all Effects honour the grab roles correctly

graesslin added inline comments. INLINE COMMENTS > broulik wrote in kwineffects.h:1551 > 5.8.4 I'll update that prior to pushing. If the change would have been reviewed when I uploaded it, it would have been correct. > hein wrote in kwineffects.h:2036 > The code in setData() always emits

[Differential] [Commented On] D3288: Add graphics reset to the OpenGL compositing safety checks

graesslin added a comment. In https://phabricator.kde.org/D3288#61180, @davidedmundson wrote: > This is now replaced by https://phabricator.kde.org/rKWIN19147f5f85bd87a1fedb460939dfdcef76ed7242 by antlarr err no, that is building up on top of that change. REPOSITORY rKWIN

[Differential] [Requested Changes To] D3290: Introduce a VirtualDesktop class

hein requested changes to this revision. hein added a reviewer: hein. hein added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > virtualdesktops.h:351 > **/ > -void handleDesktopsRemoved(uint previousCount); > +void handleDesktopsRemoved(uint

[Differential] [Commented On] D3262: Get .desktop file name for launcher URL and activities string from KWindowInfo.

graesslin added inline comments. INLINE COMMENTS > hein wrote in xwindowtasksmodel.cpp:490-499 > But that seems sensible. The only time the app should set the prop to > something that doesn't end with .desktop, it would be a "system menu id" > related to a .desktop file that KService can

[Differential] [Request, 134 lines] D3290: Introduce a VirtualDesktop class

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This is the first change for a larger virtual desktop refactoring.

[Differential] [Closed] D3231: [Lock Screen] Show "Switch User" button only if allowed

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE15af622ef333: [Lock Screen] Show "Switch User" button only if allowed (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Changed Subscribers] D3211: Ensure that all Effects honour the grab roles correctly

hein added inline comments. INLINE COMMENTS > kwineffects.h:2036 > + * > + * When the value changes the signal EffectsHandler::windowDataChanged > is emitted. > + * @see EffectsHandler::windowDataChanged The code in setData() always emits though, not just on a value change?

[Differential] [Commented On] D3211: Ensure that all Effects honour the grab roles correctly

broulik added inline comments. INLINE COMMENTS > kwineffects.h:1551 > + * @see EffectWindow::data > + * @since 5.8.3 > + **/ 5.8.4 REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3211 EMAIL PREFERENCES

[Differential] [Commented On] D2894: Start KDE Cleanups

davidedmundson added a comment. Done thanks REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2894 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: wbauer, mart, broulik,

[Differential] [Accepted] D3118: [effects] Support capture cursor image in Screenshot effect

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH screenshot-fullscreen-cursor REVISION DETAIL https://phabricator.kde.org/D3118 EMAIL PREFERENCES

Re: Review Request 129315: Don't install plasmoid desktop files as services

> On Nov. 3, 2016, 12:53 p.m., Marco Martin wrote: > > I'm in favor of this, let's wait to 5.29 tough > > David Faure wrote: > 5.28 RC is tagged, you can now push commits for 5.29. thanks! - Marco --- This is an automatically

Re: Review Request 129315: Don't install plasmoid desktop files as services

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/#review100678 --- Ship it! Ship It! - Marco Martin On Nov. 3, 2016,

[Differential] [Accepted] D3241: Unpolish QStyle on QApp prior to destroying internal Wayland connection

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH style-unpolish-5.8 REVISION DETAIL https://phabricator.kde.org/D3241 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D3264: [libinput] Load/store device configuration

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH libinput-device-load-config REVISION DETAIL https://phabricator.kde.org/D3264 EMAIL PREFERENCES

[Differential] [Commented On] D3288: Add graphics reset to the OpenGL compositing safety checks

hein added a comment. Would it make sense to increase the number of test frames right now, if we're uncertain about whether there's enough? What's the trade-of there? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3288 EMAIL PREFERENCES

  1   2   >