This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3cf44a9101e0: Remove outdated script for handling
translations (authored by ltoscano).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3542?vs=8614=8616
jensreuterberg added a comment.
Lovelly! <3
The animations remaining feel way cleaner
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D3538
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #kirigami, mart
Cc:
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3542
EMAIL PREFERENCES
ltoscano created this revision.
ltoscano added a reviewer: Plasma.
ltoscano added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
The files were relevant when the modules lived in its own repository.
Translations are now included in the
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Passes
Makes sure that basic push and pop usage works.
Makes sure that pressing the go back button
Plasma::Applet *applet = 0;
foreach (QObject *appletObject, m_appletInterfaces) {
if (AppletInterface *ai = qobject_cast*>(appletObject)) {
if (ai->isVisible() && ai->contains(ai->mapFromItem(this,
event->posF( {
applet = ai->applet();
colomar added a comment.
+1, definitely looks better to me (and Jens will love any killed animation,
anyway ;) )
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D3538
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol,
colomar added a comment.
Really nice!
The single thumbnail might be a bit too large, as having large notification
windows pop up could be irritating. Maybe half the size would be big enough?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3539
EMAIL
Hello everyone,
A couple of days ago, in a discussion with plasma developers it was
decided that Now Dock should better support window masking (for
animations etc.) in a separate window than the main panel one. What is
doing in the following 0.5 version is a technique based on a plasma
broulik updated the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3539
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai,
broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When a notification
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129586/
---
Review request for KDE Frameworks and Plasma.
Repository: knotifications
davidedmundson updated this revision to Diff 8607.
davidedmundson retitled this revision from "Scale surface damage events
Damage events come in global compositor space, not relative to the surface.
For a glTex2D we need the events relatvie to the surface, so they need scaling
up" to "Scale
davidedmundson updated this revision to Diff 8605.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Update line
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3499?vs=8507=8605
REVISION DETAIL
apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
It's a bit glitchy and looks a bit odd
TEST PLAN
Current: https://youtu.be/pUjmqis9E-w
NoAnimations:
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/68/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 29 Nov 2016 14:56:07 +
Build duration: 6 min 7 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/68/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 29 Nov 2016 14:56:07 +
Build duration: 6 min 7 sec
CHANGE SET
No changes
JUNIT RESULTS
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/67/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 29 Nov 2016 14:42:33 +
Build duration: 8 min 53 sec
CHANGE SET
Revision
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d9d52a37c6ba: Select correct index without timer
(authored by mart).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3533?vs=8575=8602
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5434e4bc0141: Select correct index without timer
(authored by mart).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3532?vs=8574=8601
REVISION DETAIL
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
phab/selectindex
REVISION DETAIL
https://phabricator.kde.org/D3533
EMAIL PREFERENCES
davidedmundson updated this revision to Diff 8600.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Updated line
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3496?vs=8504=8600
REVISION DETAIL
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
phab/wallpselectedindex
REVISION DETAIL
https://phabricator.kde.org/D3532
EMAIL PREFERENCES
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3425
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:f32e6550311f: Implement borderlessMaximizedWindows for
Wayland windows (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D3508?vs=8522=8598#toc
REPOSITORY
R108 KWin
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:9934f5b57537: Properly implement maximize of ShellClient
(authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3507?vs=8521=8597
REVISION DETAIL
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
shell-client-borderless-maximized-windows
REVISION DETAIL
https://phabricator.kde.org/D3508
EMAIL PREFERENCES
mart added a comment.
In https://phabricator.kde.org/D3530#65867, @dfaure wrote:
> But desktop:/ and applications:/ make no sense in other workspaces (I'm
surprised we even still have applications:/, it's kind of a toy, isn't it?).
>
> (ok applications:/ might make sense in gnome,
elvisangelaccio added inline comments.
INLINE COMMENTS
> bshah wrote in CMakeLists.txt:8
> You can't do this, framework version is bumped by release script
> automatically, so when you push this there is no 5.30.0 version of KIO. Which
> will make it fail, you need to bump version once
bshah added inline comments.
INLINE COMMENTS
> CMakeLists.txt:8
> set(QT_MIN_VERSION "5.6.1")
> -set(KF5_MIN_VERSION "5.26.0")
> +set(KF5_MIN_VERSION "5.30.0")
> set(INSTALL_SDDM_THEME TRUE)
You can't do this, framework version is bumped by release script automatically,
so when you push this
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Overall looks quite good. Please watch the coding style a little bit. That
created a few comments.
There are two conceptional things I don't get. One is why you have
elvisangelaccio updated the summary for this revision.
REPOSITORY
R120 Plasma Workspace
BRANCH
drop-slaves
REVISION DETAIL
https://phabricator.kde.org/D3531
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, davidedmundson, #plasma
Cc:
dfaure added a comment.
remote:/ sounds very workspace-independent indeed, it sounds useful to have
in kio.
But desktop:/ and applications:/ make no sense in other workspaces (I'm
surprised we even still have applications:/, it's kind of a toy, isn't it?).
(ok applications:/ might
33 matches
Mail list logo
