[Differential] [Closed] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-22 Thread kossebau (Friedrich W. H. Kossebau)
kossebau closed this revision. kossebau marked an inline comment as done. kossebau added a comment. Committed with 7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3796 EMAIL PREFERENCES

[Differential] [Closed] D3795: Fix clearing PageRow

2016-12-22 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit R169:3e7695f51e05: Fix clearing PageRow (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3795?vs=9300=9309 REVISION DETAIL

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2016-12-22 Thread colomar (Thomas Pfeiffer)
colomar added a comment. We always have to keep in mind that usind multiple layouts is an advanced feature used by a minority of users. Therefore, as long as a feature only becomes active when there are multiple layouts (and in this case only when multiple layouts are used _and_ the login

[Breeze] [Bug 348513] Ugly breeze styling in libreoffice

2016-12-22 Thread Paul M
https://bugs.kde.org/show_bug.cgi?id=348513 --- Comment #7 from Paul M --- (In reply to Paul M from comment #6) > Apparently this will be fixed in Libreoffice 5.3: https://bugs.documentfoundation.org/show_bug.cgi?id=97721 (fixed link) -- You are receiving this mail

[Breeze] [Bug 348513] Ugly breeze styling in libreoffice

2016-12-22 Thread Paul M
https://bugs.kde.org/show_bug.cgi?id=348513 Paul M changed: What|Removed |Added CC||k...@paulmcauley.com ---

[Breeze] [Bug 374057] New: Breeze Gimp Theme

2016-12-22 Thread Hyoga
https://bugs.kde.org/show_bug.cgi?id=374057 Bug ID: 374057 Summary: Breeze Gimp Theme Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: wishlist

[Differential] [Commented On] D3302: [Task Manager] Indicate applications playing audio

2016-12-22 Thread broulik (Kai Uwe Broulik)
broulik added a comment. > maybe if the button becomes big enough it should show as a corner badge? I tried, using a ShaderEffect like for the badge but I couldn't get it to work well or look great, especially since it needs to completely change for when there is a label (where it looks

[Differential] [Accepted] D3707: add simple test rig for service runner

2016-12-22 Thread dfaure (David Faure)
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > servicerunnertest.cpp:49 > +QDir(appsPath).removeRecursively(); > +Q_ASSERT(QDir().mkpath(appsPath)); > +auto fixtureDir = QDir(QFINDTESTDATA("fixtures"));

[Differential] [Accepted] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-22 Thread dfaure (David Faure)
dfaure accepted this revision. dfaure added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:365 > + > +// Qt 5 at least until 5.7.0 does not derive the directory from the > passed url > +// and set the initialDirectory option accordingly, also not for known > schemes

[Differential] [Accepted] D3795: Fix clearing PageRow

2016-12-22 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3795 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc:

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread artem
https://bugs.kde.org/show_bug.cgi?id=374035 --- Comment #9 from artem --- I've found a bug report about this problem which has been created one year ago and still unconfirmed. Is this going to be fixed in the nearest future? https://bugs.kde.org/show_bug.cgi?id=353910 --

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread artem
https://bugs.kde.org/show_bug.cgi?id=374035 --- Comment #8 from artem --- David, you are right, most apps work well now. However, there is still a problem with render quality in Gwenview. It seems it does not support high resolution yet. -- You are receiving this mail

[Differential] [Requested Changes To] D3793: add keybpard navigation for listviews

2016-12-22 Thread apol (Aleix Pol Gonzalez)
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Ah no, still needs the property. How about `property bool keyboardEnabled: true`? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3793 EMAIL PREFERENCES

[Differential] [Accepted] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-22 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH fixFileDialogDirectoryWithSelectUrl REVISION DETAIL https://phabricator.kde.org/D3796 EMAIL

[Differential] [Request, 25 lines] D3796: Fix Plasma-QPA filedialog to show wrong directory with QFileDialog::selectUrl()

2016-12-22 Thread kossebau (Friedrich W. H. Kossebau)
kossebau created this revision. kossebau added reviewers: Plasma, Frameworks, dfaure. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QFileDialog does not set the initialDirectory option in codepaths from

[Differential] [Accepted] D3793: add keybpard navigation for listviews

2016-12-22 Thread apol (Aleix Pol Gonzalez)
apol accepted this revision. apol added a reviewer: apol. apol added a comment. This revision is now accepted and ready to land. Looks good, please note there seems to be an unrelated change. INLINE COMMENTS > AbstractApplicationWindow.qml:143 > */ > -header: undefined > +

[Differential] [Request, 2 lines] D3795: Fix clearing PageRow

2016-12-22 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Makes sense because we grow in depth, so it makes sense that we free the resources in the same order.

[Differential] [Updated, 119 lines] D3793: add keybpard navigation for listviews

2016-12-22 Thread mart (Marco Martin)
mart updated this revision to Diff 9299. mart added a comment. add copyright REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3793?vs=9298=9299 BRANCH phab/keybnavig REVISION DETAIL https://phabricator.kde.org/D3793 AFFECTED FILES

[Differential] [Updated, 118 lines] D3793: add keybpard navigation for listviews

2016-12-22 Thread mart (Marco Martin)
mart updated this revision to Diff 9298. mart added a comment. add a simple test REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3793?vs=9292=9298 BRANCH phab/keybnavig REVISION DETAIL https://phabricator.kde.org/D3793 AFFECTED FILES

[Differential] [Commented On] D3793: add keybpard navigation for listviews

2016-12-22 Thread apol (Aleix Pol Gonzalez)
apol added a comment. Yes, that's what I had in mind. Why didn't you include the next/prev page thing from my implementation? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3793 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2016-12-22 Thread gregormi (gregormi)
gregormi added a comment. As I wrote here (https://bugs.kde.org/show_bug.cgi?id=373668#c14) in my experience a combination of different things (only one of them being the keyboard layout) is responsible for wrong password entry. I believe novice users would be happy if they were given

[Differential] [Commented On] D3793: add keybpard navigation for listviews

2016-12-22 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3793#70872, @apol wrote: > I thought we wanted to make it optional. > Also a test would be great :D. just an "usesKeyboardNavigation" bool property? REPOSITORY R169 Kirigami REVISION DETAIL

[Differential] [Accepted] D3794: Recheck which representation we should using in setPreferredRepresentation

2016-12-22 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH master REVISION DETAIL https://phabricator.kde.org/D3794 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3793: add keybpard navigation for listviews

2016-12-22 Thread apol (Aleix Pol Gonzalez)
apol added a comment. I thought we wanted to make it optional. Also a test would be great :D. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3793 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #kirigami Cc: apol,

[Differential] [Request, 1 line] D3794: Recheck which representation we should using in setPreferredRepresentation

2016-12-22 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Appmenu quite neatly has a config option for which should be the preferred representation,

[Differential] [Request, 14 lines] D3793: add keybpard navigation for listviews

2016-12-22 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY when the main item of a scrollablepage is a listview, use arrows to navigate TEST PLAN works fine in the

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2016-12-22 Thread mart (Marco Martin)
mart added a comment. isn't this making the thing redundant? if the complaints about the indicator being not noticeable are valid, that should be solved at the root, if they aren't then there is not much need of this? REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Differential] [Accepted] D3789: [declarativeimports] Use QtRendering on phone devices

2016-12-22 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH use-qtrendering-on-phone REVISION DETAIL https://phabricator.kde.org/D3789 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah,

Re: [KWin Question] - KWin authorize external docks to manipulate tasks and windows

2016-12-22 Thread Martin Gräßlin
Am 2016-12-21 22:58, schrieb Michail Vourlakos: Στις 21 Δεκ 2016 23:17, ο χρήστης "Martin Gräßlin" έγραψε: Am 21. Dezember 2016 21:19:02 MEZ, schrieb Michail Vourlakos : On 21/12/2016 09:16 μμ, Martin Gräßlin wrote: send from wrong address...(or

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2016-12-22 Thread Martin Gräßlin
graesslin added a comment. Honestly, I don't think that's needed at all. I think that is a non-issue in truth. Yes we have complaints about it and we adjusted the theme by making the selection more clear. Also we have the show password field. I don't think that having the language shown

Re: Review Request 129693: fix category and name in .desktop file

2016-12-22 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129693/ --- (Updated Dec. 22, 2016, 3:42 p.m.) Status -- This change has been

Re: Review Request 129693: fix category and name in .desktop file

2016-12-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129693/#review101549 --- Ship it! Ship It! - Kai Uwe Broulik On Dez. 22, 2016,

Review Request 129693: fix category and name in .desktop file

2016-12-22 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129693/ --- Review request for Plasma and Kai Uwe Broulik. Repository: kfind

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=374035 David Edmundson changed: What|Removed |Added Status|RESOLVED|CLOSED ---

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=374035 --- Comment #6 from Christoph Feck --- We can only support what Qt offers us. Right now, Qt only supports scaling by integer factors, i.e. 1x, 2x, 3x etc. -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread artem
https://bugs.kde.org/show_bug.cgi?id=374035 --- Comment #5 from artem --- The Scale feature affects anything in ugly manner. It forces everything to be rendered in low resolution (texts, images), and then just stretches the result to fit the current resolution. This makes

[Differential] [Request, 49 lines] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2016-12-22 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If the user has more

[Breeze] [Bug 373668] Lock Screen should warn when the keyboard status is not default (layout/capslock)

2016-12-22 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=373668 --- Comment #16 from Kai Uwe Broulik --- Can we continue the discussion here please https://phabricator.kde.org/D3790 -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=374035 David Edmundson changed: What|Removed |Added Resolution|WAITINGFORINFO |INVALID

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread artem
https://bugs.kde.org/show_bug.cgi?id=374035 --- Comment #3 from artem --- KDE system settings -> Fonts -> Force fonts DPI: 280 -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 373668] Lock Screen should warn when the keyboard status is not default (layout/capslock)

2016-12-22 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=373668 --- Comment #15 from Kai Uwe Broulik --- I like the idea of "Unlocking failed (please check your keyboard layout: [link to toggle layouts] de [/Link]" Btw in 5.9 there'll be a button in the text field to show the password

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=374035 David Edmundson changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread artem
https://bugs.kde.org/show_bug.cgi?id=374035 artem changed: What|Removed |Added Platform|Other |Kubuntu Packages -- You are

[Breeze] [Bug 374035] Some controls do not scale according to current DPI

2016-12-22 Thread artem
https://bugs.kde.org/show_bug.cgi?id=374035 --- Comment #1 from artem --- Created attachment 102944 --> https://bugs.kde.org/attachment.cgi?id=102944=edit Fusion theme respects DPI -- You are receiving this mail because: You are the assignee for the bug.

[Breeze] [Bug 374035] New: Some controls do not scale according to current DPI

2016-12-22 Thread artem
https://bugs.kde.org/show_bug.cgi?id=374035 Bug ID: 374035 Summary: Some controls do not scale according to current DPI Product: Breeze Version: 5.8.4 Platform: Other OS: Linux Status: UNCONFIRMED

[Differential] [Commented On] D3789: [declarativeimports] Use QtRendering on phone devices

2016-12-22 Thread bshah (Bhushan Shah)
bshah added a comment. I am not sure if QtQuickControls can be used in org.kde.plasma.components? no other component is using it? REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3789 EMAIL PREFERENCES

[Differential] [Request, 18 lines] D3789: [declarativeimports] Use QtRendering on phone devices

2016-12-22 Thread bshah (Bhushan Shah)
bshah created this revision. bshah added reviewers: Plasma, mart. bshah added a task: T4947: [bullhead] Fix issue with QtQuick Text items rendering. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ref

[Breeze] [Bug 373668] Lock Screen should warn when the keyboard status is not default (layout/capslock)

2016-12-22 Thread Gregor Mi
https://bugs.kde.org/show_bug.cgi?id=373668 Gregor Mi changed: What|Removed |Added CC||codestr...@posteo.org ---

[Breeze] [Bug 373668] Lock Screen should warn when the keyboard status is not default (layout/capslock)

2016-12-22 Thread Anton
https://bugs.kde.org/show_bug.cgi?id=373668 --- Comment #13 from Anton --- I have two layouts "EN" and "RU" but I use English more so it is default for me. I also configured it per window and I type in Russian in some windows. First of all, there is a bug v5.8.3 which

[Breeze] [Bug 373668] Lock Screen should warn when the keyboard status is not default (layout/capslock)

2016-12-22 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=373668 --- Comment #12 from Kai Uwe Broulik --- Counter question: What do you use different keyboard layouts for? I mean, why are you super surprised to have a different keyboard layout when you explicitly configured your system to

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-22 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. At a minimum this needs an upstream bug report with a description of exactly what is happening in both QPAs and in QPlatformWindow. It's one thing to have a temporary workaround, it's another to deliberately write hacks from the start. INLINE COMMENTS >

[Differential] [Accepted] D3787: [Plasmoidviewer] Allow passing "externalData" to the applet

2016-12-22 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D3787 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

Re: Review Request 128552: Italicise the name of symlink in folder view plasmoid

2016-12-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128552/#review101548 --- Ship it! Ship It! - Marco Martin On Sept. 11, 2016,

[Breeze] [Bug 373668] Lock Screen should warn when the keyboard status is not default (layout/capslock)

2016-12-22 Thread Anton
https://bugs.kde.org/show_bug.cgi?id=373668 --- Comment #11 from Anton --- yeah, the capslock is there, my bad. The default keyboard is the first one in the list, see: settings -> Keyboard Hardware and Layout -> Layouts. It is also possible to change the default layout by

Re: Selecting a Plasma logo

2016-12-22 Thread Marco Martin
On Thursday 22 December 2016 09:10:11 Sebastian Kügler wrote: > Go for it. And then let's talk where else we have to change things to > streamline our branding. > > I'm glad we have reached a consensus. done, the most visible places use the plasma logo now -- Marco Martin

Re: Review Request 128683: Add overlay(s) to items in plasma folder view

2016-12-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128683/#review101547 --- Ship it! Ship It! - Marco Martin On Aug. 15, 2016,

[Breeze] [Bug 373668] Lock Screen should warn when the keyboard status is not default (layout/capslock)

2016-12-22 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=373668 --- Comment #10 from Kai Uwe Broulik --- There is a caps lock warning on the lock screen. (I was working on a indicator about caps lock in the TextField like OS X does it but on the lock screen you cannot have any windows on top

[Differential] [Updated] D3787: [Plasmoidviewer] Allow passing "externalData" to the applet

2016-12-22 Thread broulik (Kai Uwe Broulik)
broulik updated the test plan for this revision. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D3787 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: bshah, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D3787: [Plasmoidviewer] Allow passing "externalData" to the applet

2016-12-22 Thread bshah (Bhushan Shah)
bshah added a comment. +1 REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D3787 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: bshah, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3787: [Plasmoidviewer] Allow passing "externalData" to the applet

2016-12-22 Thread broulik (Kai Uwe Broulik)
broulik updated the summary for this revision. broulik updated the test plan for this revision. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D3787 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc:

[Differential] [Request, 24 lines] D3787: [Plasmoidviewer] Allow passing "externalData" to the applet

2016-12-22 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R118 Plasma SDK. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This way an applet like Icon or Folder can

Re: Selecting a Plasma logo

2016-12-22 Thread Sebastian Kügler
On Friday, December 16, 2016 10:49:14 AM UTC Marco Martin wrote: > On Wednesday 07 December 2016 13:58:34 Jens Reuterberg wrote: > > About half a year ago this thread started and so far no actual change has > > happened. > > > > > > > > The background is that the past logo for Plasma Desktop was