Re: Review Request 129696: Fixes, popups from docks that use masking are misplaced

2016-12-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129696/#review101569 --- Is it possible to get a test to make sure these things work

Re: Review Request 129696: Fixes, popups from docks that use masking are misplaced

2016-12-24 Thread Michail Vourlakos
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129696/ --- (Updated Δεκ. 24, 2016, 9:55 μμ.) Review request for Plasma. Changes

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-24 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3777#71262, @davidedmundson wrote: > > so, is this workaround ok with a message to remove when/if we depend from a qt with a proper solution to https://bugreports.qt.io/browse/QTBUG-57785 ? > > Based on this I still don't really

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-24 Thread mart (Marco Martin)
mart added a comment. this is an attempt so use the native event filter approach (can't test yet, as i'm away and don't have an external screen handy) will proper test tomorrow (too bad it's getting really tight for release:/) REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D3777

[Differential] [Updated, 46 lines] D3777: notice when the only screen changes

2016-12-24 Thread mart (Marco Martin)
mart updated this revision to Diff 9352. mart added a comment. - use a native event filter over XCB_RANDR_NOTIFY REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3777?vs=9327=9352 BRANCH arcpatch-D3777 REVISION DETAIL

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-24 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. > so, is this workaround ok with a message to remove when/if we depend from a qt with a proper solution to https://bugreports.qt.io/browse/QTBUG-57785 ? Based on this I still don't really get why we're not just using a native event filter on xrandr

[Differential] [Accepted] D3777: notice when the only screen changes

2016-12-24 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH phab/screenheuristic REVISION DETAIL https://phabricator.kde.org/D3777 EMAIL PREFERENCES

[kio-extras] [Bug 372860] MTP not usable : connects, then disconnects, then connects...

2016-12-24 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=372860 Elvis Angelaccio changed: What|Removed |Added Product|dolphin |kio-extras

Re: Review Request 129697: Figure out software center integration on the menus

2016-12-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129697/ --- (Updated Dec. 24, 2016, 12:30 p.m.) Review request for Plasma.

[Differential] [Request, 123 lines] D3806: Reduce code duplication for processing input events

2016-12-24 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY For every input event we have similar code. We go through all InputFilters, invoke a method

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-24 Thread mart (Marco Martin)
mart added a comment. so, is this workaround ok with a message to remove when/if we depend from a qt with a proper solution to https://bugreports.qt.io/browse/QTBUG-57785 ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3777 EMAIL PREFERENCES

[Differential] [Commented On] D3777: notice when the only screen changes

2016-12-24 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3777#71209, @davidedmundson wrote: > Oh! I think I now see why we have this bug. > > We get a disconnect then connect, which from Qt5.5 goes: > > Old Real Screen > Fake Screen > New Real Screen > > You never get any

Re: Review Request 129697: Figure out software center integration on the menus

2016-12-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129697/#review101564 --- very neat :-) I especially like the red ration in the

[Differential] [Closed] D3803: Add support for on-screen-message to kwineffects

2016-12-24 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R108:ab456596777a: Add support for on-screen-message to kwineffects (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3803?vs=9343=9349 REVISION