Re: Review Request 129697: Figure out software center integration on the menus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129697/#review101624 --- Ship it! Ship It! - Martin Gräßlin On Dez. 24, 2016,

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

graesslin added a comment. Could you explain the relationship to global shortcuts? That sounds to me like a bug which needs to be fixed in kglobalaccel REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 EMAIL PREFERENCES

Re: Review Request 129697: Figure out software center integration on the menus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129697/#review101622 --- Bump? - Aleix Pol Gonzalez On Dec. 24, 2016, 12:30 p.m.,

[Differential] [Commented On] D3617: [Touchpad KCM] New KWin Wayland version

subdiff added inline comments. INLINE COMMENTS > sebas wrote in kwinwaylandtouchpad.h:36 > I wonder if it wouldn't be neater if the features would be an enum, and you'd > have methods to check for supported and enabled features. Have you thought of > this? Haven't thought about it. The

[Differential] [Updated, 2,367 lines] D3617: [Touchpad KCM] New KWin Wayland version

subdiff updated this revision to Diff 9407. subdiff marked 12 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin, Plasma on Wayland. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3617?vs=9389=9407 REVISION

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 95 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/95/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 02:06:44 + Build duration: 9 min 36 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 98 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/98/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 28 Dec 2016 02:01:13 + Build duration: 6 min 14 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Request, 31 lines] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

xuetianweng created this revision. xuetianweng added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY For some reason, the XI event is not received if the change is from global shortcut. This

[Differential] [Commented On] D3823: [Lock Screen] Use QtRendering for Clock

davidedmundson added a comment. wasn't it just large sizes with devicePixelRatio running? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3823 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc:

[Differential] [Updated] D3822: use a native event filter to notice the screen was swapped

davidedmundson added a comment. Given the only member variable we use is m_screenPool-> shouldn't this just be in ScreenPool? Also I don't understand how this is works: qxcbconnection::handleXcbEvent calls ::filterNativeEvent before ::handleScreenChange which means this

Repo freeze on Thursday

Repo freeze is on Thursday, so if anyone has any more Git modules they want added to Plasma for 5.9 speak now or forever haud yet wheesht Currently I plan the same tars as in the 5.8 release bluedevil breeze breeze-grub breeze-gtk breeze-plymouth discover kactivitymanagerd kde-cli-tools

[Differential] [Request, 7 lines] D3828: [Plasma ScrollViewStyle] Show scroll bar background only on hover

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to R242 Plasma Frameworks. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes it

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

ivan added inline comments. INLINE COMMENTS > mart wrote in kastatsfavoritesmodel.h:45 > just a line of comments for each property would help a lot for future > reference That is copied from the old model. Most of them are for back-compatibility. Will see what to do with them. REVISION

Re: Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129704/ --- (Updated Dec. 27, 2016, 6:12 p.m.) Status -- This change has been

[Differential] [Request, 1 line] D3823: [Lock Screen] Use QtRendering for Clock

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY NativeRendering often utterly breaks

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 4:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 3:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/ --- (Updated Dec. 27, 2016, 5:48 p.m.) Review request for Plasma and Albert

Re: Kirigami2 issues on static libraries.

On Tuesday 27 December 2016, Tomaz Canabrava wrote: > Hello good people, > > I started to port Subsurface to kirigami2 and I found some issues that are > interesting. > > If I try to run subsurface while plasma is not running, it works, > if I try to run subsurface while plasma is running, it

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 97 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/97/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 17:27:15 + Build duration: 57 sec CHANGE SET Revision

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 94 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/94/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 17:27:15 + Build duration: 56 sec CHANGE SET Revision

Kirigami2 issues on static libraries.

Hello good people, I started to port Subsurface to kirigami2 and I found some issues that are interesting. If I try to run subsurface while plasma is not running, it works, if I try to run subsurface while plasma is running, it doesnt. It seems that we hit a issue by using kirigami as a Static

[Differential] [Closed] D3812: Deprecate Plasma::Package API in PluginLoader

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4798310ed788: Deprecate Plasma::Package API in PluginLoader (authored by graesslin). REPOSITORY R242 Plasma Frameworks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3812?vs=9366=9395

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 4:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 96 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/96/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 17:17:38 + Build duration: 7 min 44 sec CHANGE SET Revision

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 93 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 17:17:38 + Build duration: 56 sec CHANGE SET Revision

[Differential] [Closed] D3810: Add the modifiers relevant for global shortcuts into the input Events

This revision was automatically updated to reflect the committed changes. Closed by commit R108:58361213de59: Add the modifiers relevant for global shortcuts into the input Events (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3810?vs=9364=9394#toc REPOSITORY

[Differential] [Closed] D3809: Use new xkbcommon API for consumed modifiers

This revision was automatically updated to reflect the committed changes. Closed by commit R108:d1fdb9a02fb8: Use new xkbcommon API for consumed modifiers (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3809?vs=9363=9393 REVISION DETAIL

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 624 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/624/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 16:43:57 + Build duration: 17 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 624 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/624/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 16:43:57 + Build duration: 17 min CHANGE SET Revision

[Differential] [Closed] D3033: Cancel the Switch-user-overlay by clicking on empty space

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3e9d1a48a1ca: [Look and Feel] Dismiss User Switcher on empty space click (authored by subdiff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3033?vs=7339=9392#toc REPOSITORY R120 Plasma

[Differential] [Accepted] D3809: Use new xkbcommon API for consumed modifiers

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH xkbcommon-workaround-removal REVISION DETAIL https://phabricator.kde.org/D3809 EMAIL PREFERENCES

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 3:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

[Differential] [Closed] D3806: Reduce code duplication for processing input events

This revision was automatically updated to reflect the committed changes. Closed by commit R108:e3d79cdda6ee: Reduce code duplication for processing input events (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3806?vs=9350=9391 REVISION

[Differential] [Closed] D3808: Fix the osd re-placement on X11

This revision was automatically updated to reflect the committed changes. Closed by commit R108:bba18a1ba812: Fix the osd re-placement on X11 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3808?vs=9362=9390 REVISION DETAIL

[Differential] [Accepted] D3806: Reduce code duplication for processing input events

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH input-filters REVISION DETAIL https://phabricator.kde.org/D3806 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 3:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

[Differential] [Accepted] D3810: Add the modifiers relevant for global shortcuts into the input Events

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH modifiers-relevant-global-shortcuts-in-event REVISION DETAIL https://phabricator.kde.org/D3810 EMAIL PREFERENCES

[Differential] [Accepted] D3808: Fix the osd re-placement on X11

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH fix-osd-placement-x11 REVISION DETAIL https://phabricator.kde.org/D3808 EMAIL PREFERENCES

[Differential] [Accepted] D3817: [Connection Editor] Honor lineedit_reveal_password restriction

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D3817 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Updated] D3822: use a native event filter to notice the screen was swapped

sebas added a comment. Code-wise, it looks good. let's get it into master quickly, and if we get no complaints, backport to 5.8? INLINE COMMENTS > shellcorona.h:118 > +protected: > +bool nativeEventFilter(const QByteArray & eventType, void * message, > long * result) Q_DECL_OVERRIDE; >

[Differential] [Changed Subscribers] D3617: [Touchpad KCM] New KWin Wayland version

sebas added inline comments. INLINE COMMENTS > kwin_wayland.cmake:1 > +#find_package(X11 REQUIRED) > + remove commented out bits? > kwinwaylandbackend.cpp:46 > +m_deviceManager->connection().connect(QStringLiteral("org.kde.KWin"), > + >

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review101595 --- In principle good, but Cabo Verde should not be changed.

[Differential] [Updated, 2,384 lines] D3617: [Touchpad KCM] New KWin Wayland version

subdiff updated this revision to Diff 9389. subdiff marked 4 inline comments as done. subdiff added a comment. Restricted Application edited projects, added Plasma on Wayland, KWin; removed Plasma. Replace foreach loops. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3805: Per-activity favorites (WIP)

mart added inline comments. INLINE COMMENTS > kastatsfavoritesmodel.h:45 > + > +Q_PROPERTY(bool enabled READ enabled WRITE setEnabled NOTIFY > enabledChanged) > +Q_PROPERTY(QStringList favorites READ favorites WRITE setFavorites > NOTIFY favoritesChanged) just a line of comments for

Plasma 5.8.5

Plasma 5.8.5 is now released https://www.kde.org/announcements/plasma-5.8.5.php

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 623 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/623/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 27 Dec 2016 11:45:04 + Build duration: 6 min 4 sec CHANGE SET Revision

[Differential] [Accepted] D3818: [KUIserver] Forward "destUrl" to all clients

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3818 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D3819: [Applicationjobs Data Engine] Expose job "destUrl"

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3819 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D3821: Add a manual test for unity launchers

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D3821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Updated] D3822: use a native event filter to notice the screen was swapped

mart added reviewers: davidedmundson, sebas. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3822 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, davidedmundson, sebas Cc: plasma-devel, lesliezhai,

[Differential] [Updated] D3822: use a native event filter to notice the screen was swapped

mart updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3822 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Request, 77 lines] D3822: use a native event filter to notice the screen was swapped

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this replaces the approach with the expose event in

[Differential] [Request, 92 lines] D3821: Add a manual test for unity launchers

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R289 KNotifications. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This utility allows to test and

Re: Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129704/#review101585 --- Ship it! Ship It! - Marco Martin On Dec. 26, 2016,

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

colomar added a comment. Yes, that is certainly a downside. One idea could be to move it into a submenu if there are more than X entries (though I'm not sure yet which number to choose). The downside of that would be that people who often add and remove places might get confused by the

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

mart added a comment. +1 from me but i feel that moving it to a submenu kinda misses the point to make the places immediately accessible REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3815 EMAIL PREFERENCES

[Differential] [Accepted] D3816: [Task Manager] Parent QAction to "parent" instead of this

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Accepted] D3812: Deprecate Plasma::Package API in PluginLoader

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH deprecate-package-in-pluginloader REVISION DETAIL https://phabricator.kde.org/D3812 EMAIL PREFERENCES

[kio-extras] [Bug 369850] Can't browse samba workgroups

https://bugs.kde.org/show_bug.cgi?id=369850 Elvis Angelaccio changed: What|Removed |Added Component|general |default

[kio-extras] [Bug 359278] Crash when opening smb:// folders

https://bugs.kde.org/show_bug.cgi?id=359278 Elvis Angelaccio changed: What|Removed |Added Summary|SMB crashes Dolphin |Crash when opening

Re: Review Request 128683: Add overlay(s) to items in plasma folder view

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128683/ --- (Updated Dec. 27, 2016, 9:11 a.m.) Status -- This change has been