D5219: Use better description for size when size is not known

2017-03-28 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R134:c2cc4b1e27c8: Use better description for size when size is not known (authored by jgrulich). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D5232: Add override to methods that override methods on their parent class

2017-03-28 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: KWin, kwin, plasma-devel. REVISION SUMMARY I was trying to compile kwin and it was impossible to read the output because clang complains if it should override and it doesn't

D3531: Drop remote ioslave, which is now in KIO 5.32

2017-03-28 Thread Elvis Angelaccio
elvisangelaccio added a comment. I'm going to push this by tomorrow unless someone has objections. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 To: elvisangelaccio, #plasma, davidedmundson Cc: bshah, lbeltrame, davidedmundson, plasma-devel,

[kio-extras] [Bug 378217] Use user defined in .ssh/config for fish

2017-03-28 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=378217 Elvis Angelaccio changed: What|Removed |Added Component|general |default

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-28 Thread Rik Mills
rikmills added a comment. In https://phabricator.kde.org/D5128#98591, @elvisangelaccio wrote: > It seems the upstream firefox bug has been fixed, can you update to commit message? > Anyway +1 for removing the stepper buttons, currently there is an annoying difference between breeze

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-28 Thread Rik Mills
rikmills edited the summary of this revision. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D5128 To: rikmills, #plasma Cc: elvisangelaccio, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-28 Thread Elvis Angelaccio
elvisangelaccio added a comment. It seems the upstream firefox bug has been fixed, can you update to commit message? Anyway +1 for removing the stepper buttons, currently there is an annoying difference between breeze and breeze-gtk3 scrollbars. REPOSITORY R98 Breeze for Gtk REVISION

Re: Scrap Baloo Thread Feedback

2017-03-28 Thread Martin Klapetek
On Tue, Mar 28, 2017 at 5:21 AM, Matthieu Gallien < gallien.matth...@gmail.com> wrote: > Hello all, > > Sorry to exhume this old thread, but > > Is there a common agreement on the best path forward for Baloo versus > the current situation ? > > I have an interest in having a global KDE solution

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D5227#98555, @graesslin wrote: > I'm against adding this option as the greeter does not have any influence over the lnf package. It works with our default but as soon as users change the theme we do not know. I'm against adding new

D5189: Partial rewrite to add and update info.

2017-03-28 Thread Burkhard Lück
lueck added a comment. Please readd the screenshots using the default design ( https://l10n.kde.org/docs/screenshots.php ) Thanks INLINE COMMENTS > index.docbook:70 > + > + provides a modern and customizable environment for running your > favorite applications and accessing your

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Martin Gräßlin
graesslin added a comment. I'm against adding this option as the greeter does not have any influence over the lnf package. It works with our default but as soon as users change the theme we do not know. I'm against adding new options which only work in the default setup. REPOSITORY R133

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D5227#98542, @broulik wrote: > For show password button there's a kiosk restriction available: **lineedit_reveal_password** (see https://userbase.kde.org/KDE_System_Administration/Kiosk/Keys) Indeed, that works! Now if just

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Kai Uwe Broulik
broulik added a comment. For show password button there's a kiosk restriction available: **lineedit_reveal_password** (see https://userbase.kde.org/KDE_System_Administration/Kiosk/Keys) REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D5227 To: fvogt, #plasma,

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Fabian Vogt
fvogt planned changes to this revision. fvogt added a comment. I would fix the clipboard content issue with klipper (although I find that approach wrong as it's too complicated as a seemingly unrelated component needs to support the screenlocker), but I do not have enough experience in that

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. As already outlined in your thread on distributions I think this is wrong. And as the maintainer of the lock screen I'm against adding this option to the lock screen. It's

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Fabian Vogt
fvogt updated this revision to Diff 12933. fvogt added a comment. Add a comment in greeterapp.cpp and also add a tooltip to the configuration option label. REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5227?vs=12932=12933 BRANCH master REVISION

D5222: Make the applet DBus activated

2017-03-28 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D5222 To: drosca, #plasma, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5219: Use better description for size when size is not known

2017-03-28 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH size-description REVISION DETAIL https://phabricator.kde.org/D5219 To: jgrulich, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The show password button only makes sense with a virtual keyboard on touchscreens. On desktop PCs it's not only not useful, but it can also be used to show (partially) typed in passwords. It also

D5215: [ModelContextMenu] Use Instantiator insteadof Repeater-and-reparent-hack

2017-03-28 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5215 To: broulik, #plasma, apol Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 684 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/684/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 16:36:23 + Build duration: 5 min 51 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 683 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/683/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 16:19:53 + Build duration: 15 min CHANGE SET Revision

D5223: [Folder View] Use KDirLister's root KFileItem for LabelGenerator

2017-03-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:89bcbb5fb637: [Folder View] Use KDirLister's root KFileItem for LabelGenerator (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5223?vs=12921=12929#toc REPOSITORY R119

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 102 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 16:18:33 + Build duration: 5 min 56 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 682 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/682/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 15:59:43 + Build duration: 15 min CHANGE SET Revision

D5226: [Folder View] Use toDisplayString which strips passwords

2017-03-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b9eedbe78c79: [Folder View] Use toDisplayString which strips passwords (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D4939: Get rid of KDELibs4Support

2017-03-28 Thread Denis Shienkov
denisshienkov added a reviewer: Plasma. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D4939 To: denisshienkov, volkov, afiestas, broulik, graesslin, davidedmundson, #plasma Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed,

D5224: [Folder View] Don't break FolderView url binding to configured URL when going home

2017-03-28 Thread Eike Hein
hein added a comment. :) Right, "imperative way to assign a binding" sums it up. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5224 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5226: [Folder View] Use toDisplayString which strips passwords

2017-03-28 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5226 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5226: [Folder View] Use toDisplayString which strips passwords

2017-03-28 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise we might be leaking sensitive information. TEST PLAN I want to get this in before https://phabricator.kde.org/D5223 so I can

D5224: [Folder View] Don't break FolderView url binding to configured URL when going home

2017-03-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4fb4dbe80a84: [Folder View] Don't break FolderView url binding to configured URL when going… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D5224: [Folder View] Don't break FolderView url binding to configured URL when going home

2017-03-28 Thread Kai Uwe Broulik
broulik added a comment. > So binding to a function returning that prop means when the config prop notifies the function is rerun and the value updated, right? Yes, it behaves as if I had written `url: foo` in the markup. When using JavaScript, explicitly assigning a value breaks the

D5224: [Folder View] Don't break FolderView url binding to configured URL when going home

2017-03-28 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. So binding to a function returning that prop means when the config prop notifies the function is rerun and the value updated, right? Sounds good. REPOSITORY R119 Plasma Desktop REVISION

D5223: [Folder View] Use KDirLister's root KFileItem for LabelGenerator

2017-03-28 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. +1 on making a 5.8 patch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5223 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

D5225: [slidingpopups] Only remove WindowClosedGrabRole if the effect owns the grab

2017-03-28 Thread Martin Gräßlin
graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The effect unset the WindowClosedGrabRole unconditionally if it does not manage the window. This results in any grab set by other

D5221: [desktop:/ KIO] Add descriptive name for root item

2017-03-28 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5221 To: broulik, #plasma, hein, dfaure, elvisangelaccio Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5174: Add support for wl_shell_surface::set_popup and popup_done

2017-03-28 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit R127:6c89a61d2d17: Add support for wl_shell_surface::set_popup and popup_done (authored by graesslin). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D5224: [Folder View] Don't break FolderView url binding to configured URL when going home

2017-03-28 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise after navigating to subfolders in the popup, changing the URL in configuration isn't immediately applied. TEST PLAN Had

D5223: [Folder View] Use KDirLister's root KFileItem for LabelGenerator

2017-03-28 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This way we can take into account UDS_DISPLAY_NAME for locations like desktop:/, trash:/, etc TEST PLAN With this patch and

D5222: Make the applet DBus activated

2017-03-28 Thread David Rosca
drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Killed pulseaudio - applet removed. Started pulseaudio - applet appearaed. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION

D5221: [desktop:/ KIO] Add descriptive name for root item

2017-03-28 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This way Folder View could use the root item for its heading instead of special-casing it for desktop:/ TEST PLAN I should probably check

D5220: Temp Fix ObjectModel Crash & Mic Mute Option

2017-03-28 Thread Aditya Mehra
This revision was automatically updated to reflect the committed changes. Closed by commit R846:1a83ab2e728b: Temp Fix ObjectModel Crash & Mic Mute Option (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE

D5220: Temp Fix ObjectModel Crash & Mic Mute Option

2017-03-28 Thread Aditya Mehra
Aiix created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ref https://phabricator.kde.org/T5742, https://phabricator.kde.org/T5718 Reverted to ListModel as a temporary fix from ObjectModel which was

D5034: Add support for x-gvfs style options in fstab

2017-03-28 Thread Kai Uwe Broulik
broulik added a comment. If no-one objects I'll push this after the next frameworks release REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D5034 To: broulik, #plasma, dfaure, dhaumann Cc: dhaumann, plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,

D5219: Use better description for size when size is not known

2017-03-28 Thread Jan Grulich
jgrulich added a reviewer: apol. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5219 To: jgrulich, apol Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5219: Use better description for size when size is not known

2017-03-28 Thread Jan Grulich
jgrulich created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Show that size is being fetched instead of displaying size 0 which can confuse users. Also when we fail to fetch the size, then display

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 101 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 11:55:11 + Build duration: 24 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 102 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 11:55:46 + Build duration: 6 min 10 sec CHANGE SET Revision

D5216: [Widget Explorer] Better align add widgets menu

2017-03-28 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Since the button is at the bottom, it would wrap to show above the desired location covering the button. Using openRelative with

D5215: [ModelContextMenu] Use Instantiator insteadof Repeater-and-reparent-hack

2017-03-28 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Clicking the "add widgets" button multiple times in widget explorer no longer crashes/confuses it because the Repeater

D5171: Context: Use DBus service watcher to reconnect to pulseaudio

2017-03-28 Thread David Rosca
drosca retitled this revision from "Context: Always try to reconnect when connection fails" to "Context: Use DBus service watcher to reconnect to pulseaudio". drosca edited the summary of this revision. drosca edited the test plan for this revision. REPOSITORY R115 Plasma Audio Volume Applet

D5171: Context: Always try to reconnect when connection fails

2017-03-28 Thread David Rosca
drosca updated this revision to Diff 12909. drosca added a comment. Use DBus service watcher REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5171?vs=12786=12909 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D5171

D5200: [Calendar] Shrink and elide week names like is done with day delegate

2017-03-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:5ae0651045c2: [Calendar] Shrink and elide week names like is done with day delegate (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5214: [Icon Item] Make "smooth" property actually do something

2017-03-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:611a4b592055: [Icon Item] Make "smooth" property actually do something (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D5171: Context: Always try to reconnect when connection fails

2017-03-28 Thread David Rosca
drosca added a comment. In https://phabricator.kde.org/D5171#98353, @mart wrote: > In https://phabricator.kde.org/D5171#97466, @drosca wrote: > > > > Does PulseAudio have any DBus service? The applet could be DBus activated, too > > > > Yes, but on its own connection, so I assume

D5171: Context: Always try to reconnect when connection fails

2017-03-28 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D5171#97466, @drosca wrote: > > Does PulseAudio have any DBus service? The applet could be DBus activated, too > > Yes, but on its own connection, so I assume not supported to be DBus activated by plasma. connection or

D5144: Change the volume icon/mute button into a ToolButton

2017-03-28 Thread Marco Martin
mart added a comment. i think it looks better (tough only how it looks on roman's machine) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D5144 To: Zren, #plasma, subdiff, drosca Cc: mart, subdiff, drosca, plasma-devel, progwolff, lesliezhai,

D5174: Add support for wl_shell_surface::set_popup and popup_done

2017-03-28 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH popup-done REVISION DETAIL https://phabricator.kde.org/D5174 To: graesslin, #plasma_on_wayland, #frameworks, #kwin, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

D5200: [Calendar] Shrink and elide week names like is done with day delegate

2017-03-28 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5200 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5214: [Icon Item] Make "smooth" property actually do something

2017-03-28 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5214 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

Minutes of Plasma Hangout

2017-03-28 Thread Bhushan Shah
Sorry for sending this late but here we go! --- notes --- Sho_ * [General] Improved IconItem to make source size (and by implication aspect ratio, useful for sizing) available as implicit size * [Kicker] Ported custom image mode in compact representation from Image to IconItem, fixes

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 100 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/100/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 09:55:46 + Build duration: 15 min CHANGE SET Revision

D5214: [Icon Item] Make "smooth" property actually do something

2017-03-28 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We had m_smooth but never actually used it in the texture node. With Plasma SVG icons this shouldn't be used but when

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 681 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/681/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 09:56:16 + Build duration: 5 min 36 sec CHANGE SET Revision

D5213: [Applet Alternatives] Fix icon size

2017-03-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:e28ea7a47c96: [Applet Alternatives] Fix icon size (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5213?vs=12903=12904 REVISION DETAIL

D5213: [Applet Alternatives] Fix icon size

2017-03-28 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5213 To: broulik, #plasma, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5213: [Applet Alternatives] Fix icon size

2017-03-28 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Another regression with new IconItem implicit size handling. Unintuitively implicit size has precedence over regular size when placed in a

Re: Scrap Baloo Thread Feedback

2017-03-28 Thread Matthieu Gallien
Hello all, Sorry to exhume this old thread, but 2016-12-29 13:47 GMT+01:00 Dominik Haumann : > Hi all, > > CC: plasma-devel, due to stability issues > > On Fri, Oct 7, 2016 at 5:56 PM, Christoph Cullmann > wrote: >> Hi, >> > [...] >> Actually, the

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 680 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/680/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 09:08:18 + Build duration: 6 min 44 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 679 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/679/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 08:51:38 + Build duration: 16 min CHANGE SET Revision

D5202: [Default Tooltip] Fix icon size

2017-03-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:7487e208b696: [Default Tooltip] Fix icon size (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5202?vs=12878=12900

D5146: Implement UI feedback for long-running searches, and no-results

2017-03-28 Thread Dan Leinir Turthra Jensen
leinir closed this revision. leinir added a comment. Closed by commit 73b61fcdf1408871de85d60c7341e283194b92c6 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5146 To: leinir, apol, #vdg Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed,

D5202: [Default Tooltip] Fix icon size

2017-03-28 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5202 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5201: [Folder View] Add "home" button

2017-03-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:2f607969ecd4: [Folder View] Add "home" button (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5201?vs=12877=12898 REVISION DETAIL

D5204: [Folder View] Show pin icon only if really in a popup

2017-03-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:fc94d0f2fd3e: [Folder View] Show pin icon only if really in a popup (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5204?vs=12880=12899#toc REPOSITORY R119 Plasma

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 99 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/99/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 08:50:57 + Build duration: 5 min 47 sec CHANGE SET Revision

D4761: [Task Manager] Don't delay appearance of audio stream in popup

2017-03-28 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:21ab961c2df5: [Task Manager] Don't delay appearance of audio stream in popup (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D5209: Load translations from KPackage files if bundled

2017-03-28 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 101 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 08:30:45 + Build duration: 16 min CHANGE SET Revision

D5198: [Folder View] Use KIO::iconNameForUrl

2017-03-28 Thread Kai Uwe Broulik
broulik added a reviewer: dfaure. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5198 To: broulik, #plasma, markg, hein, dfaure Cc: markg, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5204: [Folder View] Show pin icon only if really in a popup

2017-03-28 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Good catch. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5204 To: broulik, #plasma, #vdg, hein Cc: hein, plasma-devel, progwolff, lesliezhai, ali-mohamed,

D5201: [Folder View] Add "home" button

2017-03-28 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nice one, but let's not go nuts adding more toolbar buttons :). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D5201 To: broulik, #plasma, hein, #vdg Cc:

D4761: [Task Manager] Don't delay appearance of audio stream in popup

2017-03-28 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Oh, I remember asking for this even! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4761 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai,

D5112: Make archiver ioslave extensible

2017-03-28 Thread Jonathan Marten
marten updated this revision to Diff 12896. marten added a comment. Remove KF5 prefixes, the library is now libkioarchive.so REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5112?vs=12641=12896 REVISION DETAIL https://phabricator.kde.org/D5112

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 678 - Still Unstable!

2017-03-28 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/678/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Mar 2017 07:41:49 + Build duration: 8 min 57 sec CHANGE SET Revision

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-03-28 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > broulik wrote in baloofilepropertiesplugin.desktop:8 > I went through all extractors in KFileMetaData and looked at what they > support. > > Unfortunately

D5112: Make archiver ioslave extensible

2017-03-28 Thread David Faure
dfaure added a comment. Yeah KF5Konq is a bug, it shouldn't be named that way. I don't really care about casing, the cmake code will refer to the imported target (which shouldn't have a KF5:: prefix either), not to the library name anyway. REPOSITORY R320 KIO Extras REVISION DETAIL