D5914: Add template for Plasma QML Applet with QML extension

2017-05-18 Thread Friedrich W. H. Kossebau
kossebau added a comment. Get created template bundle here: https://share.kde.org/index.php/s/eHJGEku7pw7DotV REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5914 To: kossebau, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

D5914: Add template for Plasma QML Applet with QML extension

2017-05-18 Thread Friedrich W. H. Kossebau
kossebau created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Should help people to kick-off plasmoids which also use custom QML classes. TEST PLAN Created new plasmoid from

D5913: Fix fifteen puzzle solveability

2017-05-18 Thread Igor Poboiko
poboiko created this revision. poboiko added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Thus fixes bug 358940 : fifteen puzzle often appears unsolveable. There were two issues. 1. Floating

D5912: minimize dialog resizes/moves

2017-05-18 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in dialog.cpp:864 > I don't understand your description of the problem. > > this call both that resizes and moves. > but if the item hasn't changed yet, it shouldn't actually resize anything. > > you're implying it does. Why?

D5910: make shadows work on wayland

2017-05-18 Thread Hugo Pereira Da Costa
hpereiradacosta added inline comments. INLINE COMMENTS > breezeshadowhelper.cpp:177 > +QWidget* widget( static_cast( object ) ); > +if( event->type() == QEvent::Paint && ( > !_widgets.contains(widget) || _widgets.value(widget) == 0 ) ) > +{ Also,

D5912: minimize dialog resizes/moves

2017-05-18 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > dialog.cpp:864 > if (d->mainItem) { > d->syncToMainItemSize(); > } I don't understand your description of the problem. this call both that resizes and moves. but if the item hasn't changed yet, it shouldn't

D5912: minimize dialog resizes/moves

2017-05-18 Thread Marco Martin
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY take into account size hints also when adjusting with synctomainitemsize which sometimes has to be executed right before

D5910: make shadows work on wayland

2017-05-18 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > breezeshadowhelper.cpp:174 > { > +if( Helper::isWayland() ) > +{ We make check on every event for what we know what it is, does it better to use polymorphic helper? REPOSITORY R31 Breeze REVISION DETAIL

D5910: make shadows work on wayland

2017-05-18 Thread David Edmundson
davidedmundson added a comment. We're going to be leaking both Surface and Shadow objects in installWaylandFilter, no? INLINE COMMENTS > breezeshadowhelper.cpp:177 > +QWidget* widget( static_cast( object ) ); > +if( event->type() == QEvent::Paint && ( >

D5910: make shadows work on wayland

2017-05-18 Thread Marco Martin
mart added a reviewer: hpereiradacosta. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5910 To: mart, #plasma, hpereiradacosta Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5910: make shadows work on wayland

2017-05-18 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY since from Qt 5.8 QtWayland destroys its surfaces every time a window gets hidden and recreates them again when is shown (that's how the

D5868: make pagerow test pass

2017-05-18 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Tested, it's definitely better. REPOSITORY R169 Kirigami BRANCH phab/pagerowtest REVISION DETAIL https://phabricator.kde.org/D5868 To: mart, #kirigami, apol Cc: plasma-devel, apol

Re: [wayland] some findings about weird shadows in wayland

2017-05-18 Thread Marco Martin
On Wednesday 17 May 2017 15:11:05 David Edmundson wrote: > There was a potentially relevant change in plasma-integration last night. > Make sure you have that before spending longer on it. > > I don't have this issue on my tooltips hovering over the plasmoids in the > panel. > Do you have it

kdereview: qqc2-desktop-style

2017-05-18 Thread Marco Martin
Hi all, I'm anouncing the QtQuickControls2 desktop style in kdereview, repo name is qqc2-desktop-style It is intended to be a small style written in QML for QtQuickControls2 that is intended to be used by default in QQC2-based apps when used in the Plasma desktop (it shouldn't have any

[kio-extras] [Bug 371278] Dolphin crashed when opening smb location

2017-05-18 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=371278 Elvis Angelaccio changed: What|Removed |Added CC|

Re: Plasma 5.10 voice over text

2017-05-18 Thread Eike Hein
On 05/17/2017 09:03 PM, Ɓukasz Sawicki wrote: >> This explains what it is, it doesn't explain what's changed since the last >> release. >> "Folder View is now the default desktop ..." > > Changed to "Due to the popular demand we changed to Folder View as the > default desktop which allows users