D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

zzag added a comment. In D14542#375522 , @ngraham wrote: > Overall it works very well! UI-wise, I found myself confused by the unpredictability of the Add button. With multiple rows, it was not clear which row the new desktop would be added to.

D16873: [comic] Request current identifier on date changed

anthonyfieroni updated this revision to Diff 47418. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16873?vs=47417=47418 REVISION DETAIL https://phabricator.kde.org/D16873 AFFECTED FILES applets/comic/comic.cpp To: anthonyfieroni, #plasma,

D16873: [comic] Request current identifier on date changed

anthonyfieroni updated this revision to Diff 47417. anthonyfieroni added a comment. Also fix max comic strips limit REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16873?vs=46207=47417 REVISION DETAIL https://phabricator.kde.org/D16873 AFFECTED

D16856: [comicupdater] Fix last day check

anthonyfieroni updated this revision to Diff 47416. anthonyfieroni retitled this revision from "[comic] Sync configuration on write" to "[comicupdater] Fix last day check". REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16856?vs=46206=47416 REVISION

D17467: digital-clock: Show events on initial expansion for all time zones

mbehrendt marked an inline comment as done. mbehrendt added inline comments. INLINE COMMENTS > mart wrote in CalendarView.qml:60 > instead of storing a local hasExpanded, could you just check for > holidaysList.model not being null? No, the model initially seems to be an empty list.

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47409. mbehrendt added a comment. remove local variable "currentDate" and use "getDate" instead of "getDay" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17467?vs=47407=47409 REVISION DETAIL

D17467: digital-clock: Show events on expanding applet

mbehrendt updated this revision to Diff 47407. mbehrendt added a comment. Total overhaul of the patch. I think I found the root cause for the events not being displayed. I also inserted some if clauses to reduce calculations. I also removed setting holidaysList.model = null as I could

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I can confirm @zzag's bug. Overall it works very well! UI-wise, I found myself confused by the unpredictability of the Add button. With multiple rows, it was not clear

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

filipf added a comment. I have a question regarding legibility, something I've just stumbled upon in my tests. What happens if there is more than one user? Will the label of the non-selected user be legible enough? UserDelegate.qml sets the opacity of this label at 0.5 so it may be

D17367: Update Void Linux URL in README.md

This revision was automatically updated to reflect the committed changes. Closed by commit R878:4f649fec7989: Update Void Linux URL in README.md (authored by johnz, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE

D17415: Fix event type checking

amantia closed this revision. amantia added a comment. Messed up a little and this got landed together with another patch https://cgit.kde.org/plasma-desktop.git/commit/?id=40b9e34ced6b421c8585f304d91a2da37f40c4d6 REVISION DETAIL https://phabricator.kde.org/D17415 To: amantia, #plasma,

D17408: Make accessibility warning dialog usable again

This revision was automatically updated to reflect the committed changes. Closed by commit R119:40b9e34ced6b: Make accessibility warning dialog usable again (authored by amantia). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17408?vs=47044=47374#toc REPOSITORY R119 Plasma Desktop

D17346: Support Bluetooth batteries

abetts added a comment. In D17346#375165 , @broulik wrote: > No. Can we not digress from this, I just need an icon... :**( It's all good. Just a thought. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D17367: Update Void Linux URL in README.md

johnz added a comment. In D17367#375366 , @mvourlakos wrote: > @johnz can you provide a valid e-mail address in order to commit this for you? Yep, jo...@posteo.net REPOSITORY R878 Latte Dock REVISION DETAIL

D17367: Update Void Linux URL in README.md

mvourlakos added a comment. @johnz can you provide a valid e-mail address in order to commit this for you? @apol no worries, I found the steps at: https://community.kde.org/Infrastructure/Phabricator#Landing_someone_else.27s_diff REPOSITORY R878 Latte Dock REVISION DETAIL

D17367: Update Void Linux URL in README.md

mvourlakos added a comment. @apol do we have any guide what is the proper way to land a patch from phabricator as a different user? in order to commit this for @johnz? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D17367 To: johnz, #latte_dock, apol Cc:

D17225: Update translation kcm docbook to plasma 5.14

lueck added a comment. please review REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17225 To: lueck, #plasma, #documentation Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D17501: Install Platform theme plugin into bin/platformthemes for unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit R135:8df8dea58059: Install Platform theme plugin into bin/platformthemes for unit tests (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

abetts added a comment. Can the section title be called something different instead of using the word "Component"? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17372 To: ngraham, #plasma, #vdg Cc: abetts, davidedmundson, plasma-devel, ragreen, Pitel,

D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

ngraham added a comment. In D17372#373654 , @davidedmundson wrote: > > and some users report that it actually does the wrong thing for certain URLs. > > Bug reports are also an indication people use it. Well, it's the default, so I

D17367: Update Void Linux URL in README.md

johnz added a comment. Yes you can push it, I don't have any permission here that I'm aware of. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D17367 To: johnz, #latte_dock, apol Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17493: [WIP] Implementation of an Easy Mode in KCM fonts module

harmathy added inline comments. INLINE COMMENTS > freetype-renderer.cpp:342-345 > +int result_r = ((255 - value_r) * backgound_r + value_r * pen_r) > / 255; > +int result_g = ((255 - value_g) * backgound_g + value_g * pen_g) > / 255; > +int result_b = ((255

D17493: [WIP] Implementation of an Easy Mode in KCM fonts module

harmathy updated this revision to Diff 47361. harmathy added a comment. fix some rendering issues, fix logical errors REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17493?vs=47298=47361 REVISION DETAIL https://phabricator.kde.org/D17493 AFFECTED

D17508: Simplify perStripe definition

McPain created this revision. McPain added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY We can get rid of double-checking of > gridView.flow == GridView.FlowLeftToRight because

D17367: Update Void Linux URL in README.md

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good, do you need us to push the change? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D17367 To: johnz, #latte_dock, apol Cc: apol, plasma-devel, ragreen,

D17482: Upload new screenshots in the documentation and uncomment a section

yurchor added a comment. In D17482#375270 , @ognarb wrote: > In D17482#375191 , @broulik wrote: > > > Breaks build of plasma-desktoop: > > > > index.docbook:104: parser error : Opening and

D17482: Upload new screenshots in the documentation and uncomment a section

ognarb added a comment. In D17482#375191 , @broulik wrote: > Breaks build of plasma-desktoop: > > index.docbook:104: parser error : Opening and ending tag mismatch: variablelist line 53 and article > > ^ >

D17467: digital-clock: Show events on expanding applet

mart added inline comments. INLINE COMMENTS > CalendarView.qml:60 > +// would always be empty. > +holidaysList.model = > monthView.daysModel.eventsForDate(monthView.currentDate); > +hasExpanded = true; instead of storing a local hasExpanded,

D17493: [WIP] Implementation of an Easy Mode in KCM fonts module

yurchor added inline comments. INLINE COMMENTS > freetype-renderer.h:487 > + * The given text will be rendered offside using the options provided as > parameters. This is > + * intended to be presented to a user to give an imperssion, what > rendering with the given > + * parametrs

D17493: [WIP] Implementation of an Easy Mode in KCM fonts module

davidedmundson added inline comments. INLINE COMMENTS > harmathy wrote in fonts.cpp:505 > This doesn't work on current kde-neon/dev/unstable > > The Qt documentation http://doc.qt.io/qt-5/qqmlengine.html#addImageProvider > says: > > > All required image providers should be added to the engine

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.11 - Build # 120 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.11/120/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 11 Dec 2018 13:30:13 + Build duration: 3 min 25 sec and counting

D17482: Upload new screenshots in the documentation and uncomment a section

yurchor added a comment. Fixed. Thanks. Sorry for been negligent when reviewing this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb, #documentation, davidedmundson, yurchor, broulik Cc: broulik, yurchor, plasma-devel, kde-doc-english,

D17482: Upload new screenshots in the documentation and uncomment a section

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. Breaks build of plasma-desktoop: index.docbook:104: parser error : Opening and ending tag mismatch: variablelist line 53 and article ^ index.docbook:118:

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.11 - Build # 120 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.11/120/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 11 Dec 2018 13:14:10 + Build duration: 1 min 41 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.11 - Build # 119 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.11/119/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 11 Dec 2018 13:14:12 + Build duration: 1 min 26 sec and counting CONSOLE OUTPUT

D17482: Upload new screenshots in the documentation and uncomment a section

This revision was automatically updated to reflect the committed changes. Closed by commit R119:86bc4bb1f806: Upload new screenshots in the documentation and uncomment a section (authored by ognarb). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17487: Check if the form has changed, and only reconnect if it has

jgrulich added a comment. It looks good to me and makes sense. I'll try to ask those who had problems to connect to Cisco AnyConnect servers with my first attempt. Thank you for looking into that. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D17482: Upload new screenshots in the documentation and uncomment a section

ognarb added a comment. In D17482#375170 , @yurchor wrote: > Oops... Sorry. No problems :) Thanks for the review. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb,

D17482: Upload new screenshots in the documentation and uncomment a section

yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Oops... Sorry. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D17482 To: ognarb, #documentation, davidedmundson, yurchor Cc: yurchor,

D17482: Upload new screenshots in the documentation and uncomment a section

ognarb added inline comments. INLINE COMMENTS > yurchor wrote in index.docbook:103 > To keep the result valid this line should be removed as well. Look line 78, I just moved the beginning of the comment. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17482

D17493: [WIP] Implementation of an Easy Mode in KCM fonts module

harmathy added a comment. Thanks for the help. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17493 To: harmathy Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17346: Support Bluetooth batteries

broulik added a comment. No. Can we not digress from this, I just need an icon... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17346 To: broulik, #plasma, bruns, #vdg Cc: abetts, ndavis, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17493: Implementation of an Easy Mode in KCM fonts module

broulik added a comment. > Is there another way to mark this as "not ready"? We typically write "WIP:" or "RFC:" in the title, you can also set the review status to "Changes planned" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17493 To: harmathy Cc:

D17493: Implementation of an Easy Mode in KCM fonts module

harmathy added a comment. Please consider this work in progress. There are no reviewers. Is there another way to mark this as "not ready"? INLINE COMMENTS > fonts.cpp:505 > engine()->addImageProvider("preview", new > PreviewImageProvider(generalFont())); > +

D17412: [kcms/fonts] Don't set minimium DPI value

This revision was automatically updated to reflect the committed changes. Closed by commit R119:61b6e098f825: [kcms/fonts] Dont set minimium DPI value (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17412?vs=47060=47342

D17482: Upload new screenshots in the documentation and uncomment a section

yurchor requested changes to this revision. yurchor added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > index.docbook:103 > > --> > To keep the result valid this line should be removed as well. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17501: Install Platform theme plugin into bin/platformthemes for unit tests

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Unset QT_PLUGIN_PATH my test used to fail, now passes REPOSITORY R135