D17598: Improve "No internet connection!" error message

pino added a comment. The error message is still not optimal (contractions, not correct spelling of "the Internet", etc). "Could not load any application; please verify your network connectivity." REPOSITORY R134 Discover Software Store REVISION DETAIL

D17533: Make the button's purpose more clear

amantia added a comment. I'm not a native speaker, but I don't see how OK/Cancel is better. The dialog shows a question that can be answered with Yes or No. See also the HIG https://hig.kde.org/components/assistance/message.html > - Apply confirmation button labels when further

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein added a comment. Apply button working for me: https://youtu.be/LvMhpCLxdWY REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson, ltoscano, zzag, ngraham Cc: ngraham, davidedmundson, broulik, plasma-devel, kwin, GB_2, mkulinski,

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

hein added a comment. In D14542#376846 , @zzag wrote: > Hmm, I'm no longer able to save new settings, i.e. if any option has been changed, the Apply button is still not enabled. Can you give me more specific steps? Because I can't

D17598: Improve "No internet connection!" error message

ngraham created this revision. ngraham added reviewers: Discover Software Store, VDG, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Old message was a bit unclear. Hopefully this is better. TEST PLAN

D17393: [Folder View] make file context menu consistent with Dolphin's

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d75a37b58992: [Folder View] make file context menu consistent with Dolphins (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17393: [Folder View] make file context menu consistent with Dolphin's

ngraham added a comment. Thanks Eike! :) REPOSITORY R119 Plasma Desktop BRANCH context-menu-consistency-with-dolphin (branched from master) REVISION DETAIL https://phabricator.kde.org/D17393 To: ngraham, #plasma, hein, #vdg, ndavis Cc: ndavis, mart, janpr, plasma-devel, GB_2,

D17393: [Folder View] make file context menu consistent with Dolphin's

hein accepted this revision. hein added a comment. Alrighty, I'll go in with the majority opinion then. Consistency is certainly an improvement by itself. Go go go! REPOSITORY R119 Plasma Desktop BRANCH context-menu-consistency-with-dolphin (branched from master) REVISION DETAIL

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R119:185c0d38381c: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen… (authored by GB_2, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17533: Make the button's purpose more clear

ngraham added a comment. In D17533#376922 , @amantia wrote: > You can't change to Yes/No (that was my first try), as the question might be one of the following: > > - "Activate foo ?" > - "Deactivate foo?" > - "Activate foo and

D17592: Introduce a DelegateRecycler attached object

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It allows us to reach the context of the delegate from our delegate component. TEST PLAN Now I

D17584: SwipeListItem: always show the icons if !supportsMouseEvents

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17584 To: apol, #kirigami, mart, ngraham Cc: ngraham, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17591: Make AbstractCard.background react to AbstractCard.highlighted

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise we'd just see no change TEST PLAN Keyboard navigation in Discover has feedback again

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

GB_2 requested review of this revision. GB_2 added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:58 > This doesn't make sense.. > > We're re-evaulating because hasElement might have changed when switching > themes. So just remove the line? REPOSITORY R119 Plasma

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

abetts added a comment. Thanks Dave! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17321 To: GB_2, #plasma, #vdg, ngraham, davidedmundson Cc: davidedmundson, abetts, ngraham, #vdg, plasma-devel, #plasma, squeakypancakes, alexde, IohannesPetros, GB_2,

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. If Nate and Andy say to use this icon, go for it. One code change INLINE COMMENTS > main.qml:58 > imagePath: "widgets/configuration-icons" > -

D17393: [Folder View] make file context menu consistent with Dolphin's

ngraham added a comment. Since this is VDG-accepted and most of the comments seem to be slightly to strongly positive so far, if I don't get a formal Changes Requested status from someone in #plasma , I'll land on December 19th (or earlier if I get a

D17533: Make the button's purpose more clear

amantia updated this revision to Diff 47590. amantia added a comment. Improve dialog title as well REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47441=47590 BRANCH accesbility_dialog_improvement REVISION DETAIL

D17584: SwipeListItem: always show the icons if !supportsMouseEvents

ngraham accepted this revision as: ngraham. ngraham added a comment. This revision is now accepted and ready to land. Exactly, perfect! REPOSITORY R169 Kirigami BRANCH cosa REVISION DETAIL https://phabricator.kde.org/D17584 To: apol, #kirigami, mart, ngraham Cc: ngraham,

D17584: SwipeListItem: always show the icons if !supportsMouseEvents

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R169 Kirigami BRANCH cosa REVISION DETAIL https://phabricator.kde.org/D17584 AFFECTED FILES

D17583: Simplify code in MnemonicAttached

apol updated this revision to Diff 47579. apol added a comment. Tune in REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17583?vs=47578=47579 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17583 AFFECTED FILES src/mnemonicattached.cpp

D17583: Simplify code in MnemonicAttached

apol updated this revision to Diff 47578. apol added a comment. Polish REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17583?vs=47577=47578 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17583 AFFECTED FILES src/mnemonicattached.cpp

D17583: Simplify code in MnemonicAttached

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Having a map of an object into a value is equivalent to having this value as an attribute.

D17393: [Folder View] make file context menu consistent with Dolphin's

ndavis added a comment. +1 to making the menus the same. In D17393#373155 , @hein wrote: > Can we patch Dolphin instead? I think the order there is pretty bad, with weird random dividers etc. (From the screenshots in the original user bug.)

D17393: [Folder View] make file context menu consistent with Dolphin's

mart added a comment. important is that "open with $default" and "open with..." are grouped together. apart from that i don't have much preferences for one or the other REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17393 To: ngraham, #plasma, hein Cc:

D17448: Revamp README

Aiix accepted this revision. Aiix added a comment. This revision is now accepted and ready to land. Looks good to me, Thanks :) REPOSITORY R846 Mycroft Plasma integration REVISION DETAIL https://phabricator.kde.org/D17448 To: marcinse, Aiix Cc: plasma-devel, GB_2, ragreen, jackyalcine,

D17574: Remove period ( . ) character from the end

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17574 To: shubham, #plasma, #vdg, mart Cc: abetts, GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef,

D17533: Make the button's purpose more clear

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. While we're here, let's change yes to Accept and No to Cancel. Also, the dialog's title should probably be something more descriptive than "Warning". REPOSITORY R119 Plasma

D17533: Make the button's purpose more clear

amantia added a comment. You can't change to Yes/No (that was my first try), as the question might be one of the following: - "Activate foo ?" - "Deactivate foo?" - "Activate foo and deactivate bar?" REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17571: Fix pixmap scaling on HiDPI screens

davidedmundson added a comment. > Aren't the charts and process list handled by libksysguard instead of this repository? This flag affects the process not where the code comes from. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D17571 To: emateli, mlaurent,

D17561: Fix memory leak in notifications applet if only tracking jobs

davidedmundson updated this revision to Diff 47565. davidedmundson added a comment. cover even more cases REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17561?vs=47517=47565 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17561

D17556: Make Status and Notification popup consistent with others.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:743e5583ced0: Make Status and Notification popup consistent with others. (authored by shubham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D17574: Remove period ( . ) character from the end

This revision was automatically updated to reflect the committed changes. Closed by commit R120:998d1a02c670: Remove period ( . ) character from the end (authored by shubham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17574?vs=47551=47563

D17556: Make Status and Notification popup consistent with others.

shubham added a comment. could I go ahead pushing it? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17556 To: shubham, #vdg, broulik, #plasma, mart Cc: fabianr, abetts, loh.tar, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17556: Make Status and Notification popup consistent with others.

loh.tar added a comment. Two more cents. > I feel that all the items are simply too close to the left edge. I agree but currently fit the look with all other applets (at least have there, Volume/Clipboard/Bluetooth). Perhaps could that changed somehow globally? REPOSITORY R120

D17556: Make Status and Notification popup consistent with others.

shubham updated this revision to Diff 47562. shubham added a comment. Use units.smallSpacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17556?vs=47552=47562 REVISION DETAIL https://phabricator.kde.org/D17556 AFFECTED FILES

D17533: Make the button's purprose more clear

amantia added a comment. How it looked before: F6476429: new_dialog.jpg How it looks now: F6476432: new_dialog.jpg REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17533 To:

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

zzag added a comment. In D14542#371677 , @zzag wrote: > - if any virtual desktop is removed, then System Settings window will be sent to the last virtual desktop. Should be addressed by D17576 .

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

zzag added a comment. Hmm, I'm no longer able to save new settings, i.e. if any option has been changed, the Apply button is still not enabled. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson, ltoscano, zzag, ngraham Cc: ngraham,

D17347: Translate color scheme names

broulik added a comment. It seems most codepaths assume the colorscheme names are never translated... `KColorSchemeManager` uses the `Qt::DisplayRole` for mapping. The `Qt::UserRole` contains the full path to the scheme but it never stores just the untranslated name. Affects Krita, Kate,

D17556: Make Status and Notification popup consistent with others.

fabianr added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:98 > topMargin: hiddenItemsView.visible ? units.smallSpacing : 0 > -leftMargin: hiddenItemsView.iconColumnWidth + units.largeSpacing; > +leftMargin: 5 > } Please don't use

D17571: Fix pixmap scaling on HiDPI screens

emateli added a comment. The only difference in the process list is that the plasmashell icon becomes smaller. Aren't the charts and process list handled by libksysguard instead of this repository? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D17571 To:

D17574: Remove period ( . ) character from the end

shubham added a comment. my battery drained in "After" image even though it was charging : ) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17574 To: shubham, #plasma, #vdg, mart Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros,

D17556: Make Status and Notification popup consistent with others.

shubham updated this revision to Diff 47552. shubham edited the summary of this revision. shubham removed a reviewer: hein. shubham added a comment. use 5px margin REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17556?vs=47497=47552 REVISION

D17574: Remove period ( . ) character from the end

GB_2 added a comment. The two images need to be swapped. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17574 To: shubham, #plasma, #vdg, mart Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ndavis,

D17574: Remove period ( . ) character from the end

shubham created this revision. shubham added reviewers: Plasma, VDG. shubham added projects: Plasma, VDG. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REVISION SUMMARY Before: F6476200: 1.png After: F6476201:

D17571: Fix pixmap scaling on HiDPI screens

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. I didnt push D14490 yet as there are issues. For instance, `KWindowSystem::icon` returns incorrect dpr for pixmaps, so the application