D17154: Go back to SCSS

lbeltrame added a comment. https://invent.kde.org/sysadmin/ci-tooling/commit/d3443ccf5b0233f4fd0b19c93d8332046b616f58 adds the PyCairo dependency to the CI, although the build system must still check for it (as it doesn't now). REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D17154: Go back to SCSS

lbeltrame added a comment. In D17154#391718 , @lbeltrame wrote: > > - It requires the Breeze style to be installed to load the color schemes but the dependency isn't checked anywhere This should be hopefully fixed by

KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.11 - Build # 12 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/12/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 11 Jan 2019 23:16:09 + Build duration: 2 min 55 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » breeze-gtk » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.12/4/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 11 Jan 2019 23:16:09 + Build duration: 24 sec and counting CONSOLE OUTPUT [...truncated 148

KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/11/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 11 Jan 2019 23:01:38 + Build duration: 3 min 16 sec and counting CONSOLE OUTPUT [...truncated

D17154: Go back to SCSS

lbeltrame added a comment. In D17154#391718 , @lbeltrame wrote: > > - There are decoding errors in the Python script because it doesn't take into account translations Fixed in

KDE CI: Plasma » breeze-gtk » kf5-qt5 FreeBSDQt5.12 - Build # 3 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.12/3/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 11 Jan 2019 23:01:38 + Build duration: 26 sec and counting CONSOLE OUTPUT [...truncated 148

D17154: Go back to SCSS

lbeltrame added a comment. There are several issues with this patch, which cause build failures: - It requires PyCairo (python3-cairo in openSUSE) but the dependency isn't checked anywhere - It requires the Breeze style to be installed to load the color schemes but the dependency

D18194: Fix autohide behaviour after dragging a panel

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. In D18194#391599 , @scoenen wrote: > I updated the diff as you asked. Just one minor thing: Calling View::restoreGrabItemBehavior()

D18006: Include only the largest size for the "Next" wallpaper

ngraham planned changes to this revision. ngraham added a comment. Per discussion in D18005 , we're not gonna do this for 5.15. Instead we'll try to get a local wallpaper cache, and then we can do it. REPOSITORY R31 Breeze REVISION DETAIL

D18005: Include only the largest size for each wallpaper

This revision was automatically updated to reflect the committed changes. Closed by commit R131:c39e8d7a1003: Include only the largest size for each wallpaper (authored by ngraham). REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18005?vs=49285=49295

D18005: Include only the largest size for each wallpaper

ngraham added a comment. In D18005#391626 , @filipf wrote: > For D18078 it would be best to wait until a save cache is implemented, right? I believe so. Once we have that, we can remove these

D18005: Include only the largest size for each wallpaper

filipf added a comment. For D18078 it would be best to wait until a save cache is implemented, right? BTW, can you **add summer_1am** to `CMakeLists.txt` as a part of this diff? This poor wallpaper has been in the repo for over 3 years but was never

D18194: Fix autohide behaviour after dragging a panel

scoenen updated this revision to Diff 49286. scoenen added a comment. I updated the diff as you asked. Just one minor thing: Calling View::restoreGrabItemBehavior() under X11 seems to be redundant now. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE

D18005: Include only the largest size for each wallpaper

ngraham updated this revision to Diff 49285. ngraham added a comment. Really add symlinks REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18005?vs=49283=49285 BRANCH arcpatch-D18005 REVISION DETAIL https://phabricator.kde.org/D18005

D18005: Include only the largest size for each wallpaper

ngraham updated this revision to Diff 49283. ngraham added a comment. Add compatibility symlinks for images shipped in prior releases REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18005?vs=48779=49283 BRANCH arcpatch-D18005 REVISION DETAIL

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#391560 , @ngraham wrote: > I believe you'll need to file a sysadmin ticket to get that changed. Will do! Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975

D17975: [Notifications] Add padding to notifications

ngraham added a comment. I believe you'll need to file a sysadmin ticket to get that changed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham, davidedmundson Cc: broulik, Codezela, abetts, filipf, davidedmundson,

D18194: Fix autohide behaviour after dragging a panel

mvourlakos added a comment. Can you update your diff with ? F6540248: mouseevent.diff I moved the X code under xwindowinterface which feels better to be and I fixed also the mouse positioning when the drag is started REPOSITORY R878 Latte Dock

D18195: Always draw the tooltip on top of everything else

This revision was automatically updated to reflect the committed changes. Closed by commit R858:8af8d55a408c: Always draw the tooltip on top of everything else (authored by ngraham). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D18195: Always draw the tooltip on top of everything else

ngraham created this revision. ngraham added reviewers: hein, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Without this, the tooltip would be drawn below things that manipulate `z`. With it, the

D18194: Fix autohide behaviour after dragging a panel

scoenen created this revision. scoenen added a project: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. scoenen requested review of this revision. REVISION SUMMARY Currently, when dragging a window from the panel to move it, it breaks the autohide behaviour

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#391371 , @davidedmundson wrote: > @rooty if you want to re-apply for a commit account, I'll approve it. Thank you you guys! One problem though - I used an alias (Pete Cho) on identity.kde.org, but i'd

D18048: [Connections] Add search ellipsis to network connection search

This revision was automatically updated to reflect the committed changes. Closed by commit R116:9c7de905eab3: [Connections] Add search ellipsis to network connection search (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R116 Plasma Network Management Applet

D18047: [plasma-desktop] Add search ellipsis to Font Management and Date and Time

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c52d93976e60: [plasma-desktop] Add search ellipsis to Font Management and Date and Time (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES

D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG

This revision was automatically updated to reflect the committed changes. Closed by commit R126:d8069f6fcbde: [kde-cli-tools] Add search ellipsis to label, make label more consistent with… (authored by Krešimir Čohar kco...@gmail.com, committed by GB_2). REPOSITORY R126 KDE CLI Utilities

D18189: Fix ComboBox

apol created this revision. apol added reviewers: Kirigami, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It wasn't working at all REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master

D17975: [Notifications] Add padding to notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6a625cd61d29: [Notifications] Add padding to notifications (authored by Krešimir Čohar kco...@gmail.com, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D17154: Go back to SCSS

davidedmundson closed this revision. davidedmundson added a comment. Merged. This didn't close because we had to disable the commit hooks. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D17154 To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd,

KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.11 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/10/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 11 Jan 2019 16:17:10 + Build duration: 44 sec and counting CONSOLE OUTPUT [...truncated 251

KDE CI: Plasma » breeze-gtk » kf5-qt5 FreeBSDQt5.12 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.12/2/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 11 Jan 2019 16:17:10 + Build duration: 25 sec and counting CONSOLE OUTPUT [...truncated 148

D18186: set skipTaskbar on SurfaceEvent::SurfaceCreated

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cc8d3e775185: set skipTaskbar on SurfaceEvent::SurfaceCreated (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18186?vs=49249=49250

D18186: set skipTaskbar on SurfaceEvent::SurfaceCreated

mart updated this revision to Diff 49249. mart added a comment. - don't set in the caller REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18186?vs=49248=49249 BRANCH phab/skip REVISION DETAIL https://phabricator.kde.org/D18186 AFFECTED FILES

D18186: set skipTaskbar on SurfaceEvent::SurfaceCreated

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY makes sure the flag is set on time TEST PLAN can't get the panelcontroller in the taskbar anymore

D17975: [Notifications] Add padding to notifications

davidedmundson added a comment. @rooty if you want to re-apply for a commit account, I'll approve it. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham, davidedmundson Cc: broulik, Codezela, abetts,

D17975: [Notifications] Add padding to notifications

davidedmundson added a comment. yep REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham, davidedmundson Cc: broulik, Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton,

D17975: [Notifications] Add padding to notifications

ngraham added a comment. @davidedmundson, does this look good to you? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham, davidedmundson Cc: broulik, Codezela, abetts, filipf, davidedmundson, hein,

D17975: [Notifications] Add padding to notifications

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely, works perfectly now. :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngraham,

D18182: Fix new file creation leading to dupe items on a fresh view

hein updated this revision to Diff 49234. hein added a comment. Forgot a hunk when moving to 5.12 branch. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18182?vs=49233=49234 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D18182

D18182: Fix new file creation leading to dupe items on a fresh view

hein updated this revision to Diff 49233. hein edited the summary of this revision. hein added a comment. Add BUG to message. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18182?vs=49232=49233 BRANCH Plasma/5.12 REVISION DETAIL

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

hein added a comment. Here's my take: https://phabricator.kde.org/D18182 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17689 To: McPain, #plasma, hein, davidedmundson Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18182: Fix new file creation leading to dupe items on a fresh view

hein created this revision. hein added reviewers: Plasma, McPain. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This was a regression caused by the code attempting to insert new items at drop position, if available. `setSortMode` was being called in

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49230. rooty added a comment. Use units.smallSpacing for padding consistently except when bodyText.lineCount > 1, spruce things up REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=49209=49230 BRANCH

D17975: [Notifications] Add padding to notifications

rooty added a comment. You were right! Thank you so much, it was so much easier when I started thinking about it as a math problem rather than a design problem. I'm going to upload another diff, I hope this one stands up to scrutiny. I apologize for the very long "implicitHeight" but it

D17689: [RFC] Positioner: call initMaps even if m_enabled == false

hein added a comment. Thanks for the ping, it worked :) I'm looking into this today. I won't be able to accept this patch as-is, because it's working around the real problem. But it definitely helps in finding it! REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18180: Fix layout issues in the AboutPage personDelegate component

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. the bug is legit.. however i think it should be tried harder to avoid manual layouting, there must be a legit problem somewhere that this is triggering, i would like more

D18180: Fix layout issues in the AboutPage personDelegate component

leinir added a comment. Before (initial): F6539760: image.png Before (after resizing): F6539762: image.png After (after resizing): F6539758: image.png

D18180: Fix layout issues in the AboutPage personDelegate component

leinir created this revision. leinir added a reviewer: Kirigami. leinir added a project: Kirigami. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY Without this patch, a couple of somewhat odd layout issues would happen in the person delegate