D18443: Load Plasma QtQuick settings in KCMShell

2019-01-21 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY BUG: 403314 FIXED-IN: 5.15.0 TEST PLAN Clone of code used in

D15684: DateTime Runner timezone and 24 hour clock time conversion.

2019-01-21 Thread James Smith
smithjd added a comment. Timezone name expansion and multiple matches: F6561200: Screenshot_20190121_164314.png 24-hr conversion and multiple matches: F6561199: Screenshot_20190121_164852.png REPOSITORY

D18318: Prettify and search enable the error page

2019-01-21 Thread Nathaniel Graham
ngraham added a comment. Nice! Now the icon is still too big, especially with color. For these error pages, can we experiment with using a smaller size? I bet half as big would look good. Now that I thin of it, the icon should probably go above the text, too. If the goal was to use the

D18441: [Desktop theme KCM] Use new icon

2019-01-21 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Icon was just introduced with D18433 . The new icon's

D18438: [Task Manager] When closing apps, resize only when mouse is out.

2019-01-21 Thread Thomas Surrel
thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When closing several apps from the task manager with the mouse middle button, it is

Re: Issue with Discover on the Plasma/5.14 branch

2019-01-21 Thread David Edmundson
Presumably also requires 4b6420596ca6a557591c24184a57b7985c77984e and more importantly e8e3160cd20c11090572bd66337b41d9567bf461 from KNS which is a whole new error reporting API with the error codes which you'd need As it's new API any backported fix would need all that to be #ifdef'd, and you'd

D18419: Adjust some KCMs to implement new Appearance section layout

2019-01-21 Thread Nathaniel Graham
ngraham added a comment. I'm trying to get a sense of when we should do this. 1. Improve text on existing QWidgets KCMs to conform to the HIG 2. Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG 3. Port all QWidgets KCMs to QML 4. Merge various KCMs together

Issue with Discover on the Plasma/5.14 branch

2019-01-21 Thread Nate Graham
Hello folks, We have a non-ideal situation with Discover. Its package update functionality is broken for many users of Plasma 5.14 due to https://bugs.kde.org/show_bug.cgi?id=399981. The fix requires: - Frameworks 5.54 for

D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time

2019-01-21 Thread Enrique Melendez
enriquem created this revision. enriquem added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. enriquem requested review of this revision. REVISION SUMMARY The way an invalid certificate fingerprint is saved in the [vpn-secrets] section does not

D18435: Handle ShutdowntypeDefault in KSMserver legacy code

2019-01-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:fc2d0c4f56eb: Handle ShutdowntypeDefault in KSMserver legacy code (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18435: Handle ShutdowntypeDefault in KSMserver legacy code

2019-01-21 Thread David Edmundson
davidedmundson added a comment. > This should go into 5.15, right? Yep. REPOSITORY R120 Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D18435 To: davidedmundson, #plasma, broulik Cc: ngraham, plasma-devel, jraleigh, GB_2,

D18435: Handle ShutdowntypeDefault in KSMserver legacy code

2019-01-21 Thread Nathaniel Graham
ngraham added a comment. This should go into 5.15, right? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18435 To: davidedmundson, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D18435: Handle ShutdowntypeDefault in KSMserver legacy code

2019-01-21 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY In the ksmserver porting most code was moved to explicitly calling logout

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

2019-01-21 Thread Nathaniel Graham
ngraham added a comment. I tried to test this out, but it doesn't apply to master anymore. Applying and then rebasing on master results in a ton of merge conflicts. :( Is there any movement on this? It would be a real shame to let such a huge amount of valuable work rot away. Even just

D15684: DateTime Runner timezone and 24 hour clock time conversion.

2019-01-21 Thread Nathaniel Graham
ngraham added a comment. Some screenshots would be helpful here. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15684 To: smithjd, #plasma, mart Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D18321: support for the concept of expandible items

2019-01-21 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:2e7602f3fa5f: support for the concept of expandible items (authored by mart). CHANGED PRIOR TO COMMIT

D18430: [DesktopView] Don't set a window icon

2019-01-21 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The desktop view isn't visible in the task bar, tabbox, and neither does it have a window

D17217: Implement free memory notifier

2019-01-21 Thread Oleg Solovyov
McPain added a comment. In D17217#378768 , @davidedmundson wrote: > > Thanks. Any examples in KDE? I can't implement this from scratch right now. > > There is not, it would requires writing new C code. > It's something I can help with.

D18428: actually remove unused ksnrc file

2019-01-21 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R99:f43864feb2d0: actually remove unused ksnrc file (authored by sitter). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18428?vs=49989=49990

D18428: actually remove unused ksnrc file

2019-01-21 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this file is not getting installed for years. it was dropped in

D18318: Prettify and search enable the error page

2019-01-21 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 49984. leinir added a comment. Changes as discussed: The component is now all nice and centered, and the icon is fully opaque. Yup, much prettier all 'round, and would be nice and easy to turn into a full-on component :) F6559581: image.png

Monday meeting minutes for 2019-01-21 (week 4)

2019-01-21 Thread Kai Uwe Broulik
Hi all, this week's meeting minutes for Plasma: notmart === * fixed loading of default iconset deco from lnf package * (5.16) systemsettings sidebar icons are now 32 px with less margin, as agreed with VDG d_ed * fixed a kscreen-kwin crash * Back on some wayland work: * added

D18318: Prettify and search enable the error page

2019-01-21 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D18318#395986 , @ngraham wrote: > +1 for always showing the search field. But that icon looks a bit big. I might make it smaller and lose the opacity. > > Also, while we're prettifying the error page, how about

D18419: Adjust some KCMs to implement new Appearance section layout

2019-01-21 Thread David Edmundson
davidedmundson added a comment. To clarify one thing, I didn't say "porting". The original task was to go through all of them unifying them, rethinking design and following Fabian's new HIG as well as making sure all options are in the right place, etc.. I personally don't particularly care