D18607: Add a popup search bar to the plasma-nm applet

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good to me and also seems to work properly. Wait for @ngraham if he agrees with this, but I think it's okay in this form and it will not bother people by forcing them a

D18607: Add a popup search bar to the plasma-nm applet

jgrulich added a comment. In D18607#402657 , @abetts wrote: > Does the hug allow for just a search button and a non-always visible search field? Yep, I want to have it visible only when a user opens it manually, it shouldn't be visible

D18607: Add a popup search bar to the plasma-nm applet

abetts added a comment. Does the hug allow for just a search button and a non-always visible search field? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18607 To: vpilo, #vdg, #plasma Cc: abetts, jgrulich, ngraham, davidedmundson,

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. In D18621#402605 , @alexeymin wrote: > In D18621#402558 , @ngraham wrote: > > > In my opinion, this sort of thing is a "help the user feel in control" issue. > > >

D18607: Add a popup search bar to the plasma-nm applet

jgrulich added a comment. +1, I actually like it now with the search button. I will try it properly later and go through your code. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18607 To: vpilo, #vdg, #plasma Cc: jgrulich, ngraham,

D18621: Add again a button to manually scan for wireless networks

vpilo updated this revision to Diff 50583. vpilo added a comment. - Review comments: change button tooltip REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18621?vs=50566=50583 BRANCH vpilo/refreshButton (branched from master)

D18607: Add a popup search bar to the plasma-nm applet

vpilo marked an inline comment as done. vpilo added inline comments. INLINE COMMENTS > PopupDialog.qml:45 > > -Toolbar { > -id: toolbar > +ColumnLayout { > +anchors.fill: parent This is to solve layouting issues when toggling the search bar. REPOSITORY R116 Plasma

D18607: Add a popup search bar to the plasma-nm applet

vpilo updated this revision to Diff 50582. vpilo added a comment. - New implementation with a toolbutton - Also added search reset on Esc keypress, on applet close, on search close I made a few tests and with all 3 toolbuttons (wifi/mobile/airplane) in place, also adding the search

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 50581. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15189?vs=50580=50581 REVISION DETAIL https://phabricator.kde.org/D15189 AFFECTED FILES kioclient/kioclient.cpp To: achauvel, #frameworks, dfaure,

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 50580. achauvel added a comment. Added an `ifdef` so that it could compile with older version of KIO. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15189?vs=47987=50580 REVISION DETAIL

D18341: Support icons from local files in buttons

nicolasfella added a comment. Ping? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18341 To: nicolasfella, #plasma, mart Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

dfaure added a comment. #include #if KIO_VERSION >= QT_VERSION_CHECK(5,55,0) ... #endif REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, anthonyfieroni, ngraham,

D18621: Add again a button to manually scan for wireless networks

alexeymin added a comment. In D18621#402558 , @ngraham wrote: > In my opinion, this sort of thing is a "help the user feel in control" issue. +1, it would be cool to have a button to scan for wireless networks. Today I tried to connect

D18621: Add again a button to manually scan for wireless networks

vpilo added a comment. In D18621#402558 , @ngraham wrote: > In my opinion, this sort of thing is a "help the user feel in control" issue. We had the same sort of conversations in Discover back when it didn't have a manual "refresh updates"

D10156: Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked

zzag added a comment. We have to send a configure event when the resize is complete. So far it looks like this change tries to prevent that; when clientFinishUserMovedResized is emitted, geometry updates are still blocked and there is no RequestGeometryBlocker around. REPOSITORY R108

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel added a comment. @dfaure I don’t see how to do that, since there does not seem to have such `ifdef` in the actual codebase. However I can make `set(KF5_MIN_VERSION "5.55.0")` instead of 5.54.0 in the `CMakeLists.txt`. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL

D18607: Add a popup search bar to the plasma-nm applet

jgrulich added a comment. Besides, it doesn't seem to work as it should: 1. It removed the button in the top right corner which opens the KCM 2. When I restart plasmashell, the search bar is visible even when I have only 4 connections (no scrollbar), typing some text and clearing it

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. In D18621#402559 , @jgrulich wrote: > I'm wrong, it actually doesn't perform scanning when the applet is opened. It should maybe be doing that, do initial scan on applet popup and then every 15 seconds only if you keep

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. I'm wrong, it actually doesn't perform scanning when the applet is opened. It should maybe be doing that, do initial scan on applet popup and then every 15 seconds only if you keep it opened. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D18621: Add again a button to manually scan for wireless networks

ngraham added a comment. In D18621#402540 , @jgrulich wrote: > I don't think this should be added again, there is no reason to. Plasma-nm will do an initial scan once the applet is opened so you get the new networks immediately. This has been

D18607: Add a popup search bar to the plasma-nm applet

ngraham added a comment. In D18607#402549 , @jgrulich wrote: > only when you start typing. Not a great idea since there's no way to know you can search if you start typing; it would be an invisible UI and nobody would ever find it.

D18620: Display shortcut badges while holding Super

trmdi updated this revision to Diff 50574. trmdi marked an inline comment as done. trmdi retitled this revision from "Display shortcut badges while holding Super_L" to "Display shortcut badges while holding Super". trmdi edited the summary of this revision. REPOSITORY R878 Latte Dock CHANGES

D18607: Add a popup search bar to the plasma-nm applet

jgrulich added a comment. With this approach I will basically see it all the time, you can have just one connection hidden and the search bar will pop up, I don't want that and in my opinion it doesn't look good. Either should be placed in the toolbar or visible only when you start typing.

D18620: Display shortcut badges while holding Super_L

mvourlakos added inline comments. INLINE COMMENTS > globalshortcuts.cpp:278 > +//display shortcut badges while holding Meta > +m_mKeyInfoTimer.setInterval(1000); > +connect(_mKeyInfoTimer, ::timeout, this, [&]() { I think a lower interval may be better e.g. 500ms REPOSITORY R878

D18621: Add again a button to manually scan for wireless networks

jgrulich added a comment. I don't think this should be added again, there is no reason to. Plasma-nm will do an initial scan once the applet is opened so you get the new networks immediately. This has been discussed with NetworkManager developers and everyone has to do now periodic scanning

D18621: Add again a button to manually scan for wireless networks

ngraham added a comment. +1, this annoys me too. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18621 To: vpilo, #vdg, #plasma, jgrulich, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18620: Display shortcut badges while holding Super_L

mvourlakos added inline comments. INLINE COMMENTS > globalshortcuts.cpp:283 > +connect(_keyInfo, ::keyPressed, this, [&](Qt::Key > key, bool state) { > +if (key == Qt::Key_Super_L && state) { > +m_mKeyInfoTimer.start(); shouldnt this be valid for

D18620: Display shortcut badges while holding Super_L

trmdi updated this revision to Diff 50569. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18620?vs=50564=50569 REVISION DETAIL https://phabricator.kde.org/D18620 AFFECTED FILES CMakeLists.txt README.md app/CMakeLists.txt app/globalshortcuts.cpp

D18620: Display shortcut badges while holding Super_L

trmdi added a comment. In D18620#402521 , @mvourlakos wrote: > @trmdi > > 1. does it work? any issues? > 2. under wayland did you have any success? 1. It works without any issue with my use case. Not sure other cases. Can you

D18620: Display shortcut badges while holding Super_L

mvourlakos added a comment. @trmdi 1. does it work? any issues? 2. under wayland did you have any success? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18620 To: trmdi, #latte_dock, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18620: Display shortcut badges while holding Super_L

mvourlakos requested changes to this revision. mvourlakos added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:57 > KF5::CoreAddons > +KF5::GuiAddons > KF5::GlobalAccel please add the new framework to README file also REPOSITORY

D18607: Add a popup search bar to the plasma-nm applet

vpilo added inline comments. INLINE COMMENTS > davidedmundson wrote in PopupDialog.qml:81 > The connection view changes height depending on the presence of a search bar > The search bar becomes visible depending on the height of the listview > > I would expect that to be giving binding loops

D18607: Add a popup search bar to the plasma-nm applet

vpilo updated this revision to Diff 50567. vpilo added a comment. - review Up, not down No label Changed search label REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18607?vs=50518=50567 BRANCH vpilo/searchBar (branched

D18621: Add again a button to manually scan for wireless networks

ngraham added inline comments. INLINE COMMENTS > Toolbar.qml:124 > + > +tooltip: i18n("Rescan wireless networks") > +iconSource: "view-refresh" How about "Scan for new wireless networks"? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D18621: Add again a button to manually scan for wireless networks

vpilo created this revision. vpilo added reviewers: VDG, Plasma, jgrulich, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vpilo requested review of this revision. REVISION SUMMARY The current 15 seconds timeout is really annoyingly long. NetworkManager

D18607: Add a popup search bar to the plasma-nm applet

ngraham added a comment. BTW regardless of where we put the search field, its placeholder text should just be `Search...`. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18607 To: vpilo, #vdg, #plasma Cc: jgrulich, ngraham, davidedmundson,

D18607: Add a popup search bar to the plasma-nm applet

vpilo added a comment. Here's my latest change, not submitted yet. | F6576947: short.png | F6576946: search.png | F6576945: long.png | | The differences are that I

D18620: Display shortcut badges while holding Super_L

trmdi created this revision. trmdi added reviewers: Latte Dock, mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Use `KModifierKeyInfo` to display shortcut badges while holding Super_L BUG: 401768

D18619: property to override the globaltoolbar style of a single page

mart added a comment. F6576894: Screenshot_20190130_171634.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18619 To: mart, #kirigami, #vdg Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18619: property to override the globaltoolbar style of a single page

mart added a comment. F6576892: Screenshot_20190130_171551.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18619 To: mart, #kirigami, #vdg Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18619: property to override the globaltoolbar style of a single page

mart added a comment. F6576890: vokoscreen-2019-01-30_17-08-42.mp4 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18619 To: mart, #kirigami, #vdg Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18619: property to override the globaltoolbar style of a single page

mart created this revision. mart added reviewers: Kirigami, VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY add a property in page to override the globaltoolbar style, to either force a top toolbar on a

D18607: Add a popup search bar to the plasma-nm applet

ngraham added a comment. In D18607#402435 , @jgrulich wrote: > Alternatively we can show a small input box just saying "Search ..." and clicking into it to start typing it would hide all the switches in the toolbar (wifi, wwan, airplane) and

D17809: Check icon positions after move

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e2aa89898db3: Check icon positions after move (authored by McPain, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18607: Add a popup search bar to the plasma-nm applet

jgrulich added a comment. > Putting the search bar in the toolbar on top is an interesting idea. There's definitely room on mine. However it does start to feel a bit cramped. +1 for the idea of a search field though. Alternatively we can show a small input box just saying "Search ..."

D18607: Add a popup search bar to the plasma-nm applet

jgrulich added a comment. In D18607#402415 , @ngraham wrote: > In D18607#402363 , @jgrulich wrote: > > > I guess it's not, maybe this can be configured in Phabricator somehow, no idea, I just don't

D18607: Add a popup search bar to the plasma-nm applet

ngraham added a comment. In D18607#402363 , @jgrulich wrote: > I guess it's not, maybe this can be configured in Phabricator somehow, no idea, I just don't want to miss any plasma-nm review as its maintainer. This is something that

D18607: Add a popup search bar to the plasma-nm applet

jgrulich added a comment. In D18607#402360 , @vpilo wrote: > In D18607#402261 , @jgrulich wrote: > > > Wouldn't be a small search bar placed next to the aiplane mode enough? That way it will not

D18607: Add a popup search bar to the plasma-nm applet

vpilo added a comment. In D18607#402261 , @jgrulich wrote: > Wouldn't be a small search bar placed next to the aiplane mode enough? That way it will not need additional vertical space. Hiding it when there is only a small amount of connections

D18615: Fix mime type filter on background selection button

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Ported to explicit QFileDialog instance instead of static method partly

D18614: Fix loading of background image preview

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY 50445f794b3142f29dcc043f3af83c549c694bcd

D18598: Defer initial positions apply until listing is complete

This revision was automatically updated to reflect the committed changes. Closed by commit R119:aaebb51077ae: Defer initial positions apply until listing is complete (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18598?vs=50509=50545#toc REPOSITORY R119 Plasma

D17706: Fix lock screen focus

andreyby added a comment. On x11 flag removal does not affect the created window, we can use this to put the focus. INLINE COMMENTS > graesslin wrote in greeterapp.cpp:460 > David already said it: we cannot do this. Changing the > X11BypassWindowManagerHint flag after the window is created

D17706: Fix lock screen focus

andreyby updated this revision to Diff 50543. andreyby added a comment. It's works for x11 platform. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17706?vs=49444=50543 REVISION DETAIL https://phabricator.kde.org/D17706 AFFECTED FILES greeter/greeterapp.cpp To: andreyby,

D18607: Add a popup search bar to the plasma-nm applet

jgrulich added a comment. Wouldn't be a small search bar placed next to the aiplane mode enough? That way it will not need additional vertical space. Hiding it when there is only a small amount of connections is a good idea. PS: Please add me as a reviewer next time for plasma-nm

D18578: Reduce string objects

tcanabrava added a comment. In D18578#401842 , @apol wrote: > Looks okay from a theoretical point of view, I can expect the practical impact of this be about 0~ :P What I really like about math is that sum of changes with zero impact i

D18579: Rework Sensor Browser

tcanabrava added inline comments. INLINE COMMENTS > argonel wrote in SensorBrowser.cpp:51 > This one caused me to notice the style issues. The rule is "For pointers or > references, use a single space before '*' or '&', but not after" ups. that was a typo. > argonel wrote in