D19148: Make shadow sizes linear

ndavis added a comment. In D19148#416749 , @zzag wrote: > In D19148#416006 , @ndavis wrote: > > > kstyle uses entirely different shadows, even more so compared to the original values for

D19096: Improvements for long label items in Application Dashboard

trmdi added a comment. On some small screens e.g <= 1024x768, `units.iconSizes.large` is a bit too big, it may look better with `units.iconSizes.medium` > property int iconSize: smallScreen ? units.iconSizes.large : units.iconSizes.huge Should I change it in this patch or create

D19210: [Updates page] Try our best to not elide version strings

This revision was automatically updated to reflect the committed changes. Closed by commit R134:d2d33a20b0e0: [Updates page] Try our best to not elide version strings (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D19214: [sddm-theme] WIP, Replace login button label with icon

rooty marked 2 inline comments as done. rooty added a comment. Oh I tried that - the problem is that when I use "iconSource" and then adjust the height by subtracting 1/2 units.smallSpacing (line 106), the icon isn't vertically centered: F6629088: image.png

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. Thanks, much better! Just a few more UI nitpicks. And one more thing: What does "Stored" mean in this context? As a non-Thunderbolt expert, I don't know what this means, and I suspect most users wouln't, either. INLINE COMMENTS > DeviceList.qml:41 > +

D19214: [sddm-theme] WIP, Replace login button label with icon

ngraham added a comment. In D19214#417185 , @rooty wrote: > Issues unresolved so far: > (1) Should this be done at all? I think so! > (2) Should the password field + login button be centered, or should just the password field be

D19214: [sddm-theme] WIP, Replace login button label with icon

ngraham added a comment. +1 for this design as well. It's much better-looking overall. If click targets are a potential problem for touch, my preference would be to make all of the textual elements larger, which would have the effect of scaling everything up--and also making the text

D19214: [sddm-theme] WIP, Replace login button label with icon

rooty added a comment. Issues unresolved so far: (1) Should this be done at all? (2) Should the password field + login button be centered, or should just the password field be centered and the login button lie to its right? Especially considering the impact it would have on the user

D19214: [sddm-theme] WIP, Replace login button label with icon

rooty updated this revision to Diff 52264. rooty added a comment. Apply changes to lock screen as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19214?vs=52263=52264 BRANCH loginbutton-icon (branched from master) REVISION DETAIL

D19214: [sddm-theme] WIP, Replace login button label with icon

rooty added a comment. There's also the problem that even though they're technically the same height, when it's highlighted, the password field just seems taller (the highlight adds a pixel above and below it). F6629062: image.png And yet if I

D19214: [sddm-theme] WIP, Replace login button label with icon

rooty added a comment. In D19214#417178 , @filipf wrote: > Design-wise I've been advocating this as well so it's obviously a +1 from me. > > Usability-wise I'd like use to increase the height of the input field and consequently the login

D19214: [sddm-theme] WIP, Replace login button label with icon

filipf added a comment. Design-wise I've been advocating this as well so it's obviously a +1 from me. Usability-wise I'd like use to increase the height of the input field and consequently the login button size because you have to keep touchscreen users in mind. Bigger button = easier

D19214: [sddm-theme] WIP, Replace login button label with icon

rooty added a comment. By the way, I've been testing this with Breeze Dark only - I don't know why the icon looks a lot dimmer with the Breeze color scheme, hence WIP Also, I don't think that we have consensus yet whether we want this change or not - but in case we decide to go for it,

D19214: [sddm-theme] Replace login button label with icon

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch replaces the login button label "Log In" with an icon, places it to the right of the password field, and centers the

D15907: Compare float values in DecorationButton contains check

romangg added a comment. In D15907#417151 , @zzag wrote: > Tests are not less important than the rest of the project. It's not good that we don't care about their readability. Oh I do care about readability. Did you notice the huge

D15907: Compare float values in DecorationButton contains check

zzag added a comment. Tests are not less important than the rest of the project. It's not good that we don't care about their readability. I'm not convinced by "current autotest fails without the change on current master and works with the patch". Please make the test simpler. I don't

D15907: Compare float values in DecorationButton contains check

romangg added a comment. In D15907#415347 , @zzag wrote: > Looks good to me. > > I think the test is too much complicated. Would it be simpler to have something like > > QTest::addColumn("geometry"); > QTest::addColumn("pos"); >

D19077: Redesign the theme preview window

filipf added a comment. In D19077#417105 , @ngraham wrote: > This introduces a new warning: > WARNING: viewBackgroundColor is deprecated, use backgroundColor with colorSet: Theme.View instead I would use the new value, but it doesn't

D15907: Compare float values in DecorationButton contains check

romangg updated this revision to Diff 52257. romangg marked an inline comment as done. romangg added a comment. - Long variable names REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15907?vs=42753=52257 BRANCH decorationContainsFix

D19209: [sddm-kcm] Adjust Background label and button

rooty updated this revision to Diff 52256. rooty added a comment. Remove "Customize theme" heading REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19209?vs=52235=52256 BRANCH bckgr-label-padding (branched from master) REVISION

D19077: Redesign the theme preview window

ngraham added a comment. This introduces a new warning: WARNING: viewBackgroundColor is deprecated, use backgroundColor with colorSet: Theme.View instead +1 on removing the italic styling. I also think bolding the title is unnecessary too while it's using its maximum size (level

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52255. dvratil added a comment. - fix look of the device list REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=51737=52255 BRANCH arcpatch-D19011 REVISION DETAIL https://phabricator.kde.org/D19011

D19077: Redesign the theme preview window

GB_2 added a comment. In D19077#417065 , @filipf wrote: > OK so down to only one hack now. If possible I'd really like to keep it because it works in 100% of the cases I tested it with and results in better visuals; don't know how to fix on the

D19210: [Updates page] Try our best to not elide version strings

ngraham created this revision. ngraham added reviewers: Discover Software Store, colomar. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY With this patch, Discover will try its back to never elide version

D19077: Redesign the theme preview window

filipf added a comment. OK so down to only one hack now. If possible I'd really like to keep it because it works in 100% of the cases I tested it with and results in better visuals; don't know how to fix on the C++ side of things. Couple of things that might be worthy of being

D19077: Redesign the theme preview window

filipf updated this revision to Diff 52249. filipf added a comment. clean up whitespace, remove MouseArea hacks, remove the double Rectangle hack by defining height with Units.gridUnit, add spacing below the last label, better samples value for the DropShadow REPOSITORY R123 SDDM

D19157: Don't show entries with NoDisplay=true with the applauncher containmentaction

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8192bd3aec27: Dont show entries with NoDisplay=true with the applauncher containmentaction (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ngraham updated this revision to Diff 52242. ngraham marked an inline comment as done. ngraham added a comment. Correct awkward string REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19186?vs=52156=52242 BRANCH use-the-word-sleep (branched from

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ltoscano added inline comments. INLINE COMMENTS > index.docbook:152 > > -If this option is chosen, a special behavior for activity can be chosen. If > this is a presentation activity, you can check the Never shutdown > the screen and Never suspend or shutdown the > computer boxes. It is

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

ngraham added a comment. In D19186#416850 , @aacid wrote: > -0.2 from my side, the thing is called suspend not sleep, if you look for "linux sleep" in a search engine you get references to the sleep (3) and sleep (1) man pages, which would only

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

abetts added a comment. +1 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D19186 To: ngraham, #vdg, #plasma, broulik Cc: abetts, aacid, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed,

D19209: [sddm-kcm] Adjust Background label and button

abetts added a comment. +1 REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: rooty, #vdg, #plasma, filipf, ngraham Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D19209: [sddm-kcm] Adjust Background label and button

filipf added a comment. In D19209#416946 , @rooty wrote: > Also, should we ditch the heading "Customize theme"? It doesn't seem necessary seeing as there's nothing to customize... aside from the wallpaper I'm also in favor of this, it's

D19209: [sddm-kcm] Adjust Background label and button

ngraham added a comment. In D19209#416946 , @rooty wrote: > Also, should we ditch the heading "Customize theme"? It doesn't seem necessary seeing as there's nothing to customize... aside from the wallpaper Yes please! REPOSITORY R123

D19192: [Updates page] Improve selected/unselected explanation view

This revision was automatically updated to reflect the committed changes. Closed by commit R134:5d254de6fa4f: [Updates page] Improve selected/unselected explanation view (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D19192: [Updates page] Improve selected/unselected explanation view

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Otherwise it should go in. INLINE COMMENTS > UpdatesPage.qml:110 > Layout.fillWidth: true > +text: (page.unselected === 0 ? i18n("All updates selected") > :

D19077: Redesign the theme preview window

filipf added a comment. In D19077#416726 , @mmustac wrote: > To be honest this kcm looks out of place when I compare it to the newer refurbished ones. The new look is quite an improvement compared to the current state but when I look at the

D19160: [about-distro] update osrelease parser for latest values in spec

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense, also thanks for adding a test! In Discover we're also parsing os-release files (in 2 places), it could make sense to share this code somehow. REPOSITORY R102 KInfoCenter

D19181: [about-distro] run logo lookup via osrelease

apol added inline comments. INLINE COMMENTS > Module.cpp:153 > + > +QString logoPath = cg.readEntry("LogoPath", QString()); > +if (logoPath.isEmpty()) { Put os.logo as the fallback? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19181 To: sitter Cc:

D19187: unbreak help button activation by not double-resetting the view

apol added a comment. +1 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19187 To: sitter, #plasma Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19077: Redesign the theme preview window

rooty added a comment. In D19077#416726 , @mmustac wrote: > To be honest this kcm looks out of place when I compare it to the newer refurbished ones. The new look is quite an improvement compared to the current state but when I look at the

D19162: Add KAboutData

apol added inline comments. INLINE COMMENTS > powerdevilapp.cpp:69 > + i18nc("@info:credit", "(c) 2015-2019 Kai Uwe > Broulik")); > +aboutData.addAuthor(i18nc("@info:credit", "Kai Uwe Broulik"), > +i18nc("@info:credit", "Maintainer"),

D19209: [sddm-kcm] Adjust Background label and button

rooty added a comment. Also, should we ditch the heading "Customize theme"? It doesn't seem necessary seeing as there's nothing to customize... aside from the wallpaper REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: rooty, #vdg,

D19209: [sddm-kcm] Adjust Background label and button

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch adjusts the "Background:" label (adds padding and changes its alignment) and button to align with the changes implemented

D19206: [Colors KCM] Fix color scheme editor context

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5c879b258391: [Colors KCM] Fix color scheme editor context (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19206?vs=52225=52230

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

aacid added a comment. -0.2 from my side, the thing is called suspend not sleep, if you look for "linux sleep" in a search engine you get references to the sleep (3) and sleep (1) man pages, which would only confuse the users. REPOSITORY R122 Powerdevil REVISION DETAIL

D19206: [Colors KCM] Fix color scheme editor context

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY `Kirigami.Action` has no `parent` TEST PLAN Classic case of "how could this have ever worked"

D18644: GlobalDrawerActionItem: properly reference icon by using group property.

pwegner updated this revision to Diff 52223. pwegner added a comment. rebased with master REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18644?vs=50647=52223 BRANCH arcpatch-D18644_1 REVISION DETAIL https://phabricator.kde.org/D18644 AFFECTED FILES

D18939: KMenuEdit: add search/filter bar

ngraham accepted this revision. ngraham added a comment. LGTM. @cfeck, are you happy now? REPOSITORY R103 KMenu Editor BRANCH search-bar REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham, #plasma, cfeck Cc: ognarb, mlaurent, ngraham, plasma-devel, jraleigh, GB_2,

D19023: [Kickoff] Don't respond to window resizing/tiling shortcuts

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a33e1130612: [Kickoff] Dont respond to window resizing/tiling shortcuts (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19154: [Kickoff] remove hint state

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1312ab1cb4fe: [Kickoff] remove hint state (authored by matthieugras, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19096: Improvements for long label items in Application Dashboard

ngraham added a comment. Works great on my 1920x1080 screen BTW. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma, #vdg Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18716: Add an ActionTextField component

ognarb updated this revision to Diff 52214. ognarb marked 2 inline comments as done. ognarb added a comment. - Revert unrelated change - Use icon.name instead of iconName REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=52204=52214 BRANCH

D19148: Make shadow sizes linear

zzag added a comment. In D19148#416006 , @ndavis wrote: > kstyle uses entirely different shadows, even more so compared to the original values for kdecoration. Should it not be that way? Well, my concern was that now decoration shadows

D18644: GlobalDrawerActionItem: properly reference icon by using group property.

mart added a comment. ping? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18644 To: pwegner, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18716: Add an ActionTextField component

mart added a comment. it''s lmost perfect, just a little point on the icon loading, then is good to go INLINE COMMENTS > MultipleColumnsGallery.qml:61 > Controls.Label { > -anchors.horizontalCenter: parent.horizontalCenter > +Layout.alignment:

D19077: Redesign the theme preview window

mmustac added a comment. To be honest this kcm looks out of place when I compare it to the newer refurbished ones. The new look is quite an improvement compared to the current state but when I look at the color, window decoration kcm we have at first a big grid view and can then customize

D19203: ColumnView and partial C++ refactor of PageRow

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY ColumnView is a container component which encapsulates most of the logic from PageRow (minus the

D19077: Redesign the theme preview window

rooty added a comment. This color "hack" actually makes the rectangle's color match some kind of weird in-between color that's not in the color scheme: F6628246: 75f5ca80-946e-4324-8f24-977fc96bc09b.jpeg It takes on a color like the Applications tab

D19194: Adjust date string height to match time string with vertical panel

ngraham added subscribers: Zren, davidedmundson, ngraham. ngraham added reviewers: Plasma, davidedmundson, Zren. ngraham added a comment. Thank you for the patch! You did great, and on the first try, too! I can confirm that this change fixes the issue for me and I do not notice any

D19194: Adjust date string height to match time string with vertical panel

abetts added a comment. I would probably add just a bit of left and right padding to the time as well. LGTM REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19194 To: antnyzilla, #vdg Cc: abetts, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18716: Add an ActionTextField component

ognarb updated this revision to Diff 52204. ognarb added a comment. - Use Kirigami.Icon instead of Controls.ToolBouton - Fix doc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=52141=52204 BRANCH master REVISION DETAIL

D19179: Use PointingHand when hovering links in Label

This revision was automatically updated to reflect the committed changes. Closed by commit R858:632c9cce4a3b: Use PointingHand when hovering links in Label (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19179?vs=52136=52197#toc REPOSITORY R858 Qt Quick Controls

D19044: [InlineMessage] Do not draw shadows around the message

mart added a comment. - whole InlineMessage should be moved into templates - background: item should be deleted such that it doesn't have any background at all (lines from 123 to 173) - in controls, an InlineMessage.qml is still present, and will be import "templates" as T

D19179: Use PointingHand when hovering links in Label

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. actually the hoverhandler seems not to be adapt for the job, so go for it REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir,

D19180: map powerdevil daemon to product

This revision was automatically updated to reflect the committed changes. Closed by commit R871:3a77c89068f7: map powerdevil daemon to product (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19180?vs=52142=52196 REVISION DETAIL

D15907: Compare float values in DecorationButton contains check

zzag requested changes to this revision. zzag added a comment. This revision now requires changes to proceed. See my comment above. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D15907 To: romangg, #kwin, zzag, davidedmundson Cc: plasma-devel,

D19194: Adjust date string height to match time string with vertical panel

antnyzilla added a comment. Is the panel orientation checked on lines 101, 183, and 256? I haven't noticed any changes or problems with the horizontal panel with this change on my system. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19194 To:

D19194: Adjust date string height to match time string with vertical panel

anthonyfieroni added inline comments. INLINE COMMENTS > DigitalClock.qml:305 > // this can be marginal bigger than contentHeight because of > the horizontal fit > -height: Math.max(0.8 * timeLabel.height, minimumPixelSize) > +height: