KDE CI: Plasma » plasma-browser-integration » stable-kf5-qt5 FreeBSDQt5.13 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-browser-integration/job/stable-kf5-qt5%20FreeBSDQt5.13/24/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 23 Oct 2019 05:53:22 + Build duration: 5 min 23 sec and counting

D24847: KCM Icons fix theme selected when we hit delete theme

ervin added a subscriber: bport. ervin added a comment. Hello, - F7654931: signature.asc REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24847 To: bport, mart, ervin, #plasma, crossi Cc: bport, ngraham, broulik,

D24706: [RFC] Change button style

ndavis added a comment. I think it might be a good idea to add an animation mode for the sunken state. Right now, the transition is just instant. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: ngraham, plasma-devel, LeGast00n,

D24706: [RFC] Change button style

ndavis added a comment. In D24706#552291 , @ngraham wrote: > I'm not a fan of changing the background for focused buttons. I think it just confuses things, and doesn't fix the current problem; it just changes it. IMO focus (not hover, focus)

D24706: [RFC] Change button style

ndavis updated this revision to Diff 68584. ndavis added a comment. - Remove focus background REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24706?vs=68496=68584 BRANCH ndavis/pushbutton-style (branched from master) REVISION DETAIL

D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

apol added a comment. +1 conceptually. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24877 To: davidedmundson, #plasma Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf,

D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

ngraham added a comment. > Deal with a certain distro renaming qdbus. FWIW we have the same issue in other places too (https://bugs.kde.org/show_bug.cgi?id=413007) so perhaps a generic solution would work... or else maybe we should lobby said distro(s?) to make a compatibility symlink.

D24877: RFC: Move shortcuts out of ksmserver into kglobalaccel

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY I want to move the shortcuts out of ksmserver. None of the actions now

D22382: Add global shortcuts for switching to the previous/next activity

muesli added a comment. Would love to finish this one up! :) Any suggestions how to move forward? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22382 To: muesli, apol, davidedmundson, #vdg, #plasma Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n,

D24759: [ksmserver] Drop unused logout effect widget

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9b857cce251f: [ksmserver] Drop unused logout effect widget (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 169 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/169/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 19:49:16 + Build duration: 6 min 51 sec and counting JUnit Tests Name:

D24865: [SystemTray] Support for AttentionIcon

kmaterka requested review of this revision. kmaterka added a comment. I added ugly way of checking if passed QVariant(QIcon) is null. Should I create native C++ method for that check or this can be done in QML, but in nicer way? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D24865: [SystemTray] Support for AttentionIcon

kmaterka added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:52 > +if (taskIcon.status === PlasmaCore.Types.NeedsAttentionStatus) { > +if (AttentionIcon && AttentionIcon != "QVariant(QIcon, > QIcon(null))") { > +return AttentionIcon I

D24865: [SystemTray] Support for AttentionIcon

kmaterka updated this revision to Diff 68566. kmaterka added a comment. Fallback to Icon if there is no AttentionIcon. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24865?vs=68543=68566 BRANCH master REVISION DETAIL

D24870: Apply autoplay prevention evasion also to document.createElement

broulik added a comment. I am not sure. I thought since a video is likely in the DOM or otherwise it won't be visible, the user can at least play it. But then I just remembered how Spotify used a `` tag for playing its music... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D24711: [Mouse KCM] Fix acceleration profile on X11

miraiko added a comment. @romangg sorry for the late reply, all is well, thanks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24711 To: miraiko, #plasma, romangg, ngraham Cc: anthonyfieroni, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24870: Apply autoplay prevention evasion also to document.createElement

fvogt added a comment. Is this not needed for `` as well? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24870 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D24870: Apply autoplay prevention evasion also to document.createElement

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It affects audio player created this way the same as a `new Audio()` BUG: 411742 TEST

D24847: KCM Icons fix theme selected when we hit delete theme

ngraham added a comment. Does this patch have unmarked dependencies? It doesn't apply for me: $ arc patch D24847 INFO Base commit is not in local repository; trying to fetch. created and checked out branch arcpatch-D24847. This diff is against commit

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 168 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/168/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 18:05:17 + Build duration: 7 min 31 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/52/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 17:59:21 + Build duration: 14 min and counting JUnit Tests

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 456 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/456/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 18:05:16 + Build duration: 8 min 13 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/14/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 18:01:08 + Build duration: 9 min 26 sec and counting JUnit Tests

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/37/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 18:03:13 + Build duration: 5 min 22 sec and counting JUnit Tests Name:

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 74 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/74/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 18:03:16 + Build duration: 4 min 0 sec and counting JUnit Tests

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 39 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/39/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 18:01:07 + Build duration: 3 min 57 sec and counting JUnit Tests

D24192: WIP: Active page follow the focus

mart added a comment. loses the focus after changing page because when current item changes, it sets focus to the page, which probably isn't set as focus scope INLINE COMMENTS > ognarb wrote in PageRow.qml:172 > @mart removePage doesn't work well, how can I change the current page? what do

D24861: Fix size of SpinBoxes

This revision was automatically updated to reflect the committed changes. kmaterka marked an inline comment as done. Closed by commit R885:2481a8eb6a22: Fix size of SpinBoxes (authored by kmaterka). REPOSITORY R885 Redshift Control for Plasma CHANGES SINCE LAST UPDATE

D24861: Fix size of SpinBoxes

kmaterka marked an inline comment as done. kmaterka added inline comments. INLINE COMMENTS > ngraham wrote in ConfigGeneral.qml:64 > Don't hardcode things like this; instead do `Kirigami.Units.gridUnit * 4` OK, I made it the same width as IconPicker, it should look nice REPOSITORY R885

D24861: Fix size of SpinBoxes

kmaterka updated this revision to Diff 68558. kmaterka added a comment. Do not use hardcoded values REPOSITORY R885 Redshift Control for Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24861?vs=68529=68558 BRANCH master REVISION DETAIL

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

anthonyfieroni added a comment. You can try it like that: if (!m_editMode) { event->setAccepted(false); } REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24748 To: davidedmundson, #plasma Cc: anthonyfieroni, wbauer, plasma-devel,

Plasma 5.17.1

Plasma 5.17.1 is now released https://www.kde.org/announcements/plasma-5.17.1.php

D24861: Fix size of SpinBoxes

ngraham added inline comments. INLINE COMMENTS > ConfigGeneral.qml:64 > id: manualTemperatureStep > +Layout.minimumWidth: 80 > decimals: 0 Don't hardcode things like this; instead do `Kirigami.Units.gridUnit * 4` REPOSITORY R885 Redshift Control for

D24706: [RFC] Change button style

ngraham added a comment. I'm not a fan of changing the background for focused buttons. I think it just confuses things, and doesn't fix the current problem; it just changes it. IMO focus (not hover, focus) should be indicated exclusively with an outline around the control drawn in the

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 51 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/51/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 14:40:47 + Build duration: 27 min and counting CONSOLE OUTPUT

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 73 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/73/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 14:52:27 + Build duration: 13 min and counting CONSOLE OUTPUT

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

wbauer added a comment. One thing maybe: with the Desktop layout, if you switch an applet to edit mode (by pressing and holding the left mouse button), it's not possible to exit edit mode by left-clicking on the desktop (even if no left-click action is configured). You need to click on a

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 36 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/36/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 14:52:21 + Build duration: 14 min and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 201 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/201/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 14:51:10 + Build duration: 10 min and counting CONSOLE OUTPUT

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b3065f7db0d6: Install krunner desktop file to ${KDE_INSTALL_APPDIR} (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven updated this revision to Diff 68550. meven added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24857?vs=68523=68550 BRANCH arcpatch-D24857 REVISION DETAIL https://phabricator.kde.org/D24857 AFFECTED FILES

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 13 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/13/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 14:38:49 + Build duration: 6 min 1 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 38 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/38/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 14:38:52 + Build duration: 4 min 50 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 455 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/455/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 14:22:28 + Build duration: 9 min 49 sec and counting CONSOLE OUTPUT

D24798: Migrate QQC1 to QQC2

kmaterka added inline comments. INLINE COMMENTS > ngraham wrote in configTimeZones.qml:53 > While you're doing some porting, this entire thing can be replaced with a > `Kirigami.InlineMessage` which will drastically reduce the amount of code > here, and you can also remove the

D24711: [Mouse KCM] Fix acceleration profile on X11

This revision was automatically updated to reflect the committed changes. Closed by commit R119:829501dd7779: [Mouse KCM] Fix acceleration profile on X11 (authored by miraiko, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24732: Rewrite AppChooser dialog

ngraham added a reviewer: VDG. ngraham added a comment. There still isn't a border around the inner view. That's what I'm trying to get there. Otherwise it doesn't look like an inner view; it looks like a floating rectangle. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop

D24732: Rewrite AppChooser dialog

jgrulich added a comment. Updated screenshot: F7649124: Screenshot_20191022_161043.png To be honest, I liked the result more when the "view" wasn't using a different background. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 454 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/454/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 22 Oct 2019 13:52:18 + Build duration: 15 min and counting CONSOLE OUTPUT [...truncated

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka marked 3 inline comments as done. kmaterka added a comment. In D24853#552228 , @ngraham wrote: > Some of this partially conflicts with D24798 FWIW. I can wait and rebase later - your

D24855: Rename "Close Edit Mode" tooltip to just "Close"

ngraham added a comment. > n alternative would be "Finish Customizing Layout" so it matches the menu entry. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24855 To: GB_2, #plasma, #vdg Cc: ngraham, #vdg, plasma-devel, #plasma, LeGast00n,

D24856: Add a .desktop file to ksplashqml

ngraham added inline comments. INLINE COMMENTS > ksplashqml.desktop.cmake:3 > +Exec=@CMAKE_INSTALL_PREFIX@/bin/ksplashqml > +Name=ksplashqml > +NoDisplay=true Human readable name please REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24856 To: meven, apol,

D24853: [DigitalClock] Fix layout and QML warnings

ngraham added a comment. Some of this partially conflicts with D24798 FWIW. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24853 To: kmaterka, #plasma, #plasma_workspaces Cc: ngraham, davidedmundson, plasma-devel,

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 166 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/166/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 22 Oct 2019 13:52:19 + Build duration: 2 min 5 sec and counting CONSOLE OUTPUT

D24822: Port the desktoptheme kcm to ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R119:331c25893d06: Port the desktoptheme kcm to ManagedConfigModule (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24822?vs=68409=68547

D24866: Wired setting: improve handling of link negotiation

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Adds option to ignore link-negotiation, also uses a combobox, similar to what nm-connection-editor is using, to give a choice

D24844: [Applet] Remove hamburger button and menu

ngraham abandoned this revision. ngraham added a comment. All right, sounds like this needs to go back to the drawing board. Sorry for raising everyone's blood pressure. :) @manueljlin has some very nice mockups for an improved UI. Perhaps a saner approach is to first implement those,

D24865: [SystemTray] Support for AttentionIcon

kmaterka added a comment. In D24865#552202 , @broulik wrote: > You might want to split that into a proper if statement otherwise it becomes somewhat hard to read. Something like > > source: { > if (taskIcon.status ===

D24865: [SystemTray] Support for AttentionIcon

broulik added a comment. You might want to split that into a proper if statement otherwise it becomes somewhat hard to read. Something like source: { if (taskIcon.status === PlasmaCore.Types.NeedsAttentionStatus && (AttentionIcon || AttentionIconName)) { return

D24865: [SystemTray] Support for AttentionIcon

kmaterka added a comment. I need to add one more check: when AttentionIcon is not set, it should fallback to Icon(Name) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24865 To: kmaterka, #plasma, broulik, #plasma_workspaces Cc: lbeltrame,

D24865: [SystemTray] Support for AttentionIcon

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks for following up! (Out of curiosity, do we not need to fall back to the regular icon in case it doesn't have an attention icon in needs attention state? Spec only says "can be

D24865: [SystemTray] Support for AttentionIcon

lbeltrame added a comment. Tested, works. +1. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24865 To: kmaterka, #plasma, broulik, #plasma_workspaces Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24865: [SystemTray] Support for AttentionIcon

kmaterka updated this revision to Diff 68543. kmaterka added a comment. Use enum for status check REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24865?vs=68541=68543 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24865 AFFECTED

D24865: [SystemTray] Support for AttentionIcon

kmaterka added a comment. In D24865#552191 , @broulik wrote: > `PlasmaCore.IconItem` has a `status` property, so you probably need to explicitly check `taskIcon.status` then it should work with the proper enum Oh! Now it looks obvious! I

D24767: [SystemTray] Support for AttentionIcon

kmaterka added a comment. In D24767#552096 , @broulik wrote: > Doesn't this break the binding for `source`? My tray icons don't update anymore Fix in D24865 , sorry... REPOSITORY R120 Plasma

D24865: [SystemTray] Support for AttentionIcon

broulik added a comment. `PlasmaCore.IconItem` has a `status` property, so you probably need to explicitly check `taskIcon.status` then it should work with the proper enum REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24865 To: kmaterka, #plasma,

D24865: [SystemTray] Support for AttentionIcon

kmaterka created this revision. kmaterka added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Adding support for Attention Icon to StatusNotifier tray icons. Binding is working

D24730: Port KCMSplashScreen to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:77b27da43cd2: Port KCMSplashScreen to KConfigXT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24730?vs=68532=68534 REVISION DETAIL

D24731: KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fd1f77d5dbff: KCMSplashScreen fix warning, use KPackage::Package instead of Plasma::Package (authored by crossi). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY

D24819: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method private, typo in enum declaration

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1b857f927037: KCM LookAndFeel : Remove unused Q_PROPERTIES, getter const, internal method… (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24820: KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package

This revision was automatically updated to reflect the committed changes. Closed by commit R119:550a9a25d628: KCM LookAndFeel : fix warnings, use KPackage instead of Plasma::Package (authored by crossi). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY R119

D24729: remove unnecessary ; + add const to getter + typo in Roles declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c402ff93c219: remove unnecessary ; + add const to getter + typo in Roles declaration. (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24730: Port KCMSplashScreen to KConfigXT

crossi updated this revision to Diff 68532. crossi added a comment. Use both key and name tag in entry to generate pretty signals' name. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24730?vs=68450=68532 REVISION DETAIL

D24848: fix kcm fonts "typo" on connect

ervin accepted this revision. ervin added a comment. In D24848#551863 , @broulik wrote: > Interesting, I thought Qt would/could static_assert that Well, it turns out the signatures were compatible in fact (getters connected to a function

D24767: [SystemTray] Support for AttentionIcon

kmaterka added a comment. In D24767#552096 , @broulik wrote: > Doesn't this break the binding for `source`? My tray icons don't update anymore Hmm, I will test that. It is possible :/ Definitely there is something wrong with

D24861: Fix size of SpinBoxes

kmaterka created this revision. kmaterka added reviewers: martinkostolny, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY The numbers in the text entry box for "Manual Brightness Step" in the

D24767: [SystemTray] Support for AttentionIcon

broulik added a comment. Doesn't this break the binding for `source`? My tray icons don't update anymore REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24767 To: kmaterka, #plasma, davidedmundson, apol, mart, ngraham Cc: broulik, plasma-devel, LeGast00n,

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka updated this revision to Diff 68524. kmaterka marked 3 inline comments as done. kmaterka added a comment. Review changes: Kirigami component, removed anchors REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24853?vs=68512=68524 BRANCH

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka marked 3 inline comments as done. kmaterka added inline comments. INLINE COMMENTS > davidedmundson wrote in configTimeZones.qml:32 > Do you need these? > > Generally it's a sign of a problem or bad layering if the root item has > anchors in it. Ops, copy from HolidayConfig.qml. I'll

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven updated this revision to Diff 68523. meven added a comment. Fix unrelated change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24857?vs=68522=68523 BRANCH arcpatch-D24857 REVISION DETAIL https://phabricator.kde.org/D24857 AFFECTED

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven updated this revision to Diff 68522. meven added a comment. Fix unrelated change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24857?vs=68521=68522 BRANCH arcpatch-D24857 REVISION DETAIL https://phabricator.kde.org/D24857 AFFECTED

D24857: Install krunner desktop file to ${KDE_INSTALL_APPDIR}

meven created this revision. meven added reviewers: apol, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY To avoid kwin warnings in ~/.local/share/sddm/wayland-session.log such as : kwin_core: Could not

D24856: Add a .desktop file to ksplashqml

meven created this revision. meven added reviewers: apol, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY To prevent warnings in kwin such as : kwin_core: Did not grant the interface

D24765: Notification applet on the phone

This revision was automatically updated to reflect the committed changes. Closed by commit R120:739935124269: Notification applet on the phone (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24765?vs=68518=68519 REVISION DETAIL

D24765: Notification applet on the phone

mart updated this revision to Diff 68518. mart added a comment. - remove unused import REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24765?vs=68517=68518 BRANCH mart/mobilenotifications REVISION DETAIL https://phabricator.kde.org/D24765

D24765: Notification applet on the phone

mart updated this revision to Diff 68517. mart added a comment. - always show jobs REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24765?vs=68455=68517 BRANCH mart/mobilenotifications REVISION DETAIL https://phabricator.kde.org/D24765

D24853: [DigitalClock] Fix layout and QML warnings

davidedmundson added a comment. Concept +1, I love layouts INLINE COMMENTS > configTimeZones.qml:32 > id: timeZonesPage > -width: parent.width > -height: parent.height > +anchors.left: parent.left > +anchors.right: parent.right Do you need these? Generally it's a sign

D24854: [Desktop Toolbox] Add missing i18n domain

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c79902431d9a: [Desktop Toolbox] Add missing i18n domain (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24854?vs=68513=68515 REVISION

D24855: Rename "Close Edit Mode" tooltip to just "Close"

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY We don't call it the "edit mode" anywhere else in the UI. An alternative would be "Finish Customizing

D24854: [Desktop Toolbox] Add missing i18n domain

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 413227 FIXED-IN: 5.17.1 TEST PLAN My toolbox is now ridiculously long "Werkzeugkasten

D24853: [DigitalClock] Fix layout and QML warnings

kmaterka created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY Fixed issue when time zone configuration page was not scaling corrently. As a result two srollbars were rendered. Fixed few

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

GB_2 updated this revision to Diff 68510. GB_2 added a comment. Avoid negating entire boolean statements REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24839?vs=68480=68510 BRANCH arcpatch-D24839 REVISION DETAIL

D24849: [Windows Runner] Gather window again when running result

This revision was automatically updated to reflect the committed changes. Closed by commit R120:549374ba5f1e: [Windows Runner] Gather window again when running result (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24711: [Mouse KCM] Fix acceleration profile on X11

romangg added a comment. In D24711#551742 , @romangg wrote: > @miraiko Do you have an email address that should be used for the commit? Name Mirai Komachi, right? ping @miraiko REPOSITORY R119 Plasma Desktop BRANCH

D24849: [Windows Runner] Gather window again when running result

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Since we fixed `RunnerManager::teardown` to actually be emitted, the runner would throw away its

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68502. jgrulich added a comment. - Add Kirigami2 as a dependency REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68501=68502 BRANCH new-app-dialog REVISION DETAIL

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68501. jgrulich added a comment. - Code improvements REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68382=68501 BRANCH new-app-dialog REVISION DETAIL

D24706: [RFC] Change button style

ndavis added a comment. Currently, this makes text on light colorschemes that use a light Selection Text color difficult to read. To fix that and keep this look, one of these things will need to happen: -Change the colorschemes to use dark Selection Text on light themes. For

D24839: Only show "Unlock Widgets" in the UI, not "Lock Widgets"

broulik added inline comments. INLINE COMMENTS > menu.cpp:146 > +// Only show "Unlock Widgets" in the UI, not "Lock Widgets" > +if (!(name == QLatin1String("lock widgets") && > c->corona()->immutability() == Plasma::Types::Mutable)) { > +

D24846: Port kcm icons to kconfigxt

bport added inline comments. INLINE COMMENTS > broulik wrote in IconSizePopup.qml:45 > Do you not need to leave this (or a similar) connect in place? This one is replaced (and that fix bug described above by call onVisibleChange) and with kconfigxt property handling > broulik wrote in

  1   2   >