KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 188 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/188/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 04:35:04 + Build duration: 23 min and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 20 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/20/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 31 Oct 2019 04:33:33 + Build duration: 18 min and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 187 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/187/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 02:25:13 + Build duration: 2 min 14 sec and counting CONSOLE OUTPUT

D24126: [GTK3] CSD windows show handles on .solid-csd

davidedmundson added a comment. Code wise. Very sensible +++ Good to know gtk thought about our case. Pixel pushing details I'll leave up to the vdg, but +1 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24126 To: cblack, #breeze, ngraham, ndavis Cc:

D24743: Update GTK settings according to Plasma settings

ervin added inline comments. INLINE COMMENTS > configeditor.cpp:49 > +QString > configLocation(QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation)); > +QString gtk3ConfigPath(configLocation + "/gtk-3.0/settings.ini"); > + Better wrap the const char* in a

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 419 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/419/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 29 Oct 2019 11:06:06 + Build duration: 1 day 7 hr and counting

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. Approach is fine, but please move the MouseArea into the audioStreamIconLoader's source component so it's not always instantiated even when it's not needed. :) REPOSITORY R119

D24126: [GTK3] CSD windows show handles on .solid-csd

wbauer added a comment. FTR, we got a downstream bug report about this for openSUSE Leap 15.1 (which ships Plasma 5.12 LTS): https://bugzilla.opensuse.org/show_bug.cgi?id=1155387 That's mainly why I asked... ;-) REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Looks good to me. Please just wait a bit before pushing to give David a chance to object to my comments. ;-) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kpropertywriter_p.h:26 > Throwing out another option > > class KPropertyWriter : public QObject, public QQmlPropertyValueSource > { > Q_INVOKABLE bool writeProperty(QVariant value); > } > >

D25082: [applets/weather] Reduce label minimum width to accommodate narrow vertical panels

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The temperature label's minimum width was set high enough to overflow in a narrow vertical

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin added a comment. In D25000#556761 , @davidedmundson wrote: > There's a Plasma rule that if we're working round a Qt bug, there should be a Qt bug created and linked before accepting a workaround. > > From the sounds of it we want a

D24847: KCM Icons fix theme selected when we hit delete theme

bport added a comment. Indeed don't know why even if isSaveNeeded return true, button is not updated. I will investigate Thanks for the catch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24847 To: bport, mart, ervin, #plasma, crossi, ngraham Cc: bport,

Re: KF6 Sprint

Hi, we have a date and venue by now: November 22 - 24 at the MBition office in Berlin (Dovestraße 1, 10587 Berlin), that's right after the Qt Contributor Summit to reduce travel overhead a bit. Thanks to Eike and Agustin for making this possible! Please subscribe to

D25081: [kcms/krdb] Fix krdb executable

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY krdb is mostly a library used by some KCMs. It also exists as an

Notes from 5.18 kickoff meeting

apol, nate, veggero, romang, fvogt, gb_2, bhushan, veqz, ahiemstra, nicofee, notmart, kbroulik, leinir Discuss VDG priorities: Breeze theme evolution https://phabricator.kde.org/T10891. also (Re)define modes when editing panels and widgets, Discuss themes being installed by default Discussed

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19822 To: faridb, #plasma, #vdg, ngraham, hein, GB_2 Cc: GB_2, mart, hein, filipf, mvourlakos, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24847: KCM Icons fix theme selected when we hit delete theme

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. The behavior is now fine, but your ability to actually delete icon themes has regressed. Once you click on a delegate's inline delete button, the apply button at the bottom of

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham added a comment. In D25055#556755 , @mart wrote: > In D25055#556752 , @ngraham wrote: > > > In D25055#556751 , @mart wrote: > > > > > I would

D25000: Do not assign combobox currentIndex as it breaks binding.

davidedmundson added inline comments. INLINE COMMENTS > kpropertywriter_p.h:26 > + > +class KPropertyWriter : public QObject > +{ Throwing out another option class KPropertyWriter : public QObject, public QQmlPropertyValueSource { Q_INVOKABLE bool writeProperty(QVariant value); }

D25000: Do not assign combobox currentIndex as it breaks binding.

davidedmundson added a comment. There's a Plasma rule that if we're working round a Qt bug, there should be a Qt bug created and linked before accepting a workaround. From the sounds of it we want a QQuickControls::ComboBox::setIndex(int) invokable that doesn't update the binding? Or

D25055: [containments/desktop] Delete the "Tweaks" page and its options

mart added a comment. In D25055#556756 , @GB_2 wrote: > I wonder, can that be added to mouse actions instead of a page with only one option? makes sense REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25055: [containments/desktop] Delete the "Tweaks" page and its options

GB_2 added a comment. I wonder, can that be added to mouse actions instead of a page with only one option? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham, mart, GB_2, #plasma, hein Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25055: [containments/desktop] Delete the "Tweaks" page and its options

mart added a comment. In D25055#556752 , @ngraham wrote: > In D25055#556751 , @mart wrote: > > > I would prefer keeping the press to move stuff > > > As far as I could tell, the option on this

D25055: [containments/desktop] Delete the "Tweaks" page and its options

GB_2 added a comment. In D25055#556751 , @mart wrote: > I would prefer keeping the press to move stuff Is there a reason to disable it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham,

D25055: [containments/desktop] Delete the "Tweaks" page and its options

mart added a comment. I would prefer keeping the press to move stuff REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham, mart, GB_2, #plasma, hein Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham marked an inline comment as done. ngraham added a comment. In D25055#556751 , @mart wrote: > I would prefer keeping the press to move stuff As far as I could tell, the option on this page doesn't actually change anything anymore.

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 473 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/473/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 30 Oct 2019 14:56:43 + Build duration: 5 min 55 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 186 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/186/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 30 Oct 2019 14:56:43 + Build duration: 2 min 51 sec and counting CONSOLE OUTPUT

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > broulik wrote in main.qml:268 > A conf update isn't needed as it's this code hiding the toolbox when > disabled, so without it it will just always show Ah of course! REPOSITORY R119 Plasma Desktop

D24855: Rename "Close Edit Mode" tooltip to "Finish Customizing Layout"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a74c3657a071: Rename Close Edit Mode tooltip to Finish Customizing Layout (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25055: [containments/desktop] Delete the "Tweaks" page and its options

broulik added a comment. +1 INLINE COMMENTS > main.qml:268 > -property: "visible" > -value: plasmoid.configuration.showToolbox > -} A conf update isn't needed as it's this code hiding the toolbox when disabled, so without it it will just always show REPOSITORY R119

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi updated this revision to Diff 69055. crossi added a comment. Missing const ref, rename private header accordingly REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25000?vs=69053=69055 REVISION DETAIL

Plasma 5.18 features document

https://share.kde.org/s/6AfZWwfcweKHi68 please add new features! -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature

D24916: KCM style : fix combobox that weren't updated after user made change

ervin added a comment. Once we got D25000 completed, please remember to abandon that one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24916 To: crossi, #plasma, ervin, mart, bport Cc: broulik, plasma-devel, LeGast00n,

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Almost there! Glad we're getting near a proper fix. Can you confirm this works with *and* without D24916 applied? Can you also confirm this

D24126: [GTK3] CSD windows show handles on .solid-csd

cblack added a comment. In D24126#556711 , @wbauer wrote: > In D24126#556709 , @ngraham wrote: > > > Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC. > > > Indeed,

D24126: [GTK3] CSD windows show handles on .solid-csd

ngraham added a comment. Yeah, probably. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24126 To: cblack, #breeze, ngraham, ndavis Cc: wbauer, ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24126: [GTK3] CSD windows show handles on .solid-csd

wbauer added a comment. In D24126#556709 , @ngraham wrote: > Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC. Indeed, 5.12 didn't use scss yet to generate gtk.css, but contains the gtk.css in the first place.

D24126: [GTK3] CSD windows show handles on .solid-csd

ngraham added a comment. Doubtful; it relies on the scss rewrite which happened in 5.15 or 5.16 IIRC. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24126 To: cblack, #breeze, ngraham, ndavis Cc: wbauer, ngraham, ndavis, plasma-devel, LeGast00n,

D24744: Remove unneeded options in GTK KCM

ngraham added a comment. "Absolutely not" is right. We can't remove this option entirely; that would be a big regression. If not all apps respect it, we need to fix those apps. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari,

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi updated this revision to Diff 69053. crossi added a comment. Remove assignement to currentIndex. Add a C++ bypass to setCurrentIndex without breaking the binding. REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D24856: Add a .desktop file to ksplashqml

apol added inline comments. INLINE COMMENTS > ksplashqml.desktop.cmake:7 > +Type=Application > +X-KDE-Wayland-Interfaces=org_kde_plasma_window_management > + Are you sure the wayland interface is required? It seems like the warning is broken, so we could just as well remove it. REPOSITORY

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 185 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/185/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 30 Oct 2019 12:17:52 + Build duration: 13 min and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 472 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/472/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 30 Oct 2019 12:17:52 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncated

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

This revision was automatically updated to reflect the committed changes. Closed by commit R119:61cd3d4b19a9: Adjust QtQuickSettings KCM to use KConfigXT in full (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25068?vs=69038=69049

D25076: Force reevaluating state on pending deletion changes

This revision was automatically updated to reflect the committed changes. Closed by commit R119:35c84cb5f9d2: Force reevaluating state on pending deletion changes (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25076?vs=69046=69050

D24847: KCM Icons fix theme selected when we hit delete theme

ervin added a comment. nitpick, but otherwise LGTM, giving time to others (in particular Nate) to chip in. INLINE COMMENTS > iconsmodel.cpp:87 > } > - > emit pendingDeletionsChanged(); I'd say keep the empty line please. REPOSITORY R119 Plasma Desktop REVISION

D24846: Port kcm icons to kconfigxt

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:101 > > -connect(m_model, ::selectedThemeChanged, this, [this] { > -m_selectedThemeDirty = true; > -setNeedsSave(true); > -

D24870: Apply autoplay prevention evasion also to document.createElement

broulik planned changes to this revision. broulik added a comment. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24870 To: broulik, #plasma, fvogt Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24870: Apply autoplay prevention evasion also to document.createElement

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. IMO this looks uglier than multiline C macros, but ok... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24870 To: broulik, #plasma, fvogt Cc:

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in renderer.kcfg:10 > Will this mean we write "automaticloop" to the config file? > > If so, we'll need to change the KQuickAddons::QtQuickSettings::init > As it passes the variables in the config directly to Qt envs, which

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

davidedmundson added a comment. That's significantly tidier! INLINE COMMENTS > renderer.kcfg:10 > + > + > + Will this mean we write "automaticloop" to the config file? If so, we'll need to change the KQuickAddons::QtQuickSettings::init As it

D25076: Force reevaluating state on pending deletion changes

ervin created this revision. ervin added reviewers: Plasma, bport, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This was missing and thus the apply button wouldn't get enabled in case

D25074: Disable the restore defaults button if the KCModule says so

ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D25074 AFFECTED

D25068: Adjust QtQuickSettings KCM to use KConfigXT in full

ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This removes quite a lot of uneeded code and fixes the automatic default

D24744: Remove unneeded options in GTK KCM

broulik added a comment. > remove it from the view and always set it to "one page per click"? Absolutely not. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2, plasma-devel,

D24744: Remove unneeded options in GTK KCM

GB_2 added a comment. I'd be fine with that (we could always add it later in the Application Style KCM when we have it for Qt). REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24744 To: gikari, #vdg, #plasma Cc: ngraham, broulik, filipf, GB_2,

D24847: KCM Icons fix theme selected when we hit delete theme

bport updated this revision to Diff 69037. bport added a comment. Take Nate feedback and do a proper fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24847?vs=68499=69037 REVISION DETAIL https://phabricator.kde.org/D24847 AFFECTED FILES

D24846: Port kcm icons to kconfigxt

bport updated this revision to Diff 69036. bport added a comment. Take in consideration feedback (cache kicon call) Port to ManagedConfigModule REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24846?vs=68498=69036 REVISION DETAIL

5.18 kickoff meeting today

Plasma 5.18 kickoff meeting today in less than 4 hours at 14:00UTC/15:00CET

D24126: [GTK3] CSD windows show handles on .solid-csd

wbauer added a comment. Could this be backported to 5.12 too maybe? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24126 To: cblack, #breeze, ngraham, ndavis Cc: wbauer, ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24942: Require and use the new NewStuffQuick Button component

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c21a8bd82ec2: Require and use the new NewStuffQuick Button component (authored by leinir). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24744: Remove unneeded options in GTK KCM

gikari added a comment. In D24744#550210 , @ngraham wrote: > In D24744#549568 , @broulik wrote: > > > Ideally, we'd also sync `SH_ScrollBar_LeftClickAbsolutePosition` to GTK and drop the cursor to

D24942: Require and use the new NewStuffQuick Button component

leinir added a comment. In D24942#556062 , @ngraham wrote: > Thanks, that fixes the issue. This works quite well now. > > Would be nice to address the bugs I filed before 5.18 is released so it really gets polished up all nice and shiny. :)