D28134: Add ColorUtils

cblack updated this revision to Diff 78069. cblack added a comment. Add linear interpolation, alpha blending, colour adjustment, and colour scaling REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=78030=78069 BRANCH cblack/colour-utils

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 636 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/636/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Mar 2020 02:45:42 + Build duration: 1 hr 28 min and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 477 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/477/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 02:45:42 + Build duration: 28 min and counting JUnit Tests Name: projectroot

D27669: [kstyle] Tools area

cblack added a comment. In D27669#630974 , @ngraham wrote: > Nice, the colors are better now. I still see a difference in animation speed when the titlebar and toolbar change color though. It's especially visible with the current Breeze color

D27669: [kstyle] Tools area

ngraham added a comment. Nice, the colors are better now. I still see a difference in animation speed when the titlebar and toolbar change color though. It's especially visible with the current Breeze color scheme. F8185590: vokoscreenNG-2020-03-19_20-53-04.webm

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 635 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/635/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Mar 2020 02:06:02 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated 2852

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 476 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/476/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 02:06:02 + Build duration: 7 min 2 sec and counting CONSOLE OUTPUT [...truncated

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78065. cblack added a comment. Use better heuristic for determining if a widget has the correct palette set REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78063=78065 BRANCH cblack/toolsarea REVISION DETAIL

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. F8185503: Screenshot_20200320_022339.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 78064. bruns added a comment. Use Kirigami.Action for Trash REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=77574=78064 BRANCH baloo_config_rework REVISION DETAIL https://phabricator.kde.org/D28025

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. In D28025#630882 , @ngraham wrote: > In D28025#630849 , @bruns wrote: > > > Having only inclusion/exclusion is a temporary state. I plan to add more settings for each path, so

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78063. cblack marked 10 inline comments as done. cblack added a comment. Address feedback REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=77529=78063 BRANCH cblack/toolsarea REVISION DETAIL

D27669: [kstyle] Tools area

cblack added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breeze.h:104 > Why would this be more "ugly" as when there was no toolarea ? can you post a > screeshot of the said ugliness ? With: F8185479: image.png Without: F8185480: image.png

D28154: Add users KCM

cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch introduces a new users KCM based off of the AccountsService. Co-authored-by:

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. In D28025#630849 , @bruns wrote: > Having only inclusion/exclusion is a temporary state. I plan to add more settings for each path, so having an "add" button for each possible state will no longer be feasible. > >

D28098: remove pointless and arbitrary 4 line frame limit

ahmadsamir added a comment. This makes sense; also it fixes a part of the backtraceparsertest unit test, test_bug168000, which currently fails on master (output after export'ing QT_LOGGING_RULES="*drkonqi*=true"): 3: QDEBUG : BacktraceParserTest::btParserUsefulnessTest(test_bug168000)

D27935: Make kwallet-pam work with pam_fscrypt

This revision was automatically updated to reflect the committed changes. Closed by commit R107:2bb4c6dc870f: Make kwallet-pam work with pam_fscrypt (authored by aacid). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27935?vs=77963=78049

D28146: [applets/appmenu] Use libtaskmanager for appmenus

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d8d079e42e62: [applets/appmenu] Use libtaskmanager for appmenus (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28146?vs=78047=78048

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack updated this revision to Diff 78047. cblack marked 2 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28146?vs=78040=78047 BRANCH appmenu-use-libtm (branched from master)

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. In D28025#630729 , @ngraham wrote: > I have some UI suggestions: > > - Have a button to add an exclusion path as well as a button to add an inclusion path, rather than a single Add Setting button, which is a rather

D28146: [applets/appmenu] Use libtaskmanager for appmenus

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > appmenumodel.cpp:124 > +m_tasksModel->setScreenGeometry(geometry); > emit screenGeometryChanged(); > } I think you can just connect this signal to our

D28148: Fix broken paths in kirigami.qrc.in

masonm created this revision. masonm added reviewers: Kirigami, VDG. masonm added a project: Kirigami. Herald added a subscriber: plasma-devel. masonm requested review of this revision. REVISION SUMMARY Fix path for private/CardsGridViewPrivate.qml and private/CardsListViewPrivate.qml. TEST

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack added a comment. In D28146#630781 , @broulik wrote: > When filtering by screen, this now means we get appmenu only when the active window is on the same screen? Not sure if this is what we want? > (Perhaps we could do some clever "last

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack updated this revision to Diff 78040. cblack added a comment. Remove extraneous change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28146?vs=78039=78040 BRANCH appmenu-use-libtm (branched from master) REVISION DETAIL

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack updated this revision to Diff 78039. cblack marked 6 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28146?vs=78038=78039 BRANCH appmenu-use-libtm (branched from master)

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack marked an inline comment as done. cblack added inline comments. INLINE COMMENTS > broulik wrote in CMakeLists.txt:15 > Unused Linkage fails without it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28146 To: cblack, #plasma Cc: broulik,

D28146: [applets/appmenu] Use libtaskmanager for appmenus

broulik added a comment. I love patches with a lot of red! When filtering by screen, this now means we get appmenu only when the active window is on the same screen? Not sure if this is what we want? (Perhaps we could do some clever "last window with menu" tracking so we can have

D28146: [applets/appmenu] Use libtaskmanager for appmenus

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This patch ports the appmenu applet to use libtaskmanager. TEST PLAN Ensure that there aren't

D26200: Add shortcut for closing pages

ngraham added a comment. In D26200#589355 , @mart wrote: > hmm, not sure about it. > it would probably be ok for most of the cases, but i'm pretty sure it may break some existing app. > an app may want at least two pages always loaded for

D27555: Add a category for kde-only and gnome-only apps

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Requesting changes to remove from the review queue given that I have open icon and string change requests REPOSITORY R134 Discover Software Store REVISION DETAIL

D27783: Add new Account portal

ngraham added a comment. UserInfoDialog.qml an Item with a Rectangle in it, could you use a Window? https://doc.qt.io/qt-5/qml-qtquick-window-window.html REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D27783 To: jgrulich,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham requested changes to this revision. ngraham added a reviewer: mart. ngraham added a comment. This revision now requires changes to proceed. I have some UI suggestions: - Have a button to add an exclusion path as well as a button to add an inclusion path, rather than a single Add

Re: KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 779 - Still unstable!

This was a real breakage. It is super important, we could be preventing other people from doing any development work. Please can people be more on top of CI failures. Any failure should have someone either fix it, even if you didn't cause it, or write up an explanation of why it's not an issue.

D28143: Add "veryLongDuration" animation duration

ngraham updated this revision to Diff 78037. ngraham added a comment. Forgot one thing REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28143?vs=78029=78037 BRANCH veryLongDuration (branched from master) REVISION DETAIL

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 779 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/779/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Mar 2020 18:18:02 + Build duration: 9 min 51 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 778 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/778/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Mar 2020 17:59:20 + Build duration: 14 min and counting CONSOLE OUTPUT [...truncated

Re: KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Failing!

I investigated this (slightly) it seems these are false positives. A new method was introduced in kcrash, that symbol is exported, then this fails to link. It implies this is just the CI system linking against an old kcrash until frameworks sync. David

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 777 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/777/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Mar 2020 17:32:46 + Build duration: 1 min 38 sec and counting CONSOLE OUTPUT

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5e7d26dc5e38: [libtaskmanager] Add ApplicationMenu{ObjectPath,ServiceName} roles to model (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

cblack updated this revision to Diff 78032. cblack marked 2 inline comments as done. cblack added a comment. Address last feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27959?vs=77950=78032 BRANCH cblack/appmenu-libtaskmanager

D28134: Add ColorUtils

cblack updated this revision to Diff 78030. cblack added a comment. Asynchronous return values REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77976=78030 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134

D28143: Add "veryLongDuration" animation duration

ngraham created this revision. ngraham added reviewers: VDG, Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY As discussed in D28033#630649 . TEST

D28109: [applets/systemtray] Simplify icon size logic

ngraham added a comment. Depends on the view; most people don't seem to use Phab's homepage so much compared to the email notifications generated when you mention people like @broulik, @mart, or @davidedmundson ;) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D28109: [applets/systemtray] Simplify icon size logic

kmaterka added a comment. In D28109#629974 , @ngraham wrote: > This looks like a sensible refactor to me, and it solves the issue that I was having with icon size changing based on the expanded popup visibility. I can't detect any regressions

D25428: Improved support for desktop "Folder View"

cfeck added a comment. Anyone else able to review this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: cfeck, mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27509: Introduce ProcessDataModel

davidedmundson updated this revision to Diff 78025. davidedmundson marked 3 inline comments as done. davidedmundson added a comment. lambdas everywhere REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27509?vs=76653=78025 BRANCH master REVISION

D28142: Display PID & signal numbers unlocalized

kossebau added a comment. Not tested though, somehow my setup prevents my custom drkonqi to show up. So far I just know it tells and should work in theory. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28142 To: kossebau, #plasma, sitter Cc: plasma-devel, Orage,

D28142: Display PID & signal numbers unlocalized

kossebau created this revision. kossebau added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY These are less numbers, but more identifiers in the system. REPOSITORY R871 DrKonqi

D28136: Add the option to show the current activity name and icon

ivan added a comment. > used Layouts instead of Anchors I know, I'm oldschool - when I was young, we didn't have QML, Kirigami and ... :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28136 To: ivan, #plasma, ngraham, davidedmundson, mart Cc:

D28136: Add the option to show the current activity name and icon

This revision was automatically updated to reflect the committed changes. Closed by commit R119:36e322792002: Add the option to show the current activity name and icon (authored by ivan). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27166: Refactor converter runner

alex added inline comments. INLINE COMMENTS > broulik wrote in converterrunner.cpp:74 > There's also units with µ, Ω, . (fl.oz.), not taking into account how those > might be localized, so using a very specific regexp looks somewhat brittle to > me. Can't really think of a better way,

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 78020. ahiemstra added a comment. - Add some documentation to classes REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=78017=78020 BRANCH sensors_lib REVISION DETAIL

D28136: Add the option to show the current activity name and icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! I'd still prefer if main.qml used Layouts instead of Anchors, I also still think the option to show a generic icon is not really very useful; I have a hard time envisioning

D28098: remove pointless and arbitrary 4 line frame limit

ahmadsamir added a comment. In D28098#629338 , @bcooksley wrote: > There should be no further changes to Dr Konqi at this time as it fails to build from source on both FreeBSD and Windows. > Please see the relevant CI jobs for more

D27166: Refactor converter runner

broulik added inline comments. INLINE COMMENTS > converterrunner.cpp:74 > +const QString valueGroup = > QStringLiteral("(?P<%1>[0-9,./]+)").arg(valueKey); > +const QString unitGroups = > QStringLiteral("(?P<%1>[a-zA-Z/\"'^0-9\\p{Sc}²³]+)"); > +const QString sourceUnitGroup =

D28136: Add the option to show the current activity name and icon

ivan added a comment. Last change - use "activities" icon if no icon is set (though this should not happen if the user creates the activity through legal ways) REVISION DETAIL https://phabricator.kde.org/D28136 To: ivan, #plasma, ngraham, davidedmundson, mart Cc: plasma-devel, Orage,

D27166: Refactor converter runner

alex added a comment. > "5 EUR" produces: 4.6095 GBP, 5.467 USD, 7.8745 CAD with too many decimals (@sitter says this is some unrelated bug) > "5 m²" doesn't yield any results. In fact none of the ² or ³ do Fixed in the latest commit. > Units seem to be matching case sensitive

D28136: Add the option to show the current activity name and icon

ivan updated this revision to Diff 78018. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28136?vs=78014=78018 REVISION DETAIL https://phabricator.kde.org/D28136 AFFECTED FILES applets/showActivityManager/package/contents/config/config.qml

D28027: fix line rating for new format when function name is missing

ahmadsamir added a comment. In D28027#630512 , @sitter wrote: > D28026 Ah, yes, that's where those "packagekit" lines are. Thanks :) REPOSITORY R871 DrKonqi BRANCH parse-rate REVISION DETAIL

D28141: Add KSysGuard::Sensors library

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a new library for communicating with a new KSysGuard DBus-based daemon that

D27166: Refactor converter runner

alex updated this revision to Diff 78016. alex added a comment. Fix regex, round currencies to two decimal counts REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=78007=78016 BRANCH converter_runner_refactoring (branched from master)

D28136: Add the option to show the current activity name and icon

ivan marked 3 inline comments as done. ivan added a comment. Done REVISION DETAIL https://phabricator.kde.org/D28136 To: ivan, #plasma, ngraham, davidedmundson, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D28136: Add the option to show the current activity name and icon

ivan updated this revision to Diff 78014. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28136?vs=78006=78014 REVISION DETAIL https://phabricator.kde.org/D28136 AFFECTED FILES applets/showActivityManager/package/contents/config/config.qml

D27166: Refactor converter runner

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. Please also add test cases for the regressions Kai highlighted. Thanks! INLINE COMMENTS > broulik wrote in converterrunnertest.cpp:75 > I think you should change the locale for

D27166: Refactor converter runner

broulik added a comment. Nice refactoring work! Quick testing suggests a few issues, however. I haven't verified if they have been present before or are in KUnitConversion, but: "5 EUR" produces: 4.6095 GBP, 5.467 USD7.8745 CAD (@sitter says this is some unrelated bug) "5 l/100km"

D28140: Add a declarative plugin to ProcessCore

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a QML plugin to ProcessCore that exposes ProcessController and allows it to be

D28136: Add the option to show the current activity name and icon

ngraham added inline comments. INLINE COMMENTS > ConfigAppearance.qml:48 > +} > + > +CheckBox { I would add some whitespace between these, since they're different logical groups. You can easily do this with the following: `item { Kirigami.FormData.isSection: true }` REVISION DETAIL

D27096: Refactoring, improve validation in kcm, optimize

This revision was automatically updated to reflect the committed changes. Closed by commit R114:8dd8fe555a1e: characters: Refactoring, improve validation in kcm, optimize (authored by alex, committed by sitter). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D25984: Load translations

vkrause added a comment. In D25984#589426 , @mart wrote: > ping, what's the current status of this? There's also https://phabricator.kde.org/D27595, which might address the same/a similar issue. REPOSITORY R169 Kirigami REVISION

D28129: Read the new message string after rather than before

sitter added a comment. Quick recap from what we talked about on telegram: putting the print after the bt is most definitely going to throw off the backtrace parsing logic, so doing it this way would require extensive changes there, which is a dangerous place to make extensive changes. Or

D27166: Refactor converter runner

alex updated this revision to Diff 78007. alex added a comment. Implement requested changes REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27166?vs=77899=78007 BRANCH converter_runner_refactoring (branched from master) REVISION DETAIL

D28136: Add the option to show the current activity name and icon

ivan added a comment. Kirigami has quite interesting features I must say :) REVISION DETAIL https://phabricator.kde.org/D28136 To: ivan, #plasma, ngraham, davidedmundson, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D28136: Add the option to show the current activity name and icon

ivan updated this revision to Diff 78006. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28136?vs=77985=78006 REVISION DETAIL https://phabricator.kde.org/D28136 AFFECTED FILES applets/showActivityManager/package/contents/config/config.qml

D27869: Separate processcore/{formatter,unit} into its own library

This revision was automatically updated to reflect the committed changes. Closed by commit R111:182fbd95dc94: Separate processcore/{formatter,unit} into its own library (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 776 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/776/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 19 Mar 2020 14:27:54 + Build duration: 1 min 32 sec and counting CONSOLE OUTPUT

D28138: some static analyzer improvements for service runner

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fab5b5e26d7e: some static analyzer improvements for service runner (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28138?vs=78001=78004#toc REPOSITORY R120 Plasma

D28027: fix line rating for new format when function name is missing

sitter added a comment. D28026 REPOSITORY R871 DrKonqi BRANCH parse-rate REVISION DETAIL https://phabricator.kde.org/D28027 To: sitter, cfeck, ngraham Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28136: Add the option to show the current activity name and icon

ivan added a comment. The reason for the icon setting is to have full backwards compatibility. Maybe someone likes the static icon better than random icons they set for each activity. I don't like to have everything configurable, but here it is not a significant maintainance overhead, and

D27980: make opengl module support multiple dri devices

sitter updated this revision to Diff 78003. sitter added a comment. - isValid is const now - use qdiriterator - use QFile::encodeName for the stat call REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27980?vs=77716=78003 BRANCH multidri REVISION

D28138: some static analyzer improvements for service runner

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > servicerunner.cpp:114 > +for(int i = 1; i < strList.size(); ++i) { > +const auto = strList[i]; > if (category ==

D28138: some static analyzer improvements for service runner

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY - be more consty (and don't risk detatching containers) - init members - don't ql1s to qstring

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

zzag added a comment. Urgh, the authorship information is screwed up. :/ REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14910 To: graesslin, #kwin, #frameworks, davidedmundson, zzag Cc: plasma-devel, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

This revision was automatically updated to reflect the committed changes. Closed by commit R127:6bfa71d89aee: Pass a dedicated fd to each keyboard for the xkb keymap (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14910?vs=77916=78000

D28137: make servicerunner only build once

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY build the runner itself in a static lib we can use for testing and then link that into a module

D27980: make opengl module support multiple dri devices

pino added inline comments. INLINE COMMENTS > sitter wrote in opengl.cpp:210 > Is that also true for paths that are only ascii? Specifically path is a /dev > node. sure, i get this specific path is ascii the general recommendation is to use QFile::encodeName for QString -> C paths

D28136: Add the option to show the current activity name and icon

ngraham added a comment. Pretty nice! I wonder if we even need an option for the activity option though. How about this: if the activity has an icon, always show it. If it doesn't, show the generic one. That would probably satisfy everyone automatically, by re-using the user's preference

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/75/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Mar 2020 13:18:46 + Build duration: 14 min and counting CONSOLE OUTPUT [...truncated 294

D28027: fix line rating for new format when function name is missing

ahmadsamir added a comment. This doesn't apply cleanly. REPOSITORY R871 DrKonqi BRANCH parse-rate REVISION DETAIL https://phabricator.kde.org/D28027 To: sitter, cfeck, ngraham Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 17 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/17/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Thu, 19 Mar 2020 13:18:44 + Build duration: 2 min 17 sec and counting CONSOLE OUTPUT

D27166: Refactor converter runner

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:23 > +endif() > \ No newline at end of file No newline at end of file > CMakeLists.txt:6 > +ecm_add_test(converterrunnertest.cpp TEST_NAME

D28042: [DrKonqi] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R871:8d8062fe6bdc: [DrKonqi] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28042?vs=77744=77995 REVISION

D27980: make opengl module support multiple dri devices

sitter added inline comments. INLINE COMMENTS > pino wrote in opengl.cpp:210 > qPrintable is wrong when passing paths to native C functions; use > QFile::encodeName instead Is that also true for paths that are only ascii? Specifically path is a /dev node. > pino wrote in opengl.cpp:230-233 >

D28135: Port away from deprecated QSet/QList methods in some places

ahmadsamir added inline comments. INLINE COMMENTS > anthonyfieroni wrote in runnermodel.cpp:179 > But toSet() returns new container m_runners and runners are unmodified. I don't mind reverting that bit, but it seems wasteful to me to throw newRunners away, it is sorted and has no

D27980: make opengl module support multiple dri devices

pino added inline comments. INLINE COMMENTS > opengl.cpp:169 > + > +bool isValid() > +{ const > opengl.cpp:210 > struct stat fileInfo; > -if (::stat("/dev/dri/card0", ) != 0) > -return false; > -if ((fileInfo.st_mode & S_IFCHR) != S_IFCHR) > -return false;

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/74/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 19 Mar 2020 11:33:08 + Build duration: 49 sec and counting CONSOLE OUTPUT [...truncated 292

D27971: Solid-device-automounter/kcm: correctly update automountOn

meven updated this revision to Diff 77992. meven marked 2 inline comments as done. meven added a comment. Add third parameter to connect() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27971?vs=77368=77992 BRANCH arcpatch-D27971 REVISION DETAIL

D28135: Port away from deprecated QSet/QList methods in some places

anthonyfieroni added inline comments. INLINE COMMENTS > ahmadsamir wrote in runnermodel.cpp:179 > IIUC, the original code used toSet() to remove duplicates from both > "m_runners" and "runners", because QSet doesn't allow duplicate items. But toSet() returns new container m_runners and runners

D28135: Port away from deprecated QSet/QList methods in some places

ahmadsamir added inline comments. INLINE COMMENTS > anthonyfieroni wrote in runnermodel.cpp:179 > Here should be `m_runners = runners` to be exactly same as previous. I don't > see much benefit of having duplicate items. IIUC, the original code used toSet() to remove duplicates from both

D28135: Port away from deprecated QSet/QList methods in some places

anthonyfieroni added inline comments. INLINE COMMENTS > runnermodel.cpp:179 > +if (currRunners != newRunners) { > +m_runners = newRunners; > Here should be `m_runners = runners` to be exactly same as previous. I don't see much benefit of having duplicate items. REPOSITORY R120

D28136: Add the option to show the current activity name and icon

ivan added a comment. Screenshot: F8184234: Screenshot_20200319_112003.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28136 To: ivan, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

  1   2   >