D28154: Add users KCM

ngraham added a comment. You should set `smooth: true` on those avatars in the new gallery so they aren't so jaggy. Also the button to add your own avatar from a file should probably have a label in it so people can figure out what it does. And the sheet that the new gallery is on should be

D28154: Add users KCM

cblack updated this revision to Diff 79099. cblack added a comment. Add gallery REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79098=79099 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED FILES

D28154: Add users KCM

cblack updated this revision to Diff 79098. cblack added a comment. Drop group stubs; there will be bad UX because two different polkit actions (and thus two dialogs backtoback) would be needed for apply with groups REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28134: Add ColorUtils

cblack updated this revision to Diff 79097. cblack added a comment. Address feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=78510=79097 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED FILES

D28496: Hotfix for D28468 to fix broken variable refs

masonm created this revision. masonm added reviewers: Kirigami, mart. masonm added a project: Kirigami. masonm requested review of this revision. REVISION SUMMARY Fixes broken variable references that were missed as part of the code review changes here: https://phabricator.kde.org/D28468.

D27669: [kstyle] Tools area

ngraham added a comment. Lightening the stuff on the Tools Area is a nice effect though, IMO. Implementation-wise, we could also use the Fade inactive window effect in the color scheme itself for this. However it's a bit buggy as various apps have widgets that don't respect it (I've filed

D27669: [kstyle] Tools area

ndavis added a comment. In D27669#639519 , @ngraham wrote: > While working on D28317 , I noticed something: when a window becomes inactive, the icons change their colors, but only for the parts of the icon

D28389: Add support for logging categories

This revision was automatically updated to reflect the committed changes. Closed by commit R133:c103ceb1caf0: Add support for logging categories (authored by romangg). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28389?vs=78881=79092 REVISION DETAIL

D28473: BookmarksRunner: Early return and formatting

bruns added a comment. LGTM - @broulik ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28473 To: alex, bruns, broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D28468: Add property initializer support to PagePool

This revision was automatically updated to reflect the committed changes. Closed by commit R169:bb5a6c13ec0b: Add property initializer support to PagePool (authored by masonm, committed by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27100: [GTK Config] Parameterise GTK config editing

gikari updated this revision to Diff 79089. gikari marked 2 inline comments as done. gikari added a comment. - Remove `explicit` QVariant wrappers REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27100?vs=77909=79089 BRANCH

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79086. alex added a comment. Use categories for warnings, cleanup imports REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79083=79086 BRANCH bookmarksrunner_firefox_fix_prep (branched from master)

D27100: [GTK Config] Parameterise GTK config editing

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Besides one minor over-verbosity issue, this looks like shipit material to me. Drop the QVariant() wrappers (but don't drop the `#include`) before landing, please. INLINE COMMENTS >

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. It's not a terrible idea, I just need to think about it a bit. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#639693 , @ngraham wrote: > But would we still have Breeze, Breeze Light, and Breeze Dark Plasma themes? If we're going to get rid of the Breeze color scheme and just have light and dark, it might be a bit odd

D27100: [GTK Config] Parameterise GTK config editing

gikari added a comment. Ping REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27100 To: gikari, #plasma, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. But would we still have Breeze, Breeze Light, and Breeze Dark Plasma themes? If we're going to get rid of the Breeze color scheme and just have light and dark, it might be a bit odd to still have a Breeze Plasma theme. Also maybe we should discuss that after

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack added a comment. @broulik ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160 To: cblack, #vdg, #plasma, manueljlin, ngraham, broulik Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, Orage,

D28473: BookmarksRunner: Early return and formatting

bruns added inline comments. INLINE COMMENTS > firefox.cpp:166 > +if (!QSqlDatabase::isDriverAvailable(QStringLiteral("QSQLITE"))) { > +qWarning() << "SQLITE driver isn't available"; > +return; Thanks, though I was wrong about "no categories yet". #include

D28487: Upstream of the ksysguard based plasmoids

mmustac added a comment. Those look very lovely. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: mmustac, ahiemstra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79083. alex added a comment. Implement warnings REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79019=79083 BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL

D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet

ngraham added a comment. While it has focus, yes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28483 To: epopov, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D28383: Add PageRouter component

cblack updated this revision to Diff 79082. cblack marked an inline comment as done. cblack added a comment. Address more feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79080=79082 BRANCH cblack/pagerouter REVISION DETAIL

D28383: Add PageRouter component

cblack added inline comments. INLINE COMMENTS > ahiemstra wrote in pagerouter.h:308 > If you have routes as objects you could have an "active" property on the > route, removing the need for this invokable. Not really, the point of this property is to query whether a full URI is on the stack.

D28383: Add PageRouter component

cblack updated this revision to Diff 79080. cblack marked 5 inline comments as done. cblack added a comment. Address more feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=79073=79080 BRANCH cblack/pagerouter REVISION DETAIL

D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet

epopov added a comment. Is it normal that I can close pinned applet by pressing ESC? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28483 To: epopov, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Do we really still need Breeze Light to be separate from Breeze? I think it would make more sense to have just Breeze Light and Breeze Dark. After that, we should refer to all light versions of Breeze as Breeze Light instead of just Breeze. Breeze should then only be

D28461: In sidebar mode show if a module is in default state or not

ndavis added a comment. In D28461#639470 , @ngraham wrote: > So every single KCM will need to be patched to add a settings proper in support of this? Oof. Is there no easier way? Perhaps we could find a way to turn it to our advantage?

D28492: Improve powerdevil's main

This revision was automatically updated to reflect the committed changes. Closed by commit R122:41ef07d6d3c1: Improve powerdevils main (authored by apol). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28492?vs=79078=79079 REVISION DETAIL

D28492: Improve powerdevil's main

apol created this revision. apol added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Make it possible to restart the daemon for easier debugging. Use Qt::AA_DisableSessionManager

D28491: Properly store the powerdown action

apol created this revision. apol added reviewers: Plasma: Mobile, bshah, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The event needs to propagate correctly. TEST PLAN Played with it on my laptop

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

ahiemstra added a comment. Good stuff. Just two small comments. Additionally, you may be interested in https://phabricator.kde.org/D28333 , which will eventually replace ksysguardd and has a better API for sensors. INLINE COMMENTS > acpi.c:82 > +char name[ ACPIFILENAMELENGTHMAX ];

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. it succeeds. It probably doesn't need whatever commit it's trying to use. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. If you tell it to proceed after that, does it succeed or fail? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#639599 , @ngraham wrote: > You don't need to already be on the other branch, just apply this on top of master. If all goes well, `arc` should first apply D27669 , then this

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. You don't need to already be on the other branch, just apply this on top of master. If all goes well, `arc` should first apply D27669 , then this one. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. When I try to get this patch with `arc patch` on top of the branch for D27669 , git says a cherry pick failed. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis,

D28314: Allow setting separate corner radii for ShadowedRectangle

ahiemstra updated this revision to Diff 79075. ahiemstra added a comment. Rebase onto master, also support ShadowedTexture REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28314?vs=78574=79075 BRANCH shadowedrect_separatecorners REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. In D28317#639589 , @ndavis wrote: > yes Done. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#638344 , @ngraham wrote: > @ndavis like this? > > F8206344: Screenshot_20200330_123644.png yes REPOSITORY R31 Breeze REVISION DETAIL

D27979: Add top area to notifications

ngraham added a comment. This looks amazing! I love it. I think the content area below the header needs an additional `units.smallSpacing` margin though. The text in that area comes really close to touching the header: F8209858: Screenshot_20200401_115821.png

D28383: Add PageRouter component

cblack updated this revision to Diff 79073. cblack marked 2 inline comments as done. cblack added a comment. Consume ColumnView instead of PageRow REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=78948=79073 BRANCH cblack/pagerouter REVISION

D27669: [kstyle] Tools area

ngraham added a comment. Anyway I worked around that in D27669 , and I guess it's not really a huge deal for toolbar icons. One thing I notice is that the bottom separator line for the titlebar isn't drawn for 3rd-party apps where there is no Tools

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 79072. ahiemstra added a comment. - Fix qmldir file REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=78985=79072 BRANCH sensors_lib REVISION DETAIL https://phabricator.kde.org/D28141 AFFECTED

D28487: Upstream of the ksysguard based plasmoids

ahiemstra added a comment. In D28487#639476 , @mart wrote: > should faces be still installed under .local/share/ksysguard/sensorapplet/ or under share/plasma? Ideally, I'd like to see them installed into share/ksysguard/faces or

D28473: BookmarksRunner: Early return and formatting

bruns added inline comments. INLINE COMMENTS > firefox.cpp:198 > -if (profilePath.isEmpty()) { > -//qDebug() << "No default firefox profile found"; > -return; Can you leave this in, and even promote it to an active qWarning* - if we have a db and

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added a comment. In D28467#639033 , @ngraham wrote: > Make sure you test how this looks in the System Tray too, and not just as a standalone applet. ;) Two lines will appear, but that will soon be corrected by another patch

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added inline comments. INLINE COMMENTS > ngraham wrote in FullRepresentation.qml:31 > `PlasmaComponents3.Page` doesn't seem to have a `heading` property. Perhaps > you meant `header`? Apparently I managed to test the qml, and then commit an older version of the file, which is

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79070. ngraham added a comment. Make the Tools Area patch the base commit, again REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79069=79070 BRANCH tools-area-color-changes (branched from master) REVISION

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79069. ngraham added a comment. Lighten the button when the window is inactive REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79066=79069 BRANCH tools-area-color-changes (branched from master) REVISION

D28330: Color icons in titlebar if possible

davidre updated this revision to Diff 79068. davidre added a comment. Be more careful when resetting palette REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28330?vs=78860=79068 BRANCH icons (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79066. ngraham added a comment. Make 86851917557ea7deeaaac05b3d62e021d93041e9 the base commit REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79063=79066 BRANCH tools-area-color-changes (branched from master)

D27669: [kstyle] Tools area

ngraham added a comment. While working on D28317 , I noticed something: when a window becomes inactive, the icons change their colors, but only for the parts of the icon using the text color. Red icons, or parts of icons that are red, don't change at all

D27979: [WIP] Add top area to notifications

niccolove updated this revision to Diff 79065. niccolove added a comment. Remove unrelated change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27979?vs=79064=79065 BRANCH notification_toparea REVISION DETAIL

D27979: [WIP] Add top area to notifications

niccolove updated this revision to Diff 79064. niccolove added a comment. Rewrote the whole thing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27979?vs=77406=79064 BRANCH notification_toparea REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79063. ngraham added a comment. Make the close button red REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=79062=79063 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet

epopov added a comment. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28483 To: epopov, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Damn, that didn't work. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 79062. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78686=79062 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricator.kde.org/D28317

D28141: Add KSysGuard::Sensors library

mart added a comment. while porting the systemmonitor plasmoids to upstream, i found a couple of problems: - gcc didn't like inserting using a const iterator - qmldir outdated with the old plugin name diff on top of this phab: https://phabricator.kde.org/P567 REPOSITORY R111

D28483: [applets/clipboard] Don't close when clicking history item if pop-up was pinned open by another applet

This revision was automatically updated to reflect the committed changes. Closed by commit R120:247ff0bdb646: [applets/clipboard] Dont close when clicking history item if pop-up was pinned… (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28474: move the header in the OverlaySheet header

This revision was automatically updated to reflect the committed changes. Closed by commit R134:a71bf27e8e19: move the header in the OverlaySheet header (authored by mart). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28474?vs=79018=79060

D28483: Updated patch that fixes the issue of closing a pinned the Clipboard applet

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, I see what you mean now. This is indeed a better solution. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28483 To: epopov, ngraham Cc:

D28487: Upstream of the ksysguard based plasmoids

mart added a comment. should faces be still installed under .local/share/ksysguard/sensorapplet/ or under share/plasma? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28485: Move QMimeData registration back to where it belongs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yikes! Stable branch, probably REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D28485 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, Orage,

D28461: In sidebar mode show if a module is in default state or not

ngraham added a comment. So every single KCM will need to be patched to add a settings proper in support of this? Oof. Is there no easier way? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg Cc:

D28487: Upstream of the ksysguard based plasmoids

mart added inline comments. INLINE COMMENTS > metadata.desktop:11 > +X-KDE-PluginInfo-License=LGPLv2+ > +X-KDE-PluginInfo-Name=org.kde.ksysguard.barchart > +X-KDE-PluginInfo-Version=1.0 still org.kde.ksysguard plugin name prefix, or org.kde.plasma.systemmonitor as well? REPOSITORY R120

D28468: Add property initializer support to PagePool

masonm updated this revision to Diff 79059. masonm added a comment. - Rename variable and add comment REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28468?vs=79005=79059 BRANCH add-pagepool-properties (branched from master) REVISION DETAIL

D28487: upstream of the ksysguard based plasmoids

mart updated this revision to Diff 79058. mart added a comment. - remove useless debug REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=79057=79058 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487

D28487: upstream of the ksysguard based plasmoids

mart created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Those plasmoids are intended to replace the old systemmonitor plasmoids They are based upon the new ksysguard daemon: see D28333

D28485: Move QMimeData registration back to where it belongs

broulik updated this revision to Diff 79056. broulik added a comment. - use same 0 major as everything else Apparently doesn't matter REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28485?vs=79055=79056 REVISION DETAIL

D28485: Move QMimeData registration back to where it belongs

broulik updated this revision to Diff 79055. broulik retitled this revision from "Register QMimeData" to "Move QMimeData registration back to where it belongs". broulik edited the summary of this revision. REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE

D28485: Register QMimeData

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures drag and drop of results works again. BUG: 418109 FIXED-IN: 5.18.5 TEST PLAN

D28481: Revert "Fix build with Qt 5.15"

This revision was automatically updated to reflect the committed changes. Closed by commit R122:9dbae3f1c3d6: Revert Fix build with Qt 5.15 (authored by apol). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28481?vs=79043=79050 REVISION DETAIL

D28483: Updated patch that fixes the issue of closing a pinned the Clipboard applet

epopov updated this revision to Diff 79046. epopov added a comment. Rebase on **master** REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28483?vs=79045=79046 REVISION DETAIL https://phabricator.kde.org/D28483 AFFECTED FILES

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

ahmadsamir abandoned this revision. ahmadsamir added a comment. Not needed with D27808 , which will use KFontChooserDialog everywhere. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27785 To: ahmadsamir, #plasma,

D27830: [Fonts KCM] Make the font selection dialog highlight the correct style

ahmadsamir abandoned this revision. ahmadsamir added a comment. See D27808 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27830 To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport Cc: plasma-devel,

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D28000 To: ahmadsamir, #plasma, apol, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D28483: Updated patch that fixes the issue of closing a pinned the Clipboard applet

ngraham added a comment. This needs to be rebased on master, because, it needs to apply //on top of// your previous patch, not //instead// of it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28483 To: epopov, ngraham Cc: plasma-devel, Orage, LeGast00n,

D28483: Updated patch that fixes the issue of closing a pinned the Clipboard applet

epopov created this revision. epopov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY The previous patch updates the pinned state only for the active applet. For instance, if you open

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov added a comment. The previous patch updates the pinned state only for the active applet. For instance, if you open the Networks applet and pin it, then switch to the Clipboard applet and click on the history item, then the Clipboard applet closes. This is because we need to use

D28481: Revert "Fix build with Qt 5.15"

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R122 Powerdevil BRANCH arcpatch-D28481 REVISION DETAIL https://phabricator.kde.org/D28481 To: apol, broulik Cc: broulik, plasma-devel, Orage, LeGast00n,

D28482: Revert "Fix build with Qt 5.15"

apol abandoned this revision. apol added a comment. Once is enough REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D28482 To: apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

ngraham added a comment. What was the problem with the previous one? It works great for me. Can you submit your changes as a new patch rather than updating this one? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham, #plasma Cc:

D28481: Revert "Fix build with Qt 5.15"

apol added a comment. commit 46ebd11e66f6f3180043a7258b46a1aff79a69f8 Author: Lars Knoll Date: Wed Mar 25 11:20:28 2020 +0100 Fix deprecation of QComboBox:::currentIndexChanged(const QString&) Don't introduce another overload with two parameters. Users want a simple

D28481: Revert "Fix build with Qt 5.15"

apol updated this revision to Diff 79043. apol added a comment. remove unrelated changes REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28481?vs=79041=79043 BRANCH arcpatch-D28481 REVISION DETAIL https://phabricator.kde.org/D28481 AFFECTED FILES

D28482: Revert "Fix build with Qt 5.15"

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This reverts commit 3a5aca82527ec45d22d09e220ff3ff00a42971d2

D28481: Revert "Fix build with Qt 5.15"

broulik added a comment. Why? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D28481 To: apol Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

D28481: Revert "Fix build with Qt 5.15"

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This reverts commit 3a5aca82527ec45d22d09e220ff3ff00a42971d2

D28383: Add PageRouter component

ahiemstra added inline comments. INLINE COMMENTS > mart wrote in pagerouter.h:84 > how many routes an app would normally be going to have? > > this seems really a thing for QQmlListProperty (which then each route must > become a qobject tough) > so routes: [ > Route { > > name: "home" >

D27914: [Kilpper] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bcfd7f28370d: [Kilpper] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27914?vs=78634=79040

Re: notifications for non-plasmashell components

On Wed, Apr 01, 2020 at 10:32:40AM +0100, David Edmundson wrote: > I don't understand the case of latte dock being different to the applet. I believe it is separate process, no? > But generally seems sensible. Though obviously this only works if the > notification comes from a KDE source.

D28408: [applets/clipboard]: Fix applet closing itself when clicking on a history item while the tray popup is pinned open

epopov updated this revision to Diff 79034. epopov added a comment. Unfortunately, the previous patch doesn't solve the problem completely, but this one should. Can you check it and if everything works well, then replace it with the previous one? REPOSITORY R120 Plasma Workspace CHANGES

KDE CI: Plasma » powerdevil » stable-kf5-qt5 FreeBSDQt5.14 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20FreeBSDQt5.14/4/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 01 Apr 2020 09:08:14 + Build duration: 28 min and counting

D28134: Add ColorUtils

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. still, no item grabbing REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel,

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.14/8/ Project: stable-kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 01 Apr 2020 09:07:23 + Build duration: 26 min and counting JUnit Tests

D28383: Add PageRouter component

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pagerouter.cpp:154 > + > +void PageRouter::setRoutes(QJSValue routes) > +{ should add parsing and validation here > pagerouter.cpp:199 > +{ > +

Re: notifications for non-plasmashell components

On Wed, Apr 1, 2020 at 10:13 AM Bhushan Shah wrote: > > Morning, > > I was looking into notifications for plasma mobile lockscreen from last > few days, current set of patches are in kscreenlocker, plasma-workspace, > and plasma-phone-components. > > - https://phabricator.kde.org/D28455 > -

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.14 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.14/5/ Project: stable-kf5-qt5 SUSEQt5.14 Date of build: Wed, 01 Apr 2020 09:07:23 + Build duration: 7 min 2 sec and counting JUnit Tests

notifications for non-plasmashell components

Morning, I was looking into notifications for plasma mobile lockscreen from last few days, current set of patches are in kscreenlocker, plasma-workspace, and plasma-phone-components. - https://phabricator.kde.org/D28455 - https://phabricator.kde.org/D28454 -

  1   2   >