D27203: Don't try to open files we can't figure out where they are

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:226 > +//passing non-local files as the working directory is not supported. > +//See

D29595: Add gocryptfs support

ngraham added inline comments. INLINE COMMENTS > ivan wrote in vaultwizardbase.h:65 > Heh, it was my first impression when the priority patch was contributed to > Vaults. Now I'm extra careful :) Perhaps the unintuitive nature of the numbering could be clarified with a comment in a follow-up

D29140: Fix POTD in lock screen (partly)

guoyunhe updated this revision to Diff 82610. guoyunhe added a comment. Draft for PoTD KDED. Not tested. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=81064=82610 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#668884 , @ngraham wrote: > In D29024#668383 , @romangg wrote: > > > Note that I need to have this plugin system or something similar in for 5.19 or I will be

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. Default indicator discussion is now on https://phabricator.kde.org/T13008 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart Cc: GB_2, mart, ngraham, abetts, filipf,

D29603: Adds custom spacing between task manager icons

martellini added a comment. Sounds cool. I'll be working on it. I must that the iconSize setting is only visibile if the panel is vertical, why do you think it is so? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29603 To: martellini, #vdg, ngraham Cc:

D29595: Add gocryptfs support

ivan added inline comments. INLINE COMMENTS > mpilia wrote in vaultwizardbase.h:65 > Of course, sorry. For some reason I though 1 was highest priority. Heh, it was my first impression when the priority patch was contributed to Vaults. Now I'm extra careful :) REPOSITORY R845 Plasma Vault

D29595: Add gocryptfs support

mpilia added inline comments. INLINE COMMENTS > ivan wrote in vaultwizardbase.h:65 > Lower the priority to 1. > > I don't want to have gocryptfs as the default. At least for the time being. Of course, sorry. For some reason I though 1 was highest priority. REPOSITORY R845 Plasma Vault

D29595: Add gocryptfs support

mpilia updated this revision to Diff 82601. mpilia added a comment. Fix priority for gocryptfs REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29595?vs=82425=82601 BRANCH add-gocryptfs-support (branched from master) REVISION DETAIL

D29024: feat(wayland): support multiple protocol extensions through plugin system

davidedmundson added a comment. > These are not specific issues but some general complains about the overall concept chosen here without providing an alternative solution. Well yes, it makes sense to do high level discussion first. With the Plasma agreed "new approach" that we will

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

epopov added a comment. Currently, the Notifications applet closes itself when the last element (notification) is removed (or all elements are removed by pressing "Clear History" button in the top-right corner). But also it closes itself, even if the applet is pinned, and I guess that this

D29595: Add gocryptfs support

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Great work! INLINE COMMENTS > vaultwizardbase.h:65 > +{ "cryfs", 2 }, > +{ "gocryptfs", 3 }, > }; Lower the priority to 1. I don't want to have gocryptfs as

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29651 To: epopov, ngraham, plasma-devel, broulik Cc: broulik, Orage, LeGast00n,

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e6ed4a888314: [applets/notifications] Remain visible after removing all notifications while… (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

epopov updated this revision to Diff 82594. epopov added a comment. Fixed. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29651?vs=82563=82594 REVISION DETAIL https://phabricator.kde.org/D29651 AFFECTED FILES

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

ngraham added a comment. > (similar to how the Notification applet closes after the last notification is removed). But you're changing that in D29651 ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29652 To:

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

epopov added a comment. I believe that there is a better solution, but I did not come up with it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29652 To: epopov, ngraham, plasma-devel Cc: Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29651: [applets/notifications] Remain visible after removing all notifications while tray popup is pinned open

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Don't remove the curly braces for simple if statements REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29651 To: epopov, ngraham,

D29024: feat(wayland): support multiple protocol extensions through plugin system

ngraham added a comment. In D29024#668383 , @romangg wrote: > Note that I need to have this plugin system or something similar in for 5.19 or I will be forced to fork libkscreen permanently for KWinFT. I would like to avoid this and instead

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

This revision was automatically updated to reflect the committed changes. Closed by commit R120:00e64bdb3fa9: [applets/systemtray] Show base icon when AttentionIcon not set (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

ngraham abandoned this revision. ngraham added a comment. Oh I forgot that it was only in 5.19. We can continue in D29633 , it's better. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29636 To: ngraham, broulik,

D29570: Fix some alignments

ngraham added inline comments. INLINE COMMENTS > niccolove wrote in PowerManagementItem.qml:34 > It does look a bit too close on the right border in LTS. I guess I should add > a rightMargin here? Noah's point was that this doesn't automatically reverse itself due to a known Qt bug. However

D29595: Add gocryptfs support

ngraham added reviewers: ivan, Plasma. ngraham added a comment. Very cool! REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29595 To: mpilia, ivan, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D29603: Adds custom spacing between task manager icons

ngraham added a comment. In D29603#668422 , @martellini wrote: > > Also, it doesn't make sense IMO to expose separate horizontal and vertical controls; there should be just one control visible, and it should affect the task manager no matter

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

jpalecek updated this revision to Diff 82568. jpalecek added a comment. Move the client deregistering code from SensorBrowserModel to HostInfo Also remove the clear function. After investigating further, I've found out it suffers from the same problem, that it doesn't deregister from

D29288: Improve PageRouter API

This revision was automatically updated to reflect the committed changes. Closed by commit R169:db704d344b2c: Improve PageRouter API (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29288?vs=81555=82567 REVISION DETAIL

D29632: [kcms/keys] Use better collator settings

broulik added inline comments. INLINE COMMENTS > davidre wrote in shortcutsmodel.cpp:89 > We typically don't have apps with numbers but I can also add it? Ah, this is for apps, but yeah, why not... REPOSITORY R119 Plasma Desktop BRANCH collator (branched from master) REVISION DETAIL

D29644: Select application after it is added

broulik added inline comments. INLINE COMMENTS > main.qml:97 > +id: transition > +PropertyAnimation { > +target: components Sounds like you want `PropertyAction` REPOSITORY R119 Plasma Desktop BRANCH addIndex

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks please phrase the commit message the opposite way. State what the commit changes, not what the state was before the commit. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

broulik added inline comments. INLINE COMMENTS > batterymonitor.qml:61 > +} else { > +return i18n("Battery charging, currently at %1%", > pmSource.data.Battery.Percent) > } Also, just because it's plugged in, doesn't mean it's charging. REPOSITORY

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. The tooltip logic was completely rewritten in 5.19. This patch does not apply to 5.18. Also, D29633 REPOSITORY R120 Plasma Workspace

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

epopov created this revision. epopov added reviewers: ngraham, plasma-devel. Herald added a project: Plasma. epopov requested review of this revision. REVISION SUMMARY It would be correct to close the Clipboard applet after clearing the history or deleting the last element, since there is

D29625: Add global shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R124:63a6340a711d: Add global shortcut (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29625?vs=82532=82564 REVISION

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

epopov created this revision. epopov added reviewers: ngraham, plasma-devel. Herald added a project: Plasma. epopov requested review of this revision. REVISION SUMMARY When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself. BUG: 421344

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Superseeded by https://phabricator.kde.org/D29548 since there was no activity for >2 months. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27353

D29548: Drag and drop assigning windows to activities in the default switcher

ivan closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29548 To: ivan, #plasma, mart, davidedmundson, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI

mart added a comment. Sorry, i don't think it's the right path, for several reasons, - The spinbox look is different from the desktop one, better or worse is secondary, but it's actually a sore point of the plasma theme at the moment :/ - It exposes very directly pixel numbers in the

D29637: Introduce ImageColors

cblack added inline comments. INLINE COMMENTS > colorutils.h:182 > +/** > + * Returns the Cielab "Chroma" of the color which is a slightly better > quantificator for how much a color appears > https://en.wikipedia.org/wiki/Colorfulness > + * This is how much a color looks diffenent

D29535: Add a SpinBox (with draggability) to panel thickness adjustment UI

mart added a comment. -1 :( REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29535 To: ngraham, abetts, #vdg, #plasma Cc: mart, ahiemstra, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29548: Drag and drop assigning windows to activities in the default switcher

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. What Nate says, after that go for it REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D29548 To: ivan, #plasma, mart, davidedmundson, ngraham

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

mart added a comment. the different Units.qml depend from the style, QT_QUICK_CONTROLS_STYLE all of them, including those in plasma-framework should be updated at once REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29462 To: Zren, #kirigami, mart Cc:

D29644: Select application after it is added

davidre created this revision. davidre added reviewers: broulik, ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY After adding an application, an user will probably want to edit shortcuts for

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

yurchor accepted this revision as: yurchor. yurchor added a comment. This revision is now accepted and ready to land. Thanks. No objections for porting this into a stable translation branch from the Ukrainian team. REPOSITORY R120 Plasma Workspace BRANCH fix-non-updating-battery-tooltip

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

ltoscano added a comment. Adding a few more details to make it easier to decide on the localization side: - Plasma 5.18 is the new LTS - its next releases (5.18.6) is currently planned for September 17th, 2020. I'd say there is enough time to fix this translation, and having the

D29637: Introduce ImageColors

cblack added inline comments. INLINE COMMENTS > imagecolorstest.qml:1 > + > +import QtQuick 2.12 There's no test cases here, this should probably go in examples. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29637 To: mart, #kirigami Cc: cblack, plasma-devel,

D29632: [kcms/keys] Use better collator settings

davidre added inline comments. INLINE COMMENTS > shortcutsmodel.cpp:89 > QCollator collator; > +collator.setCaseSensitivity(Qt::CaseInsensitive); > std::sort(m_components.begin(), m_components.end(), > [&](const Component , const

D29637: Introduce ImageColors

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY ImageColors is a class to extract color statistics out of an image. it supports as source : -

D29632: [kcms/keys] Use better collator settings

broulik added inline comments. INLINE COMMENTS > shortcutsmodel.cpp:89 > QCollator collator; > +collator.setCaseSensitivity(Qt::CaseInsensitive); > std::sort(m_components.begin(), m_components.end(), > [&](const Component , const

D29603: Adds custom spacing between task manager icons

martellini added a comment. In D29603#668283 , @niccolove wrote: > Are we really sure this is worth exposing to the user? Not sure at all. I just can't stand the default spacing, because it feels like the icons are crammed. At least if

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

ngraham created this revision. ngraham added reviewers: broulik, Plasma, Localization. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Current code only updates the text on the "not charging" condition, causing

D29632: [kcms/keys] Use better collator settings

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. It could make sense to leverage QCollatorSortKey in this class if it's sorting often. REPOSITORY R119 Plasma Desktop BRANCH collator (branched from master) REVISION DETAIL

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

jpalecek added inline comments. INLINE COMMENTS > ahiemstra wrote in SensorBrowser.cpp:53 > I agree with Anthony though, if you delete a hostInfo it _should_ remove its > connection. So it's better to move this code into a destructor for HostInfo. But the host info, at least in its present

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

ahiemstra requested changes to this revision. ahiemstra added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > jpalecek wrote in SensorBrowser.cpp:53 > No, it only deletes the HostInfo structure. See the source >

D29635: [kcms/keys] Make saving sync

davidre created this revision. davidre added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY If it's async it will not save when changing modules, or quitting kcmshell, see T13140

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. These are not specific issues but some general complains about the overall concept chosen here without providing an alternative solution. I chose this plugin system because it allows robust extension to the current system. Plugins are well contained and reuse

D29140: Fix POTD in lock screen (partly)

guoyunhe added a comment. I was looking for kded documentation but cannot find a good example. Do you know any? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n,

D26934: KCM/Autostart Add a model to separate logic from UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:01776488ab8b: KCM/Autostart Add a model to separate logic from UI (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=80200=82533

D29625: Add global shortcut

guoyunhe updated this revision to Diff 82532. guoyunhe added a comment. Create symlink REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29625?vs=82515=82532 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29625 AFFECTED FILES

D28154: Add users KCM

ltoscano added a comment. Technically kcm should be called kcm_. So far the Plasma_version part has been ignored, but at least kcm_ should be there. I'm not sure about the lack of the button. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D28154 REVISION DETAIL

D27203: Don't try to open files we can't figure out where they are

meven accepted this revision. meven added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:226 > +//passing non-local files as the working directory is not supported. > +//See QFileDialogPrivate::initialSelections > +

D28154: Add users KCM

yurchor added a subscriber: ltoscano. yurchor added a comment. Please do not get me wrong (I'm fine with the new designs and updating the code and this new KCM is very good), but it would be good to hear some words from @ltoscano on the catalog (and KCM) naming. It is also evident that

D29633: [Battery Monitor] Fix toolTipMainText when plugged in

broulik created this revision. broulik added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It only had a return value for "NoCharge" since the else case was only for not plugged

D29632: Use better collator settings

davidre created this revision. davidre added reviewers: ognarb, broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH collator (branched from master) REVISION DETAIL

D29024: feat(wayland): support multiple protocol extensions through plugin system

davidedmundson added a comment. It's still got this pointless plugin within plugin situation. > For that at least one Wayland event loop has to be launched It needs a roundrip after the registry is fetched. That doesn't need an event loop. REPOSITORY R110 KScreen Library

D27203: Don't try to open files we can't figure out where they are

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=408174? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27203 To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir Cc: ngraham, plasma-devel, Orage,

D29548: Drag and drop assigning windows to activities in the default switcher

ngraham added a comment. So cool! Can you make the activity that the window is being dragged into highlight or otherwise somehow provide a visual indication that it's going to accept the drop? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29548 To: ivan,

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

jpalecek added inline comments. INLINE COMMENTS > anthonyfieroni wrote in SensorBrowser.cpp:53 > When you delete the map content, all agents should loose their connections, > no? No, it only deletes the HostInfo structure. See the source

D29603: Adds custom spacing between task manager icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I think it would make more sense to fix the default sizing behavior rather than adding these. We already have an "icon size" setting which roughly adjusts this already, just

D29626: Fix Warning about KF5::ProcessCore target being deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit R119:baa168ede063: Fix Warning about KF5::ProcessCore target being deprecated (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29623: Fix Warning about KF5::KSysGuard target being deprecated

meven added a comment. Improved by D29628 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29623 To: meven, #plasma, ahiemstra, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D29603: Adds custom spacing between task manager icons

niccolove added a comment. Are we really sure this is worth exposing to the user? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29603 To: martellini, #vdg Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.14 - Build # 104 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.14/104/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 11 May 2020 12:48:21 + Build duration: 7 min 7 sec and counting JUnit Tests Name:

D29570: Fix some alignments

niccolove added inline comments. INLINE COMMENTS > ndavis wrote in PowerManagementItem.qml:34 > How does this affect RTL layouts? It does look a bit too close on the right border in LTS. I guess I should add a rightMargin here? REPOSITORY R120 Plasma Workspace BRANCH fixspacing (branched

D29630: Use the new KSysGuard namespace for KSysGuard related targets

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY The targets in the KF5 namespace have been deprecated. This updates the cmake files to

D29628: Use the right targets for KSysGuard

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8ae9b561c82f: Use the right targets for KSysGuard (authored by ahiemstra). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29628?vs=82516=82522 REVISION

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.14 - Build # 103 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.14/103/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 11 May 2020 12:45:11 + Build duration: 2 min 3 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 90 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/90/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 11 May 2020 12:45:11 + Build duration: 2 min 10 sec and counting CONSOLE OUTPUT

D29619: Improve StatusNotifierTest

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5459a533974e: Improve StatusNotifierTest (authored by davidre). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29619?vs=82491=82521 REVISION DETAIL

D28208: Move sni icon handling logic from data engine to applet

davidre updated this revision to Diff 82519. davidre added a comment. - fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=82492=82519 BRANCH sni (branched from master) REVISION DETAIL https://phabricator.kde.org/D28208 AFFECTED

D29628: Use the right targets for KSysGuard

meven added a comment. Related fix in `plasma-desktop` https://phabricator.kde.org/D29626 REPOSITORY R120 Plasma Workspace BRANCH ksysguard_targets REVISION DETAIL https://phabricator.kde.org/D29628 To: ahiemstra, #plasma, meven Cc: meven, plasma-devel, Orage, LeGast00n,

D29626: Fix Fix Warning about KF5::ProcessCore target being deprecated

meven updated this revision to Diff 82518. meven added a comment. Update root CMakeLists.txt REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29626?vs=82509=82518 BRANCH arcpatch-D29626 REVISION DETAIL https://phabricator.kde.org/D29626

D29628: Use the right targets for KSysGuard

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R120 Plasma Workspace BRANCH ksysguard_targets REVISION DETAIL https://phabricator.kde.org/D29628 To: ahiemstra, #plasma, meven Cc: meven, plasma-devel, Orage,

D29628: Use the right targets for KSysGuard

ahiemstra updated this revision to Diff 82516. ahiemstra added a comment. - Also change system monitor plasmoid REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29628?vs=82513=82516 BRANCH ksysguard_targets REVISION DETAIL

D29628: Use the right targets for KSysGuard

meven added a comment. ANd `KSysGuard::Sensors` `KSysGuard::SensorFaces` in `applets/systemmonitor/systemmonitor/CMakeLists.txt` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29628 To: ahiemstra, #plasma, meven Cc: meven, plasma-devel, Orage, LeGast00n,

D29628: Use the right targets for KSysGuard

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. It miss a KSysGuard::ProcessCore in `applets/systemmonitor/systemmonitor/CMakeLists.txt` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29628

D29626: Fix Fix Warning about KF5::ProcessCore target being deprecated

ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. You need to change `find_package(KF5 REQUIRED COMPONENTS SysGuard)` to `find_package(KSysGuard CONFIG REQUIRED)` in the root CMakeLists file. REPOSITORY R119 Plasma

D28662: KCM LookAndFeel check widgetStyle availability before applying it

crossi added a comment. In D28662#664211 , @heikobecker wrote: > This breaks the lookandfeel-kcm test. I saw this with 5.18.5 but it also fails on build.kde.org for a while, e.g.: > > 14:11:19 FAIL! : KcmTest::testKCMSave() Compared

D29625: Add global shortcut

guoyunhe updated this revision to Diff 82515. guoyunhe added a comment. Use KGlobalAccel instead REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29625?vs=82508=82515 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29625 AFFECTED

D29544: [applets/systemtray] Show base icon when AttentionIcon not set

kmaterka added a comment. Can we have it reviewed before 5.19 release? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29544 To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29625: Add global shortcut

davidre added a comment. In D29625#668203 , @davidre wrote: > -1 for khotkeys. Add `X-KDE-Shortcuts` to the desktop file instead and instal it to share/kglobalaccel REPOSITORY R124 System Settings REVISION DETAIL

D29625: Add global shortcut

davidre added a comment. -1 for khotkeys. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D29625 To: guoyunhe, #plasma Cc: davidre, ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29625: Add global shortcut

guoyunhe added a comment. In D29625#668190 , @ognarb wrote: > I think khotkeys is deprecated: https://phabricator.kde.org/T2050 Not yet, it is delayed to KF6. REPOSITORY R124 System Settings REVISION DETAIL

D29628: Use the right targets for KSysGuard

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Otherwise the build fails when things try to link to KF5::SysGuard etc. TEST PLAN Builds

D29625: Add global shortcut

ognarb added a comment. I think khotkeys is deprecated: https://phabricator.kde.org/T2050 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D29625 To: guoyunhe, #plasma Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. Since this has now the structure with exported headers as requested in D29028#653150 and D29028#654526 I'll push later today if there are no more specific issues pointed out in

D29626: Fix Fix Warning about KF5::ProcessCore target being deprecated

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D29626 AFFECTED FILES

D29625: Add global shortcut

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY The "Tools" key is function key in some laptops. In ThinkPad + Windows, when you press that key, it will open Control Panel or

D29623: Fix Warning about KF5::KSysGuard target being deprecated

ahiemstra added a comment. Uh, I'm not sure how this fixes anything? It'll remove the warning but it means anything using the previous KF5:: namespaced targets is now broken. So this at least needs a follow up to change those usages. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28922: Port Sensor Face loading from plasmoid

mart closed this revision. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D28922 To: mart, #plasma, ahiemstra, #vdg Cc: zzag, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf,

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 89 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/89/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 11 May 2020 11:09:31 + Build duration: 2 min 7 sec and counting CONSOLE OUTPUT

  1   2   >