D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

anthonyfieroni added a comment. I test, current situation, i don't think the parch is needed as is. 2 monitors FullHD and 4K (HDMI) now KScreen does not allow different scale factor, to distinct monitor but you can changed config [KScreen] ScaleFactor=1

D29807: WIP: Change Chrome API design

anthonyfieroni added reviewers: broulik, Plasma. anthonyfieroni added a comment. Commented code should be removed. INLINE COMMENTS > chromeprofile.h:11 > +public: > +ProfileBookmarks(const QString , const QString ); > +static QList findAllProfiles(const QString > ); You can move

D29688: Ignore mount paths that start with '/snap/'

anthonyfieroni added a comment. Should it /var/lib/flatpak (or just /flatpak/) be included as well? REPOSITORY R106 KSysguard BRANCH ignore_snap_partitions REVISION DETAIL https://phabricator.kde.org/D29688 To: ahiemstra, #plasma, davidedmundson Cc: anthonyfieroni, jriddell,

D29616: Fix memory errors caused by using dangling pointers to SensorClients in SensorAgent

anthonyfieroni added inline comments. INLINE COMMENTS > SensorBrowser.cpp:53 > +} > qDeleteAll( mHostInfoMap ); > mHostInfoMap.clear(); When you delete the map content, all agents should loose their connections, no? REPOSITORY R106 KSysguard REVISION DETAIL

D29506: rejigger lookup of services by exec

anthonyfieroni added inline comments. INLINE COMMENTS > servicerunner.cpp:164 > > -QString finalQuery = QStringLiteral("exist Exec and ( (%1) or (%2) > or (%3) or ('%4' ~~ Exec) or (%5) )") > -.arg(keywordTemplate, genericNameTemplate, nameTemplate, >

D29028: feat(wayland): add Wrapland plugin

anthonyfieroni added a comment. In D29028#653194 , @romangg wrote: > In D29028#653192 , @apol wrote: > > > I don't really see why we'd want to support something that is not offering ABI stability

D28785: Don't request blur when panel is opaque

anthonyfieroni added inline comments. INLINE COMMENTS > panelview.cpp:1015 > > QQuickItem *rootObject = this->rootObject(); > if (rootObject) { You have it as `casted` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28785 To: cblack,

D28904: Cleanup dependencies

anthonyfieroni added inline comments. INLINE COMMENTS > CMakeLists.txt:20 > > -find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets DBus > X11Extras) > -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Activities Auth > IdleTime Config DBusAddons Solid I18n

D28817: Fix KScreen output identifier position on wayland

anthonyfieroni added a comment. In D28817#647912 , @bport wrote: > I don't think we have a leak, on destructor we delete all view > qDeleteAll(m_views); At that point, when rootObj is nullptr, view is not added to m_views. REPOSITORY

D28817: Fix KScreen output identifier position on wayland

anthonyfieroni added inline comments. INLINE COMMENTS > output_identifier.cpp:58 > if (!rootObj) { > continue; > } view leaks, no? I see it's not a problem in this patch. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28817 To: bport,

D28692: Don't leak DrKonqi dialog / fix crash on wayland

anthonyfieroni added inline comments. INLINE COMMENTS > main.cpp:67 > void openDrKonqiDialog () { > DrKonqiDialog *w = new DrKonqiDialog(); > +QObject::connect(qApp, ::aboutToQuit, w, > ::deleteLater); Adding a qApp as a parent here? REPOSITORY R871 DrKonqi REVISION

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

anthonyfieroni added inline comments. INLINE COMMENTS > acpi.c:147 > if ( maximum > 0) { > -state = charge * 100 / maximum; > +state = charge/(float)(maximum/100);/* to get 0.1% changes */ > } `(float)(var_int/var_int)` does not what you want, it should be

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. In D28286#641165 , @dfaure wrote: > That wouldn't work either, you need to be able to choose between a Notification delegate, a Dialog delegate (which lives in a different library due to the QtWidgets

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. OK, let's not keep things as they are. Because the best i can make without dedicated function is `new KIO::ApplicationLauncherJob(service, KIO::ApplicationLauncher::WITH_AUTO_ERROR_HANDLED_DELEGATE)` REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. And what about the idea to pass delegate to job constructor? At least it's better than current one. I'm pretty pedantic about duplicate code in plus it makes porting harder. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28215: [RFC]: WIP: Make mobile broadband actually functional

anthonyfieroni added inline comments. INLINE COMMENTS > main.qml:63-67 > +checked: false > +onEnabledChanged: { > +if (!enabled) > +checked = false > +} This should work enabled: mobileDataCheckbox.enabled checked :

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. In D28286#636881 , @dfaure wrote: > Why not -> because it just doesn't scale. 30 jobs * 4 delegates = 120 wrapper methods... Even 1200 is not problem to me. REPOSITORY R119 Plasma Desktop REVISION

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. Why not? Furthermore they can be easy fixable. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 To: broulik, #plasma, hein, dfaure Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. In D28286#636668 , @dfaure wrote: > Benefit: available everywhere, unlike a local wrapper function. I think wrapper function in KIO :) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added inline comments. INLINE COMMENTS > backend.cpp:236-239 > +auto *job = new KIO::ApplicationLauncherJob(service); > +auto *delegate = new KNotificationJobUiDelegate; > +delegate->setAutoErrorHandlingEnabled(true); > +

D28289: Refactor of OverlaySheet

anthonyfieroni added inline comments. INLINE COMMENTS > OverlaySheet.qml:2-19 > +* Copyright (C) 2016 by Marco Martin > +* > +* This program is free software; you can redistribute it and/or modify > +* it under the terms of the GNU Library General Public License as > +* published by the

D28135: Port away from deprecated QSet/QList methods in some places

anthonyfieroni added inline comments. INLINE COMMENTS > ahmadsamir wrote in runnermodel.cpp:179 > IIUC, the original code used toSet() to remove duplicates from both > "m_runners" and "runners", because QSet doesn't allow duplicate items. But toSet() returns new container m_runners and runners

D28135: Port away from deprecated QSet/QList methods in some places

anthonyfieroni added inline comments. INLINE COMMENTS > runnermodel.cpp:179 > +if (currRunners != newRunners) { > +m_runners = newRunners; > Here should be `m_runners = runners` to be exactly same as previous. I don't see much benefit of having duplicate items. REPOSITORY R120

D28107: Fix overlayIcon sometimes not visible

anthonyfieroni added a comment. Can we just set/clear OverlayIconName depends of icon presence then `overlays: model.OverlayIconName` ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28107 To: davidre, kmaterka, #plasma, broulik, davidedmundson Cc:

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

anthonyfieroni added a comment. In D28074#628309 , @zzag wrote: > Well, we could do something like this (not sure whether it works though) > > for (KWindowShadow *shadow : _shadows) > disconnect(shadow, nullptr, this, nullptr); >

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

anthonyfieroni added inline comments. INLINE COMMENTS > CMakeLists.txt:89 > + > +set_target_properties(breezedecoration PROPERTIES CXX_STANDARD 17) > if(BREEZE_HAVE_X11) That's too offensive. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To: davidre, #breeze,

D27847: [applet/taskmanager] Remove the launcher items' tooltip icons

anthonyfieroni added a comment. Why? REPOSITORY R119 Plasma Desktop BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27847 To: ngraham, #vdg, #plasma, niccolove, ognarb Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

anthonyfieroni added a comment. Do it like in pager for wayland https://github.com/KDE/plasma-desktop/blob/master/applets/pager/plugin/pagermodel.cpp#L577 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27353 To: wstephenson, #plasma, ivan, davidedmundson

D27650: ItemContainer: disconnect signals in destructor

anthonyfieroni added inline comments. INLINE COMMENTS > itemcontainer.cpp:66 > { > +disconnect(m_sizeHintAdjustTimer, ::timeout, this, > ::sizeHintsChanged); > +disconnect(m_editModeTimer, ::timeout, this, nullptr); You can translate this calls to

D27556: HiDPI pixmap

anthonyfieroni added inline comments. INLINE COMMENTS > AuthDialog.cpp:108 > > +const qreal dpr = devicePixelRatio(); > + You wanna use `devicePixelRatioF` right? REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D27556 To: guoyunhe, #plasma

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

anthonyfieroni added inline comments. INLINE COMMENTS > componentchooser.h:51 > > +int validLastCurrentIndex() { > +// m_currentIndex == -1 means there are no previously saved value { in new line, add const REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

anthonyfieroni added a comment. F8107246: Screenshot_20200216_195252.png How it looks now with 0 spacing, with 2 will have no space in panel at all. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To:

D27438: Set System Tray Plasmoid spacing value from 0 to units.smallSpacing

anthonyfieroni added a comment. Maybe units.smallSpacing / 2, i'm pretty sure people that use show all entries in systray will be unhappy to see no free space in their panels. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev,

D27401: [SysterTray] Fix crash on shutdown

anthonyfieroni added a comment. It should target 5.18. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27401 To: kmaterka, #plasma_workspaces, #plasma, broulik Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27257: [Applet]Move toolbar to the bottom

anthonyfieroni added a comment. Why? That's make huge inconsistency, bluetooth applet has it on top, battery and brightness too. REVISION DETAIL https://phabricator.kde.org/D27257 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: anthonyfieroni, ngraham, plasma-devel, Orage, LeGast00n,

D26881: [Applets/Folder View] Allow using a folder that ends with a space

anthonyfieroni added a comment. If url ends with more than one space? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26881 To: ngraham, hein, #plasma Cc: anthonyfieroni, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26773: Added option to blur background on active window

anthonyfieroni added a comment. That's look interesting but indeed it should be a KWin feature, say it has effect `dim inactive` this should be `blur inactive` then wallpaper and any other inactive window will be blurred. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26688: WIP: [Night Color] Display time when the next transition will start

anthonyfieroni added inline comments. INLINE COMMENTS > zzag wrote in main.qml:57 > 6500K is the neutral screen color temperature. Although I don't think that I > follow you. Do you recommend not to hardcode this constant? > Do you recommend not to hardcode this constant? Yes. REPOSITORY

D26688: WIP: [Night Color] Display time when the next transition will start

anthonyfieroni added inline comments. INLINE COMMENTS > main.qml:57 > +if (monitor.operationMode != Monitor.ConstantMode) { > +if (monitor.currentTemperature == 6500) { > +// TODO: Show a better message... The bigger todo is hardcoded 6500K ? REPOSITORY

D25449: Start of the new Formats KCM

anthonyfieroni added inline comments. INLINE COMMENTS > kcm.cpp:39 > +{ > +qmlRegisterType(); > +qmlRegisterUncreatableType("org.internal.kcm.formats", 1, > 0, "LocaleModel", QStringLiteral("Model to access the data")); https://doc.qt.io/qt-5/qqmlengine-obsolete.html > kcm.cpp:41 > +

D26434: [Battery Monitor] Don't blink when battery is critical

anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. > Given battery critical notification is persistent and always on top of everything these days, you can't really miss the fact that you're almost ouf of power. I

D26267: Replace deprecated QWeakPointer::data() with .toStrongRef().data()

anthonyfieroni added a comment. `auto c = client().toStrongRef().data();` This is completely wrong, the idea behind shared / weak pointer is ability to know when non-owning resource goes out of scope. by calling toStrongRef you extend its lifetime if and only if it exists at time of call

D26185: Fix font rendering when compiled against Qt >= 5.14

anthonyfieroni added a comment. Can forcing bigger font DPI make things better? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel,

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

anthonyfieroni added inline comments. INLINE COMMENTS > main.xml:10 > > - 100 > + 150 > I don't think the default should be anything but 100 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D26234 To: gvgeo, #vdg, #plasma,

D26185: Fix font rendering when compiled against Qt >= 5.14

anthonyfieroni added a comment. Test with `qputenv(QT_ENABLE_HIGHDPI_SCALING, "1")` it's especially for 5.14+ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

anthonyfieroni added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

anthonyfieroni added a comment. So with the patch is it drawn when it is ticked in window decoration? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

anthonyfieroni added a comment. Is that configurable (Window decorations -> ^ Draw separator between titlebar and a window ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: anthonyfieroni, broulik, ngraham, plasma-devel,

D22418: WIP [wayland] make automatic backend selection truly automatic

anthonyfieroni added inline comments. INLINE COMMENTS > main_wayland.cpp:398-400 > +if ((*it).isDouble()) { > +prio1 = static_cast((*it).toDouble()); > +} Just use `toInt` > main_wayland.cpp:405-407 > +if ((*it).isDouble()) {

D23413: [System Tray] Unified data model for System Tray items

anthonyfieroni added inline comments. INLINE COMMENTS > PlasmoidItem.qml:85-87 > if (!applet) { > -plasmoidContainer.destroy(); > print("applet destroyed") > } Remove that code as well. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25185: Icon: solve threading issue on when the source is http

anthonyfieroni added a comment. Can we just use queued connection, it'll avoid mutex weirdness. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25185 To: apol, #kirigami, mart Cc: anthonyfieroni, bcooksley, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D25125: Use KListOpenFilesJob for retrieving apps blocking unmount

anthonyfieroni added a comment. Set QT_PLUGIN_PATH to you local path with plugin after that set the system path for others `QT_PLUGIN_PATH=/local/path:/system/path executable` INLINE COMMENTS > ksolidnotify.h:50 > void notify(Solid::ErrorType solidError, const QString& error, const

D24985: [wallpapers/image] Seed random number generator

anthonyfieroni added inline comments. INLINE COMMENTS > slidefiltermodel.cpp:140 > std::iota(m_randomOrder.begin(), m_randomOrder.end(), 0); > std::random_shuffle(m_randomOrder.begin(), m_randomOrder.end()); > } random_shuffle is removed in C++17, so maybe we can change

D24748: [containmentlayoutmanager] Don't accept button events that only start timers

anthonyfieroni added a comment. You can try it like that: if (!m_editMode) { event->setAccepted(false); } REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24748 To: davidedmundson, #plasma Cc: anthonyfieroni, wbauer, plasma-devel,

D24683: [KWindowSystem] in icon() return realistic icon size

anthonyfieroni added inline comments. INLINE COMMENTS > meven wrote in windowsystem.cpp:173 > @anthonyfieroni Hey Anthony > Do you remember where the if comparison width values come from in your commit > https://cgit.kde.org/kwindowsystem.git/commit/?id=e8762b96ae7a9fabc6af8fc5dcf2b82a7206053f

D24711: KCM mouse: fix the bug with flat acceleration profile for libinput DDX driver

anthonyfieroni added a comment. https://phabricator.kde.org/source/plasma-desktop/browse/master/kcms/mouse/backends/x11/x11_libinput_dummydevice.cpp$126 It should be changed also, right? When you create a diff add a more context to it, like `git diff -U100 > patch` REPOSITORY R119

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

anthonyfieroni added reviewers: mart, Plasma. anthonyfieroni added a comment. Kirigami itself depends on 5.11 https://phabricator.kde.org/source/kirigami/browse/master/CMakeLists.txt$8 so update version to that one https://doc.qt.io/qt-5/qtquickcontrols-index.html REPOSITORY R169 Kirigami

D24009: RFC: Make Breeze Dark darker

anthonyfieroni added a comment. I'm using it from 5.1 and it's great because it's not so dark, -1 from me. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24009 To: filipf, cblack, ndavis, #vdg, ngraham, #plasma Cc: anthonyfieroni, plasma-devel, LeGast00n,

D23984: [System Settings] redesign intro page

anthonyfieroni added inline comments. INLINE COMMENTS > introPage.qml:60 > +Kirigami.Heading { > +text: "KDE Plasma" > +font.pointSize: 24 // largest level is too small, so we use > pointSize Use i18n also only Plasma about me. > introPage.qml:61 >

D23389: Use "Make default" buttons to switch the default device

anthonyfieroni added a comment. In D23389#518211 , @ngraham wrote: > I can add a note for translators that this string should be kept as short as possible. Furthermore in bulgarian is even longer, there is no short word that fits

D23389: Use "Make default" buttons to switch the default device

anthonyfieroni added a comment. My big concern is that translated text is mainly not too big in English but in other lang. Even we change it to "Default Out" (since it has a label "Outputs"). REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

anthonyfieroni added a comment. But in settings is radio button F7276400: Screenshot_20190824_185610.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca, #plasma, #vdg Cc: ndavis,

D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button

anthonyfieroni added a comment. Why not it's a checkbox ? Make default looks big. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca, #plasma, #vdg Cc: anthonyfieroni, shubham, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23350: Chaning default iconSize in systemtray

anthonyfieroni added a comment. In D23350#516765 , @ngraham wrote: > So this is a complaint that comes up a lot. I do see what you mean, and in my opinion, what we need is a dual-mode size control UI that lets you switch between "scale icons to

D22316: Avoid garbling the sound if the volume slider is moved fast

anthonyfieroni added a comment. updateTimer uses slider value and it takes 200 ms to react, so you can sync the timer with keyboard one by increase the interval https://phabricator.kde.org/source/plasma-pa/browse/master/applet/contents/ui/ListItemBase.qml$198 REPOSITORY R115 Plasma Audio

D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM

anthonyfieroni added a comment. Since we have 4 values on right / left, 0 should be the default one, no? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22885 To: davidedmundson, #plasma Cc: anthonyfieroni, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D21667: Optionally display threads as if they were processes

anthonyfieroni added a comment. Use spaces instead of tabs. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D21667 To: topimiettinen Cc: anthonyfieroni, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22333: Move Solid::Device::listFromQuery calls to a separate thread

anthonyfieroni added a comment. https://phabricator.kde.org/source/solid/browse/master/src/solid/devices/frontend/devicemanager.cpp$301 @bruns, It's backend per thread REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22333 To: apol, #plasma,

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

anthonyfieroni added inline comments. INLINE COMMENTS > logout.cpp:399-400 > } else { > -Solid::PowerManagement::stopSuppressingSleep(inhibitCookie); > +delete inhibitionJob; > +inhibitionJob = nullptr; > qCDebug(KSMSERVER) << "Client " << c->program() << "

D22122: use pwquality_strerror to get error strings

anthonyfieroni added inline comments. INLINE COMMENTS > passworddialog.cpp:157 > +const QString errorString = > +QString::fromLatin1(pwquality_strerror(buf, > PWQ_MAX_ERROR_MESSAGE_LEN, > + error, auxerror)); Shouldn't be

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

anthonyfieroni added inline comments. INLINE COMMENTS > xwindowtasksmodel.cpp:673-675 > +if (d->lastActivated.contains(window)) { > +return d->lastActivated.value(window); > +} That's double lookup in intensive called function, what about int idx =

D22084: Span wayland objects to lifespan of the QApplication

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in waylandintegration.cpp:95-99 > Since qApp is the parent are they needed? When destroyed qApp will call > delete on m_waylandBlurManager, no? Or that's when removed during the normal execution? REPOSITORY R130

D22084: Span wayland objects to lifespan of the QApplication

anthonyfieroni added inline comments. INLINE COMMENTS > waylandintegration.cpp:95-99 > connect(m_waylandBlurManager, > ::Client::BlurManager::removed, this, > [this] () { > m_waylandBlurManager->deleteLater(); > -m_waylandBlurManager =

D21918: [powerdevil] Connect to battery source events

This revision was automatically updated to reflect the committed changes. Closed by commit R122:a1f9e365a5b4: [powerdevil] Return battery source monitoring (authored by anthonyfieroni). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21918?vs=60098=60131

D21918: [powerdevil] Connect to battery source events

anthonyfieroni added a reviewer: davidedmundson. anthonyfieroni added a comment. it's removed in D20157 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D21918 To: anthonyfieroni, broulik, #plasma, davidedmundson Cc:

D21918: [powerdevil] Connect to battery source events

anthonyfieroni created this revision. anthonyfieroni added reviewers: broulik, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY I don't know how this works till now, but without monitor battery

D19745: Fix system tray UI/UX & refactor

anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in PlasmoidItem.qml:45 > Huh? how did this work before? Applets do it by itself, when it not do, it does not work like Weather Widget embed in systray. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19796: [Device Notifier] Restore Solid notification messages

anthonyfieroni added inline comments. INLINE COMMENTS > DeviceItem.qml:50 > > -readonly property bool hasMessage: statusSource.lastUdi == udi && > statusSource.data[statusSource.last] ? true : false > -readonly property var message: hasMessage ? > statusSource.data[statusSource.last]

D20786: ProcessList: add support for cgroups

anthonyfieroni added inline comments. INLINE COMMENTS > anthonyfieroni wrote in ProcessList.c:420-421 > for (int i = strlen(buf) - 1; buf[i] == '\n'; i++) > buf[i] = '\0'; I made mistake i mean `i--` we start from last. REPOSITORY R106 KSysguard REVISION DETAIL

D20859: Crash in sddmthemeinstaller invalid use of errorString

anthonyfieroni added a comment. That's maybe KAuth bug or KCoreAddons one, when job fails it should have errorString. Also check jobs does not delete itself. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D20859 To: johngehrig, ngraham Cc:

D20786: ProcessList: add support for cgroups

anthonyfieroni added inline comments. INLINE COMMENTS > ProcessList.c:420-421 > +if ( buf[0] == '0' && buf[1] == ':' && buf[2] == ':' ) { > + while (buf[strlen(buf) - 1] == '\n') > +buf[strlen(buf) - 1] = '\0'; /* trim trailing newlines */ > + ps->cGroup = strdup( [3] );

D19947: systray: show a small animation on the icons when activated

anthonyfieroni added a comment. In D19947#438052 , @apol wrote: > In D19947#438003 , @davidedmundson wrote: > > > It's subtle but I quite like it. > > > \o/ > > > It feels a bit

D19745: Fix system tray UI/UX & refactor

anthonyfieroni added reviewers: VDG, Plasma, broulik. anthonyfieroni added a comment. Video or screenshot will be helpful. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik Cc: anthonyfieroni, plasma-devel,

D19588: [Notifications] Improve finished notification

anthonyfieroni added inline comments. INLINE COMMENTS > Jobs.qml:117-120 > +var displayDestUrl = (destUrl ? destUrl.toString() : ""); > +if (displayDestUrl.indexOf("file:///") === 0) { > +displayDestUrl = displayDestUrl.substr(7);

D19550: [Media Frame] Set sourceSize for higher quality and lower memory consumption

anthonyfieroni added inline comments. INLINE COMMENTS > main.qml:224-225 > > +onWidthChanged: imageReloadTimer.start() > +onHeightChanged: imageReloadTimer.start() > + Maybe restart is better, you can resize more than a second, so it'll wait a timer interval

D19194: Adjust date string height to match time string with vertical panel

anthonyfieroni added inline comments. INLINE COMMENTS > DigitalClock.qml:305 > // this can be marginal bigger than contentHeight because of > the horizontal fit > -height: Math.max(0.8 * timeLabel.height, minimumPixelSize) > +height:

D19036: [notifications] Lift up notification content if one line of body text droops

anthonyfieroni added inline comments. INLINE COMMENTS > NotificationItem.qml:34-47 > +if (bodyText.lineCount > 1) { > +return mainLayout.height > +} else { > +if (appIconItem.valid || imageItem.nativeWidth > 0) { > +return

D18805: Workaround for the bug 393630 - SystemTray part

anthonyfieroni added a comment. Ok, so @trmdi you can apply exactly David suggest and discard D18804 , i've test it and it works. Push it in 5.15 not 5.16 that's bug fix not feature. 5.12 can be also interested path as LTS version. REPOSITORY R120

D18805: Workaround for the bug 393630 - SystemTray part

anthonyfieroni added a comment. @davidedmundson it works. I really don't know that sharing model between contexts cause a such behavior. It's caused by some ref counting ? Did you know why, it's internal Qt issue that we can fix or it's expected ? REPOSITORY R120 Plasma Workspace

D18805: Workaround for the bug 393630 - SystemTray part

anthonyfieroni added a comment. I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18805 To: trmdi,

D17874: [dimdisplay] Effectively waits display to wake-up

This revision was automatically updated to reflect the committed changes. Closed by commit R122:c40b8ba3b66d: [dimdisplay] Waits a bit display to wake-up (authored by anthonyfieroni). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17874?vs=48407=49468

D16890: [systemtray] Keep config entries after modifying

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0885170daf56: [systemtray] Workaround component creation (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16890?vs=45502=49467#toc REPOSITORY R120 Plasma

D17874: [dimdisplay] Effectively waits display to wake-up

anthonyfieroni added a comment. The problem is too specific, it happen when dpms is activated after dimm display is setted screen to 0, if dimm option is not checked it works correct to me. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D17874 To:

D17874: [dimdisplay] Effectively waits display to wake-up

anthonyfieroni added a comment. Video can't handle it. F6522997: Screenshot_20190103_181438.png Laptop at this configuration, screen brightness < 100%, waits more that 10 min inactivity, plug-in adapter will wake-up screen with brightness at

D17874: [dimdisplay] Effectively waits display to wake-up

anthonyfieroni added a comment. Does someone test it, @thsurrel ? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D17874 To: anthonyfieroni, mart, broulik, thsurrel, #plasma Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D17874: [dimdisplay] Effectively waits display to wake-up

anthonyfieroni created this revision. anthonyfieroni added reviewers: mart, broulik, thsurrel, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. anthonyfieroni requested review of this revision. REVISION SUMMARY This is 2nd patch of fixes annoying side effect

D16918: [dimdisplay] Do not change screen brightness on invalid values

This revision was automatically updated to reflect the committed changes. Closed by commit R122:6f350690723a: [dimdisplay] Do not change screen brightness on invalid values (authored by anthonyfieroni). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D16856: [comicupdater] Fix last day check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:28493251921b: [comicupdater] Fix last day check (authored by anthonyfieroni). REPOSITORY R114 Plasma Addons

D16873: [comic] Request current identifier on date changed

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:fd19c36ec4e4: [comic] Request current identifier on data change (authored by anthonyfieroni). CHANGED PRIOR TO COMMIT

D16918: [dimdisplay] Do not change screen brightness on invalid values

anthonyfieroni added a comment. @broulik, @thsurrel any other ideas or to commit it? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16918 To: anthonyfieroni, #plasma, broulik, mart Cc: thsurrel, broulik, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

  1   2   3   4   5   6   7   >