Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2017-02-08 Thread Ashish Bansal
--- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal

Re: Plasma appet with C++ plugin

2016-04-29 Thread Ashish Bansal
___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > [0] http://blog.davidedmundson.co.uk/node/89 -- *Regards,* *Ashish Bansal* *http://ashish-bansal.in <http://ashish-bansal.in>* ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: robots.txt in quickgit.kde.org

2015-12-29 Thread Ashish Bansal
> > > > -- > > Lydia Pintscher - http://about.me/lydia.pintscher > > KDE e.V. Board of Directors / KDE Community Working Group > > http://kde.org - http://open-advice.org > > > >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to > unsubscribe

robots.txt in quickgit.kde.org

2015-12-27 Thread Ashish Bansal
the search engines. [0] https://quickgit.kde.org/robots.txt -- *Regards,* *Ashish Bansal* *http://ashish-bansal.in <http://ashish-bansal.in>* ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-12-22 Thread Ashish Bansal
ImageFetcher::setupImageFetcher ? libs/mediacenter/medialibrary.h (line 59) <https://git.reviewboard.kde.org/r/125993/#comment61657> mediaUpdated still sounds wrong, although I am not sure what it should be named. Anyway replace it with more logically correct name. - Ashish Bansal On Dec.

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Ashish Bansal
edia in the view ? Check PmcMetadataModel::signalUpdate libs/mediacenter/pmcmetadatamodel.cpp (line 87) <https://git.reviewboard.kde.org/r/125993/#comment60835> Remove White space error. - Ashish Bansal On Nov. 23, 2015, 1:50

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-13 Thread Ashish Bansal
> On Nov. 13, 2015, 9:23 a.m., Ashish Bansal wrote: > > libs/mediacenter/lastfmimagefetcher.cpp, line 158 > > <https://git.reviewboard.kde.org/r/125993/diff/2-3/?file=416650#file416650line158> > > > > As imageFetcher is a signal, append "emit

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-13 Thread Ashish Bansal
tps://git.reviewboard.kde.org/r/125993/#comment60563> As imageFetcher is a signal, append "emit" word in the beginning. Although it is an empty macro, but it helps in understanding code better. - Ashish Bansal On Nov. 12, 2015, 7:21 p.m., Aditya

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-12 Thread Ashish Bansal
n connect function. - Ashish Bansal On Nov. 12, 2015, 4:23 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://gi

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-05-02 Thread Ashish Bansal
name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-05-02 Thread Ashish Bansal
marked as submitted. Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- Submitted with commit c806f88e4ea65330719fa1721cdf15ea5cbddb5a by Ashish Bansal to branch master. Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-30 Thread Ashish Bansal
). Expected name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-30 Thread Ashish Bansal
? It seems to me that removing this first if() branch would work just the same. Ashish Bansal wrote: The first if() has been used for getting . (1).txt instead of .txt (1) But yeah, code looks nasty with this special case. Should I remove this? - Ashish

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-28 Thread Ashish Bansal
wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-26 Thread Ashish Bansal
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: autotests/globaltest.cpp, line 96 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96 This should be (1).txt? Ashish Bansal wrote: imho if my any file starts with ., that's my dot file and I would

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-26 Thread Ashish Bansal
--- On April 26, 2015, 12:19 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-26 Thread Ashish Bansal
/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-06 Thread Ashish Bansal
--- On April 4, 2015, 1:15 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 4

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-04 Thread Ashish Bansal
f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-03 Thread Ashish Bansal
--- On Nov. 2, 2014, 3:34 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69671 --- On Oct. 28, 2014, 5:50 p.m., Ashish Bansal wrote

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Ashish Bansal
L25 of plasma-mediacenter/CMakeLists.txt for example Ashish Bansal wrote: Like this - find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct then it's okay because cmake is unable to find its path for me that's why I hardcoded its path. Bhushan Shah wrote: umm nope but like

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Ashish Bansal
--- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Ashish Bansal
--- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-10-28 Thread Ashish Bansal
to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-10-28 Thread Ashish Bansal
:14 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:14 p.m

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-10-28 Thread Ashish Bansal
/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo