Re: Oxygen Sounds split

Thanks Jonathan -- Benjamin Port - enioka Haute Couture 06 38 83 18 16 On mercredi 26 janvier 2022 17:29:08 CET Jonathan Riddell wrote: > I've added licencing to the oxygen-sounds repo after discussion with > Ruphy. I've removed the sounds from the oxygen repo and in Plasma 5.25 > I'l

Re: Proposal: Split oxygen sounds

/share/sounds/name_starting_with_Oxygen (like now) We will still need to implement the spec in knotification to support the spec Benjamin > On Thu, Nov 25, 2021 at 2:55 PM Benjamin Port > wrote: > > > > Hello, > > > > Currently all plasma sounds came from oxygen

Proposal: Split oxygen sounds

Hello, Currently all plasma sounds came from oxygen, even if you use breeze theme you still need to install oxygen package in order to have sound notification for example. That's why I will suggest to split oxygen repository. Current oxygen repository will keep everything except sounds. And a

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. Default indicator discussion is now on https://phabricator.kde.org/T13008 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart Cc: GB_2, mart, ngraham, abetts, filipf,

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

bport accepted this revision. bport added a comment. ok then ship it REPOSITORY R119 Plasma Desktop BRANCH l-setnearest (branched from master) REVISION DETAIL https://phabricator.kde.org/D29155 To: ahmadsamir, #plasma, bport, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n,

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

bport added a comment. I don't think we will have same behavior, we don't only check name but also size, type... If we are ok to fallback in all case to the same font that can work. From your test plan, something look strange you don't end with a monospaced font for fixed font as

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

bport accepted this revision. bport added a comment. OK for me, as long as VDG is ok with this behavior INLINE COMMENTS > fonts.cpp:272 > +const int generalFontPointSize = font.pointSize(); > +if (generalFontPointSize > 8) { > +

D29056: [libtaskmanager] add stacking order data for wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c46446e65b98: [libtaskmanager] add stacking order data for wayland (authored by bport). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29064: Support module commandline paramenter

bport added inline comments. INLINE COMMENTS > IconMode.cpp:204 > + > +if (!startupModule().isEmpty()) { > +MenuItem *item = rootItem()->descendantForModule(startupModule()); Indentation is not correct REPOSITORY R124 System Settings REVISION DETAIL

D28916: fix(kded): center action OSD on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R104:b3b45721ee17: fix(kded): center action OSD on wayland (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28916?vs=80376=80899#toc REPOSITORY R104 KScreen CHANGES SINCE

D29056: [libtaskmanager] add stacking order data for wayland

bport created this revision. bport added reviewers: broulik, davidedmundson, zzag, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Depends on D29055 and D29054

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

bport added a comment. In D28740#652419 , @broulik wrote: > This is for displaying whether do not disturb is on. The "until disabled" option just sets it to one year in the future. But it's odd to show "until 2021", so we don't show the date

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

bport added a comment. According to settings.h documentation When invalid or in the past, do not disturb mode should be considered disabled. So why not setting date to invalid date or one year in the past and do a test if date is in the future REPOSITORY R120 Plasma Workspace

D28916: fix(kded): center action OSD on wayland

bport added inline comments. INLINE COMMENTS > davidedmundson wrote in OsdSelector.qml:34 > That was confusing, I'll rephrase. > > Is it so the property "x" remains unset when running under the x windowing > environment? Yes I wanted to ensure we don't change it on X Didn't found a way to do

D28653: Set cursor size default to 24 to align with KCM default value

This revision was automatically updated to reflect the committed changes. Closed by commit R135:4a7786999d31: Set cursor size default to 24 to align with KCM default value (authored by bport). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D28655: Set default cursor size as 24 to follow new default on KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7d19c5fc0fa7: Set default cursor size as 24 to follow new default on KCM (authored by bport). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28652: [Cursors] Remove Resolution Dependant option

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a68554d39c5c: [Cursors] Remove Resolution Dependant option (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28652?vs=79590=80379

D28916: fix(kded): center action OSD on wayland

bport created this revision. bport added reviewers: romangg, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Currently on wayland action OSD is not centered on the screen. On Wayland we will

D28462: [KCM] Add color state probe to allow system settings to display current default state

bport updated this revision to Diff 80215. bport added a comment. fix build REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28462?vs=79781=80215 REVISION DETAIL https://phabricator.kde.org/D28462 AFFECTED FILES kcms/colors/CMakeLists.txt

D28817: fix (kcm): correct output identifier position on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R104:538116fd1096: fix (kcm): correct output identifier position on wayland (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28817?vs=80121=80125#toc REPOSITORY R104 KScreen

D28818: fix(kcm): show output ids in reference to currently applied config

This revision was automatically updated to reflect the committed changes. Closed by commit R104:544a7c14946a: fix(kcm): show output ids in reference to currently applied config (authored by bport). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D28817: fix (kcm): correct output identifier position on wayland

bport updated this revision to Diff 80121. bport added a comment. Fix import order (remove unused one) Remove QTimer m_timer (field not used). Let me know if you want this one in a separate commit. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D28817: fix (kcm): correct output identifier position on wayland

bport updated this revision to Diff 80120. bport added a comment. fix leak and style REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28817?vs=80090=80120 REVISION DETAIL https://phabricator.kde.org/D28817 AFFECTED FILES kcm/CMakeLists.txt

D28817: Fix KScreen output identifier position on wayland

bport added a comment. In D28817#647930 , @anthonyfieroni wrote: > In D28817#647912 , @bport wrote: > > > I don't think we have a leak, on destructor we delete all view > > qDeleteAll(m_views);

D28817: Fix KScreen output identifier position on wayland

bport updated this revision to Diff 80090. bport added a comment. Remove border and shadow REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28817?vs=80085=80090 REVISION DETAIL https://phabricator.kde.org/D28817 AFFECTED FILES kcm/CMakeLists.txt

D28817: Fix KScreen output identifier position on wayland

bport added a comment. I don't think we have a leak, on destructor we delete all view qDeleteAll(m_views); REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28817 To: bport, #plasma, meven, ervin Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n,

D28817: Fix KScreen output identifier position on wayland

bport updated this revision to Diff 80085. bport added a comment. update commit message REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28817?vs=80082=80085 REVISION DETAIL https://phabricator.kde.org/D28817 AFFECTED FILES kcm/CMakeLists.txt

D28818: Identify output according to current applied position, not an unapplied position

bport updated this revision to Diff 80086. bport added a comment. update commit message REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28818?vs=80083=80086 REVISION DETAIL https://phabricator.kde.org/D28818 AFFECTED FILES kcm/config_handler.h

D28818: Identify output according to current applied position, not an unapplied position

bport created this revision. bport added reviewers: Plasma, meven, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Depends on D28817 . REPOSITORY R104 KScreen

D28817: Fix KScreen output identifier position on wayland

bport created this revision. bport added reviewers: Plasma, meven, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY BUG: 385672 REPOSITORY R104 KScreen REVISION DETAIL

D28462: [KCM] Add color state probe to allow system settings to display current default state

bport updated this revision to Diff 79781. bport added a comment. Rename state probe to data and use them in KCM And fix defaultness of spellchecking inside data (default at loading without widget state) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28461: In sidebar mode show if a module is in default state or not

bport updated this revision to Diff 79771. bport added a comment. - Factorize QML code - Rename isDefault to showDefaultIndicator REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28461?vs=79499=79771 REVISION DETAIL

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. Thanks for your work REPOSITORY R119 Plasma Desktop BRANCH l-kfontchooserdialog (branched from master) REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma,

D28652: [Cursors] Remove Resolution Dependant option

bport added a comment. For the wayland one at least I'm sure it's not that because without restarting session nothing happen For the X one I didn't see anything related to apply on the bug report (but yes the apply bug exist) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28652: [Cursors] Remove Resolution Dependant option

bport added a comment. In D28652#643733 , @ngraham wrote: > After locally fixing the compile error, applying this patch as well as all three others, and restarting KWin, I'm unfortunately seeing the bugs marked as fixed still happening: I

D28652: [Cursors] Remove Resolution Dependant option

bport updated this revision to Diff 79590. bport added a comment. Add migration to delete old default REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28652?vs=79576=79590 REVISION DETAIL https://phabricator.kde.org/D28652 AFFECTED FILES

D28652: [Cursors] Remove Resolution Dependant option

bport added inline comments. INLINE COMMENTS > ngraham wrote in x11_backend.cpp:145 > Would `size` ever be empty now (not a leading question; I'm genuinely asking) No never be empty, not sure what I made there... looks like I reverted something before commiting REPOSITORY R119 Plasma

D28652: [Cursors] Remove Resolution Dependant option

bport planned changes to this revision. bport added a comment. In D28652#643612 , @ngraham wrote: > For them I guess we'll need a kconf update file to migrate them to the new 24 value. We will need to remove this entry we don't write

D28652: [Cursors] Remove Resolution Dependant option

bport updated this revision to Diff 79576. bport added a comment. fix build REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28652?vs=79569=79576 REVISION DETAIL https://phabricator.kde.org/D28652 AFFECTED FILES

D28652: [Cursors] Remove Resolution Dependant option

bport added a comment. Those code review are linked to this one: https://phabricator.kde.org/D28653 https://phabricator.kde.org/D28654 https://phabricator.kde.org/D28655 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28652 To: bport, #plasma, meven,

D28653: Set cursor size default to 24 to align with KCM default value

bport added a comment. Those code review are linked to this one: https://phabricator.kde.org/D28652 https://phabricator.kde.org/D28654 https://phabricator.kde.org/D28655 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D28653

D28655: Set default cursor size as 24 to follow new default on KCM

bport added a comment. Those code review are linked to this one: https://phabricator.kde.org/D28652 https://phabricator.kde.org/D28653 https://phabricator.kde.org/D28654 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28655 To: bport, #plasma, meven,

D28655: Set default cursor size as 24 to follow new default on KCM

bport created this revision. bport added reviewers: Plasma, meven, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28655 AFFECTED

D28653: Set cursor size default to 24 to align with KCM default value

bport created this revision. bport added reviewers: Plasma, meven, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

D28652: [Cursors] Remove Resolution Dependant option

bport created this revision. bport added reviewers: Plasma, meven, davidedmundson. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. bport requested review of this revision. REVISION SUMMARY This option don't work as expected for years on X,

D28461: In sidebar mode show if a module is in default state or not

bport updated this revision to Diff 79499. bport added a comment. Change icon with a blue dot REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28461?vs=78970=79499 REVISION DETAIL https://phabricator.kde.org/D28461 AFFECTED FILES

D28462: [KCM] Add color state probe to allow system settings to display current default state

bport updated this revision to Diff 79497. bport added a comment. Adapt to kcmutils update and add cursor, fonts, spellchecking example REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28462?vs=78971=79497 REVISION DETAIL

D28461: In sidebar mode show if a module is in default state or not

bport added inline comments. INLINE COMMENTS > mart wrote in CategoriesPage.qml:207 > try to keep the item count as small as possible, especially in item delegates. > I would really prefer if we could do without this wrapper Indeed this wrapper is not needed > mart wrote in

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. Yes we will need to have a probe for each KCM, and I currently look to reuse this probe in the KCM that will split a bit more data and UI. Some KCM like pulseaudio one don't need that for example, because there is no default setup REPOSITORY R124 System Settings

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. In D28461#639056 , @ngraham wrote: > Is D28460 the only other patch that's needed? I applied that and then this patch compiled fine, but I don't see any difference in the sidebar,

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. In D28461#639022 , @ngraham wrote: > I get a compile error: > > /home/nate/kde/src/systemsettings/core/MenuItem.cpp: In member function ‘void MenuItem::updateDefault()’: >

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. In D28461#639016 , @abetts wrote: > If I am understanding correctly, this patch adds icons in the kcm list to indicate changes you can revert by going to the kcm. Basically, default settings have changed and now you have

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. F8208462: image.png Test with a blue dot, took less space than an icon Wa can imagine a tooltip when you go hover the dot explaining it REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. Goal of this feature is to improve user discoverability and allow them to find more easily which settings diverged from defaults one, so they can more easily revert to the default value when needed Indeed the current indicator is not the good one, and I will be happy

D28462: [KCM] Add color state probe to allow system settings to display current default state

bport created this revision. bport added reviewers: Plasma, ervin, meven, crossi, hchain. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28462

D28461: In sidebar mode show if a module is in default state or not

bport created this revision. bport added reviewers: Plasma, ervin, meven, crossi, hchain. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

bport added a comment. Some coding style nitpicking INLINE COMMENTS > export_scheme_dialog.cpp:46 > int item=0; > -Q_FOREACH(QString component, mComponents) > +for (const QString : qAsConst(mComponents)) > { { on same line > export_scheme_dialog.cpp:74 > +const auto

D28232: [SpellChecking KCM] Fix the build

bport added a comment. https://community.kde.org/Schedules/Plasma_5#Support_status_by_Release_Series So we need to see if we can update the CI REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28232 To: ahmadsamir, #plasma, bport, meven, crossi, ervin Cc:

D28232: [SpellChecking KCM] Fix the build

bport added a comment. Next version of plasma will depend on Qt 5.14 AFAIK so it's not a problem to depend on it INLINE COMMENTS > CMakeLists.txt:9 > set(QT_MIN_VERSION "5.12.0") > -set(KF5_MIN_VERSION "5.66.0") > Indeed this is needed thanks REPOSITORY R119 Plasma Desktop REVISION

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

This revision was automatically updated to reflect the committed changes. Closed by commit R119:38a874ab82aa: [KCM Spellchecking] port to KPropertySkeletonItem (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27503?vs=77267=78297

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. Ok for me but need to wait approval on font dialog review (to ensure correct font style is selected when editing) REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D27785 (branched from

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d28337b6d379: KCM Fonts port anti aliasing part to KPropertySkeletonItem (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport updated this revision to Diff 77267. bport added a comment. fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27503?vs=76516=77267 REVISION DETAIL https://phabricator.kde.org/D27503 AFFECTED FILES kcms/spellchecking/CMakeLists.txt

D27785: [Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary

bport requested changes to this revision. bport added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fonts.cpp:115 > +if (!sameFont) { > +if (font.weight() == QFont::Normal && font.styleName().isEmpty() > +&& result.weight() ==

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

bport added a comment. With your change, we are not allowed anymore to change for example only font and keeping different size, style for each kind of font (window, menu, toolbar...), right ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To:

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport added inline comments. INLINE COMMENTS > ervin wrote in spellchecking.cpp:88 > Sure but still, the skeleton is expected to be already be in a "loaded" state > at that point, that's why it works for the items (otherwise a findItem > wouldn't be enough, it'd have to call readConfig on them

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport added inline comments. INLINE COMMENTS > ervin wrote in spellchecking.cpp:88 > Are you sure this is necessary? I'd expect KCModule::load() to call load() on > m_skeleton no load only do findItem for managed widget on the skeleton > ervin wrote in spellcheckingskeleton.cpp:51 > I have a

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport updated this revision to Diff 76516. bport marked 19 inline comments as done. bport added a comment. cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27503?vs=76385=76516 REVISION DETAIL https://phabricator.kde.org/D27503 AFFECTED

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport updated this revision to Diff 76385. bport added a comment. Take change from sonnet patch in consideration and other ervin feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27503?vs=75998=76385 REVISION DETAIL

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

bport accepted this revision. bport added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > DeviceAutomounter.cpp:39 > DeviceAutomounter::DeviceAutomounter(QObject *parent, const QVariantList > ) > -: KDEDModule(parent) > +: KDEDModule(parent),

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

bport created this revision. bport added reviewers: Plasma, meven, crossi, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27503 AFFECTED

D27482: Update kdeglobals config file for Breeze widgetStyle

bport added inline comments. INLINE COMMENTS > style_widgetstyle_default_breeze.pl:8 > +chomp; > +s/widgetStyle=breeze/widgetStyle=Breeze/; > +print "$_\n"; This will fix only for Breeze theme This will fix existing case but we also need to fix the root cause (i.e. how we end up

D27470: Set good default value for cursor theme and size in KRDB

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ca9f0eeb9b53: Set good default value for cursor theme and size in KRDB (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27470: Set good default value for cursor theme and size in KRDB

bport added a comment. This is not a KCM, and because of how stuff works with KRDB we can't reuse kcfg easily there (because build by 5 or 6 kcm) About the 0 as default value, perhaps we can change that but it's totally unrelated to this patch, goal there is only to honor default value as

D27470: Set good default value for cursor theme and size in KRDB

bport created this revision. bport added reviewers: Plasma, broulik, ervin, meven, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27470

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75890. bport added a comment. fix build. KRDB can't use Kxftconfig directly so we can't avoid stuff in kdeglobals REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75844=75890 REVISION DETAIL

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

bport added inline comments. INLINE COMMENTS > DeviceAutomounterKCM.cpp:84 > saveLayout(); > +delete m_settings; > } We can also change kcfgc to add parent in constructor REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27127 To: meven, ervin,

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75844. bport added a comment. Add missing space REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75813=75844 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES kcms/fonts/CMakeLists.txt

D27380: [GTK Config] Write Font without style name

bport added a comment. I just read bug report again and the from seems to came from , not from localization. By the way I neved end with localized style, how do you achieve that ? (I mean even in UI) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D27380: [GTK Config] Write Font without style name

bport added a comment. I think a good fix can be to use @davidedmundson solution combined with a check to know if font styleName is not set (if it set it will be not translated. I think QFont yourFont = QFont(...); auto f = QFontInfo(youFont) f.styleName(); <<= is in theory empty

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75813. bport added a comment. Add kconfupdate script to remove unused keys REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75541=75813 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

bport requested changes to this revision. bport added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > componentchooserbrowser.cpp:107 > { > +if (currentIndex() == count() -1) { > +// no browser installed, nor selected add a space between - and 1

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0c4da0774e43: [KCM Fonts] force need save to false during load to avoid state to be true too… (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

bport added a comment. I will look at a proper fix in the next days REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, The-Feren-OS-Dev Cc: The-Feren-OS-Dev, plasma-devel, Orage,

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

bport added a comment. Yes emiting signal from setNeedsSave in all case fix stuff too So this patch is here to solve for "short term" In more long term we need to fix ConfigModule do you think is better to do a setNeedsSave(false) after loading or emiting signal in all case ?

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

bport added a comment. @davidedmundson We have 2 bugs : - KCModuleQML apply button will stay disabled forever if at the end of load function need save is true (probably qml connection not yet done or something like that I guess, not yet found why) => We need to investigate on it too,

D27381: [sidebar] Resolve changes in module before switching

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. Can reproduce bug and fix work as expected REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D27381 To: davidedmundson, #plasma, bport Cc:

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

bport created this revision. bport added reviewers: Plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY This will resolve a bug (apply never enabled).

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75541. bport added a comment. Fix reset and default button for Anti Aliasing area (states were ok, but UI values were not updated after clicking them) depends on https://phabricator.kde.org/D27342 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport added inline comments. INLINE COMMENTS > usta wrote in main.qml:242 > I am really away from qml thing but are you sure this one correct ? I mean > isnt this should be > kcm.dpi instead of kcm.fontsAASettings.dpi ?? No dpi is declared inside fontsAASettings REPOSITORY R119 Plasma

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75465. bport added a comment. fix coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75446=75465 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES kcms/fonts/CMakeLists.txt

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75446. bport added a comment. coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75444=75446 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES kcms/fonts/CMakeLists.txt

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75444. bport added a comment. Fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75442=75444 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES kcms/fonts/CMakeLists.txt

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75442. bport added a comment. Take in consideration Cyril's feedbacks REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27156?vs=75000=75442 REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED FILES

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

bport added inline comments. INLINE COMMENTS > kcm.cpp:257 > +{ > +m_currentBehavior = m_behaviorSettingsList[identifier]; > +emit behaviorSettingsChanged(); Add a if to emit signal only if needed REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27188

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport created this revision. bport added reviewers: Plasma, ervin, crossi, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27156 AFFECTED

D26842: Fix fonts KCM button state

bport added a comment. In D26842#605839 , @fvogt wrote: > Does this mean the default fonts have a style name of "Regular" now? That will break setting bold fonts and such, see https://phabricator.kde.org/D9070. Default is not serialized

D26842: Fix fonts KCM button state

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0a107dcbe9fc: Fix fonts KCM button state (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26842?vs=74576=74982 REVISION DETAIL

D26842: Fix fonts KCM button state

bport added a comment. In D26842#602522 , @ngraham wrote: > We are getting duplicates of https://bugs.kde.org/show_bug.cgi?id=416358, so I guess it would be nice if this made it into 5.18. Ok I will land it to 5.18 and then merge to

D26842: Fix fonts KCM button state

bport updated this revision to Diff 74576. bport added a comment. fix coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26842?vs=74127=74576 REVISION DETAIL https://phabricator.kde.org/D26842 AFFECTED FILES kcms/fonts/fonts.cpp

  1   2   3   >