D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

Zren added a comment. > The `plasma-framework` patch is D29463 Ran my KirigamiDevicePixelRatioTest.qml with `QT_QUICK_CONTROLS_STYLE=Plasma`, `/usr/.../styles/org.kde.desktop`, `/usr/.../styles/org.kde.desktop.plasma`, and `/usr/.../Kirigami.2`.

D29462: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

Zren created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I recently noticed that `Kirigami.Units.devicePixelRatio` was `1.3` even though I was at the default 96dpi when writing a widget's

D27346: emojier: Improve resizing performance

Zren added a comment. As in `clip: true`? delegate: MouseArea { width: emojiView.cellWidth height: emojiView.cellHeight clip: true Rectangle { border.color: "#ff0"; anchors.fill: parent; border.width: 1; color: "transparent" }

D27346: emojier: Improve resizing performance

Zren added a comment. Not sure. Backwards compatibility? Firefox renders a couple of them fine, while the TaskManager widget doesn't. Could it be the "Noto" font? The facepalm ones not working are 3 glyphs merged together (facepalm+skincolor+sex). It's rendering (facepalm+skincolor)

D27346: emojier: Improve resizing performance

Zren added a comment. FixedSize 25pt does help, but "2 glyph emojis" will overlap each other. F8099880: 2020-02-12___11-38-36.png F8099891: screen-2020-02-12_11.34.09.mp4 Rectangle { width:

D27337: [Emojier] Optimize performance

Zren added a comment. I used `Loader` as I didn't want loading glyphs to block scrollbar responsiveness. `GridView` reuses delegates, but I don't think it's the `MouseArea` + `Label` constructor that's slow. I think it's the "rendering the emoji glyph" in the GUI draw that is the root

D27337: [Emojier] Optimize performance

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY BUG: 417454 The emojier fairly slow. Launching is slow. Resizing the window is slow. Changing pages is slow. Scrolling is also

D26773: Added option to blur background on active window

Zren added a comment. I don't care if Inactive Blur is upstreamed or not as all my code is GPL. I didn't upstream it since I thought the feature was niche enough I shouldn't burden others with it's maintenance. This doesn't blur the desktop widgets,

D26681: [TabBox] Thumbnail Grid window switcher

This revision was automatically updated to reflect the committed changes. Closed by commit R114:59cd237a7146: [TabBox] Add Thumbnail Grid window switcher (authored by Zren). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26681?vs=73648=73675 REVISION

D26681: [TabBox] Thumbnail Grid window switcher

Zren updated this revision to Diff 73648. Zren edited the summary of this revision. Zren added a comment. Fix implicitWidth error by using Layout.min/maxWidth. Scale captionRow.spacing by dpi. Take into account the close button is 30x30. Use a ColumnLayout for thumbnailGridItems instead

D26681: [TabBox] Thumbnail Grid window switcher

Zren added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:183 > you can use Layout.preferredWidth > > One shouldn't specifiy a width/height from an item inside a layout Uhg, I was using `width: parent.height` and `height: parent.height` but changed it when cleaning it up.

D26681: [TabBox] Thumbnail Grid window switcher

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Cleaned up my code from https://github.com/Zren/kwin-tabbox-thumbnail_grid The column is calculated recursively, but survived a

D19821: Fix breeze dialog background with Qt 5.12.2

Zren added a comment. Another option I believe is to keep the

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

Zren added a comment. Was skimming the Plasma Scripting API today for something else and found where I saw the "update scripts" before: - https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Update_scripts -

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

Zren added inline comments. INLINE COMMENTS > configAppearance.qml:137 > +icon.name: "preferences-desktop-locale" > +onClicked: KCMShell.open("formats.desktop") > +} Was afk today sorry. Do we need `visible:

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

This revision was automatically updated to reflect the committed changes. Closed by commit R120:58e6cc6e119f: [weather] envcan: Fix typo in lowercase icon lookup string (authored by Zren). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19233: [plasmoidviewer] Add --nobuttons flag to hide button bar

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY This also fixes the `Background { id: backgroundButtons }` not hiding by binding it's visibility to `buttons.visible`. Is the

D19194: Adjust date string height to match time string with vertical panel

Zren added inline comments. INLINE COMMENTS > anthonyfieroni wrote in DigitalClock.qml:305 > You should check if panel orientation, now it's broken horizontal view? This is inside a `State { when: plasmoid.formFactor == PlasmaCore.Types.Vertical }` REPOSITORY R120 Plasma Workspace REVISION

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

Zren added a comment. https://doc.qt.io/qt-5/qt.html#CheckState-enum `i18n("Use locale default")` should be in the middle (`currentIndex=1`). 12h should be `currentIndex=0`, and 24h should be `currentIndex=2`

D19176: [weather] envcan: Fix typo in lowercase icon lookup string

Zren created this revision. Zren added reviewers: Plasma, kossebau. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY The capital `S` breaks the icon match. It was broken in Plasma 5.6

D19174: [weather] envcan: Document urls for example data + list all warnings

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I can place this in the `ion_envcan.h` or the `ion_envcan.cpp`. It's not worth backporting so it'll get merged to master. REPOSITORY

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

Zren closed this revision. Zren added a comment. Shoot, I accidentally forgot the Phab Rev link in the commit message (though I remembered the bugzilla tags). I've setup a `.git/hook/prepare-commit-msg` -like thing for Sublime Text to

D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

Zren created this revision. Zren added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY In 12h system locales (eg: en_US), checked=1 is cast as Qt::PartiallyChecked=1 which defaults to the

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

Zren added a comment. In D18961#410792 , @kossebau wrote: > > we no longer have to install the widget to .../share/plasma/plasmoids/ > > No experience here, but do we not still need to install the QML extension plugins to have the applet

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY If `plasmoid.nativeInterface.source != ""`, we copy it to `plasmoid.configuration.source` + same with all other properties besides

D18936: [weather] Fix weather Notices tab not showing

This revision was automatically updated to reflect the committed changes. Closed by commit R114:46204a5e2a84: [weather] Fix weather Notices tab not showing (authored by Zren). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18936?vs=51449=51455#toc REPOSITORY R114 Plasma Addons

D18936: [weather] Fix weather Notices tab not showing

Zren added a comment. Ah, `NoticesView.qml` in Plasma 5.12 was slightly different. - https://github.com/KDE/kdeplasma-addons/blob/Plasma/5.12/applets/weather/package/contents/ui/NoticesView.qml -

D18936: [weather] Fix weather Notices tab not showing

Zren added a comment. Note: Env Canada lists all their Warnings + Watches for all of Canada at https://weather.gc.ca/warnings/index_e.html should anyone need to test in the future. Is there any other Ion besides EnvCanada that currently displays "Warnings"? I can definitely push to

D18936: [weather] Fix weather Notices tab not showing

Zren updated this revision to Diff 51449. Zren edited the summary of this revision. Zren added a comment. Add `Layout.alignment: Qt.AlignHCenter` to the `PlasmaExtras.Heading` F6608836: 2019-02-11___17-47-22.png REPOSITORY R114 Plasma Addons

D18936: [weather] Fix weather Notices tab not showing

Zren added a comment. I just noticed that the "Warnings Issued" text is left aligned. Might as well center align it while we're at it. Add this as a child of `PlasmaExtras.Heading` to debug: Rectangle { anchors.fill: parent; border.color: "#f00"; border.width: 1; color:

D18936: [weather] Fix weather Notices tab not showing

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY `Toronto, ON` in the `Env Canada` ion currently has a weather warning. The weather widget's code currently has a bug that will only show

D18696: Update `libdbusmenuqt` and the AppMenu plugin

Zren added inline comments. INLINE COMMENTS > CMakeLists.txt:27 > > -# add_subdirectory(test) > +add_subdirectory(test) We do not bundle the libdbusmenuqt test directory in this repo. So you need to comment this line out otherwise it will not build with the test directory missing.

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

This revision was automatically updated to reflect the committed changes. Closed by commit R114:80bd32b12a01: Consistent arrow key handling in the Informative Alt+Tab skin (authored by Zren). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D16093: Consistent arrow key handling in the Informative Alt+Tab skin

Zren added a comment. I forgot to merge this after david's patch was merged. I just tested this in the Neon Beta ISO to confirm the fix still works. In D16093#359639 , @ngraham wrote: > Hmm, this does not actually work for me. Seems like it

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. There was a few +1s, but I wasn't exactly sure who specifically "approves" this for a merge to `plasma-workspace` or `digital-clock` specifically. My bad, I shouldn't of left this feature to the last minute and felt rushed to get it in. I'll try to avoid the time

D18019: [Digital Clock] Add ability to set a custom date format string

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:235fa8107dab: [Digital Clock] Add ability to set a custom date format string (authored by Zren). REPOSITORY R120

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. > D18155 Looking at the alternative patch, I've renamed the config key variable to `customDateFormat`. Most of the differences stem from not using a "variant" data type for `DigitalClock.qml`'s `dateFormat` variable. The `string

D18019: [Digital Clock] Add ability to set a custom date format string

Zren updated this revision to Diff 49332. Zren edited the summary of this revision. Zren edited the test plan for this revision. Zren added a comment. - Rename config key from `dateFormatStr` and config TextField `dateFormatTextField` to `customDateFormat`. - Remove the "Color Format

D18168: [WIP] [Digital Clock] Embed date formatting variable documentation

Zren created this revision. Zren added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Assuming D18019 is merged, this would: - Provides

D18019: [Digital Clock] Add ability to set a custom date format string

Zren updated this revision to Diff 49137. Zren edited the summary of this revision. Zren added a comment. Translate the "Time Format Documentation" link. Add a link to QML's Text RichText docs under the "Color Format Documentation" label (translated). Place the 2 links below the text

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. The "show date" / "show seconds" toggles only affect the current widget instance as well. It would be nice if plasma had a `plasmoid.globalConfiguration.dateFormatStr` API which all widget instances (on all panels/screens) were bound to, so the user only had to

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. In D18019#388829 , @ndavis wrote: > Shouldn't the documentation explain that apostrophes need to be used or is the fact that they need to be used unusual and specific to this clock widget? The time format docs

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added a comment. In D18019#388811 , @ndavis wrote: > I'm leaning towards no, but a second link to text formatting documentation might be a good idea. Adding a second link is pretty easy, though I wrote this before I noticed your

D18019: [Digital Clock] Add ability to set a custom date format string

Zren added inline comments. INLINE COMMENTS > configAppearance.qml:145 > +'name': "custom" > } > ] Does this also need a `i18nc("custom date format", "Custom")` translation context? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D18018: [Digital Clock] Add ability to change first day of week

Zren added a comment. In D18018#387920 , @davidedmundson wrote: > Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide? https://bugs.kde.org/show_bug.cgi?id=390330#c5 > Just

D18019: [Digital Clock] Add ability to set a custom date format string

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Adds a new `dateFormatStr` config key which is used when the `dateFormat` "StringEnum" is set to `custom`. Shows a link to the Qt time

D18018: [Digital Clock] Add ability to change first day of week

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY CCBUG: 390330 The Qt enum can have Sunday value of 0 or 7, so we start the enum at -1 to represent the locale's default value.

D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

Zren added a comment. That still requires the user to drag a button, which isn't exactly obvious or a normal behaviour, just to discover what it is. It doesn't look like a desktop widget, not that the user would recognize it as one, as KDE by default does not display any desktop widgets the

D17921: Show Desktop Toolbox Icon/Svg next to checkbox in the config

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Even when a user scours the system settings + desktop config looking how to disable this button, the user will have no indication this

D15888: new icons (Breeze style)

Zren added a comment. We're currently trying to draw the C++ Breeze/forks window decorations in T9899 (and https://bugs.kde.org/show_bug.cgi?id=399757), which would make these SVGs obsolete. However we can merge these in the short term until that code is

D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app

This revision was automatically updated to reflect the committed changes. Closed by commit R118:47e4fa8e5366: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app (authored by Zren). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE

D16521: [cuttlefish] Bind StandardKey.Quit (Ctrl+Q) to exit the app

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY QML `Shortcut` requires Qt 5.5, so we bumped QtQuick to 2.5. https://doc.qt.io/qt-5.11/qml-qtquick-shortcut.html As discussed

D16516: [cuttlefish] Auto-focus on search textfield when app opens

Zren added a comment. - https://doc.qt.io/qt-5.11/qml-qtquick-shortcut.html - http://doc.qt.io/qt-5/qkeysequence.html#StandardKey-enum - http://doc.qt.io/archives/qt-4.8/qkeysequence.html#standard-shortcuts - `QKeySequence::Quit` - http://doc.qt.io/qt-5/qml-qtqml-qt.html#quit-method

D16516: [cuttlefish] Auto-focus on search textfield when app opens

Zren added a comment. In D16516#350641 , @ngraham wrote: > YES lol, that annoyed you too eh? It's been bugging me for ages. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D16516 To: Zren, ngraham Cc:

D16516: [cuttlefish] Auto-focus on search textfield when app opens

This revision was automatically updated to reflect the committed changes. Closed by commit R118:542388f984cf: [cuttlefish] Auto-focus on search textfield when app opens (authored by Zren). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16516?vs=7=8

D16516: [cuttlefish] Auto-focus on search textfield when app opens

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. TEST PLAN Manually edited `/usr/share/plasma/packages/org.kde.plasma.cuttlefish/contents/ui/Tools.qml`, then launched cuttlefish. REPOSITORY R118

[Powerdevil] [Bug 304696] Display is dimmed in half the time you configure to dim

https://bugs.kde.org/show_bug.cgi?id=304696 Chris Holland changed: What|Removed |Added CC||zrenf...@gmail.com --- Comment #14 from Chris

D16327: Update libdbusmenuqt folder

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R884:bb680e8dbfc2: Update libdbusmenuqt folder (authored by Zren). REPOSITORY R884 Active Window Control Applet for

D16394: Hide Buttons With Empty Text (Gtk Separators)

This revision was automatically updated to reflect the committed changes. Closed by commit R884:942169541d33: Hide Buttons With Empty Text (Gtk Separators) (authored by Zren). REPOSITORY R884 Active Window Control Applet for Plasma CHANGES SINCE LAST UPDATE

D16327: Update libdbusmenuqt folder

Zren added a comment. For now, I'm going to merge this so I can keep the widget in sync with the global menu widget. We can revisit linking to a shared library later on. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D16327 To: Zren

D16394: Hide Buttons With Empty Text (Gtk Separators)

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Fixes issue #146 on GitHub: https://github.com/kotelnik/plasma-applet-active-window-control/issues/146 This is the same method the

D16327: Update libdbusmenuqt folder

Zren added a comment. KNotifications provides an example of linking to `dbusmenu-qt5`: https://github.com/KDE/knotifications/blob/master/src/CMakeLists.txt#L46-L49 However REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D16327

D16327: Update libdbusmenuqt folder

Zren added a comment. Yeah, I'm not 100% sure why the Active Window Control widget needs it. I assume it should be dynamically linking to the `/usr/lib/x86_64-linux-gnu/libdbusmenu-qt.so.2`, but I wanted to update all the common code first before making major refactoring. REPOSITORY R884

D16329: Add a ReadMe with install from Git instructions and bugzilla links

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY TODO: Figure out all the build dependencies. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL

D16328: Saner config defaults

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Make sure the buttons have a dedicated place, filling the entire height of the panel rather than only 50%. We could probably limit the

D16327: Update libdbusmenuqt folder

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY I needed to add `include(ECMQtDeclareLoggingCategory)` to the root `CMakeLists.txt` to get it to compile.

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. Sorry, just merged both to master. Thanks davidedmundson for the patches that updated the ComboBox. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12040 To: Zren, #plasma, davidedmundson Cc: ngraham, cfeck, mart, davidedmundson,

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R119:347f43c42b70: Add Get Wallpaper Plugins... button to Config Desktop dialog (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5e1b650859fe: Add wallpaperplugin.knsrc + QML function to open GHNS dialog (authored by Zren). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren updated this revision to Diff 42950. Zren added a comment. - Got rid of the signal+slot that emits KNewStuff changes since wallpaperComboBox is automagically updated. - Reordered the command arguments so the variable is last in `wallpaperplugin.knsrc`. - Put the `plasmoids.knsrc`

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. Finally got around to updating this patch and formally testing with `kdesrc-build` (sort of) in Neon Unstable which has Frameworks 5.51. F6306500: screen-2018-10-05_16.35.50.mp4 Updated diff incoming as soon as I figure

D15862: option to specify icons spacing for systray

Zren added inline comments. INLINE COMMENTS > Zren wrote in main.qml:310 > Hmm. We might want to scale by DPI. While the default 0px will not be > affected by DPI, if a Look And Feel sets it to 10px, it would look different > for users with 1x DPI and 2x DPI. > > Eg: > > spacing:

D15862: option to specify icons spacing for systray

Zren added inline comments. INLINE COMMENTS > main.qml:310 > id: tasksRow > -spacing: 0 > +spacing: plasmoid.configuration.iconsSpacing > height: parent.height - (vertical && expander.visible ? > expander.height : 0) Hmm. We might want to scale by DPI. While

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. Awesome! The KPackage patch will end up in... Frameworks 5.51? And the Plasma 5.14.0 release is set to depend on Frameworks... 5.45 (according to `plasma-workspace`'s `CMakeList.txt`). So we'll need to wait for the 5.14 tag to appear (Oct 4th), but to be safe,

D14234: [Folder View] Improve file name text rendering

Zren added a comment. I tested the `x: -main.x % 1` code. Before: F6120560: 2018-07-19___13-46-20.png After: F6120562: 2018-07-19___13-47-29.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D14105: Use a broom-style icon for clearing clipboard and notification history

Zren added a comment. Should the context menu also use this icon? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13596: Fix there being more security updates than total updates in notifier

Zren added a comment. Thanks @apol for merging it. Thanks @ngraham for testing it and the link and @davidedmundson for explaining how bugfixes are merged. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13596 To: Zren, #discover_software_store, apol

D13596: Fix there being more security updates than total updates in notifier

This revision was automatically updated to reflect the committed changes. Closed by commit R134:9577e7d1d333: Fix there being more security updates than total updates in notifier (authored by Zren). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D13596: Fix there being more security updates than total updates in notifier

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY We currently read the previous `m_securityCount` instead of using the current `securityCount`. BUG:

D13508: Swap Trash for Delete action when only one is enabled and the Shift modifier is pressed

Zren added inline comments. INLINE COMMENTS > FolderView.qml:281 > pressedItem = hoveredItem; > - > +https://bugs.kde.org/show_bug.cgi?id=120008 > var pos = mapToItem(hoveredItem.actionsOverlay, mouse.x, > mouse.y); Looks like you accidently pasted this, or

D13390: Fonts KCM: Fix text readability regression

Zren added a comment. Would the `TextField.readOnly` property be useful here? http://doc.qt.io/qt-5/qml-qtquick-controls-textfield.html#readOnly-prop F5894577: 2018-06-06___19-47-34.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

Zren abandoned this revision. Zren added a comment. No prob. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13162 To: Zren Cc: hein, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY This prevents the user from accidentally dragging a `.desktop` file into their browser. BUG: 390034

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:b0fc4805e961: [QuickShare] Respect units.iconSizeHints.panel for panel icon (authored by Zren). REPOSITORY R114

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

Zren updated this revision to Diff 34138. Zren added a comment. Remove unrelated brace formatting. If there's nothing else, I'll merge it this evening. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12859?vs=34090=34138 REVISION DETAIL

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Reported on reddit:

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren updated this revision to Diff 33951. Zren added a comment. Use `connect(m_newStuffDialog.data(), ...)` to support gcc 4.8. Add license headers. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12040?vs=33024=33951 REVISION DETAIL

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. In D12040#257170 , @mart wrote: > so, if the qpointer is used in a connect, it needs to have .data() to work on gcc 4.8. > if accessed normally, it doesn't need it So I need to change

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added a comment. I use `gcc --version 5.4.0`, so I've no idea. I assume that is a QPointer feature though? We can always check the other DownloadDialog initializations: - Image Wallpapers added `m_newStuffDialog->setWindowModality(...)` 9 months ago: -

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren updated this revision to Diff 33024. Zren changed the repository for this revision from R131 Plasma Wallpapers to R120 Plasma Workspace. Zren added a comment. Remove `.data()` since it seems to work without it. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Zren added a comment. In D12041#247352 , @abetts wrote: > Why not save the room on the right of the KCM and instead blur the actual image in the list? Move the controls closer to that list item? The arrangement looks off the way it shows in the

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren added inline comments. INLINE COMMENTS > davidedmundson wrote in wallpaperplugin.cpp:26 > You don't need to do this. > > QPointer has a custom -> operator > > So m_newStuffDialog->setTitle works just fine. > > Same for in newStuffFinished I copy pasted from `image.cpp` ... which

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Zren added a comment. I'm still unsure how to update the dropdown after you download a new plugin. I've moved the "open GHNS window" function in plasma-workspace to `components/shellprivate/wallpaperplugin`, but I've just noticed the dropdown is populated by

D12040: [WIP] Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren updated this revision to Diff 32247. Zren edited the summary of this revision. Zren added a comment. Move open GHNS window function from Wallpaper.Image to ShellPrivate.WallpaperPlugin REPOSITORY R131 Plasma Wallpapers CHANGES SINCE LAST UPDATE

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Zren updated this revision to Diff 32246. Zren retitled this revision from "[WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog" to "Add "Get Wallpaper Plugins..." button to Config Desktop dialog". Zren edited the summary of this revision. Zren added a comment. Change from

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Zren updated this revision to Diff 31700. Zren added a comment. Remove commented code. Add " New " to button label. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12041?vs=31652=31700 REVISION DETAIL https://phabricator.kde.org/D12041 AFFECTED

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Zren added inline comments. INLINE COMMENTS > ngraham wrote in ConfigurationContainmentAppearance.qml:159 > It might be a bit wordy, but to be consistent with the form used everywhere > else, this should say, "Get new Wallpaper Plugins..." "Get New Wallpaper" is capitalized. Are we using

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

Zren created this revision. Zren added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Patch 2/2 (other patch is D12040 for

D12040: [WIP] Add wallpaperplugin.knsrc + QML function to open GHNS dialog

Zren created this revision. Zren added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Patch 1/2 (other patch is for plasma-desktop) BUG: #386621 -

D11970: Fix typo in the kcm_desktoptheme edit theme tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R119:85416dd8ef30: Fix typo in the kcm_desktoptheme edit theme tooltip (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11970?vs=31420=31503

  1   2   3   >