D27572: [kcm] Drop 'Enable bluetooth integration' setting

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Applet doesn't need the KDED module, it only talks with BlueZ directly. This is for stuff like bluetooth:// kio protocol and receiving files. What happens if someone have it disabled

D20871: Don't delete profiles and ports on update

drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > card.cpp:78 > +const QList profileKeys = m_profiles.keys(); > +for (const QString& profileKey : profileKeys) { > +if (!newProfiles.contains(profileKey))

D20262: [StreamRestore] Don't mess with channels

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Please also to stable branch. REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D20262 To: broulik, sitter, drosca, nicolasfella Cc: plasma-devel,

D14147: Port from GConf to GSettings

drosca added inline comments. INLINE COMMENTS > pino wrote in gsettingsitem.cpp:42 > As I said, to better not silently miss new types of keys, as logging to > terminal will not help with a GUI application. Sure, but qFatal here will take down the whole plasmashell and effectively break the

D14147: Port from GConf to GSettings

drosca added inline comments. INLINE COMMENTS > pino wrote in gsettingsitem.cpp:42 > should this be qCCritical, to hard-fail in case other types of keys are used > (instead of silently doing nothing)? qCritical is not hard-fail, that would be qFatal, but don't really see a reason to abort

D14147: Port from GConf to GSettings

drosca added inline comments. INLINE COMMENTS > gsettingsitem.cpp:58 > +GVariant *oldValue = g_settings_get_value(m_settings, > key.toLatin1().data()); > +GVariant *newValue; > + `= nullptr`, otherwise you have a crash if the following switch falls to default case. REPOSITORY R115

D19994: Add microphone indicator

drosca added a comment. Looks good. Personally I would work directly with the SourceOutputMap (and maybe duplicate it as list here in MicrophoneIndicator) instead of working with the models. I'm not saying that it's wrong / you should change it though, just a note. INLINE COMMENTS >

D15304: [KCM] Port to QQC2

drosca accepted this revision. drosca added a comment. Looks good now! REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D15304 REVISION DETAIL https://phabricator.kde.org/D15304 To: ngraham, #plasma, drosca Cc: apol, huftis, nicolasfella, davidedmundson, plasma-devel,

D15304: [KCM] Port to QQC2

drosca accepted this revision. drosca added a comment. I don't really like that this port became full of workarounds to be honest, but if it works and there's no other way then fine. REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D15304 REVISION DETAIL

D17784: Don't ignore default virtual devices

This revision was automatically updated to reflect the committed changes. Closed by commit R115:5dc7cca58a72: Dont ignore default virtual devices (authored by sharhalakis, committed by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D15304: [WIP] [KCM] Port to QQC2

drosca added a comment. In D15304#398048 , @ngraham wrote: > Thanks for the approval, but the scrollviews still don't actually scroll when the window is too small to fit all the content! I haven't been able to figure out why this is yet, so

D15304: [WIP] [KCM] Port to QQC2

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Advanced.qml:32 > > +Layout.fillWidth: true > +Layout.fillHeight: true This should be set where this item is used (main.qml). > Advanced.qml:40 >

D17784: Don't ignore default virtual devices

drosca added a comment. In D17784#396418 , @sharhalakis wrote: > Thanks for the review. Can you submit it for me? My KDE developer account is disabled, probably because of years of inactivity. I'll need your full name + email then.

D18276: Fix KDE Connect volume control

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Related patch to plasma-pa D16443 REPOSITORY R994 Pulseaudio Qt Bindings BRANCH noglibcheck REVISION DETAIL https://phabricator.kde.org/D18276

D18276: Fix KDE Connect volume control

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. I think it would be better to edit the check only to `contains("Glib")` as it still makes sense to check for GLib event loop, as otherwise the code will just silently fail.

D16082: Notify headphone being plugged in on some hardware

drosca added a comment. In D16082#359173 , @ngraham wrote: > Maybe we could use a generic icon, or make a new one that depicts speakers plus headphones or something? It can be any device really, not just speakers/headphones, as long as

D16082: Notify headphone being plugged in on some hardware

drosca added a comment. In D16082#356111 , @thsurrel wrote: > So now the question is whether it is acceptable to show a headphone on the OSD when we could have been plugging something else in the jack. It will already show in device list

D16082: Notify headphone being plugged in on some hardware

drosca added a comment. In D16082#356099 , @thsurrel wrote: > So, it seems that pulseaudio can not tell the difference what we are plugging in the jack connector on a laptop, but I guess it must be the same behavior with computers that get a

D15827: [applet] Avoid showing a generic audio-card icon

drosca added a comment. I don't really think it looks better, now you have those icons duplicated (big one being for the "device" and small one in volume slider). I think it would be much better to have new icon for "speakers" and "microphone" devices instead of using "output-volume" and

D15304: [KCM] Port (almost) entirely to QQC2

drosca added a comment. In D15304#332755 , @ngraham wrote: > > Plasma items should not be used in KCM. > > Hmm, what you you recommend then for showing an icon item? The old `QIconItem` breaks for fractional scale factors. Kirigami has a

D15304: [KCM] Port (almost) entirely to QQC2

drosca added inline comments. INLINE COMMENTS > CardListItem.qml:33 > RowLayout { > -QIconItem { > +PlasmaCore.IconItem { > id: clientIcon Plasma items should not be used in KCM. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D15304: [KCM] Port (almost) entirely to QQC2

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. There is `ScrollView` in QQC2 (since Qt 5.9), so please use it. Also as @davidedmundson said, please edit the commit message. REPOSITORY R115 Plasma Audio Volume Applet

D15304: [KCM] Port label-bearing controls to QQC2 to fix fractional scaling support

drosca added a comment. I'd prefer to port it completely to QQC2. As it is now, in some files you just changed Labels with QQC2 import and in others you changed QQC1->QQC2 import while there are also other QQC items. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D14147: Port from GConf to GSettings

drosca added inline comments. INLINE COMMENTS > CMakeLists.txt:46 > + > +if(USE_GCONF AND USE_GSETTINGS) > +message(FATAL_ERROR "USE_GCONF and USE_GSETTINGS cannot be used at the > same time") This should probably use cache variables: set(USE_GCONF FALSE CACHE STRING "Build with GConf")

D14147: Port from GConf to GSettings

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:54 > +set(USE_GCONF FALSE) > +endif() > Those two options (gconf, gsettings) should be mutually exclusive. > Advanced.qml:76 >

D14147: Port from GConf to GSettings

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. It still needs to keep GConf code for systems without gsettings pulseaudio module (eg. pulseaudio < 12.0). Also make the Qt keywords changes in separate commit or include

D13931: [KCM] Add speaker placement test

drosca added inline comments. INLINE COMMENTS > nicolasfella wrote in Advanced.qml:117 > When I remove this line and switch profile e.g. from Stereo to 5.1 the UI > doesn't get updated. I'm no QML expert but it looks like a change to > sinkmodel does not result in reevaluation of data(). I'm

D13734: Make GConf optional dependency

drosca added a comment. Sorry, bad merge. Should be ok now. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13734 To: drosca, #plasma, davidedmundson Cc: rikmills, plasma-devel, asturmlechner, apol, matthiasdahl, ragreen, Pitel, ZrenBot,

D13931: [KCM] Add speaker placement test

drosca added inline comments. INLINE COMMENTS > canberracontext.cpp:27 > > -class Sink : public Device > +CanberraContext * CanberraContext::s_context = nullptr; > + `*` > canberracontext.cpp:29 > + > +CanberraContext * CanberraContext::instance() > { `*` > canberracontext.cpp:51 > >

D13734: Make GConf optional dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R115:c9fae1fb3f8e: Make GConf optional dependency (authored by drosca). Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R115 Plasma

D14056: Remove FileItemActionPlugin in favor of Purpose plugin

drosca added a comment. Is it still available in Dolphin? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D14056 To: nicolasfella, broulik, drosca Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13931: [KCM] Add speaker placement test

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Looks much better now. INLINE COMMENTS > canberracontext.h:44 > private: > -ca_context *m_context = nullptr; > +ca_context *m_canberra; > +int m_references;

D13931: [KCM] Add speaker placement test

drosca added a comment. In D13931#290544 , @nicolasfella wrote: > I can get the PulseObject, that is not the problem, the problem is that I can't access the model outside of a delegate. model[index] does not work because QAbstractItemModel

D13931: [KCM] Add speaker placement test

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. And the whole ComboBox/SinkModel code needs to be changed. You should be able to get the PulseObject from the model just with QML code (see invokables in

D13931: [KCM] Add speaker placement test

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Advanced.qml:112 > + > +delegate: > + So this will show this grid as many times as you have sinks below each other and scrollable in ListView

D13694: Fix wrong availability of profiles and ports.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R115:ba737f478208: Fix wrong availability of profiles and ports. (authored by akrutzler, committed by drosca). REPOSITORY

D13770: Only show available ports in port selection

drosca added a comment. I don't think hiding it makes sense, indicating that it is unavailable/unplugged as pavucontrol does is enough. User should see that pulse knows about those ports, but they are just not plugged so if user choose them, it won't play audio. REPOSITORY R115 Plasma

D13568: SinkModel: Ignore virtual sinks for preferredSink

This revision was automatically updated to reflect the committed changes. Closed by commit R115:974bd408f719: SinkModel: Ignore virtual sinks for preferredSink (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D13694: Fix wrong availability of profiles and ports.

drosca added a comment. In D13694#282499 , @nicolasfella wrote: > This breaks the profile selection Combobox in the KCM. How does this break that combobox? The current code is obviously wrong. REPOSITORY R115 Plasma Audio Volume

D13568: SinkModel: Ignore virtual sinks for preferredSink

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY Preferred sink is used for volume control with media keys, so it

D4140: Rework playing of volume feedback

drosca added a comment. In D4140#259101 , @apol wrote: > Could we maybe accept this? Not as is, because after D9755 this would need duplicated `SinkModel` (or revert D9755

D7724: [ListItemBase] Open options menu on right click

drosca added a comment. In D7724#253041 , @broulik wrote: > Should we go for it or abandon this? If it gets +1 from VDG. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7724 To: broulik,

D12356: Move volume constants into functions

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Yeah, sorry, it would actually build, but it wouldn't do what you wanted. REPOSITORY R994 Pulseaudio Qt Bindings BRANCH nopulseheader REVISION DETAIL

D12356: Move volume constants into functions

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Yes, that's what I had in mind. But please make it build (`MinimalVolume` in header vs `minimalVolume` in source). Also I think we should use "minimum" instead of "minimal",

D12083: Show OSD when default output changes

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ListItemBase.qml:284 > menuItem.clicked.connect(function() { > +paSinkModel.pendingPreferredSinkChange = true; >

D11807: AbstractModel: Check if index is valid in setData

This revision was automatically updated to reflect the committed changes. Closed by commit R115:0284a425f3db: AbstractModel: Check if index is valid in setData (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D11807: AbstractModel: Check if index is valid in setData

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY It would crash in MapBase::objectAt if the index is not valid

D11721: Fix issues in models to pass ModelTest

This revision was automatically updated to reflect the committed changes. Closed by commit R115:d498ec301bb3: Fix issues in models to pass ModelTest (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11721?vs=30639=30640

D11721: Fix issues in models to pass ModelTest

drosca updated this revision to Diff 30639. drosca added a comment. fix issues REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11721?vs=30638=30639 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11721 AFFECTED FILES

D11721: Fix issues in models to pass ModelTest

drosca added inline comments. INLINE COMMENTS > broulik wrote in maps.h:116 > This creates a temporary list just to iterate it, better use iterators and > then `key()` provided by it (I bet there's even a fancy `std` algorithm for > what you're trying to do here) Some fancy `std` algorithm

D11721: Fix issues in models to pass ModelTest

drosca updated this revision to Diff 30638. drosca added a comment. whitespace REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11721?vs=30637=30638 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11721 AFFECTED FILES

D11721: Fix issues in models to pass ModelTest

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. TEST PLAN Did all sort of things with pulseaudio and all ModelTest tests passed.

D11613: call beginRemoveRows before removing the data

drosca added a comment. Into Plasma/5.12 please. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D11613 To: davidedmundson, #plasma, drosca Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D11670: [cursors] Add arrow cursor symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit R31:3e4620e09ded: [cursors] Add arrow cursor symlinks (authored by drosca). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11670?vs=30469=30482 REVISION DETAIL

D11670: [cursors] Add arrow cursor symlinks

drosca created this revision. drosca added reviewers: Breeze, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY Add arrow -> left_ptr symlinks. Same symlink can

Re: PulseAudio switch-on-connect and device-manager modules

On Wed, Mar 21, 2018 at 4:51 PM, Nate Graham wrote: > Howdy folks, > > It seems that we have KCMs that conflict with one another: > - The Phonon Audio/Video KCM uses the module-device-manager PulseAudio Module. > - plasma-pa's KCM has an "Automatically switch all running streams

D11166: Simplify display when there's only a single input device and a single output device

drosca added a comment. In D11166#224814 , @ngraham wrote: > Can you help me understand why this might be unwanted in that circumstance? You'd still have only one input and one output, no? In case where both cards support both

D11166: Simplify display when there's only a single input device and a single output device

drosca added a comment. There is still one case where this may not be wanted: when you have two cards and first have only sink and second source. Also this doesn't apply to Applications tab, why? INLINE COMMENTS > DeviceListItem.qml:39 > +} > +labelOpacity: onlyOne ? 1 : 0.6 >

D11082: [WIP] Display all StreamRestore entries in it's own config Tab

drosca added a comment. You forgot to add StreamRestoreTab.qml to review. > I duplicated BaseMap in map.h to use a QString key focused on the info.name property. Code duplication sucks. :/ Can't you just qHash() the name and use it as integer index for normal MapBase? > Every

D10901: Add "move to device" functionality to hamburger menu

This revision was automatically updated to reflect the committed changes. Closed by commit R115:359ec78cb6ff: Add move to device functionality to hamburger menu (authored by Fuchs, committed by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10901?vs=28221=28260#toc REPOSITORY

D10901: Add "move to device" functionality to hamburger menu

drosca accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D10901 To: Fuchs, broulik, drosca Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10901: Add "move to device" functionality to hamburger menu

drosca added a comment. @ngraham This is not a new feature, only people didn't know about the drag functionality, which is understandable, but nevertheless the functionality is there for a long time already (since around Plasma 5.7/5.8). REVISION DETAIL https://phabricator.kde.org/D10901

D10901: Add "move to device" functionality to hamburger menu

drosca added inline comments. INLINE COMMENTS > ListItemBase.qml:340 > +var menuItem = newMenuItem(); > +if(type == "sink-input") { > +menuItem.text = i18nc("Heading for a list of possible > output devices (speakers, headphones, ...) to

D10901: Add "move to device" functionality to hamburger menu

drosca added a comment. +1. No more code comments. Just a note, we can't guarantee that audio is actually playing from that stream. INLINE COMMENTS > drosca wrote in ListItemBase.qml:338 > `sinkView.model.count > 1` -> `sinkView.count` Sorry about this comment, it's nonsense. It was

D10901: Add "move to device" functionality to hamburger menu

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. I'm not sure on the wording "Output on" "Record from", I would prefer simple "Move to" or "Move to device", but I am not native speaker so I leave others to decide. Can you

D10426: Applet: Fix accessing SourceModel from main item

This revision was automatically updated to reflect the committed changes. Closed by commit R115:fb789820c69e: Applet: Fix accessing SourceModel from main item (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D10426: Applet: Fix accessing SourceModel from main item

drosca updated this revision to Diff 26876. drosca added a comment. Rename to paSourceModel + paSinkModel REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10426?vs=26875=26876 BRANCH Plasma/5.12 REVISION DETAIL

D10426: Applet: Fix accessing SourceModel from main item

drosca created this revision. drosca added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY BUG: 390161 FIXED-IN: 5.12.1 TEST PLAN Pressed micmute

D10148: KCM: Show only available device profiles

drosca added a comment. @ngraham It needs "better" filtering as suggested in the bugreport. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D10148 To: drosca, #plasma, nicolasfella Cc: ngraham, nicolasfella, broulik, plasma-devel, ZrenBot,

D10148: KCM: Show only available device profiles

This revision was automatically updated to reflect the committed changes. Closed by commit R115:1e644e5723df: KCM: Show only available device profiles (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10148?vs=26480=26865

D10397: Use Qt.openUrlExternally instead of Kio

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D10397 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10396: Support "phone" form factor

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D10396 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10395: Use plasmoid.icon instead of Logic.icon()

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D10395 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10148: KCM: Show only available device profiles

drosca updated this revision to Diff 26480. drosca added a comment. Fixed issues REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10148?vs=26080=26480 BRANCH arcpatch-D10148 REVISION DETAIL https://phabricator.kde.org/D10148

D10252: Applet: Use new device icons

This revision was automatically updated to reflect the committed changes. Closed by commit R115:9d354da68994: Applet: Use new device icons (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10252?vs=26382=26479 REVISION

D10280: Fix output device context menu

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH fix REVISION DETAIL https://phabricator.kde.org/D10280 To: nicolasfella, broulik, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10252: Applet: Use new device icons

drosca created this revision. drosca added reviewers: Plasma, andreask. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY They were now added to Breeze icon theme REPOSITORY R115

D9671: Show only available profiles in Pulseaudio KCM

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R115:206a00f95858: Move availability property from Port to Profile (authored by nicolasfella, committed by drosca).

D10148: KCM: Show only available device profiles

drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY ^ CCBUG: 365723 TEST PLAN Unavailable profiles are now filtered

D10098: Fix drag cursor

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D10098 To: broulik, #plasma, drosca, #vdg Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10093: Fix moving streams by drag and drop

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D10093 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9671: Show only available profiles in Pulseaudio KCM

drosca added a comment. I'd like to have this in, do you think you could finish it? If not, I will take over. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9671 To: nicolasfella, #plasma, drosca Cc: plasma-devel, #plasma, ZrenBot, progwolff,

D4140: Rework playing of volume feedback

drosca added a comment. In https://phabricator.kde.org/D4140#188956, @Zren wrote: > Is the `onVolumeChange` call delayed? I'm not sure if it's fired when we set it, or PulseAudio gets back to us. > > Does this fire `onVolumeChange` immediately? > >

D9575: Only send low peripheral battery notification when in discharging state

This revision was automatically updated to reflect the committed changes. Closed by commit R122:fad8ac422a07: Only send low peripheral battery notification when in discharging state (authored by drosca). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D6388: Don't use plasma theme icons for stream/device icons

drosca added a comment. Ping? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D6388 To: broulik, #plasma, drosca, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9755: Move contents into fullRepresentation

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9755 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D6387: Also try application.name to get iconName

drosca added a comment. Ping? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D6387 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9755: Move contents into fullRepresentation

drosca added a comment. Actually I have a patch https://phabricator.kde.org/D4140 that depends on all models being initialized immediately. But yeah, given the fact that I haven't landed it yet and there are no bug reports about incorrect volume notifications I guess this can go in.

D9726: Change device "master volume" to be the max of all channels instead of the avg

drosca added a comment. Do you have dev account? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9726 To: Zren, #plasma, drosca Cc: drosca, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9726: Change device "master volume" to be the max of all channels instead of the avg

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. Alright, thanks for the writeup. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9726 To: Zren, #plasma, drosca Cc: drosca, plasma-devel,

D9726: Change device "master volume" to be the max of all channels instead of the avg

drosca added a comment. Well, this was actually intended to work like that. In case of split channels, I would say "avg" describes the merged volume better than "max", because with "max" you can have situation where one channel is 0%, second is 100% and merged volume now shows 100% which is

D9671: Show only available profiles in Pulseaudio KCM

drosca requested changes to this revision. drosca added a comment. I'm ok with the part of the patch that moves availability property from Port to Profile. Adding availableProfiles is not a good way to achieve what you want though. Profiles should be filtered on QML side. REPOSITORY R115

D9364: [Bluetooth applet] Allow copying device details to clipboard

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D9364 To: broulik, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9079: bluedevil-sendfile: Set option descriptions for command line help

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D9079 To: marten, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8909: Fix uninitialized warning on valgrind

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D8909 To: apol, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8909: Fix uninitialized warning on valgrind

drosca requested changes to this revision. drosca added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > stream.cpp:28 > : VolumeObject(parent) > +, m_deviceIndex(std::numeric_limits::max()) > , m_clientIndex(PA_INVALID_INDEX) Should be

D8054: Show headset icons for devices identifying as "Headset" in Description

This revision was automatically updated to reflect the committed changes. Closed by commit R115:6940b08074fd: Show headset icons for devices identifying as Headset in Description (authored by antlarr, committed by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D8054: Show headset icons for devices identifying as "Headset" in Description

drosca accepted this revision. drosca added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > DeviceListItem.qml:29 > icon: { > if (currentPort) { > +switch(FormFactor) { This check is no longer needed. REPOSITORY R115 Plasma Audio

D8054: Show headset icons for devices identifying as "Headset" in Description

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. Perfect solution! But why is it in Profile when it is device property? Just remove it from Profile and leave it only in Device. INLINE COMMENTS > DeviceListItem.qml:30 >

D8054: Show headset icons for devices identifying as "Headset" in Description

drosca added a comment. `pactl list sinks` `pactl list sources` If pulseaudio even differentiates between headset and headphones. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D8054 To: antlarr, #plasma, davidedmundson, drosca Cc: drosca,

  1   2   3   4   5   6   7   8   9   10   >