D27684: [applets/taskmanager] Show PA-related features even when audio indicators are disabled

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Good stuff. REPOSITORY R119 Plasma Desktop BRANCH show-mute-feature-even-when-audio-indicators-are-disabled (branched from master) REVISION DETAIL https://phabricator.kde.org/D27684

D27182: [applets/taskmanager] Clean up Tooltip code

hein added a comment. trmdi's point is good, otherwise I like it. REPOSITORY R119 Plasma Desktop BRANCH clean-up-tooltip-code (branched from master) REVISION DETAIL https://phabricator.kde.org/D27182 To: ngraham, #plasma, #vdg, ndavis Cc: hein, trmdi, broulik, plasma-devel, Orage,

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks :) REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26582 REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel,

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

hein added a comment. So does this fall through to the dialog when the type hasn't been determined? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26582 To: meven, #plasma, broulik, aleksejshilin, hein Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D25428: Improved support for desktop "Folder View"

hein added a comment. Just a quick note I will review this tomorrow or next week when I'm on vacation, sorry for the long wait. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham, mart Cc: mart, ngraham, nicolasfella,

D26580: Kicker/RecentDocuments display place's icon when resource matches one

hein added a comment. This patch is fine and in line with the existing implementation, but it occurs to me we probably should make the RecentUsageModel use FileEntry and put it centrally there at some point. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D26386: Kicker/RecentDocuments: add icons to actions

hein accepted this revision. hein added a comment. Good stuff! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26386 To: meven, #plasma, ngraham, hein Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26378: [Download Plugin] Register downloaded files as recent documents

hein accepted this revision. hein added a comment. I love it. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D26378 To: broulik, #plasma, hein, #vdg, fvogt, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26385: Kicker/RecentDocuments Avoid referring to hidden places

hein added a comment. Thanks! We can revisit it after some more discussion. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26385 To: meven, #plasma, ngraham, hein Cc: hein, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26385: Kicker/RecentDocuments Avoid referring to hidden places

hein added a comment. I don't agree with this patch. Hiding a place or section from the Places panel doesn't mean the user didn't add it and it's not to be used. We don't hide it from Folder View's config or relative title generator either. Hidden is not removed. Please revert. REPOSITORY

D26386: Kicker/RecentDocuments: add icons to actions

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. It should be `iconName` after `label`. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26386 To: meven, #plasma, ngraham, hein Cc: hein,

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

hein added a comment. It's definitely a discussion I'd enjoy more :) REPOSITORY R119 Plasma Desktop BRANCH some-apps-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D25773 To: ngraham, #plasma, broulik, #vdg, hein, filipf, ndavis Cc: filipf,

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

hein accepted this revision. hein added a comment. Ah sorry, I had a reply typed into the text field but must have botched hitting Submit. Personally, I'm not a fan - I think there's a bad trend of us overstuffing the default panel now like we're looking out of "what more can we add

D25762: Only serialize window pixmap if we're using it

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nice :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25762 To: broulik, #plasma, hein Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26147: Kickoff computer tab : don't display filepath for places in description

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. The `return QString()` shouldn't be necessary if we just fall through to the final return. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26147

D25874: [Task Manager] Consider parent PID for audio stream

hein added a comment. Just as a sanity check: libtm knows the pid for a window. Have you checked if there might be a faster way of doing this by checking if the stream pid is among its children? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25874 To:

D25762: Don't bother serializing window icon pixmap for known services

hein added a comment. Ah right, I didn't look at the code context and forgot we don't just load the custom pixmap in the same function body but also in Private::icon. But we also do this there: `usingFallbackIcon.insert(window)` That means you can limit serializing to cases where

D25762: Don't bother serializing window icon pixmap for known services

hein added a comment. If the concern is that QIcon::name isn't good enough but we actually have an icon inside, why don't we just change the check to QIcon::isNull? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25762 To: broulik, #plasma, hein Cc:

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

hein added a comment. Let's go for it, it's fairly in line with the TM applet refectoring we planned in Valencia at the end of the day REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2, #plasma, #vdg, hein, ngraham Cc: ngraham, hein, #vdg,

D23039: Make Kickoff restore favorites order when dragging an item to desktop

hein accepted this revision. hein added a comment. Good one, thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23039 To: lisin, #plasma, ngraham, hein Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25773: [Applets/Task Manager] Add pinned filemanager and browser apps by default

hein added a comment. I don't really understand why the panel being bare by default is a problem. Isn't it nicer when users don't have to opt out of clutter like this? REPOSITORY R119 Plasma Desktop BRANCH some-apps-by-default (branched from master) REVISION DETAIL

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:c0acd1434147: [libtaskmanager] Track stacking order and window activation (on X11) (authored by hein). REPOSITORY

D25055: [containments/desktop] Delete the "Tweaks" page and its options

hein added a comment. If we want to keep the handles-on-hover outside of Edit Mode, is there a reason it can't be always on and needs to be gated behind a checkbox? I have to admit though I have a hard time seeing users like/rely on this behavior. Hovering and just waiting, even once

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. Approach is fine, but please move the MouseArea into the audioStreamIconLoader's source component so it's not always instantiated even when it's not needed. :) REPOSITORY R119

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

hein added a comment. Ping @gpark, are you available to resume work on this too? There's a growing amount of interest which means more dev hands to aid the effort. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14796 To: gpark, hein Cc: davideichelsdoerfer,

D24454: Include an emoji picker

hein added a comment. If I understand right, the emoji workflow this implements is via copy-paste, it can't directly insert into the text fields via the IME bus. Do you have a plan for that? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24454 To: apol,

D24503: Integrate the normal keyboard layout switcher

hein added a comment. It's a small part of the work Geon Park did in his GSoC project to refactor kimpanel and our input sources management in general, but in a more merge-friendly format. The former sadly never got any review attention because the patch was too big, so maybe this is

D23728: [kicker/kickoff] Use icon from appstream handler

hein added a comment. Thanks! REPOSITORY R119 Plasma Desktop BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D23728 To: nicolasfella, hein Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D23640: [kicker/kickoff] Add icon to hide application action

hein added a comment. Would it be better to add a new icon name to the theme instead of starting to use semantically dubious icons? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23640 To: nicolasfella, #plasma, hein, ngraham Cc: plasma-devel, LeGast00n,

D23623: [kicker/kickoff] Use discover icon for manage application action

hein reopened this revision. hein added a comment. This revision is now accepted and ready to land. Distros can change the package manager to be run, so hard-coding the icon is wrong. It should be looked up from the configured application. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D23652: [Kicker/Kickoff] Re-word "Manage ..." menu item for greater clarity

hein added a comment. It was originally "Uninstall", then got renamed into "Manage" when the implementation changed to run the package manager (changable by the ISV) which can do different actions too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23652

D23677: [Folder View] Load icon only for isPopup case

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. Hmm, I'm not a fan. That only the isPopup case ends up showing the icon in the shell is something you and I know from the outside, but I don't think a widget should be making that

D23356: Add ksysguard plugin for taskmanager integration

hein added a comment. Do you really need a TasksModel, or is a WindowTasksModel enough? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D23356 To: davidedmundson, #plasma Cc: hein, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

hein added a comment. Code's fine, but let's discuss the change briefly - disabling grouping in ITM gets you a bunch of identical-looking icons you can't tell apart. I think that's a pretty ugly user experience, does it make sense to have an option to configure the applet into an invariably

D23241: Show application window icon on AboutPage

hein added a comment. I was looking into this recently and added the component named getter, which does the trick for me and is much nicer to use than setting the program logo. So in some sense this is not strictly necessary, and also it would really be better if the window icon first part

D22960: Add handle icons

This revision was automatically updated to reflect the committed changes. Closed by commit R169:29dffaf4cd72: Add handle icons (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22960?vs=63155=63327 REVISION DETAIL

D22866: [Kickoff] Always select previous category in Applications View when navigating backwards

hein accepted this revision. hein added a comment. Good idea! REPOSITORY R119 Plasma Desktop BRANCH kickoff-appview-remember-previous-category (branched from master) REVISION DETAIL https://phabricator.kde.org/D22866 To: akozlovskiy, #plasma, ngraham, hein Cc: plasma-devel,

D22988: Fix incorrect Kickoff tab bar layout for vertical panels

hein added a comment. ... I'm not the author or maintainer of this code, but I had a look anyway :). @lisin, I agree with you that the sizing bug should be fixed in TabBar instead, in plasma-frameworks.git. It's very unorthodox to call a property change handler as a function, and it's

D22960: Add handle icons

hein created this revision. hein added reviewers: Frameworks, apol, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22960 AFFECTED

D22955: Add icon used by Kirigami.AboutPage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c17c048ec2f7: Add icon used by Kirigami.AboutPage (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22955?vs=63146=63152 REVISION DETAIL

D22955: Add icon used by Kirigami.AboutPage

hein created this revision. hein added reviewers: Frameworks, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22955 AFFECTED FILES

D22901: Make alphabetic categorization of the "All Applications" section optional

This revision was automatically updated to reflect the committed changes. Closed by commit R119:258545f996cf: Make alphabetic categorization of the All Applications section optional (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22901: Make alphabetic categorization of the "All Applications" section optional

hein created this revision. hein added reviewers: Plasma, davidedmundson, tcanabrava. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Introduces a new prop and turns it off by default. Also rewrites the initial "all applications" data gathering

D22762: Take in consideration flat() for the All Applications menu

hein added a comment. It's worth noting that this patch as-is also breaks the Dashboard UI ("All Applications" no longer shows content), so this revert wasn't just about implementation details but also actively broke upstream. I'm writing an alternative patch now. REPOSITORY R119

D22868: Revamp Kirigami.AboutPage

hein added a comment. I'll remove that part of the patch later tonight and talk Marco into fixing it differently. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella Cc: nicolasfella,

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a99c14d1eac9: Consistently use Units.toolTipDelay instead of hardcoded values (authored by hein). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D22868: Revamp Kirigami.AboutPage

hein updated this revision to Diff 62883. hein added a comment. Don't hit Kirigami.Label (deprecated) REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22868?vs=62880=62883 BRANCH aboutpage REVISION DETAIL https://phabricator.kde.org/D22868 AFFECTED

D22868: Revamp Kirigami.AboutPage

hein added a comment. Discover: F7130049: Screenshot_20190801_100601.png Material style: F7130053: Screenshot_20190801_100645.png REPOSITORY R169 Kirigami REVISION DETAIL

D22868: Revamp Kirigami.AboutPage

hein added a comment. Before: F7130036: Screenshot_20190801_15.png After: F7130037: Screenshot_20190801_100033.png REPOSITORY R169 Kirigami REVISION DETAIL

D22868: Revamp Kirigami.AboutPage

hein created this revision. hein added reviewers: Frameworks, VDG, mart, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY - Use a FormLayout to work nicely in both portrait and landscape orientations -

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

hein created this revision. hein added reviewers: Frameworks, mart. Herald added a project: Kirigami. hein requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22867 AFFECTED FILES

D22762: Take in consideration flat() for the All Applications menu

hein added a comment. You got a point, but there's a higher-level thing with the Kicker backend in terms of where it came from and where it's going: - Originally it was created specifically for the Kicker menu with the backend custom-designed to that UI. AppsModel is fairly generic

D22762: Take in consideration flat() for the All Applications menu

hein added a comment. FYI, as maintainer of Kicker, I've reverted this commit in master until this review request is updated with additional info on what it's useful for. Please don't move patches through in <15 minutes without people having a chance to weigh in. REPOSITORY R119 Plasma

D18860: Add comment / description to the translations kcm

hein added a comment. Good stuff  REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham, bshah Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D22738: Remove some uses on QDesktopWidget

hein added inline comments. INLINE COMMENTS > pagermodel.cpp:123 > +}; > +for (QScreen* screen : qGuiApp->screens()) > +configureScreen(screen); Missing braces around single-line block and no const REPOSITORY R119 Plasma Desktop REVISION DETAIL

D22535: Make kimpanel a system tray applet

hein added a subscriber: gpark. hein added a comment. To catch this up to the GSoC status: https://medium.com/@mujjingun_23509/google-summer-of-code-porting-keyboard-kcm-to-qt-quick-part-2-30c115771722

D22535: Make kimpanel a system tray applet

hein added subscribers: mart, hein. hein added a comment. The configuration should be in System Settings, not in this applet, as they're system-global and override keyboard layout settings. The 2018 GSoC work started to implement this and got far, and also made kimpanel replace the

D22306: Do not skip code launching application in application dashboard

hein added a comment. Thanks, this looks a lot better and cleaner. Minor nitpick to clean up. INLINE COMMENTS > ItemGridView.qml:440 > +itemGrid.itemActivated(pressedItem.itemIndex, "", null); > +} else if (!dragHelper.dragging && !pressedItem && >

D12916: Panel should not stop auto-hiding if a window wants attention

hein added a comment. In D12916#500367 , @davidedmundson wrote: > "does the task manager need attention simply because some different window needs attention"? There's an easy answer: We have a lot of users who rely on that. A lot

D21829: Improved Touch support for Kickoff

hein added a comment. In D21829#498921 , @steffenh wrote: > I have the last days looking at plasma-frameworks, but my knowledge of the working of plasma is close to zero, so I am afraid I'm not able to do this. Before we discuss

D12916: Panel should not stop auto-hiding if a window wants attention

hein added a comment. If that's how it worked in KDE 4 I think it could well qualify as a regression. Regardless of that, my personal take would be that the user entering and exiting the panel constitutes having explicitly acknowledged "needs attention" status and then ignoring it

D12916: Panel should not stop auto-hiding if a window wants attention

hein added a comment. I wonder if there's another fix we could attempt: Rather than permanently staying visible, would having to move your mouse over the panel and exiting again to hide it again work? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12916

D12916: Panel should not stop auto-hiding if a window wants attention

hein added a comment. I don't like this. - I think it's option creep - The user would have to configure this for each of their Task Manager applets to make it pervasive (consider multiple monitors with multiple Task Managers) - It won't address other applets that may use the same

D22306: Do not skip code launching application in application dashboard

hein added a comment. First of, run `kdebugsettings` and make sure that debug output isn't disabled on your system. Then you can e.g. stop plasmashell from a terminal with: `kquitapp5 plasmashell` And restart it with `plasmashell`, and you'll see `console.log` output on the

D18860: Add comment / description to the translations kcm

hein added a comment. How about - and sorry if you're tired of the patch by now - "Change workspace and application languages"? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: bshah, sitter, apol,

D22506: Read BAMF_DESKTOP_FILE_HINT from environment

hein added a comment. The idea and approach are good. But disk I/O in a UI hotpath is pretty scary. I do think a cache would be a good addition. In general I think libtm could use some improvements on its currently very coarse cache eviction scheme. It's mostly fine but there are

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

hein added a comment. Sorry, the cryptic comment can be safely ignored. I had a concern at first, then looked into it, decided I'm OK with the patch and forgot the started sentence. :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22503 To: jbbgameich,

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. This creayes REPOSITORY R120 Plasma Workspace BRANCH translations-no-systemsettings (branched from master) REVISION DETAIL https://phabricator.kde.org/D22503 To: jbbgameich, hein Cc:

D22306: Do not skip code launching application in application dashboard

hein added a comment. I see what this is trying to do, but some of the details seem a bit wrong. E.g. you're only setting `dragging` to false in a code branch that's only executed when it already is false, which means it's not going to be set to false on a drag release, and pressX/Y

D18860: Add comment / description to the translations kcm

hein added a comment. Agreed with Harald, the wording's misleading sorry :) REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

Re: how about a developer KCM

On 7/16/19 11:36 PM, Nate Graham wrote: On 7/16/19 8:32 AM, David Edmundson wrote: However, I fear it will end up becoming some sort of hidden plasma-tweaks, where we dump general aesthetic/behaviour settings in here which we think are too niche for the main UI. I don't want that to happen.

D22230: [TaskManager] Follow KDE title & subtitle style

hein added a comment. @filipf: Yep, sounds sensible :) REPOSITORY R119 Plasma Desktop BRANCH tooltip-media-titlesubtitle-style (branched from master) REVISION DETAIL https://phabricator.kde.org/D22230 To: filipf, #plasma, #vdg, ngraham, hein Cc: plasma-devel, LeGast00n, jraleigh,

D22162: taskmanager: performance

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. In D22162#488378 , @ngraham wrote: > Not sure if it's related, but while you're at it, would you be able to also fix these errors when hovering

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY `TaskGroupingProxyModel::requestToggleMaximized` now uses this to minimize and restore groups of windows

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

hein added a comment. You can do it for Dash, though -- check that `isDash` check where it already adds some runners to the Dash it doesn't add to App Menu. I'm fine with doing it for Kicker later, but we need to resolve the design issue first so we don't create a new bug. REPOSITORY

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

hein added a comment. Let's only do it for Kickoff and the Dash? The Kicker UI is really not made for arbitrary runners. REPOSITORY R119 Plasma Desktop BRANCH add-more-runners (branched from Plasma/5.16) REVISION DETAIL https://phabricator.kde.org/D21983 To: ngraham, #vdg, #plasma,

D22004: Increment iterator before any potential continue

hein added a comment. I'm not super happy with hardcoding directory separators and schemas, judicious use of `QUrl::fromLocalFile` or `QUrl::fromUserInput` would probably be better to norm behavior. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22004 To:

D21990: Don't propagate a title change if it didn't actually change

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Ironically quite similar to a DDoS vector on the Task Manager. Apps suck :) REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D21990 To: broulik,

D21988: Reject duplicate events with identical coordinates

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0628dab8f42b: Reject duplicate events with identical coordinates (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21988?vs=60316=60319

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

hein added a comment. In D21978#483972 , @hein wrote: > That's wrong, sorry - I'm uploading a different patch that fixes the underlying cause. D21988 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D21988: Reject duplicate events with identical coordinates

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY BUG:401861 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D21978: RFC: Fix search not returning results in Kickoff when cursor is below tabbar

hein added a comment. That's wrong, sorry - I'm uploading a different patch that fixes the underlying cause. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21978 To: filipf, hein, #plasma, ngraham Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D21829: Improved Touch support for Kickoff

hein added a subscriber: mart. hein added a comment. I'm in principle quite OK with this minus that other patch I need to be written first to move DragHelper out into the lib (see other comment). Pitch: If you do that, it'll make it much easier to make the other menus (and other things) act

D21954: Handle Gimp 2.10

hein added a comment. In D21954#483133 , @ngraham wrote: > Could this go to the stable branch? Aye, backported. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21954 To: hein, ngraham Cc: ngraham,

D21954: Handle Gimp 2.10

hein added a comment. In D21954#483114 , @ngraham wrote: > Can we also pre-emptively add 2.12 as well? :) Done. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21954 To: hein, ngraham Cc: ngraham,

D21954: Handle Gimp 2.10

This revision was automatically updated to reflect the committed changes. Closed by commit R120:96655354961d: Handle Gimp 2.10 (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21954?vs=60200=60203#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21954: Handle Gimp 2.10

hein created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY GIMP 2.10 is still being a bad desktop citizen and requires a workaround of this sort as well. A nicer fix to do at a later time

Fwd: XDC 2019: Less than three weeks to go to submit your talks, workshops or demos!

Forwarded Message Subject: XDC 2019: Less than three weeks to go to submit your talks, workshops or demos! Date: Thu, 20 Jun 2019 11:55:39 -0400 From: Mark Filion Organization: Collabora Ltd. To: eve...@lists.x.org Hello! Less than three weeks to go to submit your

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks for restoring my sanity & faith in panels, this annoyed me for weeks :) REPOSITORY R120 Plasma Workspace BRANCH alignpanelmaskhandlingtodialog REVISION DETAIL

D20237: Port to new KWorkspace API

hein updated this revision to Diff 59660. hein added a comment. - Fix typo - Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20237?vs=55487=59660 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20237 AFFECTED FILES

D19829: kicker: add option to make root level icons visible

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. I'm still a bit grumpy about this and dragging my feet! My gut still says it's both option clutter and UI noise :-) However: - There's a fair amount of people calling for this now.

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

hein added a comment. I'm not sold on this. "Display" fonts typically have spacing and metrics optimized for large sizes and use cases like signage. The FAQ entry quoted in the task you linked talks about Noto Sans UI. I'd like some more solid documentation on how Display relates to this

D21429: [Fonts KCM] Switch default UI font to Noto Sans Display

hein added a comment. Why? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21429 To: GB_2, #plasma, #vdg, bshah Cc: hein, bshah, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D21336: Get PaginateModel class ready for frameworks

hein added a comment. I wouldn't call this implementation ready for frameworks, though - it just resets all the time, which is very slow as it forces views to destroy and recreate delegates instead of just updating them. A better implementation would just (re)filter source rows

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > job.cpp:30 > + > +#include > + Unused? > notificationgroupcollapsingproxymodel.cpp:194 > +{ > +if (source_parent.isValid() && m_limit > 0) { > +if (!m_expandedGroups.isEmpty() && > m_expandedGroups.contains(source_parent)) { Check

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notificationgroupcollapsingproxymodel.cpp:175 > +emit dataChanged(idx, idx, dirtyRoles); > +emit dataChanged(idx.child(0, 0), idx.child(rowCount(idx) - 1, 0), > dirtyRoles); > + I know this really sucks, and I'm not going to be pushy on

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notificationgroupcollapsingproxymodel.cpp:52 > +Q_UNUSED(bottomRight); // what about it? > +Q_UNUSED(roles); > + Not actually unused. `bottomRight`: You sure the source model will emit for single cells? Otherwise you need

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notificationgroupingproxymodel.cpp:38 > + > +bool NotificationGroupingProxyModel::appsMatch(const QModelIndex , const > QModelIndex ) const > +{ Careful there - these will match when both are empty, which is why the libtm version tests for that.

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notificationsmodel.cpp:57 > + > +int rowOfNotification(uint id) const; > + Could be worth making `inline` maybe? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20265 To: broulik, #plasma Cc: hein, mart,

D20265: Introduce libnotificationmanager

hein added inline comments. INLINE COMMENTS > notifications.cpp:828 > +{ > +return QHash { > +{IdRole, QByteArrayLiteral("notificationId")}, // id is QML-reserved While this isn't an objection, I usually use QMetaEnum to compute this from the enum instead of having a block of stuff

  1   2   3   4   5   6   7   8   9   10   >