Re: more betas / shorter windows?

6.x onwards On Mon, Dec 18, 2023 at 6:59 PM Nicolas Fella wrote: > > On 12/18/23 18:42, Harald Sitter wrote: > > With the second p6 beta sneaking up on us I've been pondering the beta > > experience... > > > > I can't help but think that the windows we've chosen we

more betas / shorter windows?

With the second p6 beta sneaking up on us I've been pondering the beta experience... I can't help but think that the windows we've chosen were too long. At least from a crash tracking POV most of the crash reports we get from !neon are either of unreasonably low quality (because of improvements

setcap on kwin

...do we still need and want it? It gets in the way of crash tracking because it results in kwin_wayland crashes getting special protection by coredumpd that make the cores unreadable for the user [1][2][3]. So we either need polkit elevation in drkonqi or drop the setcap stuff. Opinions? [1]

Re: Do you use votes on Bugzilla tickets to help you make decisions?

Never looked at them. Never seen the benefit. On Fri, Aug 4, 2023 at 3:53 PM Nate Graham wrote: > > Hello folks! > > I often find myself explaining to users that votes on Bugzilla tickets > are generally meaningless and not used by most developers to help > prioritize work. After I explain this,

[KPipeWire] [Bug 467593] Spectacle crashes in PipeWireRecordProduceThread::~PipeWireRecordProduceThread() when closed while recording the screen

https://bugs.kde.org/show_bug.cgi?id=467593 Harald Sitter changed: What|Removed |Added CC||sit...@kde.org Assignee|plasma-devel

Re: kpipewire and sddm theme in plasma6

and breeze widget style that will need to be available for qt5 :( On Fri, Mar 24, 2023 at 10:29 AM Harald Sitter wrote: > > Ciao > > It occurred to me that we have some compatibility problems coming up. > Notably the sddm login theme (which is used by sddm - may be Qt5) and &g

kpipewire and sddm theme in plasma6

Ciao It occurred to me that we have some compatibility problems coming up. Notably the sddm login theme (which is used by sddm - may be Qt5) and kpipewire (used by spectacle - also may be Qt5) Has anyone pondered these? HS

[Plasma Bigscreen] [Bug 460924] org.kde.plasma-remotecontrollers.desktop.cmake shouldn't have entries "Description"

https://bugs.kde.org/show_bug.cgi?id=460924 Harald Sitter changed: What|Removed |Added CC|plasma-devel@kde.org| -- You are receiving this mail because: You

Re: Old versions of our software in Bugzilla

by either ;) @Jonathan please note that the versions for bugzilla management are now encoded here https://invent.kde.org/sysadmin/bugzilla-bot/-/blob/master/data/versions.yml On Tue, Sep 13, 2022 at 1:53 AM Nate Graham wrote: > > On 9/7/22 07:05, Harald Sitter wrote: > > Needs a blurb

Re: Old versions of our software in Bugzilla

On Tue, Sep 6, 2022 at 11:41 PM Nate Graham wrote: > In the medium term, I would like to extend the bugzilla bot to post a > comment on bug reports filed against old unsupported versions > recommending that the reporter instead ask their distro for support. Needs a blurb for starters :) Code

Re: testing UIs and improving a11y all at once!

On Thu, Aug 18, 2022 at 12:13 PM David Edmundson wrote: > The best next step is to take a small area of Plasma (kickoff) and see > how it scales up to having multiple developers both contribute. I'm > happy to land something in the repos as optional deps and see how it > pans out. Sounds

Re: testing UIs and improving a11y all at once!

On Tue, Aug 16, 2022 at 12:30 PM Arjen Hiemstra wrote: > Have you thought about how to integrate this into our projects? Ideally I > suppose we would have the tests as part of each project's repo, but that might > not work for things like Plasma, where running things depend on a lot of other >

semicolons and the policy that was none

Aloha, Someone recently dug up this page from 2012 https://community.kde.org/Plasma/QMLStyle#JS_Code_Blocks First I'd like to point out that this page isn't a policy page, if it was meant to be then it needs to be linked on the policies page and supposedly somehow agreed upon, which I don't

testing UIs and improving a11y all at once!

Servus, A while ago I prototyped a "new" approach to UI testing and I'm wondering if there's general interest in doing more Plasma testing using it. I'm able to invest time in polishing the experience for us. Very rough prototype: https://invent.kde.org/sitter/selenium-webdriver-at-spi The

drkonqi and i18n

Moin for the longest of times we have drkonqi say that crash reports must be in english, yet people still file reports in other languages. Also, given we require people to be proficient enough to answer further queries isn't it counter productive that we have localized strings then, and by

Re: Critical Denial of Service bugs in Discover

On Mon, Feb 21, 2022 at 11:05 AM Ben Cooksley wrote: > > On Mon, Feb 21, 2022 at 10:01 PM Harald Sitter wrote: >> >> On Thu, Feb 10, 2022 at 1:11 PM Aleix Pol wrote: >> > >> > On Thu, Feb 10, 2022 at 11:05 AM Ben Cooksley wrote: >> > > >> &

Re: Critical Denial of Service bugs in Discover

On Thu, Feb 10, 2022 at 1:11 PM Aleix Pol wrote: > > On Thu, Feb 10, 2022 at 11:05 AM Ben Cooksley wrote: > > > > > > > > On Thu, Feb 10, 2022 at 8:20 AM Aleix Pol wrote: > >> > >> [Snip] > >> > >> We still haven't discussed here is how to prevent this problem from > >> happening again. > >> >

Re: Plasma versions in bugs.kde.org

On Fri, Sep 10, 2021 at 10:18 AM Alexander Potashev wrote: > > Hi, > > If someone wants to report a bug against an older version, what would you > suggest and/or expect them to do? First reproduce it on a supported version?

[Breeze] [Bug 441966] Spinner graphics need to be updated

https://bugs.kde.org/show_bug.cgi?id=441966 Harald Sitter changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You are receiving

[Breeze] [Bug 340137] Implement support for window groups (window tabs) in Breeze

https://bugs.kde.org/show_bug.cgi?id=340137 Harald Sitter changed: What|Removed |Added CC||sit...@kde.org Assignee|plasma-devel

[Powerdevil] [Bug 348082] monitor is randomly powered back on when using ddcutil support

https://bugs.kde.org/show_bug.cgi?id=348082 Harald Sitter changed: What|Removed |Added CC||sit...@kde.org Assignee|plasma-devel

Re: 5.22 Soft Freeze

Shall we go ahead with https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/560 or postpone for 5.23? On Thu, Apr 29, 2021 at 1:11 PM David Edmundson wrote: > > At the end of the day is the soft freeze for Plasma 5.22, with the > beta out on the 13th of May. > > After this point we

[kio-extras] [Bug 380417] fish doesn't use User from .ssh/config

https://bugs.kde.org/show_bug.cgi?id=380417 Harald Sitter changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -- You are receiving

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

On Mon, Apr 12, 2021 at 6:01 PM David Edmundson wrote: > > On Mon, Apr 12, 2021 at 4:21 PM Nate Graham wrote: > > > > > > > > On 4/12/21 9:15 AM, David Edmundson wrote: > > > No objections. > > > > > > Be sure to CC sysadmins before doing bulk moves. > > > > Saying what? Also what qualifies as

Re: Including LayerShellQt in Plasma in time for 5.22

- I'm like a broken record at this point: some of the cmake files and the json file lack licensing details. please run `reuse lint` to check the list. it's incredibly close to being fully licensed - you include KDEClangFormat but don't actually seem to enable it - along a similar note: the code

releaseme license clarifications

Yo! If you are in the CC list please respond whether you are ok with the licenses or not. I'm in the process of moving releaseme to reuse compliance and need y'all to approve the following clarifications on the plasma extensions inside releaseme. They are all following the general guidelines we

D6628: Fix and normalize license in .desktop files

sitter added a comment. These aren't SPDX identifiers but kaboutlicense keywords https://api.kde.org/frameworks/kcoreaddons/html/kaboutdata_8cpp_source.html#l00397 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6628 To: sebas, #plasma, sitter, mart, broulik

Re: Plasma 5.20 tars

On 08.10.20 18:59, Jonathan Riddell wrote: > Tars are up for Plasma 5.20 for packages to package. Release due on Tuesday > > Jonathan > Please respin plasma-disks up to cab4513c3886e62ced9079cd1159ab89f52ba7a6 Merci HS

Re: Plasma Firewall

On 05.10.20 16:04, Harald Sitter wrote: > On 04.10.20 17:32, Nate Graham wrote: >> I've got firewalld installed, yet I see an error asking me to install it >> upon opening the KCM: https://i.imgur.com/qQzYLwH.jpg > > Also mind the %1 in the label below ;) > I'm gue

Re: Plasma Firewall

On 04.10.20 17:32, Nate Graham wrote: > I've got firewalld installed, yet I see an error asking me to install it > upon opening the KCM: https://i.imgur.com/qQzYLwH.jpg Also mind the %1 in the label below ;) I'm guessing because no backend is loaded some var is undefined and thus the i18n

Re: plasma-systemmonitor in kdereview

On 01.10.20 14:36, Arjen Hiemstra wrote: > On Thursday, 1 October 2020 14:11:16 CEST Harald Sitter wrote: >> On 01.10.20 11:36, Arjen Hiemstra wrote: >>> Hello, >>> >>> I'd hereby like to announce that plasma-systemmonitor is in kdereview. It >>>

Re: plasma-systemmonitor in kdereview

On 01.10.20 11:36, Arjen Hiemstra wrote: > Hello, > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can > be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It makes > use of the

Re: drkonqi and the windows build

On 23.09.20 12:08, Harald Sitter wrote: > On 17.09.20 17:00, Hannah von Reth wrote: >> So with the availability of KDE applications in the Windows store we >> don't need drkonqi. >> >> We get perfect reports, if the users privacy settings allow it, for each >> subm

Re: drkonqi and the windows build

On 17.09.20 17:00, Hannah von Reth wrote: > So with the availability of KDE applications in the Windows store we > don't need drkonqi. > > We get perfect reports, if the users privacy settings allow it, for each > submitted app separately. > > Every maintainer can request access to the store,

Re: drkonqi and the windows build

On Thu, Sep 17, 2020 at 4:17 PM Hannah von Reth wrote: > > Hi, > > looks like some quoted text is missing. > > I have no idea bout the state of drkonqi on windows, > ages ago a gsoc student did *things* but I don't think anybody was ever > able to use it. > > I can remember a more recent

Re: drkonqi and the windows build

On Thu, Sep 17, 2020 at 1:07 PM David Edmundson wrote: > > >yet it gets built on windows. shall we stop > doing that > > AFAIK it is used and this was something explicitly requested. I seem to recall it not being used and Hannah also not knowing why we would. Ccing. > There is a KF6 workboard

drkonqi and the windows build

drkonqi is part of plasma, yet it gets built on windows. shall we stop doing that? windows keeps not having expected plasma requirements because the rest of plasma is not on windows https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/ this already happened a couple weeks

Re: plasma-disks in kdereview

It's been 3 weeks so I'm considering it in good enough shape for moving to plasma. Thanks! :) On Tue, Aug 4, 2020 at 3:46 PM Harald Sitter wrote: > > Hey > > It'd be awesome if I could get some eyes at the new > https://invent.kde.org/system/plasma-disks which implements sma

Re: licensing terms of plasma dictionary runner

On Fri, Aug 7, 2020 at 6:28 PM Jason A. Donenfeld wrote: > > I'm fine with GPL-2.0-or-later, if that's fine with you. Otherwise let > me know and I'll pick a different one. GPL-2.0-or-later is perfect, I'll update the files. > Thanks for getting in touch, and sorry for the delay. No worries.

Re: plasma-disks in kdereview

On Wed, Aug 5, 2020 at 12:00 AM Albert Astals Cid wrote: > > El dimarts, 4 d’agost de 2020, a les 15:46:20 CEST, Harald Sitter va escriure: > > Hey > > > > It'd be awesome if I could get some eyes at the new > > https://invent.kde.org/system/plasma-disks which i

plasma-disks in kdereview

Hey It'd be awesome if I could get some eyes at the new https://invent.kde.org/system/plasma-disks which implements smart monitoring as requested in https://bugs.kde.org/show_bug.cgi?id=254313 I've opted to not put it in kinfocenter directly because it is a bit much with its own kded module and

Re: licensing terms of plasma dictionary runner

I guess this got buried in the inbox. Try #2 :) | | v On Thu, Mar 26, 2020 at 11:11 AM Harald Sitter wrote: > > Hey Jason! > > Hope you are doing well. > I've just noticed that the dictionary runner you've made for Plasma > doesn't really have licensing terms in its sourc

license clarification for FindMtp.cmake

Hey Jan, Could you please clarify what the licensing terms for FindMtp.cmake are? (Usually BSD-3-Clause) https://invent.kde.org/network/kio-extras/-/blob/master/cmake/FindMtp.cmake https://spdx.org/licenses/BSD-3-Clause.html Cheers HS

Re: merge request and issue notifications to this list?

On Wed, Jul 29, 2020 at 2:25 PM Bhushan Shah wrote: > Other option would be to create a separate plasma-notifications mailing > list which people can subscribe if they wish to for this purpose. Twas recently discussed and a separate list was the preferred option, or rather the getting

Re: Gitlab and plasma dev

On Mon, May 18, 2020 at 3:48 PM Nate Graham wrote: > > Personally I would prefer it if we don't automatically send everything > to the mailing list. That way people can subscribe to only what they > really care about using the web UI, which is very simple and > straightforward--and then the

D29506: rejigger lookup of services by exec

sitter updated this revision to Diff 82731. sitter added a comment. s/%5/%4 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29506?vs=82197=82731 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29506 AFFECTED FILES

D29675: initialize bools to false by default

This revision was automatically updated to reflect the committed changes. Closed by commit R871:c517b795936f: initialize bools to false by default (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29675?vs=82647=82651 REVISION DETAIL

D29675: initialize bools to false by default

sitter created this revision. sitter added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY This should fix random 113 errors (user_not_insider) coming out of the api I can't

D29506: rejigger lookup of services by exec

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously we'd simply query for an Exec that contains the primary query word. that is actually

D28832: Avoid creating subwindow on internal page widget

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I am kind of thinking the cast should be asserted or if'd. But I suppose that doesn't add much over just letting it crash on the null dereference. REPOSITORY R871 DrKonqi BRANCH

D28678: adjust smb kcm size to be sufficient vis a vis headers

This revision was automatically updated to reflect the committed changes. Closed by commit R102:f2c5e10d4af3: adjust smb kcm size to be sufficient vis a vis headers (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28678?vs=79638=80087

D28678: adjust smb kcm size to be sufficient vis a vis headers

sitter added a comment. F8225234: Screenshot_20200408_142242.png F8225237: Screenshot_20200408_142227-1.png F8225239: Screenshot_20200408_142309.png REPOSITORY

D28678: adjust smb kcm size to be sufficient vis a vis headers

sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY we use Stretch to get a somewhat uniform appearance between the two views but Stretch is bit meh

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

sitter added a comment. My point is that this diff adds kguiaddons as a link library but doesn't actually use any symbol, so it may as well not be a link library (or something ought to call some function of kguiaddons so it actually links it) ;) REPOSITORY R124 System Settings REVISION

D27518: If KHelpCenter isn't available fallback to opening doc at docs.kde.org

sitter added a comment. FYI linking a library without actually using any symbols is not going to do anything in practice because many distros link with --as-needed which undoes unnecessary linking. also see https://markmail.org/message/m3mdrsfgxoyfjtte REPOSITORY R124 System Settings

D28192: WIP: Refactor dictionary runner

sitter added inline comments. INLINE COMMENTS > alex wrote in dictionaryrunner_config.cpp:29 > That makes sense but one question: The doc says: `...However, if you for some > reason reimplement it and also are using KConfigXT, you must call this > function`, does this mean we can assume that

D28192: WIP: Refactor dictionary runner

sitter added inline comments. INLINE COMMENTS > alex wrote in dictionaryrunner.cpp:90 > The current behavior is that KRunner closes when a match is selected. > But if you set the data, for instance: > `match.setData(QStringLiteral("Hello There!"));` > The text `Hello There!` will show up in

D28027: fix line rating for new format when function name is missing

This revision was automatically updated to reflect the committed changes. Closed by commit R871:113b91bfee13: fix line rating for new format when function name is missing (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D28026: further constrict line parsing of .so files

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R871:dd180bb4d057: further constrict line parsing of .so files (authored by sitter). CHANGED PRIOR TO COMMIT

D28026: further constrict line parsing of .so files

sitter updated this revision to Diff 79219. sitter added a comment. use other string REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28026?vs=77561=79219 BRANCH parse REVISION DETAIL https://phabricator.kde.org/D28026 AFFECTED FILES

D28026: further constrict line parsing of .so files

sitter added inline comments. INLINE COMMENTS > ahmadsamir wrote in backtraceparsergdb.cpp:75 > (Needs rebasing on master). > I'd move this and define "const bool file" in one place. Alas the code is garbage enough to read, I prefer the way I've written. REPOSITORY R871 DrKonqi REVISION

D27981: strip non printable characters from opengl dri info

This revision was automatically updated to reflect the committed changes. Closed by commit R102:a20ea703f659: strip non printable characters from opengl dri info (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27981?vs=77414=79217

D27980: make opengl module support multiple dri devices

This revision was automatically updated to reflect the committed changes. Closed by commit R102:72a09a3f2787: make opengl module support multiple dri devices (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27980?vs=79208=79216

D27982: use better strings for dri devices

This revision was automatically updated to reflect the committed changes. Closed by commit R102:b7d462e03ce9: use better strings for dri devices (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27982?vs=77417=79218#toc REPOSITORY R102 KInfoCenter CHANGES SINCE

D27980: make opengl module support multiple dri devices

sitter updated this revision to Diff 79208. sitter added a comment. - do however init the stat struct, its members are not initialized otherwise - streamline get_dri_device return - do not init l3 to nullptr inside the info loop. l3 is the entry for the infos, so simply leave it as-is

D27980: make opengl module support multiple dri devices

sitter added inline comments. INLINE COMMENTS > apol wrote in opengl.cpp:625 > setting twice in a row? I'd skip setting a nullptr. Mh. I think that's to ensure l3 (which is passed into newItem) is null on >1 iteration. Indeed garbage though, I'll just pass in nullptr instead. REPOSITORY

D27980: make opengl module support multiple dri devices

sitter added inline comments. INLINE COMMENTS > apol wrote in opengl.cpp:281 > Go for it. Already is in latest diff ;) REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27980 To: sitter Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28129: Read the new message string after rather than before

sitter accepted this revision. sitter added a comment. Mind the comment about the +2 please. Other than that looks reasonable. INLINE COMMENTS > backtraceparsergdb.cpp:215 > +case BacktraceLine::Info: > +d->m_infoLines << line.toString().mid(KCRASH_INFO_MESSAGE.size() + >

D28192: WIP: Refactor dictionary runner

sitter added inline comments. INLINE COMMENTS > config_keys.h:5 > + */ > + > +static const char CONFIG_TRIGGERWORD[] = "triggerWord"; Include guards please > dictionarymatchengine.cpp:85 > m_wordLock.lockForRead(); > -foreach (ThreadData *data, m_lockers.values(source)) { > +for

licensing terms of plasma dictionary runner

Hey Jason! Hope you are doing well. I've just noticed that the dictionary runner you've made for Plasma doesn't really have licensing terms in its source files. https://cgit.kde.org/kdeplasma-addons.git/tree/runners/dictionary/dictionaryrunner.cpp It'd be really grand if you could specify which

D28275: skip over supposed network shares that aren't

This revision was automatically updated to reflect the committed changes. Closed by commit R102:4847c9e2fed2: skip over supposed network shares that arent (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28275?vs=78442=78472 REVISION

D28276: only add devices to the smb mount model that are network shares

This revision was automatically updated to reflect the committed changes. Closed by commit R102:23d52fa33394: only add devices to the smb mount model that are network shares (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D28234: Use SyntaxHighlighter for highlighting

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I love it! INLINE COMMENTS > backtracewidget.cpp:230 > +m_highlighter = new > KSyntaxHighlighting::SyntaxHighlighter(ui.m_backtraceEdit->document()); > + >

D28276: only add devices to the smb mount model that are network shares

sitter added a comment. In D28276#634264 , @broulik wrote: > This is because the device monitor emits all devices, not the query returning unwanted devices? Yep connect(Solid::DeviceNotifier::instance(),

D28276: only add devices to the smb mount model that are network shares

sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously we'd add all devices which would then cause a crash when trying to access them ->as()

D28275: skip over supposed network shares that aren't

sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY we explicitly request listFromType(Solid::DeviceInterface::NetworkShare) but apparently still can

[systemsettings] [Bug 418949] plymouth-theme-breeze should have a background/wallpaper option

https://bugs.kde.org/show_bug.cgi?id=418949 Harald Sitter changed: What|Removed |Added Component|Plymouth|kcm_plymouth Product|Breeze

D28192: WIP: Refactor dictionary runner

sitter added a comment. About fixing the UX: There is some kind of preview tech in milou which you can take a look at and maybe build upon. The line space is just never going to be enough for a text only representation of a dict entry, plus it looks fairly forced anyway. So, my thinking

D28129: Read the new message string after rather than before

sitter added a comment. Mh. Not quite what I had in mind but I suppose it makes sense this way. I think we need a test case for the highlighter though :| It totally blows up in my face when I trace a running dolphin because toskip isn't quite right. INLINE COMMENTS >

D27166: Refactor converter runner

This revision was automatically updated to reflect the committed changes. Closed by commit R114:08bb4ec7370c: Refactor converter runner (authored by alex, committed by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27166?vs=78281=78287#toc REPOSITORY R114 Plasma Addons

D28098: remove pointless and arbitrary 4 line frame limit

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R871:80efb36bc807: remove pointless and arbitrary 4 line frame limit (authored by sitter). REPOSITORY R871 DrKonqi

D28137: make servicerunner only build once

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d03f98e782c3: make servicerunner only build once (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28137?vs=77999=78076 REVISION

D28142: Display PID & signal numbers unlocalized

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I guess a localized number would be one with a thousand separator?  REPOSITORY R871 DrKonqi BRANCH fixpiddisplay REVISION DETAIL https://phabricator.kde.org/D28142 To: kossebau,

D27166: Refactor converter runner

sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. Please also add test cases for the regressions Kai highlighted. Thanks! INLINE COMMENTS > broulik wrote in converterrunnertest.cpp:75 > I think you should change the locale for

D27096: Refactoring, improve validation in kcm, optimize

This revision was automatically updated to reflect the committed changes. Closed by commit R114:8dd8fe555a1e: characters: Refactoring, improve validation in kcm, optimize (authored by alex, committed by sitter). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D28129: Read the new message string after rather than before

sitter added a comment. Quick recap from what we talked about on telegram: putting the print after the bt is most definitely going to throw off the backtrace parsing logic, so doing it this way would require extensive changes there, which is a dangerous place to make extensive changes. Or

D28138: some static analyzer improvements for service runner

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fab5b5e26d7e: some static analyzer improvements for service runner (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28138?vs=78001=78004#toc REPOSITORY R120 Plasma

D28027: fix line rating for new format when function name is missing

sitter added a comment. D28026 REPOSITORY R871 DrKonqi BRANCH parse-rate REVISION DETAIL https://phabricator.kde.org/D28027 To: sitter, cfeck, ngraham Cc: ahmadsamir, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D27980: make opengl module support multiple dri devices

sitter updated this revision to Diff 78003. sitter added a comment. - isValid is const now - use qdiriterator - use QFile::encodeName for the stat call REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27980?vs=77716=78003 BRANCH multidri REVISION

D28138: some static analyzer improvements for service runner

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY - be more consty (and don't risk detatching containers) - init members - don't ql1s to qstring

D28137: make servicerunner only build once

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY build the runner itself in a static lib we can use for testing and then link that into a module

D27166: Refactor converter runner

sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:23 > +endif() > \ No newline at end of file No newline at end of file > CMakeLists.txt:6 > +ecm_add_test(converterrunnertest.cpp TEST_NAME

D27980: make opengl module support multiple dri devices

sitter added inline comments. INLINE COMMENTS > pino wrote in opengl.cpp:210 > qPrintable is wrong when passing paths to native C functions; use > QFile::encodeName instead Is that also true for paths that are only ascii? Specifically path is a /dev node. > pino wrote in opengl.cpp:230-233 >

D27935: Make kwallet-pam work with pam_fscrypt

sitter added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:329 > > How about leaving it in for 5.18 and drop it for master? > > Should there be an unexpected problem we'll at least have months of > > theoretical testing and a shorter window from 5.19.0 to .1 to hotfix a > >

D28098: remove pointless and arbitrary 4 line frame limit

sitter updated this revision to Diff 77821. sitter added a comment. update comment as well REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28098?vs=77817=77821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28098 AFFECTED FILES

D28098: remove pointless and arbitrary 4 line frame limit

sitter created this revision. sitter added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY ... and update a related test case the original motivation here was garbage _start traces

D27980: make opengl module support multiple dri devices

sitter updated this revision to Diff 77716. sitter added a comment. use qvector instead of list fix device detection by doing readlink resolution on the correct directory (subdir appending got lost in the code rejiggering) /proc/dri support is now gone entirely as it is only

D27935: Make kwallet-pam work with pam_fscrypt

sitter added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:329 > That is a good question, the old code was kind of prepared for it. > > I am going to say "no" open can not be called before authenticate, if you > read

D28042: [DrKonqi] Port QRegExp to QRegularExpression

sitter added a comment. I wouldn't terribly mind a second pair of eyes. Code generally looks good to me though, so if nobody else comments feel free to land in a couple days. INLINE COMMENTS > backtraceparsergdb.cpp:55 > +// "#5 0x7f50e99f776f in QWidget::testAttribute_helper

D28027: fix line rating for new format when function name is missing

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously this supposedly was `#2 0x7fefe9ef79e8 in ?? () at /usr/lib/dri/i965_dri.so` nowadays the ?? is simply

  1   2   3   4   5   6   7   8   9   10   >