Plasma-nm: passing on maintainership

these projects. I will still happily help from time to time to explain some things around plasma-nm, but I will no longer be able to actively fix bugs and develop new features. I will still be around, mostly working on things around Flatpak, PipeWire, etc. Thank you. Best regards, Jan Grulich

Re: license clarification for FindMtp.cmake

e) > > https://invent.kde.org/network/kio-extras/-/blob/master/cmake/FindMtp.cmake > https://spdx.org/licenses/BSD-3-Clause.html > > Cheers > HS > > -- Jan Grulich, Senior Software Engineer, Desktop Team Red Hat

D29701: Disable horizontal scrollbar in kcm

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I would say push it also to master. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D29701 To: davidre, broulik,

D29469: Icon in system tray missing when WireGuard connection active on startup

This revision was automatically updated to reflect the committed changes. Closed by commit R116:040a5c8ce9b0: Icon in system tray missing when WireGuard connection active on startup (authored by andersonbruce, committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES

D29071: FileChooser portal: add support for opening directories

This revision was automatically updated to reflect the committed changes. Closed by commit R838:976d0c5fade9: FileChooser portal: add support for opening directories (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good and it works for me, tested with Chromium. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH master REVISION DETAIL

D29071: FileChooser portal: add support for opening directories

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH filechooser-directory REVISION DETAIL https://phabricator.kde.org/D29071

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich added inline comments. INLINE COMMENTS > waylandintegration.cpp:310 > > -// HACK wait for stream to be ready > -QTimer::singleShot(3000, , ::quit); This has been removed, but I think it will still be needed. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich added a comment. With all code relevant to PipeWire removed, you can remove all needed CMake find modules in cmake subdir and you can also remove the ENABLE_PIPEWIRE option as it shouldn't be needed anymore (including all ifdefs). REPOSITORY R838 Flatpak Support: KDE Portal for

D29019: Create a hotspot KCM for Plasma Mobile

jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:39 > +Controls.Switch { > +id: enabled > +Kirigami.FormData.label: i18n("Enabled:") Using adjective as an ID looks weird

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich added inline comments. INLINE COMMENTS > waylandintegration_p.h:126 > KWayland::Client::FakeInput *m_fakeInput = nullptr; > -KWayland::Client::RemoteAccessManager *m_remoteAccessManager = nullptr; > +KWayland::Client::VideoStreaming *m_remoteAccessManager = nullptr; >

D28875: Screensharing: support variable stride

This revision was automatically updated to reflect the committed changes. Closed by commit R838:d1f0ec4d3a4c: Screensharing: support variable stride (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28875: Screensharing: support variable stride

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. TEST PLAN All current clients still work and also we now support higher stride we get from gbm_bo. REPOSITORY R838 Flatpak Support: KDE

D28799: Refactor and fix the mobile wifi kcm

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I wanted to let @ngraham to review this UI wise, but I see there are no UI changes. I don't follow mobile KCM development so I'm not sure I'm the right person to review this, but it

D28034: [Applet] Port to ExpandableListItem

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Those were probably all issues I could find. I will keep using it and if I find something later, I will let you know. Thank you. REPOSITORY R116 Plasma Network Management Applet

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit R838:b8af0f136865: Make PipeWire, GBM and Epoxy libs as required dependencies (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich updated this revision to Diff 80001. jgrulich marked 2 inline comments as done. jgrulich added a comment. - Better naming for the cmake option disabling PipeWire REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich marked 2 inline comments as done. jgrulich added inline comments. INLINE COMMENTS > asturmlechner wrote in CMakeLists.txt:23-24 > maybe make it a proper cmake option? I made it a cmake option. I have never used it before so please check if it's correct. > asturmlechner wrote in

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich updated this revision to Diff 79948. jgrulich added a comment. Make DISABLE_PIPEWIRE_SUPPORT a cmake option and remove a leftover from previous change REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28698: Save unneeded DBus roundtrip

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. In D28698#644705 , @davidedmundson wrote: > > (the ugly notification which pops on the top of screen) when Plasma notifications are not

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. I see that we already initialize the secret agent right when the kded module is loaded, but I see a potential problem in showing a notification using a fallback backend (the ugly notification which pops on the top of screen) when Plasma notifications are not ready

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. Actually it was me who pushed this, Lukáš just did some changes to it. Here are some details: https://cgit.kde.org/plasma-nm.git/commit/?id=81839a1566d0c0209a308d71b03837f996a19c96 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. In D28698#644698 , @nicolasfella wrote: > Yes, but I don't see this being a problem I think this was done this way to make the kded module used only when either the applet or KCM is running. It was Lukáš Tinkl

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. In D28698#644695 , @broulik wrote: > Isn't that `Handler` also used from the plasmoid and KCM, which is in a separate process from kded? It is. REPOSITORY R116 Plasma Network Management Applet REVISION

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich added a comment. In D28677#644196 , @davidedmundson wrote: > > Also allow to completely disable Wayland support in case some distribution don't ship PipeWire yet. > > I don't follow, why don't we just disable the screencasting

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich updated this revision to Diff 79684. jgrulich edited the summary of this revision. jgrulich added a comment. Allow to disable only PipeWire, while keeping rest of Wayland support REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich added a comment. I asked on kde-distribution-packagers, so far I got only response from Slack and the response was they don't care about Wayland, if they would, they would have included PipeWire. I think it should be either don't support Wayland at all if distribution doesn't care

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich added a comment. In D28677#644196 , @davidedmundson wrote: > > Also allow to completely disable Wayland support in case some distribution don't ship PipeWire yet. > > I don't follow, why don't we just disable the screencasting

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Also allow to completely disable Wayland support in case some distribution don't ship PipeWire yet REPOSITORY R838 Flatpak

D28517: Send notification when screencasting fails

jgrulich added a comment. Looks good to me. @broulik what do you think? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D28517 To: cblack, #plasma, #vdg, ngraham, apol, jgrulich Cc: broulik, apol, ngraham, plasma-devel, Orage,

D28214: Add background portal

jgrulich added inline comments. INLINE COMMENTS > davidedmundson wrote in background.cpp:165 > From the docs > > Commandline to use add when autostarting at login. >If this is not specified, the Exec line from the >desktop file will be used. > > I can't see us doing that last

D28214: Add background portal

jgrulich added a comment. In D28214#643478 , @bcooksley wrote: > This change, as committed does not appear to compile: >

Making PipeWire required for xdp-kde

Hi, I recently pushed a background portal implementation, which also needs some KWayland stuff, while previously it was needed just for screen sharing purpose and compiled only when PipeWire and some other libraries are found. Now I need the Wayland part available all the time and I don't want

D28214: Add background portal

This revision was automatically updated to reflect the committed changes. Closed by commit R838:0cefb5e18db4: Add background portal (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28214?vs=79515=79551#toc REPOSITORY R838 Flatpak Support: KDE Portal for XDG

D28034: [Applet] Port to ExpandableListItem

jgrulich added a comment. In D28034#643194 , @ngraham wrote: > Yeah, the PC3 busy indicator component itself seems to be to blame for items 1 and 3. I'll look into it. > > I hadn't really considered #2 as a valid use case while working on

D28034: [Applet] Port to ExpandableListItem

jgrulich added a comment. Both issues fixed, however I found two news: 1. Getting file:///usr/lib64/qt5/qml/org/kde/plasma/extras/ExpandableListItem.qml:438:13: QML BusyIndicator: Binding loop detected for property "implicitHeight" spammed in terminall from plasmashell process, but

D28214: Add background portal

jgrulich updated this revision to Diff 79515. jgrulich marked 5 inline comments as done. jgrulich added a comment. Update to fix review comments REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28214?vs=78272=79515 BRANCH

D28214: Add background portal

jgrulich added inline comments. INLINE COMMENTS > apol wrote in background.cpp:69 > I don't really understand why we're exposing this. Is it for contained apps? This is actually not API exposed to the clients, this is purely for xdg-desktop-portal needs, while the client interface

D28618: ScreenSharing: close dialogs when session is closed

This revision was automatically updated to reflect the committed changes. Closed by commit R838:a1128f123e3b: ScreenSharing: close dialogs when session is closed (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28618: ScreenSharing: close dialogs when session is closed

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY When session is closed, for example when user cancells the request through a browser dialog, we also need to close the portal

D28034: [Applet] Port to ExpandableListItem

jgrulich added a comment. Seems to work with all functionality working as before, well done!! Just few details: 1. I noticed that expanding an active connection makes it to switch the expanded "tab view" to the second tab with details information, it first expands showing the traffic

D28517: Send notification when screencasting fails

jgrulich added inline comments. INLINE COMMENTS > screencaststream.cpp:376 > +notification->setIconName(QStringLiteral("dialog-error")); > +notification->setUrgency(KNotification::NormalUrgency); > +notification->sendEvent(); Does it need to be specified if you have

D28517: Send notification when screencasting fails

jgrulich added inline comments. INLINE COMMENTS > xdp_kde.notifyrc:3 > +IconName=start-here-kde-plasma > +Comment=Friendly Name of app > +Name=KDE Portal Integration I don't know if the comments are used in the Notifications KCM, but even if not, I would use a different one, maybe something

D28218: FileChooser: add option to open file with or without write access

jgrulich added a comment. If there are objections to this change, we can just make all the opened files automatically writable. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D28218 To: jgrulich, #plasma, #vdg Cc: ngraham, apol,

D28272: Avoid copying buffer twice

This revision was automatically updated to reflect the committed changes. Closed by commit R838:f6e559702cf5: Avoid copying buffer twice (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28272: Avoid copying buffer twice

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Previously we copied frames first to a temporary QImage and then to PipeWire buffer. This shouldn't be necessary as we can

D27783: Add new Account portal

This revision was automatically updated to reflect the committed changes. Closed by commit R838:75a8fa728347: Add new Account portal (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D27783: Add new Account portal

jgrulich added a comment. In D27783#632940 , @ngraham wrote: > Ah, thanks. LGTM. Would you be okay with me submitting a patch to alter/polish the UI after it lands? Absolutely! REPOSITORY R838 Flatpak Support: KDE Portal for XDG

D28218: FileChooser: add option to open file with or without write access

jgrulich added a comment. For the record, GTK file dialog has same option: F8195023: gtkdialog.png "Otevřít soubory pouze pro čtení" -> "Open files as read-only" REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL

D28218: FileChooser: add option to open file with or without write access

jgrulich added a comment. In D28218#632909 , @ngraham wrote: > In D28218#632907 , @jgrulich wrote: > > > but you can restrict the write access if you don't the sandboxed application to modify the

D27783: Add new Account portal

jgrulich added a comment. In D27783#632900 , @ngraham wrote: > Ok. When trying to compile I get the following: > > In file included from ../libportal/portal-qt5.h:20, >from

D28218: FileChooser: add option to open file with or without write access

jgrulich added a comment. In D28218#632902 , @ngraham wrote: > Hmm, this seems like the kind of nerdy exposing-implementation-details thing that would be problematic from a UX standpoint. I can see the use cases for wanting to open a read-only

D28218: FileChooser: add option to open file with or without write access

jgrulich added a comment. In D28218#632843 , @apol wrote: > This is a feature we generally don't show. What's the use-case? The document portal can mount a file to the sandbox either as read-only or with write access. REPOSITORY R838

D28218: FileChooser: add option to open file with or without write access

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH filechooser-readonly REVISION DETAIL https://phabricator.kde.org/D28218

D27783: Add new Account portal

jgrulich added a comment. In D27783#632600 , @ngraham wrote: > How can I test this? I don't know if there is any application using this, but I test it with my testing application in libportal. You can get it here:

D28214: Add background portal

jgrulich updated this revision to Diff 78272. jgrulich added a comment. Avoid potential crash when captured variable goes out of scope REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28214?vs=78271=78272 BRANCH

D28214: Add background portal

jgrulich updated this revision to Diff 78271. jgrulich added a comment. Replace my custom function for quoting of arguments with KShell REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28214?vs=78270=78271 BRANCH

D28214: Add background portal

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Implements Background portal, providing APIS related to applications running in the background. Implemented according to:

D27783: Add new Account portal

jgrulich added a comment. In D27783#630734 , @ngraham wrote: > UserInfoDialog.qml an Item with a Rectangle in it, could you use a Window? > > https://doc.qt.io/qt-5/qml-qtquick-window-window.html I don't think that would be correct

D28176: Implement Keyboard Keycode support as suggested in the spec

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I thought I already had support for this, maybe it got lost somewhere. Looks good otherwise. INLINE COMMENTS > waylandintegration.cpp:386 > +if (m_streamInput && m_fakeInput) { >

D18392: [mobile/broadband] Port to SimpleKCM and FormLayout

jgrulich requested changes to this revision. jgrulich added a comment. This revision now requires changes to proceed. I would approve, but @ngraham requested some changes. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18392 To:

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

This revision was automatically updated to reflect the committed changes. Closed by commit R116:999f0ad9fb8b: Update L2TP to NetworkManager-l2tp 1.8.0 features (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

jgrulich added a comment. I would say it's not a big deal as we use groupboxes quite a lot in plasma-nm. We can get rid of them in future when rewriting the KCM to QML. REVISION DETAIL https://phabricator.kde.org/D27764 To: dkosovic, jgrulich Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

jgrulich added a comment. In D27764#621204 , @dkosovic wrote: > In D27764#621173 , @jgrulich wrote: > > > @dkosovic will you update the review to address my comments? > > > I agree with all

D27799: Use system color scheme from Kirigami instead of Plasma theme color

This revision was automatically updated to reflect the committed changes. Closed by commit R116:c9b2684a49d3: Use system color scheme from Kirigami instead of Plasma theme color (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

jgrulich added a comment. @dkosovic will you update the review to address my comments? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27764 To: dkosovic, jgrulich Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27799: Use system color scheme from Kirigami instead of Plasma theme color

jgrulich updated this revision to Diff 76830. jgrulich added a comment. Don't use deprecated color REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27799?vs=76824=76830 BRANCH bug-418416 REVISION DETAIL

D27799: Use system color scheme from Kirigami instead of Plasma theme color

jgrulich added a comment. One thing I'm not sure about whether to use **viewBackgroundColor** or just **backgroundColor**, because I want the buttons to look like they are part of the view. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27799: Use system color scheme from Kirigami instead of Plasma theme color

jgrulich created this revision. jgrulich added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY BUG: 418416 REPOSITORY R116 Plasma Network Management Applet BRANCH bug-418416

D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Only nitpicking, otherwise it looks good to me. INLINE COMMENTS > l2tpauth.cpp:34 > +#include "nm-l2tp-service.h" > +#include "debug.h" > + This include doesn't seem to be used. >

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. Looks this changed introduced an issue. The traffic monitor doesn't fit into the applet. See picture below: F8145280: plasma-nm.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec

This revision was automatically updated to reflect the committed changes. Closed by commit R116:803b17ad39ef: Rename L2TP IPsec Settings dialog from Advanced to IPsec (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27783: Add new Account portal

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH account-portal REVISION DETAIL https://phabricator.kde.org/D27783

D27763: Rename L2TP IPsec Settings dialog from Advanced to IPsec

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Makes sense. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27763 To: dkosovic, jgrulich Cc: plasma-devel, Orage, LeGast00n,

D27199: [Applet]Update layout based on T10470

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. It will need rebase, there are some changes in master now which will be conflicting. Other than that I think it looks good, but I would like Nate to approve this from the UI point of

D27661: wireguard: Trim IP list before submitting to NM

This revision was automatically updated to reflect the committed changes. Closed by commit R116:b7daee75ee0e: wireguard: Trim IP list before submitting to NM (authored by Haochen Tong i...@hexchain.org, committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE

D27666: Support WPA3-SAE in the applet popup

This revision was automatically updated to reflect the committed changes. Closed by commit R116:764cb342ea1b: Support WPA3-SAE in the applet popup (authored by Haochen Tong i...@hexchain.org, committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27643: FileChooser: download remote files to a cache location to open them through the portal

jgrulich abandoned this revision. jgrulich added a comment. In D27643#618132 , @fvogt wrote: > In D27643#618125 , @jgrulich wrote: > > > I have never used fuse. I see you can use kio-fuse over dbus

D27643: FileChooser: download remote files to a cache location to open them through the portal

jgrulich added a comment. I have never used fuse. I see you can use kio-fuse over dbus to mount a file, but you still have to unmount it, which will be a problem, because from the portal I don't know whether the app is still using it or not. If anyone is familiar with fuse and have

D27643: FileChooser: download remote files to a cache location to open them through the portalBUG: 418155

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27643 AFFECTED

D27563: [mobile/wifi] Use ScrollViewKCM

jgrulich added a comment. In D27563#615561 , @ngraham wrote: > What's the chance we could unify the mobile and desktop versions at some point. Seems a bit anti-Kirigami-ish to maintain a separate mobile view rather than using the power of

D27543: Set all labels to plain text

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Similar fix applied to plasma-nm. Looks good to me. REPOSITORY R97 Bluedevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D27543 To: davidedmundson, #plasma,

D27542: [kded] Escape notifications

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Thank you David. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D27542 To: davidedmundson, #plasma, jgrulich Cc:

D27541: [kded] Set password dialog boxes to plaintext

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Thank you David. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D27541 To: davidedmundson, #plasma, jgrulich Cc:

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. In D27199#613246 , @ngraham wrote: > In D27199#612689 , @jgrulich wrote: > > > This is probably not related to the UI, it might be issue in the internals. Can you open a

D27391: [Applet]Fix dimensions of traffic Monitor

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Accepting from my side. I'll wait for Nate to do the final review as I don't consider myself expert to QML and UI. REPOSITORY R116 Plasma Network Management Applet BRANCH monitor

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. In D27199#611665 , @ngraham wrote: > In D27199#611308 , @gvgeo wrote: > > > I made 3 smaller patches, to decrease this patch's size. D27391

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. I like it. I didn't go through the code changes yet, I'll wait until you finish it completely. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham,

D27277: Properly search for PipeWire libs

This revision was automatically updated to reflect the committed changes. Closed by commit R838:05a9caf5e866: Properly search for PipeWire libs (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D27277: Properly search for PipeWire libs

jgrulich updated this revision to Diff 75379. jgrulich marked 5 inline comments as done. jgrulich added a comment. Improve includes REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27277?vs=75373=75379 BRANCH

D27277: Properly search for PipeWire libs

jgrulich added a comment. Fixed all issues. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D27277 To: jgrulich, #plasma Cc: cgiboudeaux, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27277: Properly search for PipeWire libs

jgrulich updated this revision to Diff 75373. jgrulich added a comment. Drop unrelated change REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27277?vs=75372=75373 BRANCH Plasma/5.18 REVISION DETAIL

D27277: Properly search for PipeWire libs

jgrulich updated this revision to Diff 75372. jgrulich added a comment. - Fix cmake variable name REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27277?vs=75371=75372 BRANCH Plasma/5.18 REVISION DETAIL

D27277: Properly search for PipeWire libs

jgrulich updated this revision to Diff 75371. jgrulich added a comment. Simplify cmake code REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27277?vs=75343=75371 BRANCH Plasma/5.18 REVISION DETAIL

D27277: Properly search for PipeWire libs

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Recent change in upcoming PipeWire releases made all headers to be installed versioned directories so multiple versions can be

D26875: Make it possible to stream only input

jgrulich added inline comments. INLINE COMMENTS > waylandintegration.cpp:257 > m_streamingEnabled = true; > +startStreamingInput(); > bindOutput(output.waylandOutputName(), > output.waylandOutputVersion()); Maybe use m_streamInput = true for consistendy with

D26392: Add option to easily configure and start a hotspot

This revision was automatically updated to reflect the committed changes. Closed by commit R116:5e55e45d8794: Add option to easily configure and start a hotspot (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D26392: Add option to easily configure and start a hotspot

jgrulich updated this revision to Diff 73614. jgrulich marked an inline comment as done. jgrulich added a comment. - Code improvements REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26392?vs=73437=73614 BRANCH hotspot REVISION

D26392: Add option to easily configure and start a hotspot

jgrulich updated this revision to Diff 73437. jgrulich marked an inline comment as done. jgrulich added a comment. Address review comments: 1. Add text to the toolbutton and make it checkable 2. Allow to create hotspot only if WiFi is available or it's not used as primary connection

D26392: Add option to easily configure and start a hotspot

jgrulich added a comment. In D26392#592288 , @ngraham wrote: > In D26392#592133 , @jgrulich wrote: > > > Can someone please look into this review? Either try it or check the code? I would like to

  1   2   3   4   5   6   >