Re: CI moved to Qt 6.7 for Linux builds

Hi, This doesn't look terribly active to me / something receiving much in the way of release activity? Plasma 5.27.11 was released two months ago, so that’s not that far ago. And I think I haven’t merged most of my cherry-picks because of failing pipelines because of appstream. Cheers Kai

Re: CI moved to Qt 6.7 for Linux builds

Hi, (only posting to plasma-devel only below is about Plasma) > i'd also like to schedule removing CI support for [...] Plasma/5.27 Plasma 5.27 is our LTS release and we’ve just had Kubuntu 24.04 ship with it. I’m also aware of at least one other major deployment that’s also on 5.27 for the

Re: More 5.27 Releases

Agreed. I also think it’s a bad mindset to have “there won’t be any 5.27 release”. We should for now treat backporting as if there will be another one, given 6.0 isn’t even out yet. Cheers Kai Uwe Am 12.02.24 um 11:53 schrieb David Edmundson: Plasma 5.27 is not getting any more regular

Re: Wayland Nvidia situation for initial Plasma 6 release

Hi, plasma-integration already (which I am NOT happy about!) creates a GL context to check whether to use software rendering, there we could also check the GL_VENDOR and set basic render loop. But backporting won’t hurt either way I’d say. Cheers Kai Uwe Am 07.02.24 um 10:13 schrieb David

Re: QML: a packagers nightmare. Assistance please.

Hi, that ShadowedLabel is literally one QML file with a Label and a DropShadow. KWin could just not use that (and build its own) and we’d resolve the issue. Cheers Kai Uwe From what I am seeing this patch causes KWin to import a qml module that lives in plasma-workspace import

Maintainer Wanted: PowerDevil

Hi everyone, unfortunately my KDE time has been limited for a while now. I’ve seen a bunch of hot new stuff™ being worked on (notably the logical screen brightness and automatic brightness stuff) and it’s just unfair to be the bottleneck here by not reviewing them. Therefore I’d like to

Re: Moving print-manager and wacomtablet to Plasma

Hi, I can’t speak for wacomtablet but I support the idea of moving print-manager to Plasma. It always struck me as odd that it’s not part of Plasma. Realistically there’s plenty of CUPS-based printer UIs, so I don’t see why anyone would ours, which is pretty tightly integrated, outside of

Re: Cherry-picking policy

Hi, > I propose to make creating MRs for bugfix backports mandatory: Agreed. I have also been guilty of cherry-picking changes on a whim from my phone before going to bed, which is not something we want for the stable branch. Back when we were still forward-merging I was at least compiling

Re: change size of kickoff

Hi Daniel, this was very recently added and should be possible from Plasma 5.25 onwards [1], [2]. Cheers Kai Uwe [1] https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/924 [2] https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/500 Am 12.07.22 um 09:43 schrieb

[Powerdevil] [Bug 377357] configurable timer setting to turn off the keyboard's backlight

https://bugs.kde.org/show_bug.cgi?id=377357 --- Comment #9 from Kai Uwe Broulik --- Splitting out the keyboard backlight into a separate action would also enable us to dim the keyboard while keeping the screen on, like when a video player forces the screen on, you probably still want

Re: Can we move the Monday Plasma meeting to a later time?

Hi, CET is UTC+1, CE*S*T is UTC+2 :) Cheers Kai Uwe Am 17.01.22 um 20:34 schrieb Nate Graham: Cool. Europe time means CET i.e. UTC+2? Nate

Re: Akademy Plasma Bof

Hi, Was already asking :) I'd prefer Mon or Tue. Cheers Kai Uwe

Re: Has there ever been ...

Hi, I don't think we consider running KWin instead of Quartz Compositor a supported usecase, maybe that's where your glitches are coming from. /scnr > because kwin has been becoming more and more bloated over the versions leading up to 5.15, and filled with functionality I don't need. Can

Relicensing Plasma Browser Integration Host to GPLv3+

Hi all, I've noticed that the licensing of Plasma Browser Integration is all over the place, some parts seem to be resembling an MIT-style license, probably carried over all the way from when it was just a proof of concept we didn't care much about. To clean up that mess, I'd like to

Re: Clang Format Update

Setting it the column width too narrow makes it have the habit of pointlessly breaking statements apart a lot. Am 01.01.21 um 17:59 schrieb Roman Gilg: > 160 chars column limit contradicts Frameworks recommendation of 100 chars.

Monday Meeting notes for 2020-12-28

Hi all, find below today's meeting notes. Small round because of the holidays, see you next year! fvogt: * I've only got https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/532 to raise [login-sessions: (Correctly) set the correct filename depending on default session type]

[Powerdevil] [Bug 364067] Automatic suspend when inhibitor is set

https://bugs.kde.org/show_bug.cgi?id=364067 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |FIXED Latest Commit

Re: How to enable notification history for an application

Hi, Is it possible for the application to change its own "show in history" setting, instead of the user going to System Settings to do this? It is not. Cheers Kai Uwe

Re: How to enable notification history for an application

Hi, by default all well-known applications show in history. Having DesktopEntry= in the notifyrc should make it show up in System Settings. Make sure the notifyrc file is intsalled in the correct location and the DesktopEntry matches the desktop file name and that the desktop file isn't

Re: dipping a toe in waywater? :)

> this is not a standard set-up, so just selecting wayland as a login option on > the login manager screen isn't an option. Is it Mac OS?

Re: Icon-Only Task Manager Colored Backgrounds

Hi, I also thought it was pretty cool but I tried that the other day with Task Manager by using the k-cluster sampling code from Big Screen to get the dominant icon color. It didn't work very well. Our current design the line doesn't give much area for colorization (the background is pretty

Sprint notes - PowerDevil

Find below the sprint notes for the "PowerDevil" session. We decided to broaden the scope a little from PowerDevil KCM to overall PowerDevil discussion: Cheers Kai Uwe * KCM is all about plugins but I'd suggest making a static "coherent" UI * figure out disabling vs "don't touch" (e.g. screen

D27129: [Notifications] Allow expiring an entire group

broulik added a comment. Should we go with this now? I haven't seen it crash on me since I fixed the `checkIndex` thing REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27129 To: broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28881: [Applet] Fix connecting with a password

broulik added inline comments. INLINE COMMENTS > ConnectionItem.qml:234 > +} else if (connectionItem.customExpandedViewContent == > passwordDialogComponent) { > +if (passwordDialogComponent.password != "") { > +

D21987: Extend KDE Connect to images, video, audio, selection

broulik abandoned this revision. broulik added a comment. We have image/video/audio now, text selection I might add later but maybe not soo useful after alll REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D21987 To: broulik, #plasma, fvogt,

D15418: Dim application icon when it is not playing anything

broulik abandoned this revision. broulik added a comment. I'd prefer some dimmed label next to the app name but with the radio button and manual size calculations all over the place now, this is difficult REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D29478: [Clipboard Plasmoid] Port to Prison QML import

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7bd9bea0723c: [Clipboard Plasmoid] Port to Prison QML import (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29478?vs=82076=83171

D28904: Cleanup dependencies

broulik planned changes to this revision. broulik added a comment. I've noticed I accidentally removed compiling a few things, that also depend on KIO, so maybe not as lean as I hoped REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D28904 To: broulik, #plasma Cc:

Re: Gitlab and plasma dev

The thing that I found annoying is that only one person can be assigned to review. One thing that I was on the verge of doing is to @people that I'd like to notice the review in the comment to the MR. Yeah, I'm annoyed by that, too. The problem with a pure mention is that there's no

Re: Gitlab and plasma dev

Hi, > I think this could be achieved with a label, that reviewers can set and authors can clear when they're ready. > Somehow it's possible to create a label that covers all of Plasma as the VDG have one already. Good idea! I think having a "Needs changes" label would be very useful, even

D29831: Update availableScreenRect when a panel moves to another screen

broulik added a comment. Could that also mitigate task manager showing windows of the wrong screen in certain scenarios? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29831 To: akandaurov Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

Plasma Firewall

Hi all, Tomaz, Lucas, and me have been working on a simple Firewall KCM for Plasma based on nx-firewall. It supports both ufw and firewalld. I'd like to eventually include that in Plasma 5.20 so please give it some code review and testing so we can iron out any issues for that, especially

D28904: Cleanup dependencies

broulik added inline comments. INLINE COMMENTS > anthonyfieroni wrote in CMakeLists.txt:20 > That's not right at least. It should be optional when KF5NetworkManagerQt is > found. It looks weird to present at all. Yes, this looks wrong but I don't understand why I even have to add this

D27130: [Notifications] For group parents combine the child bodies

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ebf61e5ecf9e: [Notifications] For group parents combine the child bodies (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23021: [Image Wallpaper] Use layer.enabled during transition to avoid background glimpsing through

broulik abandoned this revision. broulik added a comment. Yeah, would love some @ahiemstra shader magic there :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23021 To: broulik, #plasma, ngraham Cc: ahiemstra, ngraham, plasma-devel, Orage, LeGast00n,

D25462: [Colors / Desktop Theme KCM] Use Kirigami.SearchField

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c743d36b0372: [Colors / Desktop Theme KCM] Use Kirigami.SearchField (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26296: Add Opera Extension ID

broulik abandoned this revision. broulik added a comment. Gave up on Opera review. If someone wants to maintain our Opera store presence there, feel free to get in touch. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D26296 To: broulik, #plasma,

D27130: [Notifications] For group parents combine the child bodies

broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27130 To: broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,

Re: Sunsetting PowerDevil's XRandrBrightness

> One thing which this will trip over is, if device supports both XRandr > and normal backlight control, then code will prefer to still use the > XRandr, so not sure if we can "trust" data. That's on purpose, since XRandR has the smooth brightness animation, I always prefer that one, if

Sunsetting PowerDevil's XRandrBrightness

Hi all, PowerDevil has two (three, if you count DDC) means of controlling screen brightness: * Writing to sysfs (/sys/class/backlight and /sys/class/leds) * Using XRandr output property XRandR is doing X calls and we have some lovely animated screen brightness change. However, the UPower

D7724: [ListItemBase] Open options menu on right click

broulik added a comment. https://invent.kde.org/plasma/plasma-pa/-/merge_requests/1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7724 To: broulik, #plasma, #vdg, drosca Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D7724: [ListItemBase] Open options menu on right click

broulik abandoned this revision. broulik added a comment. Will revisit on GitLab. Code has changed too much REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D7724 To: broulik, #plasma, #vdg, drosca Cc: ngraham, plasma-devel, Orage, LeGast00n,

D29464: [applets/appmenu] Hide old menu before showing new menu

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Oops, I didnt't properly apply the patch. So yeah, the flickering for which I added this code is still there. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29464: [applets/appmenu] Hide old menu before showing new menu

broulik added a comment. That focus loss flickering was fixed at some point iirc. I'll try the patch tomororw but lgtm REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29464 To: cblack, #plasma, #kwin Cc: broulik, plasma-devel, Orage, LeGast00n,

D29465: [applets/appmenu] Improve menu feel

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Clever with the `hoverEnabled`, I had to think twice to understand it, though :p REPOSITORY R120 Plasma Workspace BRANCH cblack/appmenu-better-menu-behaviour (branched from master)

D25984: Load translations

broulik abandoned this revision. broulik added a comment. Looks like D27595 fixes the issue REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid Cc: vkrause, mart,

D25462: [Colors / Desktop Theme KCM] Use Kirigami.SearchField

broulik updated this revision to Diff 83044. broulik edited the summary of this revision. broulik added a comment. - Drop `placeholderText` since the Kirigami issue has been resolved REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29771: [Notifications] Don't take updated time into account for sorting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d71181245f13: [Notifications] Dont take updated time into account for sorting (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29771?vs=82909=83042#toc REPOSITORY R120

D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too

This revision was automatically updated to reflect the committed changes. Closed by commit R120:97e843d3ead3: [Free Space Notifer] Use critical notification instead of tray icon and monitor… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29691: Restore ability to send tel: URLs to the phone

broulik closed this revision. broulik added a comment. https://invent.kde.org/plasma/plasma-browser-integration/commit/8c4c240c0c1064893aaba0cd94fadf73f0e908ce REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D29691 To: broulik, #plasma, fvogt Cc:

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

This revision was automatically updated to reflect the committed changes. Closed by commit R126:424217083a8c: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob (authored by broulik). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

broulik updated this revision to Diff 82950. broulik added a comment. - Drop manual startup stuff - Drop C stuff REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29621?vs=82500=82950 REVISION DETAIL https://phabricator.kde.org/D29621 AFFECTED

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

broulik added inline comments. INLINE COMMENTS > ahmadsamir wrote in iconapplet.cpp:435 > According to the kservice docs KService::serviceByStorageId() param is > "the storage id or desktop-file path of the service", so I guess that's why > it works. but "desktop file path" is what

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

broulik added inline comments. INLINE COMMENTS > ahmadsamir wrote in iconapplet.cpp:435 > I tried that first, and it doesn't work; those .desktop files are in a > ~/.local/share/plasma_icons, ksycoca doesn't know about that location. But why would `serviceByStorageId` work then? Looks like

D27595: Watch for language change events, and forward those to the QML engine

broulik added a comment. Is there no better way to do this? e.g. the KWin Rules KCM spends 20% of its startup time in "retranslate" :/ REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27595 To: vkrause, mart Cc: davidedmundson, broulik, rikmills, ngraham, apol,

D29760: Replace MapProxySource with some javascript code

broulik added inline comments. INLINE COMMENTS > SensorFace.qml:49 > +result = [] > +for (var sensor of root.controller.highPrioritySensorIds) { > +result.push(root.controller.sensorColors[sensor]) To match "Map"proxy source could have done ;) const

D29771: [Notifications] Don't take updated time into account for sorting

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Notification spec says, when replacing a notification: > The server must atomically (ie with

D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This refactors the free space notifier module to use a critical (i.e. persistent and always

D29744: [Kicker] Fix jump list actions in RunnerMatchesModel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9e545131faa9: [Kicker] Fix jump list actions in RunnerMatchesModel (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29765: Add a blurless SDDM theme

broulik added a comment. Can we perhaps add infrastructure so that a theme can provide options? For instance, the look and feel package can add options to the lock screen KCM which we use for e.g. "always show clock" and "show media controls". I'm not keen on duplicating the entire theme

D29744: [Kicker] Fix jump list actions in RunnerMatchesModel

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Fixes regression caused by me meddling with data in

D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:7e2e0bc0: [Reminder] Also advert Chromie store for Vivaldi and Brave (authored by broulik). REPOSITORY R856

D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave

broulik updated this revision to Diff 82814. broulik retitled this revision from "[Reminder] Also advert Chromie store for Vivaldi" to "[Reminder] Also advert Chromie store for Vivaldi and Brave". broulik edited the test plan for this revision. broulik added a comment. - Also for brave

D28154: Add users KCM

broulik added inline comments. INLINE COMMENTS > ngraham wrote in UserDetailsPage.qml:217 > FWIW KCMs opened through KRunner are now opened in System Settings so > KCMShell is something we're going to have to deal with much less. :) Yes, but it's still something to consider. Right now Esc does

D28154: Add users KCM

broulik added a comment. Pretty cool INLINE COMMENTS > UserDetailsPage.qml:36 > + > +property variant user > +property bool overrideImage: false Use `property var`, or even `property QtObject` since `User` is a `QObject` > UserDetailsPage.qml:82 > +id: fileDialog > +

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > iconapplet.cpp:435 > > -new KRun(QUrl::fromLocalFile(m_localPath), QApplication::desktop()); > +KIO::ApplicationLauncherJob *job = new >

D29691: Restore ability to send tel: URLs to the phone

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They're not `http` or `https` URLs. Add a dedicated handler with appropriate "Call on

D29633: [Battery Monitor] Fix toolTipMainText when plugged in

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ddefcfb7c901: [Battery Monitor] Fix toolTipMainText when plugged in (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29632: [kcms/keys] Use better collator settings

broulik added inline comments. INLINE COMMENTS > davidre wrote in shortcutsmodel.cpp:89 > We typically don't have apps with numbers but I can also add it? Ah, this is for apps, but yeah, why not... REPOSITORY R119 Plasma Desktop BRANCH collator (branched from master) REVISION DETAIL

D29644: Select application after it is added

broulik added inline comments. INLINE COMMENTS > main.qml:97 > +id: transition > +PropertyAnimation { > +target: components Sounds like you want `PropertyAction` REPOSITORY R119 Plasma Desktop BRANCH addIndex

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks please phrase the commit message the opposite way. State what the commit changes, not what the state was before the commit. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

broulik added inline comments. INLINE COMMENTS > batterymonitor.qml:61 > +} else { > +return i18n("Battery charging, currently at %1%", > pmSource.data.Battery.Percent) > } Also, just because it's plugged in, doesn't mean it's charging. REPOSITORY

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. The tooltip logic was completely rewritten in 5.19. This patch does not apply to 5.18. Also, D29633 REPOSITORY R120 Plasma Workspace

D29632: [kcms/keys] Use better collator settings

broulik added inline comments. INLINE COMMENTS > shortcutsmodel.cpp:89 > QCollator collator; > +collator.setCaseSensitivity(Qt::CaseInsensitive); > std::sort(m_components.begin(), m_components.end(), > [&](const Component , const

D29633: [Battery Monitor] Fix toolTipMainText when plugged in

broulik created this revision. broulik added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It only had a return value for "NoCharge" since the else case was only for not plugged

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The existing `--service` is kept for compatibility as it prints out the actually

D29475: [Global Shortcuts KCM] Also check PortableText

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c6a8b2f5e940: [Global Shortcuts KCM] Also check PortableText (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29475?vs=82073=82494

D29594: Close low battery notificaton when showing critical

This revision was automatically updated to reflect the committed changes. Closed by commit R122:afff6ae64f42: Close low battery notificaton when showing critical (authored by broulik). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29594?vs=82422=82493

D29594: Close low battery notificaton when showing critical

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When not acknowledging the low battery notification, close it when showing the critical one, to

D29533: [Reminder] Also advert Chromie store for Vivaldi

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They advertise supporting Chrome extensions TEST PLAN Untested To test: - Run

D29393: Use player "poster" as album cover if available

This revision was automatically updated to reflect the committed changes. Closed by commit R856:811ae0dd5a54: Use player poster as album cover if available (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

broulik added a comment. Ah, right, we just use the sort filter model, no model from C++. Meh, so I can't think of a better way right now either.. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To: kmaterka, #plasma_workspaces, #plasma, ngraham,

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

broulik added a comment. I would suggest we add a `count` property with a `NOTIFY` signal on the model which is then updated on C++ side? I find that cleaner than doing that from QML like this REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28180 To:

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

broulik added a comment. > Switching to it would also require user data. How many users use a vertical panel? Yes, please! It also imho depends on the usecase. On a laptop you're more likely to use a left vertical panel than on a giant desktop setup with multiple monitors. REPOSITORY

D29474: Add inHistory bool and hide heading on inHistory

broulik accepted this revision. broulik added a comment. I kinda think this should be named more generically, e.g. `headerBackgroundVisible` REPOSITORY R120 Plasma Workspace BRANCH no_heading_for_ungrouped (branched from master) REVISION DETAIL https://phabricator.kde.org/D29474 To:

D29478: [Clipboard Plasmoid] Port to Prison QML import

broulik created this revision. broulik added reviewers: Plasma, vkrause. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Which does the rendering and proper sizing for us, e.g. ensure integer scaling so the

D29475: [Global Shortcuts KCM] Also check PortableText

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Allows to find keyboard shortcuts without knowing the localized key designation. TEST PLAN

D29234: Fix various bugs introduced with heading

broulik added a comment. > I added one last thing Can we please not mix behavior changes into a patch that fixes bugs and regressions. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel,

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a5c9e000b9c9: [Notifications] Dont show do not disturb end date beyond 100 days (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29395: Refactor MediaController

broulik added a comment. Generally +1 Nice idea with this `Media` singleton INLINE COMMENTS > ExpandedRepresentation.qml:65 > +} > +Media.lockPositionUpdate= false > +} Coding style, space > ExpandedRepresentation.qml:99 > seekSlider.value

D29315: [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet

broulik added inline comments. INLINE COMMENTS > PowerManagementItem.qml:62 > +Layout.fillWidth: true > +Layout.leftMargin: units.gridUnit + units.smallSpacing // width of > checkbox and spacer > spacing: units.smallSpacing Try if this works with right-to-left layout,

D29411: [KRunner] Watch config with KConfigWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6db69ae09524: [KRunner] Watch config with KConfigWatcher (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29411?vs=81896=81904#toc REPOSITORY R120 Plasma Workspace

D29410: [Runners KCM] Notify history deletion

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8fe03502660c: [Runners KCM] Notify history deletion (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29410?vs=81895=81901 REVISION

D29411: [KRunner] Watch config with KConfigWatcher

broulik created this revision. broulik added reviewers: Plasma, ngraham, ksmanis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Rather than using a `KDirWatch` that points to the wrong place. TEST PLAN

D29410: [Runners KCM] Notify history deletion

broulik created this revision. broulik added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY So KRunner can catch that in a `KConfigWatcher` REPOSITORY R119 Plasma Desktop

D29401: [KRunner] Fix watched config file path

broulik added a comment. Ideally, we'd change the KCM to write the key with `KConfig::Notify` and then use `KConfigWatcher` here REPOSITORY R120 Plasma Workspace BRANCH krunner-fix-watched-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D29401 To:

D29401: [KRunner] Fix watched config file path

broulik added a comment. That's not the bug I tried to solve in D26444 , was it? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29401 To: ksmanis, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik added a comment. I find "for a year" odd. Also, this is a bug fix, so can we get this in or not. Changing strings can then be done in master, if we want to. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28740 To: broulik, #plasma Cc: ngraham,

D29393: Use player "poster" as album cover if available

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Media Sessions artwork takes precedence, if set. TEST PLAN Not sure how useful

D29234: Fix various bugs introduced with heading

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > NotificationItem.qml:118 > +Layout.preferredWidth: notificationHeading.implicitWidth > +id: headingElement > + Put `id` at the top >

  1   2   3   4   5   6   7   8   9   10   >