[Powerdevil] [Bug 348529] When screen is locked, turn off screen with a shorter timeout

https://bugs.kde.org/show_bug.cgi?id=348529 Méven Car changed: What|Removed |Added CC||meve...@gmail.com --- Comment #63 from Méven Car

D7939: ColorSet concept in Theme

meven added inline comments. INLINE COMMENTS > ratijas wrote in platformtheme.h:223-224 > What was this TODO all about? I am guessing adding making `colorsChanged(Kirigami::PlatformTheme::ColorSet colorSet)`. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7939 To:

D20217: Remove kwallet4 support

meven added inline comments. INLINE COMMENTS > arrowd wrote in pam_kwallet.c:436 > I wonder why one of `NULL` wasn't removed completely? The first of the NULL replaced `extraArg` naively. You can send a simple MR for this. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

meven added a comment. In D14895#683521 , @alanjds wrote: > In D14895#683516 , @meven wrote: > > > Feel free to send a MR, and include more context please. > > > Sorry my ignorance. What "MR"

D14895: Plasmashell freezes when trying to get free space info from mounted remote filesystem after losing connection to it

meven added a comment. Feel free to send a MR, and include more context please. INLINE COMMENTS > alanjds wrote in soliddeviceengine.cpp:583-584 > Can we have this number configurable somehow, even if only before startup. > > It's been annoying to have notifications when bringing lots of

[Powerdevil] [Bug 382088] power on battery: Does not consider mutiple batteries

https://bugs.kde.org/show_bug.cgi?id=382088 Méven Car changed: What|Removed |Added CC||meve...@gmail.com --- Comment #1 from Méven Car

[systemsettings] [Bug 348082] monitor is randomly powered back on

https://bugs.kde.org/show_bug.cgi?id=348082 Méven Car changed: What|Removed |Added CC||meve...@gmail.com --- Comment #16 from Méven Car

[plasmashell] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Méven Car changed: What|Removed |Added CC||meve...@gmail.com --- Comment #64 from Méven Car

[plasmashell] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Méven Car changed: What|Removed |Added CC||micraf...@gmail.com --- Comment #54 from Méven Car

[Powerdevil] [Bug 343631] With "buttons event handling" set to "turn off screen", screen does not turn off

https://bugs.kde.org/show_bug.cgi?id=343631 Méven Car changed: What|Removed |Added CC||meve...@gmail.com --- Comment #7 from Méven Car

D13988: Use subseq matching for service runner

meven added a comment. There no blockers anymore, providing there no conflict, we could land this as-is. REPOSITORY R120 Plasma Workspace BRANCH feat/app-name-subseq REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas, #plasma_workspaces, #plasma, broulik,

D22846: Port KeyboardLayout component to use generated DBus interface

meven added a comment. In D22846#676700 , @bam wrote: > Does it mean we now have to manually synchronize DBus API here in .xml and on KWin side? Only if the API breaks (which is pretty much guaranteed not to happen) or we need a need

D29466: [applets/appmenu] Add search to global application menu

meven added subscribers: ngraham, meven. meven added a comment. In D29466#674210 , @trmdi wrote: > Can this be moved to krunner? In that case it can be used even when the user doesn't use global menu? I don't think think so, this search

D26718: aggregate text for KRunner in DesktopView

meven closed this revision. meven added a comment. At moved to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/148 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26718 To: pdabrowski, #plasma, #plasma_workspaces, davidedmundson, ngraham,

D28651: Load and use global animation settings

meven added inline comments. INLINE COMMENTS > breezestyle.cpp:189 > +QStringLiteral( "org.kde.KGlobalSettings" ), > +QStringLiteral( "notifyChange" ), this, > SLOT(configurationChanged()) ); > #if QT_VERSION < 0x050D00 // Check if Qt version < 5.13 Shouldn't

[plasmashell] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Méven Car changed: What|Removed |Added CC||meven@enioka.com --- Comment #53 from Méven

D29807: Change Chrome API design

meven added a comment. In D29807#675032 , @alex wrote: > Friendly Ping :-) > > Or should I just move this to gitlab? This is close to be approved, no need to move this. I think this can land @broulik @ngraham ? INLINE COMMENTS

D29395: Refactor MediaController

meven added a comment. ping @cblack and reviewers The commit message could mention the UI changes as well. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: meven, kmaterka, iasensio, broulik, trmdi, ngraham, plasma-devel,

D29847: Fixes compile problem for freebsd because of missing crypt.h

meven added a comment. In D29847#674811 , @usta wrote: > In D29847#674807 , @adridg wrote: > > > https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes > > > > There's already a

D27129: [Notifications] Allow expiring an entire group

meven accepted this revision as: meven. meven added a comment. This revision is now accepted and ready to land. Seems fine to me REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27129 To: broulik, #plasma, meven Cc: meven, plasma-devel, Orage, LeGast00n,

D29807: Change Chrome API design

meven accepted this revision. meven added a comment. @broulik perhaps a review ? REPOSITORY R120 Plasma Workspace BRANCH api_inconsistencies (branched from master) REVISION DETAIL https://phabricator.kde.org/D29807 To: alex, broulik, #plasma, ngraham, meven Cc: anthonyfieroni,

D28544: RecentDocuments Runner: Cleanup and formatting

meven added a comment. Well @alex https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 was merged, so if you are still up to do it, now is a good time to rebase your changes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28544 To: alex,

D3835: [Calendar] Populate overview models on-demand

meven accepted this revision as: meven. meven added a comment. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. @broulik is it still on the table ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D3835 To:

D28544: RecentDocuments Runner: Cleanup and formatting

meven added a comment. To rebase after https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 lands REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28544 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage,

D26111: Runner: make recentdocument use KActivityStats data

meven abandoned this revision. meven marked an inline comment as done. meven added a comment. Moved to https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/31 INLINE COMMENTS > meven wrote in recentdocuments.cpp:78 > It is needed for QString coming from KActivitiesStats, they can

D29807: Change Chrome API design

meven accepted this revision as: meven. meven added a comment. This revision is now accepted and ready to land. Two smalls things. Seems good to me otherwise. Give some times to other to have a final say before merging. INLINE COMMENTS > chromeprofile.cpp:33 > +const

D29827: Give users the ability to disable the microphone indicator

meven added a comment. In D29827#673611 , @davidedmundson wrote: > It's an SNI, I thought the systemtray could already filter SNIs in the enties tab of the system tray? Currently it appears in the systray config only when the

D29827: Give users the ability to disable the microphone indicator

meven added a comment. In D29827#673569 , @kurmikon wrote: > In D29827#673551 , @ngraham wrote: > > > The name needs to be your full name ("Firstname Lastname"). This was a pre-existing

D29807: Change Chrome API design

meven added a comment. Seems good, two small clean ups INLINE COMMENTS > chromeprofile.cpp:8 > +ProfileBookmarks::ProfileBookmarks(const QString , const QString ) > +: m_path(path), m_name(name), m_favicon(nullptr) { > +// Remove "Bookmarks" from end of path `{` on new line >

D28154: Add users KCM

meven added a comment. So next step would be to shadow user_manager ? A naive ripgrep gave : $ rg user_manager .. ../kxmlgui/src/kbugreport.cpp 352:m_process->start(QStringLiteral("kcmshell5"), QStringList() << QStringLiteral("user_manager"));

D29819: Using background rectangle in icon text when in software rendering

meven added a comment. This can be closed : https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29819 To: brunogoncalves, #plasma, ngraham Cc: meven, plasma-devel, Orage, LeGast00n,

D10197: Fix krunner's alt+f2 on wayland

meven added inline comments. INLINE COMMENTS > view.cpp:247 > -m_plasmaShellSurface->setPanelTakesFocus(true); > -m_plasmaShellSurface->setRole(PlasmaShellSurface::Role::Panel); > -//this should be on showEvent, but it was too soon so none of > those had any

D29726: BookmarksRunner: Change caching databases

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me REPOSITORY R120 Plasma Workspace BRANCH avid_unnecessary_copying (branched from master) REVISION DETAIL https://phabricator.kde.org/D29726 To: alex, #plasma,

D29726: BookmarksRunner: Change caching databases

meven added inline comments. INLINE COMMENTS > chrome.cpp:55 > for(const Profile : profiles) { > +updateCacheFile(profile.faviconSource(), profile.faviconCache()); > m_profileBookmarks << new ProfileBookmarks(profile); Might as well check the returned value for error >

D29624: Fix Warning about KF5::KSysGuard target being deprecated

meven abandoned this revision. meven added a comment. Superseeded by D29626 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29624 To: meven, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26934: KCM/Autostart Add a model to separate logic from UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:01776488ab8b: KCM/Autostart Add a model to separate logic from UI (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=80200=82533

D27203: Don't try to open files we can't figure out where they are

meven accepted this revision. meven added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:226 > +//passing non-local files as the working directory is not supported. > +//See QFileDialogPrivate::initialSelections > +

D29626: Fix Warning about KF5::ProcessCore target being deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit R119:baa168ede063: Fix Warning about KF5::ProcessCore target being deprecated (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29623: Fix Warning about KF5::KSysGuard target being deprecated

meven added a comment. Improved by D29628 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29623 To: meven, #plasma, ahiemstra, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D29628: Use the right targets for KSysGuard

meven added a comment. Related fix in `plasma-desktop` https://phabricator.kde.org/D29626 REPOSITORY R120 Plasma Workspace BRANCH ksysguard_targets REVISION DETAIL https://phabricator.kde.org/D29628 To: ahiemstra, #plasma, meven Cc: meven, plasma-devel, Orage, LeGast00n,

D29626: Fix Fix Warning about KF5::ProcessCore target being deprecated

meven updated this revision to Diff 82518. meven added a comment. Update root CMakeLists.txt REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29626?vs=82509=82518 BRANCH arcpatch-D29626 REVISION DETAIL https://phabricator.kde.org/D29626

D29628: Use the right targets for KSysGuard

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R120 Plasma Workspace BRANCH ksysguard_targets REVISION DETAIL https://phabricator.kde.org/D29628 To: ahiemstra, #plasma, meven Cc: meven, plasma-devel, Orage,

D29628: Use the right targets for KSysGuard

meven added a comment. ANd `KSysGuard::Sensors` `KSysGuard::SensorFaces` in `applets/systemmonitor/systemmonitor/CMakeLists.txt` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29628 To: ahiemstra, #plasma, meven Cc: meven, plasma-devel, Orage, LeGast00n,

D29628: Use the right targets for KSysGuard

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. It miss a KSysGuard::ProcessCore in `applets/systemmonitor/systemmonitor/CMakeLists.txt` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29628

D29626: Fix Fix Warning about KF5::ProcessCore target being deprecated

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D29626 AFFECTED FILES

D29623: Fix Warning about KF5::KSysGuard target being deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d2c57378479a: Fix Warning about KF5::KSysGuard target being deprecated (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29624: Fix Warning about KF5::KSysGuard target being deprecated

meven created this revision. meven added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Warnings such as: CMake Warning at

D29623: Fix Warning about KF5::KSysGuard target being deprecated

meven created this revision. meven added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Warnings such as: CMake Warning at

D27576: Kill Runner: Move config keys to new file

meven accepted this revision. meven added a comment. In D27576#659971 , @alex wrote: > @meven and others, may I ship this? Yep ship it, it is low risk. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576_1 REVISION DETAIL

D26111: Runner: make recentdocument use KActivityStats data

meven marked 2 inline comments as done. meven added a comment. I need to change dev machine, now that plasma-workspace needs Qt5.14, that explains the delay. INLINE COMMENTS > broulik wrote in recentdocuments.cpp:78 > Do we really want `QUrl::fromUserInput` here? This thing typically

D29326: Bookmarks Runner: Fix extraction of firefox profile

meven added a comment. We should not have screenshots in git commit message as they are not durable. (Only in test plan section is tolerable) I think you can change your comment, to include the ini text instead, and add comments saying `; here marked default` `; here real default`

D27098: Konsole Runner: optimize and simplify

meven accepted this revision. meven added a comment. So yo won't be able to type "konsole myprofile" but I guess this is just fine. REPOSITORY R114 Plasma Addons BRANCH arcpatch-D27098 REVISION DETAIL https://phabricator.kde.org/D27098 To: alex, davidedmundson, ngraham, #plasma,

D26111: Runner: make recentdocument use KActivityStats data

meven updated this revision to Diff 81413. meven marked 3 inline comments as done. meven added a comment. Clean CMakeLists, use KShell::tildeCollapse, avoid stating in RecentDocuments::actionsForMatch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26111: Runner: make recentdocument use KActivityStats data

meven added inline comments. INLINE COMMENTS > alex wrote in recentdocuments.cpp:98 > You could use KShell:: tildeCollapse here :-) Indeed, the irony is that I created `KShell::titdeCollapes`, but this diff is older than KF that introduced it... Thanks REPOSITORY R120 Plasma Workspace

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. ping whoever... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: alex, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

meven added a comment. In D28424#637869 , @davidedmundson wrote: > looks good to me, but lets delay merging till the relevant other parts are ready. Seems ready to land ;) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R119:20f451125ce7: KCM/GlobalShortut: convert FOREACH and old signal syntax (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28154: Add users KCM

meven added a comment. Is the screenshot current ? ping @ngraham REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag,

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

meven updated this revision to Diff 80616. meven added a comment. Fix for loop REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28282?vs=80614=80616 BRANCH arcpatch-D28282 REVISION DETAIL https://phabricator.kde.org/D28282 AFFECTED FILES

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

meven updated this revision to Diff 80614. meven added a comment. Rebasing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28282?vs=78913=80614 BRANCH arcpatch-D28282 REVISION DETAIL https://phabricator.kde.org/D28282 AFFECTED FILES

D26111: Runner: make recentdocument use KActivityStats data

meven updated this revision to Diff 80516. meven added a comment. Rebasing after D28369 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=73087=80516 BRANCH arcpatch-D26111_1 REVISION DETAIL

D26934: KCM/Autostart Add a model to separate logic from UI

meven added inline comments. INLINE COMMENTS > ervin wrote in autostartmodel.h:52 > Weeell... knowing about Qt::DisplayRole is kind of prerequisite to making > your own model. :-) As you want. IMO this is not a good pattern to expect reviewers to have any previous knowledge about enum values,

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 80200. meven added a comment. Use Qt::DisplayRole directly instead of using Roles::DisplayRole REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=80196=80200 BRANCH D26934-2 REVISION DETAIL

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 80196. meven marked 11 inline comments as done. meven added a comment. Address review, fix an issue when adding a desktop item REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=79639=80196 BRANCH D26934-2

D28829: Touchpad kcm: On X11 hide scroll speed as it is not supported

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fe4d395d792d: Touchpad kcm: On X11 hide scroll speed as it is not supported (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28829: Touchpad kcm: On X11 hide scroll speed as it is not supported

meven created this revision. meven added reviewers: KWin, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 420079 TEST PLAN Tested locally REPOSITORY R119 Plasma Desktop BRANCH master

[Powerdevil] [Bug 383307] Brightness level is not remembered/restoring after sleep and levels up to maximum level

https://bugs.kde.org/show_bug.cgi?id=383307 Méven Car changed: What|Removed |Added CC||meven@enioka.com Status|REPORTED

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. I will this for a few days and merge if no more feedback is sent. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 79639. meven marked 20 inline comments as done. meven added a comment. Make most dialogs use open/finished, make all dialogs modal... REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=78855=79639 BRANCH

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0cf73170479b: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28544: RecentDocuments Runner: Cleanup and formatting

meven added a comment. Regarding the recentdocument krunner, I have a patch to make it rely on kactivity data : D26111 . It has been waiting for review of a while. This patch will introduce a lot of conflict, but I am ok either way, if this one get

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. ping @broulik REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26934: KCM/Autostart Add a model to separate logic from UI

meven added inline comments. INLINE COMMENTS > broulik wrote in autostartmodel.h:52 > Why define `DisplayRole` as dedicated enum entry, rather than just using > `Qt::DisplayRole` in the code everywhere I see, I meant my code to have all Roles used explicitly declared here rather than relying

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

meven updated this revision to Diff 78913. meven marked 5 inline comments as done. meven added a comment. Adress review (formatting) and fix a couple of indentation issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28282?vs=78522=78913 BRANCH

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

meven updated this revision to Diff 78866. meven marked 6 inline comments as done. meven added a comment. Remove unnecessary semilicons, formatting REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28331?vs=78663=78866 BRANCH arcpatch-D28331

D26934: KCM/Autostart Add a model to separate logic from UI

meven added inline comments. INLINE COMMENTS > broulik wrote in autostart.cpp:210 > You probably want to loop > > for (int i = first; i <= last; ++i) { ? > broulik wrote in autostart.cpp:182 > In preparation for a move to QML, can we please not `exec()` You mean I should use open/finished

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 78855. meven marked 10 inline comments as done. meven added a comment. code style mostly, adress Kai review REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=78681=78855 BRANCH D26934 REVISION DETAIL

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 78681. meven marked 2 inline comments as done. meven added a comment. remove spurious space REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=78680=78681 BRANCH D26934 REVISION DETAIL

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 78680. meven added a comment. Remove spaces, use static_cast for less repetition REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=78074=78680 BRANCH D26934 REVISION DETAIL

D27971: Solid-device-automounter/kcm: correctly update automountOn

This revision was automatically updated to reflect the committed changes. Closed by commit R119:aca698e497c8: Solid-device-automounter/kcm: correctly update automountOn (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

meven updated this revision to Diff 78663. meven added a comment. Fix touchpad scrollFactor loading, rename 'Scroll speed' to 'Scrolling speed' REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28331?vs=78635=78663 BRANCH arcpatch-D28331 REVISION

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

meven added a comment. In D28331#635969 , @ngraham wrote: > These KCMs have X11 versions too. They are not Wayland-specific. I'm not a fan of adding this feature only on Wayland. By those KCM, I meant their frontend (they have each 1 for

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

meven added a comment. In D28331#635945 , @ngraham wrote: > So is this Wayland-only? The dependent patch says it's for Wayland. Yes it is wayland-only, the two kcms here are Wayland specific. REPOSITORY R119 Plasma Desktop REVISION

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting

meven added a comment. Old version: F8201151: Screenshot_20200327_103032.png New: F8201345: Screenshot_20200327_123823.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting

meven updated this revision to Diff 78635. meven added a comment. Add slower/faster tags to the slider, clean onMoved code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28331?vs=78629=78635 BRANCH master REVISION DETAIL

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting

meven updated this revision to Diff 78629. meven added a comment. Use onMoved, allow to slow down the scroll speed, use presset values for the scroll speed slider REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28331?vs=78619=78629 BRANCH master

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting

meven added inline comments. INLINE COMMENTS > zzag wrote in touchpad.qml:607 > I suspect that a scroll factor less than 1 may screw up discrete axis values. > Not sure whether it might be a problem, though. My testing went ok with a 0.1 scrollFactor, although not extensive (scroll in

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting

meven added inline comments. INLINE COMMENTS > davidedmundson wrote in touchpad.qml:607 > So I can only make it faster? > > Is that sensible? We can make it slower with a number between 0 and 1. I will need to implement a custom step that's all. I am also hesitant of making the steps

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting

meven created this revision. meven added reviewers: KWin, Plasma, davidedmundson, ervin, bport, crossi, hchain. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Depends on Kwin diff: D28310

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

meven added a comment. Seems good to me @bport should be the best reviewer here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport Cc: plasma-devel, Orage, LeGast00n,

D28297: KCM/touchpad: Disables the middleEmulation when not supported

This revision was automatically updated to reflect the committed changes. Closed by commit R119:73f3855ed3c5: KCM/touchpad: Disables the middleEmulation when not supported (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28296: KCM/Mouse: fix the middleEmulation checkbox status

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fb86174858b5: KCM/Mouse: fix the middleEmulation checkbox status (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28296?vs=78523=78566

D28297: KCM/touchpad: Disables the middleEmulation when not supported

meven created this revision. meven added reviewers: Plasma, ervin, bport, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Similar to D28296 REPOSITORY R119 Plasma

D28296: KCM/Mouse: fix the middleEmulation checkbox status

meven created this revision. meven added reviewers: Plasma, ervin, bport, crossi, hchain. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The load function of the field was not called previously. Preventing the

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

meven updated this revision to Diff 78522. meven marked 4 inline comments as done. meven added a comment. Review comments, code formating more const REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28282?vs=78457=78522 BRANCH shortcuts REVISION

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

meven created this revision. meven added reviewers: ervin, bport, crossi, hchain, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Builds, changed a shortcut and back again REPOSITORY R119 Plasma Desktop

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

meven added a comment. With D28122 I think you can go ahead and port this code to it. Unless you want to take care of the QPlatform integration for it first. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To:

D28272: Avoid copying buffer twice

meven added a comment. Seems good to me REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D28272 To: jgrulich, #plasma Cc: meven, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27971: Solid-device-automounter/kcm: correctly update automountOn

meven added a comment. ping @ervin should be good now REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27971 To: meven, bport, #plasma, ervin, crossi, hchain Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27576: Kill Runner: Move config keys to new file

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Minor nitpick So the code basically extracts from KillRunnerConfigForm the Config constants. INLINE COMMENTS > killrunner.cpp:65 > > -m_sorting = (KillRunnerConfig::Sort)

  1   2   3   4   5   6   7   8   >