D13232: introduce Custom color set

mart updated this revision to Diff 35612. mart added a comment. - confised prototype for custom colors handling - coloroverrides has approach - add missing file - another route: Custom color set - propagate all colors - export a palette in the basictheme - propagate colors to

D13232: introduce Custom color set

mart added a comment. D13233 not necassary anymore REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13232 To: mart, #kirigami, broulik Cc: plasma-devel, apol, davidedmundson, mart, hein

D13232: introduce Custom color set

mart updated this revision to Diff 35516. mart added a comment. - remove dead code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13232?vs=35243=35516 BRANCH mart/customColors REVISION DETAIL https://phabricator.kde.org/D13232 AFFECTED FILES

D13232: introduce Custom color set

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:bf90602e90ea: remove dead code (authored by mart). CHANGED PRIOR TO COMMIT

D13232: introduce Custom color set

mart added inline comments. INLINE COMMENTS > broulik wrote in kirigamiplugin.cpp:172 > What's this? gah, sorry, remains of old attempts > broulik wrote in platformtheme.cpp:314 > Can this lead to issues with non-deterministic setting of properties? Ie. say > `Kirigami.Theme.textColor` is

Re: Stepping down as maintainer

identified a problem that many of us are feeling as well, but It's definitely our responsibility to make this work and some change there happen. -- Marco Martin On Sat, Jun 2, 2018, 10:14 Martin Flöser wrote: > Hi all, > > After long consideration I decided that I am no longer in a

D13237: Show action.main more prominently on the ToolBarApplicationHeader

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > PrivateActionToolButton.qml:62 > > -flat: true > +palette.button: control.kirigamiAction ? > control.kirigamiAction.icon.color : undefined > +

D13148: Allow Kirigami build without KWin tablet mode dependency

mart added a comment. ping? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13148 To: murillobernardes, mart, davidedmundson Cc: davidedmundson, plasma-devel, apol, mart, hein

D13237: Show action.main more prominently on the ToolBarApplicationHeader

mart added inline comments. INLINE COMMENTS > ToolBarApplicationHeader.qml:105 > showText: !parent.toobig > +mainButton: true > } can just assign flat: false instead of adding a new property in actiontoolbutton? REPOSITORY R169 Kirigami

D13233: Support for the Custom color set

mart added a comment. F5880598: image.png REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D13233 To: mart, #kirigami, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13233: Support for the Custom color set

mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY In some scenarios, some applications need certain areas with completely

D13232: introduce Custom color set

mart added a comment. F5880591: image.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13232 To: mart, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein

D13232: introduce Custom color set

mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY In some scenarios, some applications need certain areas with

D12982: Make the new KCMs with QtQuick translatable

mart added a comment. In D12982#270846 , @davidedmundson wrote: > Accepted, sure. But the QtQuick loading is quite separate from the library here, so I'm not sure it's easy. > > If we want to have QtQuick only KCMs (something I think

D13206: Add context property to hide cursor

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. with a comment on why the workaround, is ok for me REPOSITORY R133 KScreenLocker BRANCH hideCursorProperty REVISION DETAIL https://phabricator.kde.org/D13206 To: romangg, #plasma, mart

D13183: Use Control.palette

mart accepted this revision. mart added a comment. awesome! thanks :) REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/D13183 To: apol, #kirigami, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13178: Compress calls to configuration slots upon new connections

mart added a comment. are configureKeyboard configureMouse etc doing an immediate write to disk? (like KConfig::sync() where using timers to compress really saves a lot of time, is to compress the actual disk writes. just writing to kconfiggroup is fast, because it doesn't actually

D13192: Implement a triangle filter for mouse events on the Kickoff tabbar

mart added a comment. In D13192#270466 , @abetts wrote: > Could a different approach work here? No change on hover, but just on click? The user controls the entire action. i think the whole point of a start menu is to be fast, to require

D13207: [lookandfeel/lockscreen] Hide cursor on login controls fade out

mart added inline comments. INLINE COMMENTS > romangg wrote in LockScreenUi.qml:72 > The problem was that I first had to move the mouse to enter the MouseArea. > I.e. when the Screenlocker is activated by timer the cursor is visible until > first time the mouse is moved and then the fade out

D13183: Use Control.palette

mart added a comment. In D13183#270171 , @apol wrote: > In D13183#270156 , @mart wrote: > > > to not break all custom kirigami color set, i think by default all controls in the desktop style should

D13183: Use Control.palette

mart added inline comments. INLINE COMMENTS > apol wrote in kquickstyleitem.cpp:716 > In which case will it be a wrong palette? We are reading a Control property, > it's not really optional. m_control comes from any qquickitem, so it's not a given that will be a qqc2 control instance

D12960: Drag handle to reorder items in a ListView

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:c6f88c7d504d: Drag handle to reorder items in a ListView (authored by mart). REPOSITORY R169 Kirigami CHANGES

D12960: Drag handle to reorder items in a ListView

mart updated this revision to Diff 35107. mart added a comment. - proper version - use handle icon REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12960?vs=34430=35107 BRANCH mart/dragHandle REVISION DETAIL https://phabricator.kde.org/D12960

D13183: Use Control.palette

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. to not break all custom kirigami color set, i think by default all controls in the desktop style should be binded to Kirigami.Theme.palette or the colorset, complementary areas gets

D13183: Use Control.palette

mart added inline comments. INLINE COMMENTS > kquickstyleitem.cpp:716 > +if (m_control) { > +m_styleoption->palette = > m_control->property("palette").value(); > +} else { it should check if that proeprty is valid and if managed to get an intelligible qpalette out of it

D13148: Allow Kirigami build without KWin tablet mode dependency

mart added a comment. almost there :) since there is also a qmake mode to build for embedded, where dbus should be disabled as well, I would prefer to flip the logic. so, have a KIRIGAMI_ENABLE_DBUS which is undefined by default (so nothing to do in the .pri file) but having it defined

D13148: Allow Kirigami build without KWin tablet mode dependency

mart added a comment. In D13148#269233 , @murillobernardes wrote: > I did not patch CMakeLists.txt because I can't test it. I could not get a system with all the right versions of all build dependencies to build Kirigami. > > On

Re: QtCreator with Kirigami for Subsurface

On Mon, May 28, 2018 at 10:52 AM Marco Martin <notm...@gmail.com> wrote: Hi, unfortunately Qtcreator tends to be really picky with any 3rd party qml module... i think you need to have the file plugins.qmltypes somewhere where qtcreator understands it (i don't know if is possible for p

Re: QtCreator with Kirigami for Subsurface

could try to build and install kirigami with its own cmake as a plugin.. and install it right into the qt release that qtcreator is using, that should fix at least autocompletion, not sure wether is enough to make it available in the designer -- Marco Martin On Mon, May 28, 2018 at 10:42 AM &l

D13112: Port Plasma Desktop Scripting to QJSEngine

mart updated this revision to Diff 34864. mart added a comment. proper diff REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13112?vs=34863=34864 BRANCH mart/QJSEngineScripting REVISION DETAIL https://phabricator.kde.org/D13112 AFFECTED FILES

D13112: first round of porting to QJSEngine

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY nothing builds yet, unfortunately it needs a complete port in order to even build port of

Re: Plasma Vaults by Default

the systray popup area by default? -- Marco Martin

D12982: Make the new KCMs with QtQuick translatable

mart added a comment. In D12982#266967 , @ltoscano wrote: > We already had changes in the structure of kcm, and I prefer the names to be future-proof. > > > Besides, we already have some versioned names, so this use case should be

D13054: SwipeItem: Fix using QRC resources and custom image providers.

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > desktopicon.cpp:440 > +// QRC paths are not correctly handled by .path() > +if (iconId.size() >=2 && iconId.left(2) == QLatin1String("/:")) > +

D12974: Workspace KCM Code Improvement

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > resources.qrc:1 > + > + I don't want this kcm done differently from all the others, i want all modules using the same structure, on disk REPOSITORY R119

D12960: Drag handle to reorder items in a ListView

mart added a comment. In D12960#265012 , @alex-l wrote: > I tried with arrows too, but I think the fifth one looks better... my second choice is the third one. > > F5858203: immagine.png i like

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. now became 5.14 for sure, but i think it's safe to go REPOSITORY R119 Plasma Desktop BRANCH no-add-to-panel-as-widget-when-theres-a-task-manager (branched from Plasma/5.13) REVISION

D12960: Drag handle to reorder items in a ListView

mart added a comment. In D12960#264749 , @ngraham wrote: > IMHO the up-and-down arrows do a much better job of communicating "drag me!" than a 9 dot grid does. good point, so so far my favourite are the options by alex REPOSITORY R169

D12960: Drag handle to reorder items in a ListView

mart added a comment. In D12960#264737 , @alex-l wrote: > In D12960#264732 , @alex-l wrote: > > > F5856484: immagine.png > > > I think the mouse cursor

D12960: Drag handle to reorder items in a ListView

mart added a comment. Possible handles (to resume that old discussion) F5855838: Spectacle.q10653.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: zzag, plasma-devel, apol,

D12960: Drag handle to reorder items in a ListView

mart updated this revision to Diff 34430. mart added a comment. all files REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12960?vs=34426=34430 BRANCH mart/dragHandle REVISION DETAIL https://phabricator.kde.org/D12960 AFFECTED FILES

D12962: prototype of a drag handle

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY fix DelegateRecycler for elements that may change index when moved seamless drag finish up

D12960: Drag handle to reorder items in a ListView

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:5ba11c3b9efe: proper version (authored by mart). CHANGED PRIOR TO COMMIT

D12960: Drag handle to reorder items in a ListView

mart updated this revision to Diff 34425. mart added a comment. - proper version REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12960?vs=34423=34425 BRANCH mart/dragHandle REVISION DETAIL https://phabricator.kde.org/D12960 AFFECTED FILES

D12960: Drag handle to reorder items in a ListView

mart added a comment. in action https://youtu.be/vQUnOpwV9xU note that the red square icon is a placeholder, new breeze icons are needed for that REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12960 To: mart, #kirigami, #vdg, hein Cc: plasma-devel, apol,

D12960: Drag handle to reorder items in a ListView

mart created this revision. mart added reviewers: Kirigami, VDG, hein. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY A component to be inserted in list items of any kind, when

D12946: Single/Double Click Option at Workspace KCM

mart added inline comments. INLINE COMMENTS > romangg wrote in main.qml:84 > It was added to the double click setting below (such that the text reads now > exactly like it was in the Mouse KCM). ok BRANCH bug393547-SingleDoubleClickClicking REVISION DETAIL

D12946: Single/Double Click Option at Workspace KCM

mart added inline comments. INLINE COMMENTS > romangg wrote in main.qml:84 > It's already changed, right? i still see text: i18n("Single-click to open files and folders") BRANCH bug393547-SingleDoubleClickClicking REVISION DETAIL https://phabricator.kde.org/D12946 To: furkantokac,

D12946: Single/Double Click Option at Workspace KCM

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:84 > I don't want to bike shed on this given the timing, but it is not just about > files and folders. > It affects almost all Qt grid views. > > The old wording was "select and activate icons". yes, text should

D12944: [weather applet] Show a note why "Show temperature" is disabled

mart added a comment. can you try how it looks with the component InlineMessage from Kirigami? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12944 To: kossebau, #plasma Cc: mart, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

mart added a comment. what's the status of this? when ready, should go in, together D12040 at the beginning of 3.14 vyvle REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12041 To: Zren, #plasma Cc: mart, abetts,

D12852: Added the option to display date in the same line of clock

mart added a comment. added VDG for their opinion on this REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12852 To: astevanato, #plasma_workspaces, #vdg Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12857: Systemmonitor: use different label format when the applet is on a vertical panel

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. ship it with a minor change INLINE COMMENTS > cpu.qml:45 > //return i18n("%1 %2", Math.round(data.value), data.units); > return i18nc("CPU usage: %1 is the value, %2

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

mart added a comment. if it removes the vendor default option, how can i ask to not touch the global/local defaults in any way? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, rkflx Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot,

bugfix in frameworks vital for 5.13

, how to proceed, respin the tarball? the commit that's needed is https://commits.kde.org/qqc2-desktop-style/ 8790d850c4343b9f615457f0926cc3cdcef8d0c7 -- Marco Martin

D12822: Added null check in OverlayDrawer

mart added a comment. ok this can be abandoned then REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12822 To: Dax Cc: mart, apol, plasma-devel, davidedmundson, hein

D12823: Workaround for binding loop in Material Theme

mart added a comment. this would break the binding loop, and things should be able to dynamically change color, so the proper cause should be found REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12823 To: Dax Cc: mart, apol, plasma-devel, davidedmundson, hein

D12849: Improve layout of fonts kcm

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. for me, good to go REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D12849 To: progwolff, mart, abetts, ngraham

D12849: Improve layout of fonts kcm

mart added a comment. In D12849#262026 , @progwolff wrote: > In D12849#261837 , @ngraham wrote: > > > We might want to take the opportunity to also center-align the titles, which it better-looking

D12849: Improve layout of fonts kcm

mart added a comment. In D12849#261837 , @ngraham wrote: > Alignment looks great to me! We might want to take the opportunity to also center-align the titles, which it better-looking for these centered formlayout style UIs. And maybe use a bit

D12102: Port Language KCM to Qt Quick

mart added a comment. if i select more than one language, only one will be added, the others will be added as "unknown" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij,

D12102: Port Language KCM to Qt Quick

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:66 > +delegate: Kirigami.BasicListItem { > +width: ListView.view.width > + sorry, counter what i told you before, setting an

D12685: Fix calendar view: hide unused start/end time labels in day events list

mart added inline comments. INLINE COMMENTS > CalendarView.qml:193 > +readonly property bool hasEndTime: > !isNaN(modelData.endDateTime.getTime()); > +readonly property bool isAllDay: { > // Explicitly all-day event being a very

D12713: Make some strings easier to translate

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > FancyPlotter.cpp:597 > //Use a multi length string incase we do not have > enough room > -lastValue = i18n("%1 of %2"

D12760: Improve single-instance application behavior

mart added inline comments. INLINE COMMENTS > main.cpp:71 > +connect(service, ::activateRequested, this, [this]() { > +KWindowSystem::forceActiveWindow(display->winId()); > +}); KWindowSystem::forceActiveWindow should never be used by normal applications, it's reserved for

D12102: Port Language KCM to Qt Quick

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. on my side, code is all fine now REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D12102_1 REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx,

D12102: Port Language KCM to Qt Quick

mart added a comment. +1 for moving the add language button bottom-right INLINE COMMENTS > main.qml:66 > +delegate: Kirigami.BasicListItem { > +Layout.fillWidth: true > + same consideration for Layout.* in delegates > main.qml:185 > + > +

D12091: HIG entry for On-demand pattern and swipe list item

mart added a comment. ok for the text, the screenshots would need update: both of them at the moment are desktop, which is ok (i would add the mouse cursor) and one mobile is needed, provided here: Desktop, listview: F5833032: image.png Mobile,

D12278: WIP: [Colors KCM] Port to new design

mart added a comment. ok, will work on the widget tinting on next weeks then :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg Cc: mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12563: [Run Command] Add closable property so that close button can be disabled.

mart added a comment. In D12563#257052 , @dscheffer wrote: > In D12563#257024 , @broulik wrote: > > > Urgh. Just because you can doesn't mean you should. This will horribly break if the user is

D11410: [RFC] Add option to make applet fixed width

mart added a comment. we're here, mergein few days when 5.13 freezes and 5.14 branch opens REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11410 To: Pitel, #plasma Cc: mart, hein, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

mart added a comment. In D12040#257172 , @Zren wrote: > In D12040#257170 , @mart wrote: > > > so, if the qpointer is used in a connect, it needs to have .data() to work on gcc 4.8. > > if

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

mart added a comment. In D12040#253357 , @cfeck wrote: > In D12040#253335 , @Zren wrote: > > > Remove `.data()` since it seems to work without it. > > > Even with gcc 4.8 (openSUSE Leap)?

D11909: properly use kpackage_install_package

mart added a comment. fine tis version (with kpackage_install_package and not yet the bundled version) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11909 To: zzag, #breeze Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12278: WIP: [Colors KCM] Port to new design

mart added a comment. what about having this with just color boxes on 5.13 and then figure out controls tinting in 5.14? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg Cc: mart, abetts, ngraham, davidedmundson, plasma-devel,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

mart added a comment. -1 from here as well, it won't and it can't work reliably, it would be pretty much a false promise REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D12405 To: fvogt, #plasma Cc: mart, hein, ngraham, graesslin, davidedmundson, plasma-devel,

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

mart added a comment. anyways, that's just my personal use case (that has a lot of keep it simple) final decision is Eike's REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12462 To: Fuchs, hein Cc: mart, fabianr, plasma-devel, ragreen, Pitel, ZrenBot,

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

mart added a comment. In D12462#252987 , @Fuchs wrote: > In D12462#252982 , @mart wrote: > > > I like the idea a lot, > > tough i am not sure i like the implementation: right now is kindof

D12563: [Run Command] Add closable property so that close button can be disabled.

mart added a comment. what's the exact use case? what plasmoid are you writing? (btw, you can't use that qml file in a plasmoid, if you want to embed parts of krunner in a plasmoids, those are components coming from milou) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D12573: Style enhancement for network management applet

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. imo that's not a thing to be fixed at the applet level, that's how that particular plasma theme looks, you can't fix a 3rd party plasma theme by patching applets to not follow it.

Re: Late API change to KWayland for upcoming Frameworks release

how necessary is it for 5.13? would it miss important functionality? otherwise would be better to push dai 1 of new cycle and have the plasma part at the beginning of 5.14 cycle? too late for 5 13 to depend on next framework? On Wed, May 2, 2018 at 6:19 AM, Roman Gilg wrote: >

D12515: QML applets need to manage padding by themselves

This revision was automatically updated to reflect the committed changes. Closed by commit R124:6a9df821ecfa: QML applets need to manage padding by themselves (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12515?vs=33110=33142

D12526: export layout paddings from qstyle, start from Control

This revision was automatically updated to reflect the committed changes. Closed by commit R858:7b05c392787a: export layout paddings from qstyle, start from Control (authored by mart). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D12526: export layout paddings from qstyle, start from Control

mart updated this revision to Diff 33139. mart added a comment. - remove extra debug REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12526?vs=33112=33139 BRANCH phab/paddingsfromstyle REVISION DETAIL

D12526: export layout paddings from qstyle, start from Control

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Control gets now paddings that come from QStyle, which is useful for

D12515: QML applets need to manage padding by themselves

mart updated this revision to Diff 33110. mart added a comment. - use pixelmetrics from the style for the padding REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12515?vs=33061=33110 BRANCH phab/externalpadding REVISION DETAIL

D12515: QML applets need to manage padding by themselves

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY remove our padding from qml kcms this fixes the cutted away shadow for

D9037: use desktop file actions instead of global shortcuts

mart updated this revision to Diff 32982. mart added a comment. - Merge branch 'master' into arcpatch-D9037 - add a config update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9037?vs=23123=32982 BRANCH arcpatch-D9037 REVISION DETAIL

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

mart added inline comments. INLINE COMMENTS > Zren wrote in wallpaperplugin.cpp:26 > I copy pasted from `image.cpp` ... which apparently hasn't been touched in 4 > years since the import from kde-workspace. > > - >

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

mart added a comment. I like the idea a lot, tough i am not sure i like the implementation: right now is kindof hortogonal to pinned tasks and gets confusing as it has a partial, but not complete overlap. I think this should just be the behavior for pinned tasks, in order to map

D12449: Add hidden system setting group

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > hidden.desktop:5 > +X-KDE-Weight=100 > +Icon=preferences-desktop-default-applications > +Enabled=false can you remove the icon? REPOSITORY R124 System Settings BRANCH

D12351: introduce candidateContainments

This revision was automatically updated to reflect the committed changes. Closed by commit R120:de483d47409c: introduce candidateContainments (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12351?vs=32568=32816 REVISION DETAIL

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

https://bugs.kde.org/show_bug.cgi?id=369676 Marco Martin <notm...@gmail.com> changed: What|Removed |Added Status|CONFIRMED |RESOLVED Reso

D11928: fade to blur when the login box appears

This revision was automatically updated to reflect the committed changes. Closed by commit R120:448455c3c937: fade to blur when the login box appears (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11928?vs=32483=32809#toc REPOSITORY R120 Plasma Workspace CHANGES

D12314: expose the wallpaper config to the lockscreen

This revision was automatically updated to reflect the committed changes. Closed by commit R133:5e7e94599b78: expose the wallpaper config to the lockscreen (authored by mart). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12314?vs=32484=32807 REVISION

D12278: WIP: [Colors KCM] Port to new design

mart added a comment. In D12278#248160 , @ngraham wrote: > It would be really cool if the delegates would show a little preview of a window actually using these colors, instead of the current grid of colored squares. it's probably not

D12278: WIP: [Colors KCM] Port to new design

mart added a comment. In D12278#248109 , @davidedmundson wrote: > > Not too fond of this "Current" > > me neither, if it was up to me, I'd just show a prompt asking for a name when you click "edit" on a system scheme. Would be nice and

D12102: Port Language KCM to Qt Quick

mart added a comment. In D12102#251163 , @ngraham wrote: > +1 for putting the text on the top rather than the bottom. Once we make the list draggable, it might be nice to incorporate that into the text too, e.g "drag languages into your

D12102: Port Language KCM to Qt Quick

mart added a comment. In D12102#251163 , @ngraham wrote: > +1 for putting the text on the top rather than the > Unfortunately, our use of the hamburger button precludes use of that elsewhere-fairly-universal "three bar" symbol to mean "this

D12351: introduce candidateContainments

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY DesktopView contains a property candidateContainments which are all

<    7   8   9   10   11   12   13   14   15   16   >