D28134: Add ColorUtils

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > colorutils.h:73 > + */ > +Q_INVOKABLE PendingValue* averageColorForItem(QVariant item, int > maxPixels = 65536); > + *sigh* should be more clear... what

D28383: Add PageRouter component

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pagerouter.h:12 > + > +struct ParsedRoute { > +QString name; is this still needed for routes that are a composition of PageRoute objects like

D28383: Add PageRouter component

mart added inline comments. INLINE COMMENTS > PageRow.qml:60 > +// Private handle to columnView. > +property alias _columnView: columnView > + if is a publicly accessible property, it should be apublic and documented REPOSITORY R169 Kirigami REVISION DETAIL

D28487: Upstream of the ksysguard based plasmoids

mart updated this revision to Diff 79120. mart added a comment. - remove changes in shell/ REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=79058=79120 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487

D28497: Use non-const iterators

This revision was automatically updated to reflect the committed changes. Closed by commit R111:b5036ff7f1d3: Use non-const iterators (authored by mart). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28497?vs=79101=79103 REVISION DETAIL

D28497: Use non-const iterators

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY on some GCC (here 7.5.0) it complains when one tries to reassign an iterator that was obtained via

D28487: Upstream of the ksysguard based plasmoids

mart added a comment. In D28487#639563 , @ahiemstra wrote: > In D28487#639476 , @mart wrote: > > > should faces be still installed under .local/share/ksysguard/sensorapplet/ or under share/plasma?

D28141: Add KSysGuard::Sensors library

mart added a comment. while porting the systemmonitor plasmoids to upstream, i found a couple of problems: - gcc didn't like inserting using a const iterator - qmldir outdated with the old plugin name diff on top of this phab: https://phabricator.kde.org/P567 REPOSITORY R111

D28474: move the header in the OverlaySheet header

This revision was automatically updated to reflect the committed changes. Closed by commit R134:a71bf27e8e19: move the header in the OverlaySheet header (authored by mart). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28474?vs=79018=79060

D28487: Upstream of the ksysguard based plasmoids

mart added a comment. should faces be still installed under .local/share/ksysguard/sensorapplet/ or under share/plasma? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28487: Upstream of the ksysguard based plasmoids

mart added inline comments. INLINE COMMENTS > metadata.desktop:11 > +X-KDE-PluginInfo-License=LGPLv2+ > +X-KDE-PluginInfo-Name=org.kde.ksysguard.barchart > +X-KDE-PluginInfo-Version=1.0 still org.kde.ksysguard plugin name prefix, or org.kde.plasma.systemmonitor as well? REPOSITORY R120

D28487: upstream of the ksysguard based plasmoids

mart updated this revision to Diff 79058. mart added a comment. - remove useless debug REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=79057=79058 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487

D28487: upstream of the ksysguard based plasmoids

mart created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Those plasmoids are intended to replace the old systemmonitor plasmoids They are based upon the new ksysguard daemon: see D28333

D28134: Add ColorUtils

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. still, no item grabbing REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel,

D28383: Add PageRouter component

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pagerouter.cpp:154 > + > +void PageRouter::setRoutes(QJSValue routes) > +{ should add parsing and validation here > pagerouter.cpp:199 > +{ > +

D28468: Add property initializer support to PagePool

mart added a comment. almost good, just two minor nitpicks INLINE COMMENTS > PagePoolAction.qml:57 > + */ > +property var properties > + initialProperties > pagepool.cpp:160 > + > +class PropertyInitializingIncubator : public QQmlIncubator > +{ put a comment that as soon we can

D28194: [WIP] Fix loading button icons from qrc

mart added a comment. ping? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28194 To: nicolasfella, #plasma, mart Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D28474: move the header in the OverlaySheet header

mart created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Since now overlaysheets have the header always visible when there is a close button, put the write review button in there so that's

D28289: Refactor of OverlaySheet

This revision was automatically updated to reflect the committed changes. Closed by commit R169:800fd5b04c0e: Refactor of OverlaySheet (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=79015=79016 REVISION DETAIL

D28289: Refactor of OverlaySheet

mart updated this revision to Diff 79015. mart added a comment. - always headere when there is close button REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=78616=79015 BRANCH mart/overlaysheetrefactor2 REVISION DETAIL

D28222: Add ShadowedImage and ShadowedTexture items

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. this one i think is good to go, then afterwards, the independent radii REPOSITORY R169 Kirigami BRANCH shadowed_texture REVISION DETAIL https://phabricator.kde.org/D28222 To:

D28289: Refactor of OverlaySheet

mart added a comment. In D28289#635232 , @ngraham wrote: > Generally much nicer looking. I found one visual issue: when I switch from touchpad scrolling to touchscreen scrolling, the close button in the corner gets overlapped by the content

D28289: Refactor of OverlaySheet

mart updated this revision to Diff 78616. mart marked 4 inline comments as done. mart added a comment. - adress comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=78542=78616 BRANCH mart/overlaysheetrefactor2 REVISION DETAIL

D28289: Refactor of OverlaySheet

mart updated this revision to Diff 78542. mart added a comment. - better response to window resizes REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=78532=78542 BRANCH mart/overlaysheetrefactor2 REVISION DETAIL

D28289: Refactor of OverlaySheet

mart updated this revision to Diff 78532. mart added a comment. - Merge branch 'master' into mart/overlaysheetrefactor2 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=78482=78532 BRANCH mart/overlaysheetrefactor2 REVISION DETAIL

D28289: Refactor of OverlaySheet

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Rework OverlaySheet to remove some sizing hacks that made ListView and GridView not work well, fix

D28222: Add ShadowedImage and ShadowedTexture items

mart added a comment. +100, works very well here. an api question. it was supposed to be possible to have the corners with independent radius (to have things like an image rounded only at top) would it still be possible with that approach? i guess would be expanding roundedrectangle to

D28211: [applets/systemtray] Make Pin button a bit larger

mart added a comment. icon comes from plasma theme, which is F8195182: image.png it needs padding REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28211 To: ngraham, #vdg, #plasma, ognarb, mart Cc: mart, ndavis,

D28211: [applets/systemtray] Make Pin button a bit larger

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. wait, if you mean that you want the pin button with 22x22px icon size, this patch is not correct and it should have no size parameters REPOSITORY R120 Plasma Workspace REVISION

D28211: [applets/systemtray] Make Pin button a bit larger

mart added a comment. if the size of that button changes in systray, it muct change in calndar too REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL https://phabricator.kde.org/D28211 To: ngraham, #vdg, #plasma, ognarb Cc: mart,

A new plasma shell: Plasma Bigscreen

be browser app) the core of the qt/plasma mycroft integration is an external project here: https://github.com/MycroftAI/mycroft-gui Questions? comments? -- Marco Martin

monday meeting notes from 23/3/2020

Kai Uwe Notifications: * Ported `knotifyconfig` to use `libcanberra` for its sound preview * Makes the preview consistent with what the notification ends up using for playing the sound, since Phonon supports all sorts of formats but canberra is basically just WAV and OGG qqc2-desktop-style: *

D28194: [WIP] Fix loading button icons from qrc

mart added inline comments. INLINE COMMENTS > kquickstyleitem.cpp:218 > opt->icon = QIcon(icon.value().toLocalFile()); > +} else if (icon.canConvert() && icon.value().scheme() == > QLatin1String("qrc")) { > +const QString iconUrl = icon.value().mid(3); should

D28143: Add "veryLongDuration" animation duration

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. sorry, didn't see the other one REPOSITORY R169 Kirigami BRANCH veryLongDuration (branched from master) REVISION DETAIL https://phabricator.kde.org/D28143 To: ngraham, #vdg, #kirigami,

D28143: Add "veryLongDuration" animation duration

mart added a comment. a problem tough.. this one won't follow system settngs, so globally disabling anoimations won't disable this one it also needs implementing in plasma-framework/src/declarativeimports/kirigamiplasmadesktopstyle/ (where takes values from units.cpp in plasma units,

D28134: Add ColorUtils

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. please no item grabbing in the singlethon. item grabbing is *not* stateless REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #plasma, mart

D28103: Support multiple stacked Passive Notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R169:659324f28ec6: Support multiple stacked Passive Notifications (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28103?vs=77942=77986 REVISION

D28134: Add ColorUtils

mart added a comment. First of all.. I love the idea! :) I wanted something like that, tough i had a slightly different approach.. i find the global average color usually producing a kinda washed down color (from what happens in the plasma mobile app startup screen) For another

D28103: Support multiple stacked Passive Notifications

mart added inline comments. INLINE COMMENTS > broulik wrote in PassiveNotification.qml:35 > Just `padding`? actually, it would make the implicitHeight calculation fail (it's dumb like that and that's why for the new property inset they only added leftInset topInset etcand not a simple inset

D28103: Support multiple stacked Passive Notifications

mart updated this revision to Diff 77942. mart marked 2 inline comments as done. mart added a comment. - fix quick spawning of notifications REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28103?vs=77934=77942 BRANCH mart/passivenotification REVISION

D28103: introduce PassiveNotification type

mart updated this revision to Diff 77934. mart added a comment. - export the item - support multiple notifications - make it a private component again - fix passive notifications for ApplciationItem REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D28103: introduce PassiveNotification type

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:4e596d8bed9c: introduce PassiveNotification type (authored by mart). CHANGED PRIOR TO COMMIT

D28103: introduce PassiveNotification type

mart added a comment. In D28103#629313 , @ngraham wrote: > Didn't this already exist in Kirigami, or am I imagining that? there is ApplicationWindow.showPassiveNotification. it was only accessible by that (and not accessible by kcms)

D28103: introduce PassiveNotification type

mart added a comment. One thing I'm not sure of is whether going this way, with one popup that shows only one notification or having a popup with a listview that can show multiple notifications at once... tough for me an important thing is that this thing does *-NOT* become a full fledged

D28103: introduce PassiveNotification type

mart updated this revision to Diff 77843. mart added a comment. - export the item REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28103?vs=77842=77843 BRANCH mart/passivenotification REVISION DETAIL https://phabricator.kde.org/D28103 AFFECTED FILES

D28103: introduce PassiveNotification type

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY PassiveNotification is a type for small, passive and inline notifications in the app. used to show

monday meeting notes for 16/3/2020

Kai Uwe NOTE: !!! Plasma sprint canceled due to Corona :( !!! gmenu-dbusmenu-proxy: * Fixed radio buttons behavior in menus plasma-browser-integration: * Got bug report about supposed privacy violation but it's again Firefox just leaking file descriptors into the host... KWin: * Made

D28068: Cleanup file resolving

mart added inline comments. INLINE COMMENTS > broulik wrote in kirigamiplugin.h:58 > You sure a `qrc` URL turns into a local path (or rather Qt's internal `:/` > magic path) like this? i think only :/ works? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28068 To:

D28067: check for window existence

This revision was automatically updated to reflect the committed changes. Closed by commit R169:848b5a7345f9: check for window existence (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28067?vs=77708=77710 REVISION DETAIL

D28067: check for window existence

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY not always after componentcompleted a window is already there. if is not there, do the same check

D27984: [WIP] Add a ShadowedRectangle item

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. to me is good, would just change that one thing api wise. do you think there are other blockers from a technical pov or good to go? INLINE COMMENTS > shadowedrectangle.h:15 > +

D27984: [WIP] Add a ShadowedRectangle item

mart added a comment. tested it locally, works beautifully REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27984 To: ahiemstra, #kirigami Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson

Monday meeting notes for 9/3/2020

Kai Uwe: * not much from me, been on vacation last week. other than * PSA: Plasma Sprint in Augsburg next month has been cancelled (delayed due covid precautions) Arjen: * So I started last week by making my own implementation of a screenshot capture tool: Diff 27805 Add a screenshot capture

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

mart added a comment. In D27845#622178 , @ngraham wrote: > Not as touch-friendly, but the clock text looks better and it won't be so huge for people using low-DPI screens. However 38 is not easy to calculate by our existing units so it would

D27782: expose IncludeUsage to QML api

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0775faf25323: expose IncludeUsage to QML api (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27782?vs=76774=76835 REVISION DETAIL

D27782: expose IncludeUsage to QML api

mart updated this revision to Diff 76774. mart added a comment. - rename property to shownItems REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27782?vs=76768=76774 BRANCH phab/exposeusage REVISION DETAIL https://phabricator.kde.org/D27782

D27782: expose IncludeUsage to QML api

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in recentusagemodel.cpp:150 > we have QQmlParserStatus in this class, we probably want to use it. refresh() implementation already has a check on m_completed (which is set on componentCompleted) REPOSITORY R120 Plasma

D27782: expose IncludeUsage to QML api

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY RecentUsageModel can list all aps and docs, only aps or only docs. make possible to control that from

monday meeting notes for 2/3/2020

David E: * Yet more preparing for the plasma-systemd branch. Moving some bits slowly to master * We found and fixed an existing race condition with ksplash * that's all going well * there's some libksysguard stuff on review for exposting process stuff in a more declarative way * as part of a

D24706: [RFC] Change button style

mart added a comment. hmm, buttons look quite.. flat now? there was a lot of discussion on what should be flat and what not. while i think having things a bit flatter doesn't actually hurt, could this be considered an usability issue? REPOSITORY R31 Breeze REVISION DETAIL

D27364: Kirigami: Convert license headers to SPDX markers

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. so in the end is decided that the human readable format should be removed from the header? to me either is fine, just to know what to do in future files REPOSITORY R169 Kirigami BRANCH

D27481: Panel spacer that can center things

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7b3b06a48576: Panel spacer that can center things (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=76369=76372 REVISION DETAIL

D27481: Panel spacer that can center things

mart marked 7 inline comments as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in panelconfigview.cpp:115 > Seems like Panel could benefit from some sort of...ContinamentLayoutManager? > > Effectively we're evaluating what RowLayout evaluates by hand here anyway, it

D27481: Panel spacer that can center things

mart updated this revision to Diff 76369. mart added a comment. - take maximum size into account - document -1 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=75990=76369 BRANCH mart/panelSpacer REVISION DETAIL

Re: monday meeting notes for 24/2/2020

Aand, forgot my part :) * was away on friday, worked mostly on otherstuff, but plasma related things are # Plasma * continued with the panel centering spacer, i think is pretty much ready: https://phabricator.kde.org/D27481 * continued layout fixing for plasmacomponents3 buttons:

monday meeting notes for 24/2/2020

David R * I investigated wy sometimes icon were not colored correctly when plasma theme and color scheme were different Diff 27589 "Try to apply the colorscheme of the current theme to QIcons" [Accepted] https://phabricator.kde.org/D27589 * Maybe needs some implementation critique since it

D27449: [applets/mediacontroller] Fix Playback button icon sizes

mart added a comment. so: the latest, long discussed buttons revision is to have button icons that can scale automatically downand up to the "small" (and smallmedium for toolbuttons) size, as this is the behavior of qwidget buttons, and the goal at some point was to make the controls in

D27260: [applets/systemtray] Set pin button's size correctly

mart closed this revision. mart added a comment. this has been superseeded by R242:ba0b637de94a REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27260 To: ngraham, #plasma, ndavis

D27189: Created a top area based on widgets/toparea.svg

mart added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:48 > +fill: parent > +leftMargin: -dialog.margins.left > +topMargin: -dialog.margins.top not in all places you will have access to a dialog. the magic correct values should

D27481: Panel spacer that can center things

mart added a comment. In D27481#614250 , @davidre wrote: > In D27481#614167 , @davidre wrote: > > > I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but

D27481: Panel spacer that can center things

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in panelconfigview.cpp:115 > why is this a script? so, i need to add the second spacer at first position rather than the last. I don't think i can do this without a script, as i need to access the qquickitem to actually set a

D27481: Panel spacer that can center things

mart added a comment. In D27481#614250 , @davidre wrote: > In D27481#614167 , @davidre wrote: > > > I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but

D27481: Panel spacer that can center things

mart added a comment. In D27481#614250 , @davidre wrote: > In D27481#614167 , @davidre wrote: > > > I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but

D27481: Panel spacer that can center things

mart updated this revision to Diff 75990. mart added a comment. - bigger in edit mode REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=75988=75990 BRANCH mart/panelSpacer REVISION DETAIL https://phabricator.kde.org/D27481 AFFECTED

D27481: [WIP]Panel spacer that can center things

mart added a comment. demo of adding 2 spacers and centering mode F8112648: vokoscreen-2020-02-19_13-43-02.mp4 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27481 To: mart, #plasma, #vdg Cc: broulik, ngraham,

D27481: [WIP]Panel spacer that can center things

mart updated this revision to Diff 75988. mart added a comment. - put the second spacer at the beginning REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=75980=75988 BRANCH mart/panelSpacer REVISION DETAIL

D27481: [WIP]Panel spacer that can center things

mart updated this revision to Diff 75980. mart marked 3 inline comments as done. mart added a comment. - use a binding - use twinlayouts only when both are expanding REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27481?vs=75925=75980 BRANCH

D27481: [WIP]Panel spacer that can center things

mart added inline comments. INLINE COMMENTS > broulik wrote in main.qml:30 > Why that? no idea, is from the old applet and appears useless (also phab gets confused and doesn't understand the move of main.qml to a subfolder) > broulik wrote in main.qml:77 > Does `Qt.callLater(foo)` work? It

D27481: [WIP]Panel spacer that can center things

mart added a comment. Implementation-wise could make sense for the implementation be in the panel itself, tough it may be difficult to control from the external panel configuration tool Usability-wise i think would be fine if the first spacer is added at the end of the panel, and the

D27481: [WIP]Panel spacer that can center things

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY - Make the panel spacer take a lot more space when is in expanding mode, so much to "win"

Monday meeting notes from 17/2/2020

Kai Uwe: Notifications: * File transfer labels in details section only grow, never shrink * Keeps the dialog from constantly resizing when copying many small files * Fixed Telegram to check action ID when invoked, in preparation for new quick reply API using the action signal instead *

Re: Plasma 5.18 release post-mortem

put too much in this release: it's pretty buggy but also the one that came in with more new features since quite a while. which in retrospect wasn't that good for an lts -- Marco Martin

monday meeting notes for 10/2/2020

Kai Uwe: Notifications: * Started a thread on standardizing the inline-reply feature on XDG mailing list * https://lists.freedesktop.org/archives/xdg/2020-February/014227.html * The spec we came up with is incompatible with what I added in 5.18 but seems generally nicer * Will update

D27212: Have pullback toolbars on scrollable pages also for footers

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. almost there, just two minor nitpicks INLINE COMMENTS > AbstractApplicationHeader.qml:24 > import org.kde.kirigami 2.4 > - > +import QtQuick.Controls 2.7 as Controls > the

D27251: Relicense to LGPL-2.0-or-later

mart added a comment. I'm fine with it. should it be 2.0 or later or 2.1 or later? (I'm ok for whatever makes everyone's life easier) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27251 To: cordlandwehr, mart Cc: plasma-devel, fbampaloukas, GB_2, domson,

D27170: delay show window

This revision was automatically updated to reflect the committed changes. Closed by commit R124:e63bb075db8d: delay show window (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27170?vs=75054=75063 REVISION DETAIL

D27170: delay show window

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY show the window only after mainWidget() of the view has been called. mainWidget creates the ui on

D14562: Introduce Theme.smallestFont

mart added inline comments. INLINE COMMENTS > volkov wrote in kirigamiplugin.cpp:173 > So, should it be registered for both versions 2.2 and 2.6? > I tried to use revisions, but it looks like they don't work for properties of > attached property objects: >

D21226: search for a default wallpaper in lookandfeel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:670f3ec50456: search for a default wallpaper in lookandfeel (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21226?vs=58130=74583#toc REPOSITORY R120 Plasma Workspace

D26896: Kill the KinfoCenter binary

This revision was automatically updated to reflect the committed changes. Closed by commit R102:24f4c6f97875: Kill the KinfoCenter binary (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26896?vs=74434=74493#toc REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D26895: Introduce an Info Center mode

This revision was automatically updated to reflect the committed changes. Closed by commit R124:ca28b62000ff: Introduce an Info Center mode (authored by mart). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74491=74492 REVISION DETAIL

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74491. mart added a comment. - better todo message REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74487=74491 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26895 AFFECTED

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74487. mart added a comment. - use mode REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74481=74487 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26895 AFFECTED FILES

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74481. mart added a comment. - remove usekless qdebug REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74422=74481 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26895

D26896: Kill the KinfoCenter binary

mart updated this revision to Diff 74434. mart added a comment. - back to kinfocenter bin name REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26896?vs=74433=74434 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26896

D26896: Kill the KinfoCenter binary

mart updated this revision to Diff 74433. mart added a comment. - link kinfocenter to systemsettings5 REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26896?vs=74308=74433 BRANCH mart/kinfoCenterMode REVISION DETAIL

D26895: Introduce an Info Center mode

mart updated this revision to Diff 74422. mart marked 6 inline comments as done. mart added a comment. - base behavior on executable name REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26895?vs=74307=74422 BRANCH mart/kinfoCenterMode REVISION

D26895: Introduce an Info Center mode

mart added inline comments. INLINE COMMENTS > meven wrote in ModuleView.cpp:349 > We might want to have a different url scheme like "kinfo" insteat of "kcm" > and "org.kde.kinfocenter" instead of "org.kde.systemsettings" that's a good point. Tough, at the moment we don't do anything with the

Notes for 27/01/2020 monday meeting

Kai Uwe: * Wrote a blog post on some of the non-KDE code that still benefits our overall ecosystem I did: https://blog.broulik.de/2020/01/venturing-out/ Notifications: * Added quick reply to Telegram Desktop client \o/ Supposedly that release is already out. * When there is only a reply action,

D26896: Kill the KinfoCenter binary

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Remove the binary, only install the modules and categories. The categories have been reorganized a bit

<    1   2   3   4   5   6   7   8   9   10   >