D24264: edit mode action and dbus

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in appletslayout.cpp:100 > But we only evaluate this when this window changes - doesn't that mean we > could when any other plasma window had focus and then loses it? different approach in

D24264: edit mode action and dbus

mart updated this revision to Diff 67071. mart added a comment. - move logic of out of editmode in shellcorona REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24264?vs=66954=67071 BRANCH mart/editMode REVISION DETAIL

D24265: support global edit mode

mart updated this revision to Diff 67069. mart added a comment. - state machine for right order of opacity and visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=66955=67069 BRANCH mart/editMode REVISION DETAIL

D24264: edit mode action and dbus

mart added a comment. In D24264#538820 , @ngraham wrote: > I wonder if the widget resize handles should become visible all the time when in edit mode. Otherwise nothing visually changes with the widgets on the desktop, and it might not be

monday meeting notes for 30/9/2019

Nico Fe: * Ported Koko to Android * Needs more work to be useful For review: * Diff 24173 "Fix build against exiv for real" [Needs Review] https://phabricator.kde.org/D24173 * Diff 24175 "Don't use KDBusService on Android" [Needs Review] https://phabricator.kde.org/D24175 * Diff 24186 "Request

D24265: support global edit mode

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > mart wrote in ToolBoxButton.qml:286 > latest revision should fix that actually, revision of D24263 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D24265: support global edit mode

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > ngraham wrote in ToolBoxButton.qml:286 > Locking the widgets while in edit mode doesn't update the menu item, so it's > possible to end up in this state: > > F7448695: Screenshot_20190927_111420.png >

D24265: support global edit mode

mart added a comment. yes, it's completely ortogonal to that one REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin,

D24265: support global edit mode

mart added a comment. still has the problem of long press not working with the folderview layout (stolen events) will look into that REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24265: support global edit mode

mart added a comment. F7447783: vokoscreen-2019-09-27_17-03-51.mp4 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24265: support global edit mode

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY desktop and panel toolboxes are only visible in "edit mode" edit mode can be triggered by - long

D24264: edit mode action and dbus

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY edit mode menu action edit mode dbus property for systemsettings containmentlayoutmanager goes out of

D24208: [Notifications] Dodge Plasma dialogs

mart accepted this revision. mart added a comment. this may be good in both .17 and master, then to see if is possible, only in master to actually move the notivications out of the way REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24208 To: broulik,

D24208: [Notifications] Dodge Plasma dialogs

mart added a comment. In D24208#538239 , @ngraham wrote: > This works great! > > Instead of temporarily hiding the pop-ups, maybe it should appear above the dialog? Not a huge deal though. > > 5.17 branch? would make sense...

D23274: Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#538369 , @ngraham wrote: > I could get behind always having an "app-global" hamburger menu on the left when the menubar isn't shown, but this would require implementing the same pattern for every app, by putting

D23274: Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#538334 , @ngraham wrote: > In D23274#538315 , @mart wrote: > > > In D23274#537633 , @ngraham wrote: > > > > > Yeah I

D23274: Add "Show intro page" button to System Settings sidebar

mart reopened this revision. mart added a comment. This revision is now accepted and ready to land. In D23274#537633 , @ngraham wrote: > Yeah I would say so. i strongly disagree, it's the opposite of every other kirigami app, and i

D23274: Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#537632 , @GB_2 wrote: > Shouldn't the "Show intro page" button be on the left, like in Discover, and the hamburger menu button on the right, like in for example Dolphin? (#consistency

D24246: Only show panel toolbox when desktop toolbox is open

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. no. this is in progress in a feature branch already REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24246 To: GB_2, #plasma, #vdg, ngraham, mart

D24224: Start of the accessibility KCM

mart added inline comments. INLINE COMMENTS > Bell.qml:27 > + > +ColumnLayout { > +QQC2.GroupBox { Shouldn't use groupboxes at all, but just FormLayouts with sections Kirigami.FormLayout { Item{ Kirigami.formData.title: i18n("Audible Bell")

D24224: Start of the accessibility KCM

mart added a comment. Visually, it looks exactly like the old one, but in qml.. which gives it several layouting problems Since is tabbed (vdg should be contacted tough to see if they don't have a different option other than tabbed) it should use https://phabricator.kde.org/D23835 (which

D24187: Start of the accessibility KCM

mart added a comment. "file:///mnt/storage/diau/kde5/share/kpackage/kcms/kcmaccess/contents/ui/main.qml" "Error loading QML file.\n55: Type KeyboardFilters unavailable\n35: id is not unique\n" INLINE COMMENTS > CMakeLists.txt:26 > > -install(TARGETS kcm_access DESTINATION

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart updated this revision to Diff 66806. mart added a comment. - correctly hide subcat column REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=66780=66806 BRANCH arcpatch-D23274 REVISION DETAIL https://phabricator.kde.org/D23274

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

mart added a comment. we have to depend from 2 qt versions ago as per KDE frameworks policy, so max version that can be used is Qt 5.11 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24193 To: ouwerkerk, mart, #plasma Cc: anthonyfieroni, plasma-devel,

monday meeting notes for 23/9/2019

the drag * fixed wrong margin appearance of qwidget kcms in kcmshell * properly install all controls as plasmacomponents3 -- Marco Martin

D11352: [RFC] Auto ordered systray

mart added a comment. ok for me at beginning of 5.18 cycle, not yet for 5.17 REPOSITORY R120 Plasma Workspace BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel, #vdg, #plasma, mart, ngraham Cc: ognarb, ngraham, wsdfhjxc, mart, plasma-devel, LeGast00n,

D23950: Only show "Add Widgets..." panel context menu option in panel edit mode

mart added a comment. i'm on the fence with that. things can be editable to a certain extent always, like adding or removing widgets, and that should really remain so otherwise... it would be a locked state, really, which behavior i really don't want as default, especially for desktop

D23952: Remove panel toolbox and clean up editing options

mart added a comment. moreover, as i plan to do with the desktop one, it should still be there, just not shown in non-edit mode REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23952 To: GB_2, #plasma, #vdg, mart Cc: mart, ngraham, #vdg, plasma-devel,

D23984: [System Settings] redesign intro page

mart added a comment. overall to me looks a bit less balanced, but if VDG as a whole says it's ok, i'm fine with it. however there are some small things in the code to fix INLINE COMMENTS > davidedmundson wrote in introPage.qml:65 > Hardcoding sizes is generally frowned upon. > > Partly

D23952: Remove panel toolbox and clean up editing options

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. i'm in general not in favor of having only right click. this patch will be fine, only after the global edit mode button will be in systemsettings. That is an absolute blocker for

D23845: Add a mode to center actions and omit the title when using a ToolBar style

mart accepted this revision. mart added a comment. One thing i forgot: how does this look when a title is present? REPOSITORY R169 Kirigami BRANCH optional-centered-actions-with-no-title (branched from master) REVISION DETAIL https://phabricator.kde.org/D23845 To: ngraham, #kirigami,

D23984: [System Settings] redesign intro page

mart added inline comments. INLINE COMMENTS > introPage.qml:82 > +Rectangle { > +property real brightness: (0.2126*Kirigami.Theme.backgroundColor.r + > 0.7152*Kirigami.Theme.backgroundColor.g + > 0.0722*Kirigami.Theme.backgroundColor.b) > +anchors { add in a comment a link

D23845: Add a mode to center actions and omit the title when using a ToolBar style

mart added a comment. Like the concept, API may need a bit of improvement INLINE COMMENTS > PageRow.qml:146 > * * showNavigationButtons: OR flags combination of > ApplicationHeaderStyle.ShowBackButton and > ApplicationHeaderStyle.ShowForwardButton > + * *

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

mart added a comment. please, include screenshots REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

mart added inline comments. INLINE COMMENTS > main.qml:33 > + > +QtControls.Label { > +text: i18n("File Search helps you quickly locate all your files > based on their content") should use a Kirigami.FormLayout to have checkboxes centered? REPOSITORY R119 Plasma Desktop

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. any updates on this? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

Monday meeting notes for 2/9/2019

Nicofee: * Killed the phonon KCM * Patched Pulseaudio to not load module-device-manager for us * This means we should be able to use switch-on-connect by default * Debugged an issue in PA. Profiles that weren't actually useful were still marked as available. Apparently this is already fixed in

D23461: Remove 'magic' filtering of recent apps

mart added a comment. but good to split the patch and push #1 first and discuss separatedly #2 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23461 To: tcanabrava, hein, davidedmundson Cc: mart, ngraham, davidedmundson, plasma-devel, LeGast00n,

D23461: Remove 'magic' filtering of recent apps

mart added a comment. It does introduce a bahavior change in kicker, tough we tought that ux-wise it was a really bad behavior that ought to be "fixed" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23461 To: tcanabrava, hein, davidedmundson Cc: mart,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#520185 , @GB_2 wrote: > In D23274#520127 , @mart wrote: > > > SidebarMode::setActiveCategory may need to be modified to make it like it tough > > > Looks like

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. SidebarMode::setActiveCategory may need to be modified to make it like it tough REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#519661 , @GB_2 wrote: > This is what happens when you set the current index to -1: F7282553: System Settings Sidebar Show Intro Page Button Bug.png did you also try

Plasma BoF at Akademy

Hi all, for everybody that plans being present at the plasma Bof at Akademy, I made an etherpad https://notes.kde.org/p/Akademy2019PlasmaBof if (and only if) you plan to be there, please add topics you would like being discussed (with your name near the point) -- Marco Martin

D23288: Move XResources out of the central model into a plugin

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in xres.h:1 > I've used #pragma once all over the place already, hasn't seemed to cause an > issue. I use it quite a lot as well. If it has problems better to know it before it spreads too much ;) is not standard but appears

Monday meeting notes for 26/8/2019

Kai Uwe plasma-browser-integration: * Threshold for controlling short videos has been increased from 5s to 8s * Failure error message has been removed in favor of a toolbar icon with popup * Enhanced media controls are enabled by default now * Minor improvements and reliability fixes for tabs

D22514: Show if KRunner is still searching for more things

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in RunCommand.qml:86 > There was some code to make that magically work. > > (maybe it was that URLInterceptor we removed?) > > If it doesn't work, then just ignore me. > (maybe it was that URLInterceptor we removed?) yep :)

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. there *may* be some changes needing to be done on SidebarMode::setActiveCategory for that to work, but try to do that, then wel'll see REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: mart, #vdg,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

mart added a comment. when the intro page gets shown, (again binded from a bool property arriving from c++) categoryView.currentIndex should be set to -1, and systemsettings.activeCategory to -1 as well INLINE COMMENTS > SidebarMode.cpp:424 > > +void SidebarMode::showIntroPage() > +{

D23154: allow to set custom icon for the left drawer handle

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. it's ok, doesn't add public properties REPOSITORY R169 Kirigami BRANCH left-drawer-handle-custom-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D23154 To:

D23154: allow to set custom icon for the left drawer handle

mart added inline comments. INLINE COMMENTS > OverlayDrawer.qml:111 > } > switch(edge) { > case Qt.LeftEdge: you can write it more compact and avoid code duplication, you can do: if (root.handleClosedIcon.source &&

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

mart added inline comments. INLINE COMMENTS > Action.qml:27 > * > * @inherit QtObject > */ @inherit QtQuick.Controls.Action > Action.qml:76 > */ > -property ActionIconGroup icon: ActionIconGroup { > -id: iconGroup > -} > +// property ActionIconGroup icon:

D23049: Add Kirigami ListSectionHeader component

mart added inline comments. INLINE COMMENTS > ListSectionHeader.qml:92 > + > +Component.onCompleted: { > +for (var i = 0; i < customItems.length; i++) { This is a no-go hack: those customItems shouldn't be reparented, but rather the property should be an alias to the data

D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

mart accepted this revision. mart added a comment. Cool, tough I'm a bit hesitant on using qt.labs.platform as it may break any moment in any future release REPOSITORY R124 System Settings BRANCH port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent (branched from

D22879: Rename "Look and Feel" KCM to "Global Theme"

mart accepted this revision. mart added a comment. fine for me if this and the store are changed simultaneously, and *no* internal name is changed anywhere (folder names, plugin names and so on) REPOSITORY R119 Plasma Desktop BRANCH lnf-to-global (branched from master) REVISION DETAIL

D23031: more control on what shell is loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R120:69451047c0a3: more control on what shell is loaded (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23031?vs=63358=63367 REVISION

D23031: more control on what shell is loaded

mart added a comment. alternative to https://phabricator.kde.org/D23023 not sure what's better REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23031 To: mart, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23023: more control on what shell is loaded

mart added a comment. https://phabricator.kde.org/D23031 has a config file approach REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23023 To: mart, #plasma Cc: apol, bshah, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D23031: more control on what shell is loaded

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Since shellManager was removed, we have a quite big regressions of any other shell that isn't the

D23023: more control on what shell is loaded

mart updated this revision to Diff 63357. mart added a comment. - name it KDE_PLASMA_DEFAULT_SHELLPACKAGE REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23023?vs=63343=63357 BRANCH phab/plasmashellenv REVISION DETAIL

D23023: more control on what shell is loaded

mart added a comment. While i wouldn't mind for that feature to get back, using a temporary file wouldn't work, because as soon you have a crash and auto restart you get again on the default desktop shell. to make the env var more clear, i would call it KDE_PLASMA_DEFAULT_SHELLPACKAGE

D23023: more control on what shell is loaded

mart updated this revision to Diff 63343. mart added a comment. - KDE_PLASMA_SHELLPACKAGE REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23023?vs=63340=63343 BRANCH phab/plasmashellenv REVISION DETAIL https://phabricator.kde.org/D23023

D23023: more control on what shell is loaded

mart created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Since shellManager was removed, we have a quite big regressions of any other shell that isn't the desktop one not loading in any way

D22974: Allow usage of QQC2 actions on Kirigami components and now make K.Action based on QQC2.Action

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. good direction, unfortunately we can't remove the custom toolbutton contentitem yet, so for now let's keep the custom icon group INLINE COMMENTS > camiloh wrote in Action.qml:76 >

D22893: introduce the Defaults group for panel values

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9fa4d9417ca0: introduce the Defaults group for panel values (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22893?vs=62973=63161

D22893: introduce the Defaults group for panel values

mart added inline comments. INLINE COMMENTS > apol wrote in panel.cpp:249 > Doesn't restore need calling now? No. Before was setting the config key, and then called restore to actually sync the internal panel status with the new config. Now is setting directly the panel status, so restore

D22893: introduce the Defaults group for panel values

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY when plasma is starting up, there are no panel views yet this means that if a thickness (or other

D22867: Consistently use Units.toolTipDelay instead of hardcoded values

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. thanks! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D22867 To: hein, #frameworks, mart Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol,

notes for 29/7/2019 monday meeting

Kai Uwe: * Wrote a new model backing Milou/KRunner which avoids resetting the entire list every time results change * Improves performance, especially when dealing with results that hardly change (e.g. calculator) * Keeps the selection steady as results come in delayed and shift the

D22648: make handle follow arbitrary height of the drawer

mart added inline comments. INLINE COMMENTS > OverlayDrawer.qml:210 > +if(root.height < applicationWindow().height) { > +margin = applicationWindow().height - root.height - > root.y + Units.smallSpacing; > +} applicationWindow() should be

D22652: Desktop scripting: support args

This revision was automatically updated to reflect the committed changes. Closed by commit R120:dbd2cd472153: Desktop scripting: support args (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22652?vs=62312=62314 REVISION DETAIL

D22652: Desktop scripting: support args

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY support args in applet creation with an optional argument to containment::addWidget scripts not using

D22035: Port FolderView to ContainmentLayoutManager plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f3d914c0fafc: Port FolderView to ContainmentLayoutManager plugin (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22035?vs=61988=62269#toc REPOSITORY R119 Plasma Desktop

D22034: Introduce ContainmentLayoutManager QML plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f59aecbcfec6: Introduce ContainmentLayoutManager QML plugin (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61987=62268

D22035: Port FolderView to ContainmentLayoutManager plugin

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in ConfigOverlay.qml:171 > why do we do it explicitly here, but backed by a timer for movement? This is after being rotated, when changing rotation of an item the same doesn't get invoked automatically REPOSITORY R119 Plasma

D22035: Port FolderView to ContainmentLayoutManager plugin

mart updated this revision to Diff 61988. mart marked an inline comment as done. mart added a comment. - remove leftovers REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=61974=61988 BRANCH mart/newlayout REVISION DETAIL

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61987. mart marked an inline comment as done. mart added a comment. - set the item container directly REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61976=61987 BRANCH mart/containmentlayoutmanager

D22034: Introduce ContainmentLayoutManager QML plugin

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > davidedmundson wrote in itemcontainer.cpp:438 > If we want to use this in the panel/wherever we need ItemContainer to forward > the full min/preferred/max sizes (with margins added) and have the >

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61976. mart marked 3 inline comments as done. mart added a comment. - no manual parenting - move the reaction to size hints in layoutmanager REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61973=61976

D22035: Port FolderView to ContainmentLayoutManager plugin

mart updated this revision to Diff 61974. mart added a comment. - use the locked editmodecondition REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=61577=61974 BRANCH mart/newlayout REVISION DETAIL https://phabricator.kde.org/D22035

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61973. mart added a comment. - better manage locked plasmoid logic REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61966=61973 BRANCH mart/containmentlayoutmanager REVISION DETAIL

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61966. mart marked 5 inline comments as done. mart added a comment. - singal when can't resize - make resize work with items that update hints while resizing - use setPosition and setSize where possible - make sure to connect to busy indicator - don't

D22034: Introduce ContainmentLayoutManager QML plugin

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in abstractlayoutmanager.h:44 > I don't fully understand the split between AbstractLayoutManager and > GridLayoutManager when AbstractLayoutManager effectively enforces a grid by > having cell sizes. in the end it needed cell

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61786. mart added a comment. - never auto resize while on edit mode - try to restore size as soon as possible REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61642=61786 BRANCH

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61642. mart added a comment. - manage differently screen resize and other kind of resizes - fix snapping on RTL and BTT positioning REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61576=61642 BRANCH

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61576. mart added a comment. - allow a limited auto expanding for applets - click on empty areas always closes edit mode - wire up maximum size - start on a new logic for default sizes - event comppress sizehints - take minimum size into account -

D22035: Port FolderView to ContainmentLayoutManager plugin

mart updated this revision to Diff 61577. mart added a comment. - adapt to api change - add migration script REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=60493=61577 BRANCH mart/newlayout REVISION DETAIL

D22341: [mobile/wifi] Port to SimpleKCM

mart accepted this revision. mart added a comment. LGTM, still needs approval by Jan REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D22341 To: nicolasfella, #plasma, mart, jgrulich Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

notes for meeting of 8/07/2019

Roman: * I am at the moment refactoring the Compositor class: https://phabricator.kde.org/T11071 Already multiple patches landed last week. Thx zzag for reviews. Two more are currently in review including the split of the class into X11 and Wayland subclasses. I want to merge these today. I could

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

mart added a comment. In D22138#491173 , @hpereiradacosta wrote: > Indeed. This is a problem. As soon as treeviews are animated Qt makes a pixmap copy of the treeview viewport. This does not include the blue line on the side, which is painted

Re: Technical Advise for PlasmaQuick::ContainmentView [Latte]

On Mon, Jul 1, 2019 at 12:20 PM Michail Vourlakos wrote: > > Thank for the response Martin, > I ended up recreating the View and does the trick but that has some downsides > from accessibility and user point of view... > > > in order to do that i guess some new api is needed in AppletQuickItem

Re: notes for monday meeting 1/7/2019

whops, forgot: Tomaz Canabrava: * work on Konsole, maintaining and bugfix On Mon, Jul 1, 2019 at 12:43 PM Marco Martin wrote: > > David: > * at the plasma sprint > * ok so, not only is Qt5.13.0 wayland completely broken > so is 5.12.4 > * I've fixed all upstream, but I'll ne

notes for monday meeting 1/7/2019

David: * at the plasma sprint * ok so, not only is Qt5.13.0 wayland completely broken so is 5.12.4 * I've fixed all upstream, but I'll need to do some work with packagers to avoid this becoming an issue I think. * SHM buffers after show/restore due to one bug (so all QMenus) * And QtQuick buffers

Re: Technical Advise for PlasmaQuick::ContainmentView [Latte]

thod (callable only from c++, not qml) that would do the same with the internal qmlobject (which is kindof the api of qquickview, but without a window) to itself and all eventual applet children (in case it's a containment) Would you be interested looking into that? -- Marco Martin

D20908: RFC: Redesign QML applet configuration windows

mart added a comment. In D20908#485103 , @filipf wrote: > Preview of a highlight style in line with what's being discussed in T11124 : > > F6927189: image.png > >

D21999: [WIP] Make highlights similar to Kickoff highlight

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R31:b61b97dc6b5b: Make context menu highlight similar to Kickoff highlight (authored by ndavis, committed by mart).

D21829: Improved Touch support for Kickoff

mart added a comment. not entering in the code yet, i'm ok with it as a general UX behavior REPOSITORY R119 Plasma Desktop BRANCH kickoff REVISION DETAIL https://phabricator.kde.org/D21829 To: steffenh, #plasma, hein, ngraham Cc: mart, sbergeron, davidedmundson, ngraham,

D22035: Port FolderView to ContainmentLayoutManager plugin

mart updated this revision to Diff 60493. mart added a comment. - remove dead code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=60461=60493 BRANCH mart/newlayout REVISION DETAIL https://phabricator.kde.org/D22035 AFFECTED FILES

D22035: Port FolderView to ContainmentLayoutManager plugin

mart added a comment. Before: F6927347: Screenshot_20190623_140805.png After: F6927342: Screenshot_20190623_140647.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22035

D22035: first prototype of port to the new C++ layout code

mart updated this revision to Diff 60461. mart added a comment. - no automatic edit mode for now REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=60460=60461 BRANCH mart/newlayout REVISION DETAIL https://phabricator.kde.org/D22035

D22035: first prototype of port to the new C++ layout code

mart created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY sync edit mode bigger applet handles on touch interaction remove dead code folderViewLayer child of appletsLayout

<    2   3   4   5   6   7   8   9   10   11   >