D22418: WIP [wayland] make automatic backend selection truly automatic

2019-07-20 Thread Martin Flöser
graesslin added a comment. I'm not convinced that removing the ifdef is the solution to the problem. What you basically want is being able to do an out-of-tree build of a backend. Ideally you would want to install all the variants next to each other and be able to pick the correct one.

D22418: wayland: make automatic backend selection truly automatic

2019-07-13 Thread Martin Flöser
graesslin added a comment. Is there a real world situation where KWin is getting compiled twice with different settings? When adding the ifdefs this was based on feedback from distributions REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22418 To: alexeymin, romangg,

Re: RFC: Running clang-format across all Plasma (and more?) repos

2019-07-12 Thread Martin Flöser
Am 2019-07-11 16:18, schrieb David Edmundson: One topic discussed at the recent Plasma sprint was that we should run a code formatting tool (clang-format) over all our repos to ease all future review comments about whitespace. All new contributions simply have to run the same tool and we get

Re: Proposal: passing user idle time to systemd-logind

2019-05-27 Thread Martin Flöser
Am 2019-05-24 21:51, schrieb Aleix Pol: On Wed, May 22, 2019 at 6:13 PM Germano Massullo wrote: Hello, I am writing to you to propose the following reasoning, hoping that it can help making easier (just a bit) third parties development work on Linux. I am currently developing BOINC client

D18564: Remove support for KWin's QPA plugin for KWindowSystem

2019-01-27 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY KWin added a plugin for itself, thus it's no longer needed. See:

D16945: Fix fallback to built-in ui

2019-01-12 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R133:dfd02160746b: Fix fallback to built-in ui (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16945?vs=45744=49330 REVISION DETAIL

D16943: Disable kcrash in greeter in same way as in KWin

2019-01-12 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R133:552932c8baab: Disable kcrash in greeter in same way as in KWin (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16943?vs=45629=49329

D17659: Set parent window for dialogs

2019-01-09 Thread Martin Flöser
graesslin added a comment. In D17659#389728 , @volkov wrote: > I mean this plugin: https://cgit.kde.org/kwin.git/tree/plugins/qpa That is KWin's own plugin. No binary except KWin can use it. REPOSITORY R838 Flatpak Support: KDE Portal

D17706: Fix lock screen focus

2019-01-09 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > greeterapp.cpp:460 > // w->setFocus(Qt::OtherFocusReason); // FIXME > +w->setFlags(w->flags() | Qt::X11BypassWindowManagerHint); > } David already said it: we cannot do this. Changing the X11BypassWindowManagerHint flag after the

D17659: Set parent window for dialogs

2018-12-26 Thread Martin Flöser
graesslin added a comment. In D17659#379912 , @volkov wrote: > Is it possible to implement support for foreign windows in KWin QPA plugin? There is no such thing as a KWin QPA. REPOSITORY R838 Flatpak Support: KDE Portal for XDG

D17758: Disable KDE ServerDecoration on Qt > 5.12

2018-12-23 Thread Martin Flöser
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. I still have Qt 5.11, so I'll try to compile the change and give it a try. INLINE COMMENTS > kwaylandintegration.cpp:127 > + > +if (QLibraryInfo::version() >= QVersionNumber(5,

D17659: Set parent window for dialogs

2018-12-19 Thread Martin Flöser
graesslin added a comment. In D17659#379007 , @apol wrote: > LGTM, I also missed this! > > Maybe it would make sense to add a TODO about implementing it for Wayland? Even better would be to just implement it for Wayland.

D17217: Implement free memory notifier

2018-11-28 Thread Martin Flöser
graesslin added a comment. I don't think that this is useful - sorry. I run out of memory about once every five years, so polling every five seconds is way too often and a waste of resources. On the other hand the time when it happens polling 5 sec is way too low as then we are already

D16945: Fix fallback to built-in ui

2018-11-18 Thread Martin Flöser
graesslin updated this revision to Diff 45744. graesslin added a comment. Adjust in the way David suggested. REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16945?vs=45633=45744 BRANCH fix-fallback REVISION DETAIL

D16945: Fix fallback to built-in ui

2018-11-17 Thread Martin Flöser
graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY If the lock screen package is not available m_mainQmlPath is an empty URL. Thus

D16943: Disable kcrash in greeter in same way as in KWin

2018-11-17 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY When running KWin's lock screen test I saw: KCrash: crashing...

D16897: Allow windows to be closed from the window switchers

2018-11-16 Thread Martin Flöser
graesslin added a comment. In D16897#359912 , @ngraham wrote: > In D16897#359911 , @graesslin wrote: > > > In D16897#359900 , @ngraham wrote: > > > >

D16897: Allow windows to be closed from the window switchers

2018-11-15 Thread Martin Flöser
graesslin added a comment. In D16897#359900 , @ngraham wrote: > Good point, guys. I'll start with `StandardKey.Close` for now and see about making the KWin changes later (I'll admit I'm a bit intimidated by KWin's codebase!). I would

D16897: Allow windows to be closed from the window switchers

2018-11-15 Thread Martin Flöser
graesslin added a comment. I agree with David: please don't hardcode the key. Please don't use "W" - it has no meaning in a window manager, it's just the shortcut in some applications, others use Ctrl+Q and localized it could be something completely different. I suggest to implement

D15512: [startplasmacompositor] Add Wayland socket argument

2018-11-14 Thread Martin Flöser
graesslin added a comment. In D15512#359253 , @fvogt wrote: > > KWin doesn't need this functionality and shouldn't have this functionality and it would be difficult to implement. > > Why? That goes entirely against what I and probably many

D15512: [startplasmacompositor] Add Wayland socket argument

2018-11-13 Thread Martin Flöser
graesslin added a comment. KWin does not have functionality to generate the socket. KWin doesn't need this functionality and shouldn't have this functionality and it would be difficult to implement. Given that I fully support this change. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D12997: Add new api to support window tabs

2018-11-06 Thread Martin Flöser
graesslin added a comment. In D12997#354190 , @zzag wrote: > Ping? The code doesn't work yet, the API is still lacking some functionality REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D12997

D16425: Added new Suspend then Hibernate option

2018-10-26 Thread Martin Flöser
graesslin added a comment. I would suggest to turn "suspend then hibernate" into the new suspend. And one just can specify in the ui how long it takes till hibernate (which could also be endless). REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16425 To:

D14949: Add option for whether to show the volume change OSD

2018-10-03 Thread Martin Flöser
graesslin added a comment. It's not about that there are only complaints on Reddit. It's about the user group: do we want to deaign so that the small Reddit community is happy or do we want to design for the rest? Do we want to make the product more complicated (yes that's the result of a

Re: My ksmserver plans

2018-10-01 Thread Martin Flöser
Sounds good! Cheers Martin Am 1. Oktober 2018 13:46:56 MESZ schrieb David Edmundson : >I was making a few ksmserver patches, I thought I should document what >my >long term plans are so the patches make sense. > >https://phabricator.kde.org/T9779 > >It's not an urgent task, so might spread over

D14949: Add option for whether to show the volume change OSD

2018-10-01 Thread Martin Flöser
graesslin added a comment. Please don't introduce options based on what's unpopular on Reddit. REVISION DETAIL https://phabricator.kde.org/D14949 To: anonym, #vdg Cc: graesslin, svenmauch, ngraham, romangg, mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D15410: Handle clients which change window metadata during early startup

2018-09-10 Thread Martin Flöser
graesslin added a comment. I just want to point out that such applications are not ICCCM compliant: This property must be present when the window leaves the Withdrawn state and may be changed only while the window is in the Withdrawn state. Window managers may examine the property only when

D14923: Supress paste in screen locker

2018-08-21 Thread Martin Flöser
graesslin added a comment. In D14923#311845 , @davidedmundson wrote: > > . As a matter of fact the default options of Klipper are also fine. Only if the not default prevent empty clipboard option is used this breaks. > > Code says

D14924: Prevent paste in screen locker (alternative approach)

2018-08-19 Thread Martin Flöser
graesslin added a comment. I like the other solution better as it doesn't depend on Klipper specific behavior. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D14924 To: davidedmundson, #plasma Cc: graesslin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14923: Supress paste in screen locker

2018-08-19 Thread Martin Flöser
graesslin added a comment. I like this solution. As a matter of fact the default options of Klipper are also fine. Only if the not default prevent empty clipboard option is used this breaks. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D14923 To:

Re: KWin tests on FreeBSD all timing out

2018-08-03 Thread Martin Flöser
Am 2018-08-03 12:04, schrieb Ben Cooksley: Hi all, Sometime recently there was a change in the KWin / FreeBSD world which means all KWin tests now fail on FreeBSD, and instead of exiting nicely simply fail with a timeout on the CI system. As a consequence this means KWin builds now tie up

Re: Akademy BOF Topics

2018-08-01 Thread Martin Flöser
Am 2018-08-01 17:01, schrieb David Edmundson: We currently have a bunch of slots booked as general "Plasma". We should split them up into relevant topics people actually want to discuss so people know when to turn up to what. In case there is something you want me to remote participate: I can

Re: KDE Connect clipboard integration doesn't work on Wayland

2018-08-01 Thread Martin Flöser
Am 2018-08-01 17:43, schrieb Aleix Pol: Hey, One of the most useful features in KDE Connect is the clipboard integration, this is not working currently. I'm guessing it's a privileges issue, I was wondering if it would maybe be possible to fix it by doing something like we're doing for fake

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

2018-07-21 Thread Martin Flöser
graesslin added a comment. What's really strange is that requestShowTooltip comes from the event loop. But nothing in kdecoration or in KWin goes through a queued event to KWin::Decoration::DecoratedClientImpl::requestShowToolTip. Could it be a decoration plugin causing this?

D14264: Disconnect decoration button requestHover tooltip on decoration destuction

2018-07-21 Thread Martin Flöser
graesslin added a comment. The hovered state cannot change if there is no decoration. Hover is from an event handler from Decoration. I doubt that this change here can fix the crash. Also that's the explanation for the update slot not checking: no hover change if there's no decoration.

Re: Discussion for Virtual Desktops and Activities future

2018-07-15 Thread Martin Flöser
Hi all, just chiming in to give some KWin perspective. Activities are weird and we (Thomas and I) never knew what they are and how we should integrate them in KWin. The existing code is just a bad copy of virtual desktops (bad because it copied the code 1:1 without understanding what it does

Re: Raising windows on Wayland

2018-07-03 Thread Martin Flöser
Am 2018-07-03 18:58, schrieb David Edmundson: Ideally this needs to be standardized so that it does not only work with our applications but with any. Even within just KDE apps, we have code like QDesktopServices spawning links in code we can't manipulate. Anything non standard, simply

Re: Raising windows on Wayland

2018-07-03 Thread Martin Flöser
Am 2018-07-03 18:41, schrieb Aleix Pol: On Tue, Jul 3, 2018 at 6:32 PM Martin Flöser wrote: Am 2018-07-03 18:05, schrieb Aleix Pol: > On Tue, Jul 3, 2018 at 6:02 PM Martin Flöser > wrote: >> >> Am 2018-07-03 14:45, schrieb Aleix Pol: >> > Dear kwiners, >> >

Re: Raising windows on Wayland

2018-07-03 Thread Martin Flöser
Am 2018-07-03 18:05, schrieb Aleix Pol: On Tue, Jul 3, 2018 at 6:02 PM Martin Flöser wrote: Am 2018-07-03 14:45, schrieb Aleix Pol: > Dear kwiners, > Would it be possible to find a way to do so? > > I know we don't want windows to be positioning themselves willy-nilly > on t

Re: Raising windows on Wayland

2018-07-03 Thread Martin Flöser
Am 2018-07-03 14:45, schrieb Aleix Pol: Dear kwiners, Would it be possible to find a way to do so? I know we don't want windows to be positioning themselves willy-nilly on the window stack, but we certainly need to figure out his use-case. What would need to happen to do this? If you need to,

D13481: Recommend window border size "None"

2018-06-25 Thread Martin Flöser
graesslin added a comment. Nate, I cannot believe what I read here. Every week you do a blog post about usability. In other reviews you draw the usability card so often that it annoys me. And here you want to break user setups and break with "form follows function". This is absolutely

D13481: Recommend window border size "None"

2018-06-25 Thread Martin Flöser
graesslin added a comment. In D13481#282653 , @mart wrote: > In D13481#280767 , @romangg wrote: > > > What I thought of as a solution back when it happened was to check if it's a single click on

D13481: Recommend window border size "None"

2018-06-23 Thread Martin Flöser
graesslin added a comment. Please don't play with the users. I would have never pushed a change to test how things work. They are not our testbed. That it worked on other platforms doesn't mean a thing. Maybe that other platform cannot even run into the dead zone situation. My point

D13481: Recommend window border size "None"

2018-06-21 Thread Martin Flöser
graesslin added a comment. To everyone here: you are extremely experienced developers and software users, partially working in the window manager area. Of course you understand why the dead zone happens and of course you are able to adapt to it. But please think of your users. I fear they

D13481: Recommend window border size "None"

2018-06-21 Thread Martin Flöser
graesslin added a comment. In D13481#280754 , @ngraham wrote: > Right. That's not a workflow I think I've ever seen anyone do with a windowed game. Did you read my comment? Let me quote: "please don't tell me that nobody would use a fps

D13481: Recommend window border size "None"

2018-06-20 Thread Martin Flöser
graesslin added a comment. In D13481#279575 , @davidedmundson wrote: > There are two visual hints when the mouse is inside the deadzone. > > You would still get the different cursor > The client gets the mouse left event and would not

D13481: Recommend window border size "None"

2018-06-18 Thread Martin Flöser
graesslin added a comment. I realized that there's yet another problem with the approach: if two windows border and the window with pointer focus is lower in the stacking order this would create a dead zone in the window. With compositing disabled this would be worse as there's not even a

Re: Stepping down as maintainer

2018-06-03 Thread Martin Flöser
Am 2018-06-02 13:43, schrieb Eike Hein: To establish the full extent of the range opinions here: Personally I think the VDG has been working very well lately, and I want to thank its members for being some of the most hard-working and motivated contributors to Plasma today. They've made my work

Re: Stepping down as maintainer

2018-06-03 Thread Martin Flöser
Am 2018-06-02 16:15, schrieb David Edmundson: Fair enough. On the day to day side. ZZag's and Anemeth have both been doing an amazing job lately on the effects. I'll continue on anything wrt rendering + wayland, hopefully Roman can tackle anything on input and DRM. Hopefully Thomas L will

Re: Stepping down as maintainer

2018-06-03 Thread Martin Flöser
Am 2018-06-02 10:59, schrieb Roman Gilg: Hi Martin, first of all thank you! KWin is an amazing piece of software and we owe this to a huge part to you. Regarding your decision to step down as maintainer I hope you reconsider though. No, that decision is final. It's not that I decided

Stepping down as maintainer

2018-06-02 Thread Martin Flöser
Hi all, After long consideration I decided that I am no longer in a position to be a maintainer. I currently do not follow up on reviews and hardly contribute any code. Given that I think it's time to pass on the torch. KWin is currently in a good position we have new developers working on

D13062: Don't manipulate foreign windows

2018-05-23 Thread Martin Flöser
graesslin accepted this revision. graesslin added a comment. Please as bugfix to 5.12 branch. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D13062 To: broulik, #plasma, davidedmundson, graesslin Cc: graesslin, plasma-devel,

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

2018-05-20 Thread Martin Flöser
graesslin added a comment. Restricted Application added a subscriber: kde-frameworks-devel. any update on this? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7038 To: romangg, #frameworks, graesslin Cc: kde-frameworks-devel, graesslin, plasma-devel, ragreen,

D12997: Add new api to support window tabs

2018-05-20 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY The new API basically just provides a vector of

Re: When kwin_wayland crashes

2018-05-17 Thread Martin Flöser
Am 2018-05-17 16:32, schrieb Aleix Pol: Hey, Here's an issue I've seen and I'm pretty sure you've seen too. For any reason kwin crashes. SDDM kills the whole session and jumps back to the login UI Tue 2018-05-15 15:22:30 CEST669 1000 1000 11 truncated

Re: Cursor sizes on wayland

2018-05-13 Thread Martin Flöser
Am 2018-05-09 12:08, schrieb Aleix Pol: On Tue, May 8, 2018 at 8:57 PM, Martin Flöser <mgraess...@kde.org> wrote: Am 8. Mai 2018 17:05:57 MESZ schrieb Aleix Pol <aleix...@kde.org>: Hi, I've been looking into getting a consistent cursor look on wayland, which is specially daun

Re: Cursor sizes on wayland

2018-05-08 Thread Martin Flöser
Am 8. Mai 2018 17:05:57 MESZ schrieb Aleix Pol : >Hi, >I've been looking into getting a consistent cursor look on wayland, >which is specially daunting because of scaling. > >I'd like to look into fixing it for xwayland clients. Would somebody >be able to shed some light into

Re: Late API change to KWayland for upcoming Frameworks release

2018-05-02 Thread Martin Flöser
Am 2018-05-02 06:19, schrieb Roman Gilg: I have the following patch to KWayland adding a property for per OutputDevcie color correction via color curve adjustment: https://phabricator.kde.org/D12388 The problem is that Frameworks tag is on Saturday, but if the patch does not get in with next

D12539: Klipper: Do not insert secret data into history

2018-04-27 Thread Martin Flöser
graesslin added a comment. In D12539#254330 , @broulik wrote: > > And it's probably something we also want to add to KWallet and maybe every password field we have. > > Since when can you Copy from password fields? I just locked my

D12539: Klipper: Do not insert secret data into history

2018-04-26 Thread Martin Flöser
graesslin added a comment. And it's probably something we also want to add to KWallet and maybe every password field we have. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12539 To: hoffmannrobert, davidedmundson Cc: graesslin,

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-04-21 Thread Martin Flöser
graesslin added a comment. I'm pointing out that I'm in general against any risky changes on X11. If users want to use this features: Wayland is there. KWin is feature frozen on X11 and I highly suggest to the Plasma community to decide the same at the sprint. We will have less maintenance

D12069: Implement a keyboard selector plasmoid

2018-04-21 Thread Martin Flöser
graesslin added a comment. I don't think that there's any reason to discard this. It's a start and improvement over the current situation and a fallback is needed anyway. So we start with the fallback instead of adding it later on. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D12373: Klipper: Remove first history item on clipboard clear

2018-04-21 Thread Martin Flöser
graesslin added a comment. Sorry, but I'm against this. The options keepass provides are just bullshit (sorry to be that direct). That cannot work and will not work. One cannot remove anything from the clipboard, trying to do so is insane. What would make most sense for things like

D12405: [WIP] Per-screen scale factors on X11 using QT_SCREEN_SCALE_FACTORS

2018-04-21 Thread Martin Flöser
graesslin added a comment. I also cannot imagine this to work due to the fact how X11 works. There is just no mapping from window to screen. No window can know on which screen it is. Not even KWin knows that as the window manager (screen is not a constant property, but evaluated every time

D12069: Implement a keyboard selector plasmoid

2018-04-09 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:42 > "apl" and "mao" are 3 letters. > No idea what either of those mean, it's just in the list. I'm not sure whether a substring is the correct solution anyhow. On Wayland we get a proper name like German, but

Re: Keyboard Layout notification on Wayland

2018-04-06 Thread Martin Flöser
Am 6. April 2018 18:15:47 MESZ schrieb Aleix Pol : >Hey, >Since I moved to wayland instead of seeing an item on the tray with >the layout I see a keyboard. The behavior is right but the fact that I >just see a keyboard that doesn't tell me much pushed me to see if we >could

D10836: Ensure _NET_CURRENT_DESKTOP is set on startup

2018-03-29 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:420549603372: Ensure _NET_CURRENT_DESKTOP is set on startup (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10836?vs=28039=30856 REVISION

D11722: If GL context creation fails fall back to the software renderer

2018-03-27 Thread Martin Flöser
graesslin added a comment. An env variable would not work for things like lock screen as the process starting the lock screen is started before Plasmashell. Given that I think persistent storage makes more sense. But a way to get back would be cool. Maybe we could create a test app to

D11722: If GL context creation fails fall back to the software renderer

2018-03-26 Thread Martin Flöser
graesslin added a comment. I like this change INLINE COMMENTS > desktopview.cpp:63 > [this, corona]() { > +qDebug() << QQuickWindow::sceneGraphBackend(); > // check whether the GL Context supports OpenGL This looks like too much debug or like a

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-25 Thread Martin Flöser
graesslin added a comment. In D10816#233128 , @fvogt wrote: > In D10816#233088 , @graesslin wrote: > > > In D10816#233074 , @fvogt wrote: > > > > >

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-24 Thread Martin Flöser
graesslin added a comment. In D10816#233074 , @fvogt wrote: > `XDG_SESSION_TYPE` is not set if you run `startplasmacompositor` from a tty - so should this also check for `WAYLAND_DISPLAY` or `startplasmacompositor` set

Re: KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

2018-03-24 Thread Martin Flöser
Hi Ben, I pushed a possible fix. No guarnatees as this code obviously compiled on my system. Could the compiler settings please be adjusted so that we have warnings be warnings on all ci systems and not fail on randomly? This was rather unexpected for me and makes it quite difficult to

Re: Experience on wayland regressed

2018-03-22 Thread Martin Flöser
Am 22. März 2018 20:36:38 MEZ schrieb David Edmundson : >>At the moment it seems that kded is being ran as xcb so >the per-screen scaling isn't being set u > >All scaling will be half-broken since that change anyway. >Running clients in xwayland means we lose all

Re: Experience on wayland regressed

2018-03-22 Thread Martin Flöser
Am 2018-03-22 19:13, schrieb Martin Flöser: Am 22. März 2018 15:54:22 MEZ schrieb Aleix Pol <aleix...@kde.org>: Hi, Since the recent removal of QT_QPA_PLATFORM=wayland, we lost some functionality. At the moment it seems that kded is being ran as xcb so the per-screen scaling isn't being

Re: Experience on wayland regressed

2018-03-22 Thread Martin Flöser
Am 22. März 2018 15:54:22 MEZ schrieb Aleix Pol : >Hi, >Since the recent removal of QT_QPA_PLATFORM=wayland, we lost some >functionality. At the moment it seems that kded is being ran as xcb so >the per-screen scaling isn't being set up. Also system settings shows >the behavior

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

2018-03-22 Thread Martin Flöser
graesslin added a comment. In general I like the idea and that should be extended to Wayland as well, but private API is a no-no for breeze. That has huge runtime breakage potential. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11573 To: volkov, #breeze Cc:

D11567: Fix use of assert/crash when removing global shortcut

2018-03-21 Thread Martin Flöser
graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Or just remove the assert. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D11567 To: davidedmundson, #plasma, graesslin Cc:

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-20 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c4a0d6925ec6: No longer export QT_QPA_PLATFORM env variable to the session (authored by graesslin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D11446: Use platform detection from KWorkspace in Powerdevil

2018-03-20 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R122:8ba04f890e15: Use platform detection from KWorkspace in Powerdevil (authored by graesslin). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11446?vs=29811=30085

D11445: Use platform detection in SystemSettings

2018-03-20 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R124:2d8296904bb4: Use platform detection in SystemSettings (authored by graesslin). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11445?vs=29810=30084

Re: no OSK in Plasma Mobile

2018-03-20 Thread Martin Flöser
Am 2018-03-19 21:25, schrieb Heather Ellsworth: On 03/17/2018 02:41 PM, Martin Flöser wrote: Am 17. März 2018 02:01:24 MEZ schrieb Heather Ellsworth <heather.ellswo...@puri.sm>: On 03/15/2018 09:10 PM, Bhushan Shah wrote: Hello Heather, On Thu, Mar 15, 2018 at 06:57:27PM -0600, H

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-20 Thread Martin Flöser
graesslin added a comment. In D11447#229522 , @graesslin wrote: > There's another solution which might be cleaner and which KWin uses for that problem: modifying the process environment. I'll give a try whether this could work here.

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Martin Flöser
graesslin added a comment. In D11447#229478 , @romangg wrote: > Could we use a wrapper for QApplication being called by > > QApplication app = KWorkSpace::createPlattformAwareQApplication(argc, argv); > > > and that sets and unsets

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Martin Flöser
graesslin added a comment. In D11447#229337 , @fvogt wrote: > In D11447#229334 , @graesslin wrote: > > > In D11447#229128 , @fvogt wrote: > > > > > If

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-19 Thread Martin Flöser
graesslin added a comment. In D11447#229128 , @fvogt wrote: > If `KWorkSpace::detectPlatform(argc, argv);` were changed to edit `argc` and `argv` to pass `-platform foo` instead of setting `QT_QPA_PLATFORM`, the `qunsetenv` calls would become

D11447: No longer export QT_QPA_PLATFORM env variable to the session

2018-03-18 Thread Martin Flöser
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY As discussed the env variables are no longer exported. Thus

D11446: Use platform detection from KWorkspace in Powerdevil

2018-03-18 Thread Martin Flöser
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY On a wayland session powerdevil needs to use Wayland

D11445: Use platform detection in SystemSettings

2018-03-18 Thread Martin Flöser
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY SystemSettings needs to run on Wayland in a Wayland session

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-18 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b5c326996309: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM (authored by graesslin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Re: no OSK in Plasma Mobile

2018-03-17 Thread Martin Flöser
Am 17. März 2018 02:01:24 MEZ schrieb Heather Ellsworth : >On 03/15/2018 09:10 PM, Bhushan Shah wrote: >> Hello Heather, >> >> On Thu, Mar 15, 2018 at 06:57:27PM -0600, Heather Ellsworth wrote: >>> I've been running Plasma Mobile on my iMX6 dev board (precursor to

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-03-17 Thread Martin Flöser
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #24 from Martin Flöser <mgraess...@kde.org> --- I really like the idea presented by Marco to use a slideshow and then transition to our "existing" lock screen. I see this as a clear evolution over the current state without l

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Martin Flöser
graesslin added a comment. In D11308#227359 , @ngraham wrote: > In D11308#227358 , @graesslin wrote: > > > In D11308#227332 , @ngraham wrote: > > > >

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Martin Flöser
graesslin added a comment. In D11308#227357 , @ngraham wrote: > In D11308#227356 , @graesslin wrote: > > > In D11308#227334 , @ngraham wrote: > > > >

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Martin Flöser
graesslin added a comment. In D11308#227332 , @ngraham wrote: > In D11308#227330 , @graesslin wrote: > > > @ngraham Let's try to not work against our distros. Yes we could change that because we

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Martin Flöser
graesslin added a comment. In D11308#227334 , @ngraham wrote: > Also, Martin, this isn't about re-using the desktop wallpaper on the lock screen. It's about using the current Plasma wallpaper on the lock screen. Distros can and do override the

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-16 Thread Martin Flöser
graesslin added a comment. @ngraham Let's try to not work against our distros. Yes we could change that because we are upstream, we set the default. The result would be distros swapping the wallpaper and we have unreadable text. This is something which will happen, I have been too long in

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-15 Thread Martin Flöser
graesslin added a comment. In D11308#226836 , @ngraham wrote: > @graesslin, those are good comments for @mart's ideas for the other approach. Do you have any remaining concerns with this one that I can work on? As long as the lnf theme

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-15 Thread Martin Flöser
graesslin added a comment. In D11308#226803 , @ngraham wrote: > Thanks @mart. I think using an animated slideshow by default will be really popular, especially if we do some work to add more nice images by default and polish up the slideshow

D11308: Use the default Plasma wallpaper on the lock screen

2018-03-13 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I think we first need to bring back some background for the UI elements. Otherwise it's too difficult to read. Personally I'm very confused as it was the vdg's wish to

D10816: Add platform detection to KWorkspace library to adjust QT_QPA_PLATFORM

2018-03-07 Thread Martin Flöser
graesslin added a comment. In D10816#221084 , @romangg wrote: > Hmm, what about application distributed as distro packages? Anyways,if you think this is a non-issue, feel free to push. Let's be realistic. Many applications we ship don't

  1   2   3   4   5   6   7   8   9   10   >