Re: New maintainers wanted: KDE Telepathy, KAccounts, Plasma Notifications and others

ds a > lot of improvements and maybe you can help. With a good library (such > as QXmpp) a Telepathy service implementation would consist of about 2k > lines of code. > > [1] https://phabricator.kde.org/D12751 Yes please! You've already proven yourself throughout the years with all your contributions, so you have my blessing :) Thanks for stepping up! Cheers -- Martin Klapetek

Re: Relicensing of file in plasma-phone-components

Hi, I'm fine with relicensing my contributions to plasma-phone-components/dialer/src/dialerutils.* code from GPL2 to either GPL2+ or LGPL. Cheers -- Martin Klapetek On Sun, Nov 18, 2018 at 7:47 AM Bhushan Shah wrote: > Hello everyone, > > I am writing to you since you have

D7633: [Digital Clock] Compact and move to the end font setup

mck182 added a comment. The horizontal alignment of the label is off compared to the rest of the labels, I guess it's because it's not in a groupbox. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7633 To: broulik, #plasma, #vdg, mart Cc: mck182, mart,

D6059: Add a test that adds a notification and closes it

mck182 added a comment. That's up to Kai/VDG, I guess. I was just wondering what changed from the previous patch where everyone agreed to not do it because it would be confusing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6059 To: apol, #plasma,

D6059: Close notifications that don't have a default action by clicking

mck182 added a comment. This was discussed at length in https://phabricator.kde.org/D4215 What's the reasoning behind this change? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6059 To: apol, #plasma, broulik, #vdg Cc: mck182, plasma-devel, ZrenBot,

D5424: [Notifications] Introduce "settings" action

mck182 accepted this revision. mck182 added a comment. Ah, I see. Good to go then, unless you want to wait for VDG input. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5424 To: broulik, #vdg, #plasma, markg, mck182 Cc: mck182, markg, plasma-devel,

D5424: [Notifications] Introduce "settings" action

mck182 added a comment. While I like this, I wonder - for apps that will send "settings" action there will now be no way to access the KNotification settings, right (from the notification itself)? As in, the app can use the "settings" action for an entirely different thing, thus

D5346: DigitalClock: Use correct language for month and day names

mck182 accepted this revision. mck182 added a comment. This revision is now accepted and ready to land. Same as the other diff, if safe, good to go. EDIT: I feel like we could wrap the `Qt.locale(Qt.locale().uiLanguages[0])` into something shorter, maybe. Possibly also keep it

D5345: Calendar: Use correct language for month and day names

mck182 accepted this revision. mck182 added a comment. This revision is now accepted and ready to land. ...provided the usage of `uiLanguages[0]` is safe like this. INLINE COMMENTS > DaysCalendar.qml:315 > height: daysCalendar.cellHeight > -text:

Re: Default touch screen edge gestures

r for tasks). > Whoa, Alt+Space was discussed at length during a sprint (in Pineda iirc) and couple other Plasma meetings and a clear improvement over then-current Alt+F2 was observed. This was anything but "without much thought". Cheers -- Martin Klapetek

D5324: Revert "[calendar] Use ui language for getting the month name"

mck182 added a comment. I disagree with this because we currently don't have any easy and/or sensible way to change date formats and so we simply suggest using different locales for the different formats. However, if your UI language is all Spanish and you want to use the US date

[Powerdevil] [Bug 378404] Turn off screen when PM-inhibiting app is not the active app

https://bugs.kde.org/show_bug.cgi?id=378404 Martin Klapetek <mklape...@kde.org> changed: What|Removed |Added Severity|normal |wishlist -

[Powerdevil] [Bug 378404] New: Turn off screen when PM-inhibiting app is not the active app

https://bugs.kde.org/show_bug.cgi?id=378404 Bug ID: 378404 Summary: Turn off screen when PM-inhibiting app is not the active app Product: Powerdevil Version: unspecified Platform: Other OS: Linux

Re: Scrap Baloo Thread Feedback

here, saying that you would like Baloo to move in this direction, detail out your proposal and if nobody objects, go ahead and do it. KDE is about doers, after all :) Also, if you're still a student, you may want to consider doing this as a GSoC. Cheers -- Martin Klapetek

Re: Listening to a notification button's "onClick" in the notifications DataEngine

ou into your client side code, eg. if you use KNotification, then you can listen to those signals there. This obviously only works for notifications that you yourself have created, you cannot listen to those signals of all notifications, that's only for the client and the shell to know. Cheers -- Martin Klapetek

Re: Review Request 123300: Make the dataengine alignment timer more precise

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 2fea7077c84b97028a424d3e1d66f9838ccf9201 by Albert Astals Cid on behalf of Martin Klapetek to branch master. Repository: plasma-framework Description --- It can and does happen that in case of two

[Differential] [Commented On] D4632: [Notifications] Never manually hide() the NotificationPopup

mck182 added a comment. > it's quite a mess No it's not :P It's a delicate complex code with lots of comments. But let me know if you need some help with that. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4632 EMAIL PREFERENCES

[Differential] [Commented On] D4545: Centralize interaction with notifications

mck182 added a comment. Can we please fix and ship this quickly? https://phabricator.kde.org/D4142 shouldn't really have been shipped in that state. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4545 EMAIL PREFERENCES

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

mck182 added a comment. In https://phabricator.kde.org/D4416#82951, @hein wrote: > Gnome-only spec? Why aren't they contributing to fd.o? "Galago is dead, we took over, deal with it." https://bugzilla.gnome.org/show_bug.cgi?id=745634#c25 REPOSITORY R289 KNotifications

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. Thanks, that's a nice list. I think real examples using actual native apps would provide better insight (like calendar, low battery or music player notification), but that'd be like a weekend project, so it's ok. **macOS**: Clicking a notification popup will in

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. Fair enough. Let's make a step back then. Since you've mentioned "Plasma is the only notification system that does close-on-activate instead of executing some action", can you actually list what happens elsewhere? How is default action implemented in Gnome? What

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. Well there you go then. Just implement the default action to be always the top-most button in our actions list and make clicking the popup always execute the first action in the list. That way, if there are buttons, the user will know that clicking the popup will

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. > I think Plasma is the only notification system that does close-on-activate instead of executing some action Plasma might also be the only system that uses buttons for actions and I see nothing wrong with that; it's what we've had forever and it works well,

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. > I have never considered unpredictable on Android that when I press the "new e-mail" notification I get the e-mail client with the new e-mail. On Android, you close the notification by swiping to a side. On Plasma, you close the notification by clicking it. On

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. > If you just want to close then you have the big X, no? That doesn't change the fact that the behavior of clicking the popup itself would change in an unpredictable way. One time it's close and other times it's execute and there's no visual way of telling when

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

mck182 added a comment. -1, I don't want to keep thinking "am I now going to close the notification or execute an action" everytime I'm about to click the notification popup. I want my workspace to have predictable behavior that doesn't get in my way. REPOSITORY R120 Plasma Workspace

Re: Plasma 5.9 Beta announce

On Tue, Jan 10, 2017 at 5:00 PM, Łukasz Sawicki <kde...@gmail.com> wrote: > Heh correct link > > https://youtu.be/RX5HwumKPP8 > > Cheers > Łukasz > Looks nice! Do you have a link to the background music? Cheers -- Martin Klapetek

[Differential] [Commented On] D4050: add a "by KDE" sign in the splash

mck182 added a comment. If I may add a slightly unrelated comment - the circly parts of the new logo seem to throw the spinner a bit off visually, I think it could use some larger spacing in between those two. REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #15 from Martin Klapetek <mklape...@kde.org> --- > I will call that redundant information. For every one calling that a redundant information there will be someone calling that a missing information if it was removed. Sometimes

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 27, 2016, 4:54 p.m., Sebastian Kügler wrote: > > applets/digital-clock/plugin/timezonesi18n.cpp, line 682 > > > > > > This should stay Cape Verde, the English name is used here, not the > > Portuguese

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

> On Dec. 21, 2016, 12:25 a.m., Aleix Pol Gonzalez wrote: > > +0 > > > > Note the correct patch would possibly be to port it to > > http://doc.qt.io/qt-5/qtimezone.html and drop that list... Btw. this list exists because there is(/was) no way to get localized list of all countries from

Re: DrKonqi and BKO

On Wed, Nov 2, 2016 at 6:32 AM, Harald Sitter <sitter.har...@gmail.com> wrote: > On Wed, Nov 2, 2016 at 11:04 AM, René J. V. Bertin <rjvber...@gmail.com> > wrote: > > Martin Klapetek wrote: > > > > > >> For improving readability, there is bugzilla-tr

Re: DrKonqi and BKO

> Searching is ridiculously important. > For improving readability, there is bugzilla-traceparser plugin, that can dynamically hide long backtraces with a bit of JS magic to expand them and much more like finding duplicates and also auto-dupe. I still think this would help tremendously to all our bugzilla users. See https://bugs.kde.org/show_bug.cgi?id=354217 Cheers -- Martin Klapetek

Re: Breakout: UI and user vision for cloud services

ode for ownCloud stuff, like importing CardDAV contacts iirc. Cheers -- Martin Klapetek

Re: Breakout: UI and user vision for cloud services

ed up (if at all; I also failed to follow up on that). Cheers -- Martin Klapetek

Re: Breakout: * multiscreen behaviour: how should Plasma exactly behave in different scenarios?

reasoning for this^ is that, presumably, for privacy and/or comfort I'd be moving the primary screen from the TV back to my laptop. But then when I come back to my desk and plug in my screen, I'd need to again set the primary screen to the external screen, which is just annoying. So...my CA$ 0.02 :) Cheers -- Martin Klapetek

Re: Review Request 125743: Keep aspect ratio in default KSplash background

/ Testing --- Thanks, Martin Klapetek

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

https://bugs.kde.org/show_bug.cgi?id=366608 Martin Klapetek <mklape...@kde.org> changed: What|Removed |Added CC||mklape...@k

[Plasma Workspace Wallpapers] [Bug 366470] Add unsplash wallpapers to KDE

https://bugs.kde.org/show_bug.cgi?id=366470 Martin Klapetek <mklape...@kde.org> changed: What|Removed |Added CC||mklape...@k

Re: task manager lines instead of blocks

omment. > I prefer blocks. Also, we started with lines, people got used to lines, we changed it to blocks. Now people got used to blocks and we want to change it back to lines. I don't feel like the theme should be constantly changing back and forth. Cheers -- Martin Klapetek

Re: multiscreen logging

On Wed, Jul 27, 2016 at 7:35 AM, Sebastian Kügler <se...@kde.org> wrote: > On dinsdag 26 juli 2016 19:44:11 CEST Martin Klapetek wrote: > > On Tue, Jul 26, 2016 at 8:03 AM, Sebastian Kügler <se...@kde.org> wrote: > > > > What do you think? If you like t

Re: multiscreen logging

s using some automation and sort by timestamp. Unless Qt on Linux actually handles concurrent write access just fine and in the correct order (I know it didn't on Windows last time I looked). Cheers -- Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

mck182 added a comment. In https://phabricator.kde.org/D2212#41055, @drosca wrote: > The calendar popup size is fine for me (with patched plasma-framework), what I *still* think is broken is the gridSize scaling - see https://git.reviewboard.kde.org/r/125773/ > > You can also test

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

mck182 added a comment. Can you post a screenshot of before/after? For future reference - any review request that touches the UI should always be accompanied by a screenshot ;) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2212 EMAIL

Re: Minutes Monday Plasma Meeting

d in KNotification. Cheers -- Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Which applications does the Plasma team recommend to use with Plasma?

net streaming by default and Spotify integration and is a music player, above all. VLC is primarily a video player, using it for playing music works, but it's not its primary use case, making it lesser app when compared to Clementine (or Cantata, even). Ch

New maintainers wanted: KDE Telepathy, KAccounts, Plasma Notifications and others

for Plasma desktop and really need some attention. If you'd like to put your name on any of the things above, please let me know. I'll make sure to do a proper hand-off with explaining everything :) Cheers -- Martin Klapetek ___ Plasma-devel mailing l

[Powerdevil] [Bug 364275] sleep and hibernate gone after update

https://bugs.kde.org/show_bug.cgi?id=364275 Martin Klapetek <mklape...@kde.org> changed: What|Removed |Added CC||mklape...@k

Re: plasma-desktop on other environments (bis)

On Sat, May 28, 2016 at 2:22 PM, René J. V. <rjvber...@gmail.com> wrote: > Quick related question: has knotify4 been replaced by a KF5 equivalent, or > rather made obsolete? > It's gone completely, everything happens in KNotification at runtime. Cheers -- Martin Klapetek

Re: plasma-desktop on other environments (bis)

o configure whatever last century sounds they want to use is perfectly fine and should be done. But if you're going to split events out from plasma_workspace.notifyrc, split them to per-platform files and modify those dialog events to use the sound the platform uses *by def

Re: plasma-desktop on other environments (bis)

On Sat, May 28, 2016 at 10:27 AM, David Edmundson < da...@davidedmundson.co.uk> wrote: > On Sat, May 28, 2016 at 3:11 PM, Martin Klapetek < > martin.klape...@gmail.com> wrote: > >> On Sat, May 28, 2016 at 9:10 AM, Kai Uwe Broulik <k...@privat.broulik.de> >>

Re: plasma-desktop on other environments (bis)

want native integration > and not a "familiar KDE interface". I bet the average one-platform user > group we imho should be targeting does the same. > This^. Very much this. Please don't make our apps aliens in other environments. Cheers -- Martin Klapetek | KDE Developer _

[Breeze] [Bug 363602] Symlinked SVG files fails to load under Windows

https://bugs.kde.org/show_bug.cgi?id=363602 Martin Klapetek <mklape...@kde.org> changed: What|Removed |Added Summary|Aliased SVG files fails to |Symlinked SVG files

Re: plasma-desktop on other environments (bis)

sounds instead of these outdated sounds we still use. In other words, ship custom .notifyrc for message box events on OS X. It really really really really *really* shouldn't use the Oxygen sounds by default. Cheers -- Martin Klapetek | KDE Developer ___

Re: Kirigami popup

On Thu, May 12, 2016 at 7:34 AM, Marco Martin <notm...@gmail.com> wrote: > On Wednesday 11 May 2016 22:36:37 Martin Klapetek wrote: > > > > > > I would say OverlaySheet > > > > Is ScrollabePage a requirement for that? I can see that the Gallery

Re: Proposal: kde-libs.org, a repository of contributed libraries

ojects. If you think such server would be a good thing, then go ahead and create it. Things don't just magically happen, they need people behind it. And if your idea will appeal to wider audience, you will attract more people. That's how great things in open

Re: Kirigami popup

On Tue, May 10, 2016 at 10:43 AM, Marco Martin <notm...@gmail.com> wrote: > On Tuesday 10 May 2016 10:23:28 Martin Klapetek wrote: > > Hey, > > > > so in SpaceBar, there's a button that opens a 1/3-screen-height > > popup with emojis for the user to select. How s

Kirigami popup

thing would be to have the keyboard window replaced by the popup and/or implement it as a maliit input plugin. Would one of these things be possible? Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 127818: [calendar] Add "No events for today" in the agenda when no events are available

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 95e7f32597a77e3e0928f9f5645f53e921ad5ebd by Martin Klapetek to branch master. Repository: plasma-workspace Description --- Fills the big block of empty space with some nice string. "No events for

Review Request 127818: [calendar] Add "No events for today" in the agenda when no events are available

ard.kde.org/r/127818/diff/ Testing --- See screenshot File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2016/05/03/ea42a866-f390-489a-bac4-f20e2ae8ee56__snapshot114.png Thanks, Martin Klapetek

Re: Proposal: kde-libs.org, a repository of contributed libraries

ed. In any case, we could really use a quick overview of what your TextSize.qml does and why do you think it's useful for other Plasmoid developers, then we'll advise you on next steps :) [1] http://api.kde.org/frameworks-api/frameworks5-apidocs/plasma-framework/html/ Cheers -- Martin Klapete

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

marked as submitted. Review request for Plasma. Changes --- Submitted with commit eb7544704751dc1a9c2997da56d386811b00454f by Martin Klapetek to branch master. Repository: plasma-workspace Description --- This is very simple for now as there is no configuration yet, so it just takes

Re: Review Request 127734: Revert the revert of the revert that removed the agenda from calendar

marked as submitted. Review request for Plasma. Changes --- Submitted with commit e8c5a28df28d2d66e8eaee47550425941e3e7ade by Martin Klapetek to branch master. Repository: plasma-workspace Description --- Brings back the agenda to the calendar that was redone in September. Once

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 28, 2016, 8:44 p.m., Kai Uwe Broulik wrote: > > You broke the zoomed out view, ie. in the year/decade overview you now get > > a tick at *every* cell... > > Martin Klapetek wrote: > Oops, I'll fix, thanks. This

Re: Review Request 127586: [calendar] Add a mark to days containing events

n automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127586/#review94987 --- On April 21, 2016, 5:41 a.m., Martin Klapetek wrote: > > --- > This is an a

[Differential] [Updated] D1478: [Notifications] Don't group job finished notifications

mck182 added a comment. In https://phabricator.kde.org/D1478#27445, @colomar wrote: > Why are those notification even persistent in the first place? If a user misses the notification, they should notice that the job was finished by the fact that it's not running anymore. > Only

Re: Review Request 127734: Revert the revert of the revert that removed the agenda from calendar

Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127734: Revert the revert of the revert that removed the agenda from calendar

/127734/diff/ Testing --- See the screenshot with kholidays plugin backend. File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2016/04/24/64ce9060-a12d-49ca-bd21-469af396fbb5__snapshot112.png Thanks, Martin Klapetek

Re: Kirigami: a feature needed for subsurface and api change feedback

tried to build the example gallery locally but CMake complains about > missing ECM 0.0.8 - where do I find that? > In case you still haven't - git://anongit.kde.org/extra-cmake-modules.git Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mai

Re: Review Request 127586: [calendar] Add a mark to days containing events

marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 08312b2e340e10d640131c0186e81a0b9f0f2505 by Martin Klapetek to branch master. Repository: plasma-framework Description --- Simple triangle at the bottom right corner, see

Kirigami Page.title

have the standard blue titlebar too. Unless more things could go in there. I can perhaps write a patch to hide it if empty, if you agree. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request 127586: [calendar] Add a mark to days containing events

/ Testing --- File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 13, 2016, 10:28 a.m., Marco Martin wrote: > > what's the status of this? > > Martin Klapetek wrote: > Working on it. > > Martin Klapetek wrote: > Ok so I'm unable to render that svg, it is properly installed > and everything, but this d

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 13, 2016, 10:28 a.m., Marco Martin wrote: > > what's the status of this? > > Martin Klapetek wrote: > Working on it. > > Martin Klapetek wrote: > Ok so I'm unable to render that svg, it is properly installed > and everything, but this d

Re: Review Request 127586: [calendar] Add a mark to days containing events

> On April 13, 2016, 10:28 a.m., Marco Martin wrote: > > what's the status of this? > > Martin Klapetek wrote: > Working on it. Ok so I'm unable to render that svg, it is properly installed and everything, but this doesn't show anything (not even error): ```

Re: Review Request 127586: [calendar] Add a mark to days containing events

view94567 --- On April 6, 2016, 5:53 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Kirigami.Page breaks with Loader+Component inside

On Mon, Apr 11, 2016 at 6:07 AM, Aleix Pol <aleix...@kde.org> wrote: > On Mon, Apr 11, 2016 at 10:44 AM, Marco Martin <notm...@gmail.com> wrote: > > On Monday 11 April 2016, Martin Klapetek wrote: > >> Hey, > >> > >> so I've ported SpaceBar to Kir

Kirigami.Page breaks with Loader+Component inside

will show the green rectangle. Changing the Page to say, an Item, shows both Rects. This was working before and I have tried to look into it, but couldn't figure out what's up with that. Can somebody have a look? Cheers -- Martin Klapetek | KDE Developer import QtQuick 2.1 import QtQuick.Controls 1.4

Re: Review Request 127586: [calendar] Add a mark to days containing events

a triangle shaped QSGGeometryNode? > > Kai Uwe Broulik wrote: > There's even exactly that on WikiBooks :D > https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation > > Martin Klapetek wrote: > Ah, that's handy. Now I wonder though - it's under CC-B

Re: Review Request 127586: [calendar] Add a mark to days containing events

a triangle shaped QSGGeometryNode? > > Kai Uwe Broulik wrote: > There's even exactly that on WikiBooks :D > https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation > > Martin Klapetek wrote: > Ah, that's handy. Now I wonder though - it's under CC-B

Re: Review Request 127586: [calendar] Add a mark to days containing events

a triangle shaped QSGGeometryNode? > > Kai Uwe Broulik wrote: > There's even exactly that on WikiBooks :D > https://en.wikibooks.org/wiki/Qt/Qt_Quick_Overview#Triangle_implementation > > Martin Klapetek wrote: > Ah, that's handy. Now I wonder though - it's under CC-B

Re: Review Request 127586: [calendar] Add a mark to days containing events

-------- On April 6, 2016, 5:53 a.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127586/ > -

Review Request 127586: [calendar] Add a mark to days containing events

/DaysCalendar.qml d4b8fe4 Diff: https://git.reviewboard.kde.org/r/127586/diff/ Testing --- File Attachments Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2016/04/06/afefe7ce-7757-4505-9f17-63fca2ec26cb__snapshot109.png Thanks, Martin Klapetek

Re: Review Request 127456: [2/2] Fix calendar applet not clearing selection when hiding

marked as submitted. Review request for Plasma. Changes --- Submitted with commit d3beb0b647a543436d3d23ab82b39a2f98a384be by Martin Klapetek to branch Plasma/5.6. Bugs: 360683 https://bugs.kde.org/show_bug.cgi?id=360683 Repository: plasma-workspace Description

Re: Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding

marked as submitted. Review request for Plasma. Changes --- Submitted with commit cff18c2cd28e8676cbcc0713ba45efde6cf09db0 by Martin Klapetek to branch master. Bugs: 360683 http://bugs.kde.org/show_bug.cgi?id=360683 Repository: plasma-framework Description --- This removes

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

> On Feb. 23, 2016, 2:09 p.m., David Edmundson wrote: > > Martin, what is the state of this? > > > > You're in danger of missing Plasma 5.6. > > Martin Klapetek wrote: > I very likely won't be able to finish it in this cycle. > > David Edmundson wrote:

Re: Review Request 126949: Remove Air and Oxygen themes

/widgets/tooltip.svgz 33d0bb5 src/desktoptheme/oxygen/widgets/translucentbackground.svgz 47b418d src/desktoptheme/oxygen/widgets/viewitem.svgz cec433e Diff: https://git.reviewboard.kde.org/r/126949/diff/ Testing --- Thanks, Martin Klapetek

Re: Plasma 5.6 video

is key. Otherwise - really really really well done. Kudos. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding

viewboard.kde.org/r/127455/#review93841 --- On March 21, 2016, 10:11 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 127456: [2/2] Fix calendar applet not clearing selection when hiding

/show_bug.cgi?id=360683 Repository: plasma-workspace Description --- The workspace part of the fix. Diffs - applets/digital-clock/package/contents/ui/CalendarView.qml 09dbe5e Diff: https://git.reviewboard.kde.org/r/127456/diff/ Testing --- Thanks, Martin Klapetek

Review Request 127455: [1/2] Fix calendar applet not clearing selection when hiding

iveimports/calendar/qml/DayDelegate.qml 6877150 src/declarativeimports/calendar/qml/DaysCalendar.qml 8248a8f src/declarativeimports/calendar/qml/MonthView.qml 76c605a Diff: https://git.reviewboard.kde.org/r/127455/diff/ Testing --- Selection is properly cleared. Thanks, Marti

Re: Plasma 5.6 video

memorable as possible. Loose the whole https://www. part, it's not a clickable link ;) "kde.org/donate" is all you need to type into your browser. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.o

Re: left-click on libappindicator indicators

ug.cgi?id=358589 Can you try that patch? In any case, I'll post it for review. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127102: Use fixed width for digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/#review93603 --- Ship it! Ship It! - Martin Klapetek On March 16, 2016

Re: Review Request 127102: Use fixed width for digital clock applet

> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 565-568 > > <https://git.reviewboard.kde.org/r/127102/diff/3/?file=448492#file448492line565> > > > > Can't we just compare "

Re: Review Request 127102: Use fixed width for digital clock applet

> On March 15, 2016, 5:48 p.m., Martin Klapetek wrote: > > I've tested it extensively and it works great. Thanks a lot! > > > > There's one more issue - http://paste.opensuse.org/view/raw/f8ba5d0d - the > > same font size should also be app

Re: Plasma 5.6 video

t;. Other than that, outstanding work, thanks a lot for that. And kudos for Darude - Sandstorm :D Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127102: Use fixed width for digital clock applet

nd "P" width's and use that? Would spare creating two Date objects and two calls to Qt.formatTime - Martin Klapetek On March 8, 2016, 6:53 p.m., Daniel Faust wrote: > > --- > This is an automatically generated e-mail. To reply, v

[plasmashell] [Bug 360309] [Window List applet] add text field to widget for the panel

https://bugs.kde.org/show_bug.cgi?id=360309 Martin Klapetek <mklape...@kde.org> changed: What|Removed |Added Component|general |Windo

Re: Review Request 127285: use QDBusConnectionInterface::serviceOwnerChanged to watch mpris2 service

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127285/#review93360 --- Ship it! Ship It! - Martin Klapetek On March 5, 2016

  1   2   3   4   5   6   7   8   9   10   >