T13927: Pop shell in KDE Plasma

niccolove added a comment. In T13927#245978 , @ngraham wrote: > What is "pop shell"? I think they are talking about pop_os customized gnome shell. TASK DETAIL https://phabricator.kde.org/T13927 To: plasma-devel, niccolove Cc:

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

niccolove added a comment. strong +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack,

D29824: Avoid system tray resizing

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Currently, there was some code to avoid system tray resizing. However, being the properties not set to the root element, this

D29824: Avoid system tray resizing

niccolove added a comment. whops, this created a diff, not a MR REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29824 To: niccolove Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D28627: Adaptive panel opacity

niccolove added a comment. Ping @davidedmundson ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

niccolove added a comment. I agree with a single KCM called wallpapers used to set all wallpaper in System Settings. Not a fan of having so many apply buttons, but I'm sure we can come up with something good. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29798: [wallpapers/image] Add button to open lock screen and SDDM KCMs

niccolove added a comment. I'm a bit torn about this. It is indeed very nice, but at the same time I don't feel like it's the right solution. Ignoring minor complaints I'd have ("it's a very large button!") it doesn't feel right that the user, in order to change login wallpaper, would think

D28627: Adaptive panel opacity

niccolove added a comment. In D28627#652806 , @ngraham wrote: > In D28627#652538 , @niccolove wrote: > > > Actually -- this seems to no longer apply panel internal margins? > > > Works for me.

D29264: New tabs for Breeze

niccolove added a comment. +1 for the direction! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29264 To: abstractdevelop, #vdg, #breeze Cc: niccolove, manueljlin, filipf, ngraham, cblack, plasma-devel, dmenig, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian,

D29570: Fix some alignments

This revision was automatically updated to reflect the committed changes. Closed by commit R120:de52cb8944e8: Fix some alignments (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29570?vs=82389=82631 REVISION DETAIL

D29603: Adds custom spacing between task manager icons

niccolove added a comment. Are we really sure this is worth exposing to the user? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29603 To: martellini, #vdg Cc: niccolove, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29570: Fix some alignments

niccolove added inline comments. INLINE COMMENTS > ndavis wrote in PowerManagementItem.qml:34 > How does this affect RTL layouts? It does look a bit too close on the right border in LTS. I guess I should add a rightMargin here? REPOSITORY R120 Plasma Workspace BRANCH fixspacing (branched

D29570: Fix some alignments

niccolove added a comment. For some reason, the heading is still one or two pixels off... still, much better than before REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29570 To: niccolove, #vdg, #plasma Cc: plasma-devel, Orage, LeGast00n,

D29570: Fix some alignments

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This fixes some wrong alignments REPOSITORY R120 Plasma Workspace BRANCH fixspacing (branched from master) REVISION

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

niccolove added a comment. Generic +1 to the idea, but: - I would not go higher than 50 as panel width - The clock is too small, it probably needs a version where there's a new line between hour and minutes - We should check that all widgets work correctly in a vertical panel

D29081: [QStyle] Make menu titles look less like menu items

niccolove accepted this revision as: niccolove. niccolove added a comment. This revision is now accepted and ready to land. VDG wise, this looks good and consistent. REPOSITORY R31 Breeze BRANCH menu-title-looks-less-like-a-menu-item (branched from master) REVISION DETAIL

D29490: This removes the negative top margin, as it's already removed by the NotificationPopup

This revision was automatically updated to reflect the committed changes. Closed by commit R120:571f0aba2fc5: This removes the negative top margin, as its already removed by the… (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29490: This removes the negative top margin, as it's already removed by the NotificationPopup

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY The negative top margin was not necessary and causes missing round corners. REPOSITORY R120 Plasma Workspace BRANCH

D29474: Add inHistory bool and hide heading on inHistory

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7e4b0979: Add inHistory bool and hide heading on inHistory (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29474: Add inHistory bool and hide heading on inHistory

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This hides the plasmoidHeading on history for not grouped notifications REPOSITORY R120 Plasma Workspace BRANCH

D29234: Fix various bugs introduced with heading

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf6b8353a73f: Fix various bugs introduced with heading (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=82062=82065

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 82062. niccolove added a comment. Remove inHistory change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=82060=82062 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove added a comment. Sorry, I'll make a different patch for that REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29234: Fix various bugs introduced with heading

niccolove requested review of this revision. niccolove marked 4 inline comments as done. niccolove added a comment. I added one last thing: I feel like it was not a good idea to show the heading in history for notifications that are not in group. I added a inHistory bool, false by default,

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 82060. niccolove added a comment. Address feedback and add inHistory bool REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81791=82060 BRANCH fix_notifications (branched from master) REVISION

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81791. niccolove added a comment. Fix very long application names REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81750=81791 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81750. niccolove added a comment. Fix very long notification titles REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81748=81750 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81748. niccolove added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81733=81748 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81733. niccolove added a comment. Move lineSvg to root element REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81732=81733 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81732. niccolove added a comment. Fix visibility REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81730=81732 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove planned changes to this revision. niccolove added a comment. Ah, there's a mistake on visibility, just a sec REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n,

D29234: Fix various bugs introduced with heading

niccolove added a comment. Keyboard navigation is now working again; however, pressing tab to focus buttons seem to no longer be possible after this patch; looking at the code, I'm given the impression that it was true before porting notifications to page as well. Is that correct, or should

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81730. niccolove added a comment. Fix keyboard navigation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81727=81730 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove added a comment. I used the Svg instead of the plasmoidHeading to avoid using a Control. User-wise, it works correctly, but can I get your opinion code-wise? INLINE COMMENTS > broulik wrote in FullRepresentation.qml:454 > Move the `Svg` somewhere outside the delegate, I don't want

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81727. niccolove added a comment. Remove plasmoidHeading element as it's a control REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81389=81727 BRANCH fix_notifications (branched from master)

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81389. niccolove added a comment. Fix close button not clickable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81372=81389 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove added inline comments. INLINE COMMENTS > broulik wrote in NotificationItem.qml:125 > Please use one of the `State` below for `inGroup` state I originally did this but I had a problem. It displays and works just as good, but it will throw a "you are using anchors in layouts" error in

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81372. niccolove added a comment. Fix spacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81368=81372 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove planned changes to this revision. niccolove added a comment. Ahh, this adds top margin in history. Let me fix. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n,

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81368. niccolove added a comment. Missing space REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81367=81368 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81367. niccolove added a comment. unrelated pt3 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81366=81367 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81366. niccolove added a comment. Unrelated pt2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81365=81366 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81365. niccolove added a comment. Remove unrelated REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81364=81365 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This fixes: - Indented notifications line (it's back) - Heading being non-clickable - Buttons not being right-aligned

D29142: Add footer support to systray

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0f28094f584c: Add footer support to systray (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29142?vs=81184=81221 REVISION DETAIL

D29142: Add footer support to systray

niccolove added a comment. Should work now REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29142 To: niccolove, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29142: Add footer support to systray

niccolove updated this revision to Diff 81184. niccolove added a comment. Set height correctly code and more concise code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29142?vs=81183=81184 BRANCH master REVISION DETAIL

D29142: Add footer support to systray

niccolove updated this revision to Diff 81183. niccolove edited the summary of this revision. niccolove added a comment. Fix bars not disappearing when switching to a component without page REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29142: Add footer support to systray

niccolove added a comment. Sorry! I'll double check from now on. INLINE COMMENTS > ngraham wrote in PlasmoidPopupsContainer.qml:38 > Nothing was using this? Nothing REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29142 To: niccolove, ngraham Cc:

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

niccolove added a comment. Size should be an even number - For sizes from 36 to 40, I'm OK with it - At 42 and 44 the icons in the task manager become too big for the panel; their size should be reduced to same as the launcher button, then it's fine - At 46 and over it's fine

D29142: Add footer support to systray

niccolove created this revision. niccolove added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D29142

D29137: Added plasmoidHeading to clipboard and ported to Page

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0a7b99bb6ae1: Added plasmoidHeading to clipboard and ported to Page (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29137: Added plasmoidHeading to clipboard and ported to Page

niccolove updated this revision to Diff 81038. niccolove added a comment. Added margin REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29137?vs=81037=81038 BRANCH clipboard_page_heading (branched from master) REVISION DETAIL

D29137: Added plasmoidHeading to clipboard and ported to Page

niccolove added a comment. In D29137#655936 , @ngraham wrote: > Thanks! Implementation-wise, I would have re-arranged things a bit to have only one header for the `PC3.Page`, with the contents changing depending on the page in the stack, rather

D29137: Added plasmoidHeading to clipboard and ported to Page

niccolove updated this revision to Diff 81037. niccolove added a comment. Rebase and enabled REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29137?vs=81036=81037 BRANCH clipboard_page_heading (branched from master) REVISION DETAIL

D29137: Added plasmoidHeading to clipboard and ported to Page

niccolove added a comment. Heh, I just noticed :P REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29137 To: niccolove, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29137: Added plasmoidHeading to clipboard and ported to Page

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH clipboard_page_heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D29137

D29111: [applet] Port to Kirigami.PlaceholderMessage

niccolove accepted this revision. niccolove added a comment. This revision is now accepted and ready to land. Yeah, I agree. I see that this behavior is consistent, so I'll accept it. REPOSITORY R97 Bluedevil BRANCH port-to-PlaceholderMessage (branched from master) REVISION DETAIL

D29111: [applet] Port to Kirigami.PlaceholderMessage

niccolove added a comment. Correct, but shouldn't the focus state stop after button press, or when I click away, or at least when I close the applet? Or am I getting the concept of focus wrong? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D29111 To: ngraham,

D28996: Converted to page and added heading

This revision was automatically updated to reflect the committed changes. Closed by commit R115:a876b365bb22: Converted to page and added heading (authored by niccolove). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28996?vs=80589=80940

D28996: Converted to page and added heading

niccolove added a comment. In D28996#652157 , @ngraham wrote: > Great! However the footer looks a bit weird since it doesn't touch the edges: F8247573: Screenshot_20200419_154306.png True but it's

D29111: [applet] Port to Kirigami.PlaceholderMessage

niccolove added a comment. It seems like the button never gets out of hovered state: F8254176: Screenshot_20200422_231804.png REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D29111 To: ngraham, #vdg, #plasma, drosca,

D28873: Add SwipeNavigator component

niccolove added a comment. In D28873#652724 , @mart wrote: > for those that are a sidebar, there is already a standard, agreed upon look, that is being slowly and painfully moved to be adopted, which is: > F8249505:

D28627: Adaptive panel opacity

niccolove added a comment. Actually -- this seems to no longer apply panel internal margins? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson, plasma-devel, Orage,

D28627: Adaptive panel opacity

niccolove accepted this revision. niccolove added a comment. Works great! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n,

D28996: Converted to page and added heading

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY screenshots coming REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL

D28576: Converted to page and added Heading

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7d0a74721c5f: Converted to page and added Heading (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28576?vs=79484=80583 REVISION

D28467: Converted to Page with a PlasmoidHeading in the heading

This revision was automatically updated to reflect the committed changes. Closed by commit R97:4a8adbaeac4e: Converted to Page with a PlasmoidHeading in the heading (authored by niccolove). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=80324=80327

D28575: Make headings of systray and applet merge

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1a6b40cb5e0e: Make headings of systray and applet merge (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=80315=80326

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove updated this revision to Diff 80324. niccolove added a comment. rebase x3 REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=80321=80324 BRANCH arcpatch-D28467 REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove updated this revision to Diff 80321. niccolove added a comment. rebase x2 REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=80320=80321 BRANCH arcpatch-D28467 REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove updated this revision to Diff 80320. niccolove added a comment. rebase REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=79889=80320 BRANCH arcpatch-D28467 REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added a comment. In D28467#649913 , @ngraham wrote: > Hmm, seems broke: > > file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.bluetooth/contents/ui/FullRepresentation.qml:145:1: Expected token `}' >

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove requested review of this revision. niccolove added a comment. Should finally work with latest D28575 REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D28467 To: niccolove, #plasma, ngraham Cc: ngraham, plasma-devel,

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 80315. niccolove added a comment. third one's a charm REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=80314=80315 BRANCH systray_merged_topbar (branched from master) REVISION DETAIL

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 80314. niccolove added a comment. try 2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=80313=80314 BRANCH arcpatch-D28467 REVISION DETAIL https://phabricator.kde.org/D28575 AFFECTED FILES

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 80313. niccolove added a comment. Only merge if header is actually visible REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=79483=80313 BRANCH arcpatch-D28467 REVISION DETAIL

D28873: Add SwipeNavigator component

niccolove added inline comments. INLINE COMMENTS > mart wrote in SwipeNavigator.qml:55 > different tabbars should really depend only on whether it's a mobile device > or not (and be at bottom if mobile): a very small window on desktop is not a > mobile app I think the tabbar should not be at

D28873: Add SwipeNavigator component

niccolove added a comment. My opinion from the consistency side: I actually think this is a good possibility for the Consistency goal. After some digging around, my opinion is that > Tabs should only be used on application views that are user-editable (eg: when it's possible to open a

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added inline comments. INLINE COMMENTS > ngraham wrote in FullRepresentation.qml:31 > the visibility should be dependent on it having any items in it; or else it's > still visible when Bluetooth is disabled. I though that was done by toolbar.visible = (state == "DevicesState" ||

D28627: Adaptive panel opacity

niccolove added a comment. I feel like it makes sense for the user to want to use a opaque panel rather than a transparent one. Also, that relies on themes actually turning on the effect, while users could already benefit from it even on current themes if the setting was exposed. Also, that

D28627: WIP: Made panel opaque on maximized window

niccolove added a comment. I have a question though: we ship the pager widget in the panel that does the same by default. Wouldn't that have the same efficiency impact, if not even more? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: niccolove,

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added a comment. In D28467#646626 , @ngraham wrote: > Does `activeApplet.fullRepresentationItem` actually have a `header` property? Yes. I tried to console log it (...header) and it returns Toolbar qml element, which is

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added a comment. I need a small help for the second one. When there's no toolbar, the toolbar.visible is set to false; otherwise, it's true. But when I'm in the systemtray and I try to check activeApplet.fullRepresentationItem.header.visible, it always returns false. What could

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove updated this revision to Diff 79889. niccolove added a comment. Removed extra line REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=79155=79889 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28627: WIP: Made panel opaque on maximized window

niccolove added a comment. > You're rendering a transparent panel. we're still even blurring the background very expensively. And then we're drawing something on top. That's very wasteful. > We're also mixing up shadows from one SVG with the output of another. Right. Originally I

D28627: WIP: Made panel opaque on maximized window

niccolove added a comment. Thanks Nate for explaining. Couple of things that hit my mind: - Plasmoids should also be opaque, to be fully integrated: F8223607: Screenshot_20200407_191202.png Should I have very similiar code in the applet

D27979: Add top area to notifications

niccolove added a comment. In D27979#643330 , @ngraham wrote: > So I think the padding issue isn't related to fonts after all. I noticed while doing a backup today that there's no spacing between the header and the content underneath it even

D28627: WIP: Made panel opaque on maximized window

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY The idea is to offer an option, possibly default, to make the panel opaque when a window is maximized on the same screen.

D28576: Converted to page and added Heading

niccolove added a comment. Ok, should be fine now REPOSITORY R120 Plasma Workspace BRANCH notification_page_heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28576 To: niccolove, #plasma, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28576: Converted to page and added Heading

niccolove updated this revision to Diff 79484. niccolove added a comment. Fixed layouts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28576?vs=79347=79484 BRANCH notification_page_heading (branched from master) REVISION DETAIL

D28575: Make headings of systray and applet merge

niccolove added a comment. Should be fixed now REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28575 To: niccolove, #plasma, #vdg Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 79483. niccolove added a comment. Unnecessary newline REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=79482=79483 BRANCH systray_merged_topbar (branched from master) REVISION DETAIL

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 79482. niccolove added a comment. There was a wrong spacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=79477=79482 BRANCH systray_merged_topbar (branched from master) REVISION DETAIL

D28575: Make headings of systray and applet merge

niccolove updated this revision to Diff 79477. niccolove added a comment. Generic fixes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28575?vs=79344=79477 BRANCH systray_merged_topbar (branched from master) REVISION DETAIL

D28576: Converted to page and added Heading

niccolove added a comment. Yes, also the notifications don't fill width, just noticed, I'm investigating REPOSITORY R120 Plasma Workspace BRANCH notification_page_heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28576 To: niccolove, #plasma, mart Cc:

D28576: Converted to page and added Heading

niccolove updated this revision to Diff 79347. niccolove added a comment. Fixed context menu REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28576?vs=79346=79347 BRANCH notification_page_heading (branched from master) REVISION DETAIL

D28576: Converted to page and added Heading

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY As per D28575 , converted the FullRepr to be a Page and added a PlasmoidHeading

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove added a comment. In D28467#640854 , @ngraham wrote: > So here's what I see in the system tray popup: F8213414: Screenshot_20200403_102113.png > > The toolbar doesn't touch the edges of its

D28575: Make headings of systray and applet merge

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY When the applet is a page with a plasmoidHeading as header, merge it with systray one. Screenshots incoming. The only

  1   2   3   >