Re: Soft Feature Freeze

Hello, I would like to get one final Breeze QStyle patch into the beta: https://invent.kde.org/plasma/breeze/-/merge_requests/136 It's a one-liner that just enables antialiasing on combobox menu items, so it shouldn't cause any problems. On Thu, Sep 16, 2021 at 4:11 AM Tom Zander wrote: > > On

Re: Feedback and problems regarding the application launcher

Hi Tom, I'm already working on a patch that will solve some of the issues you listed. The current version of Kickoff has a fixed size, which is why text gets elided so much. My patch will make the default size scale to fit the content better. It's not quite ready since the context menus for apps

Re: qqc2-breeze-style

Just chiming in: I agree that qqc2-breeze-style is a stopgap and not an effective long term solution for our QQC2 theming. I agree that a new unified theming system would be the ideal solution to arrive at, but I knew it wasn't being worked on and couldn't be finished in a timely manner for the

Re: Gitlab merge workflow: reverse it?

I'm in favor of merging to master first. It's just easier for me to work that way because the cherry picking is something I can just add on top of my normal git workflow instead of having to remember a different git workflow for situations where we may want to patch a stable branch. On Thu, Jun

Re: Icon-Only Task Manager Colored Backgrounds

This looks really cool. We'd have to change our task manager style yet again to correctly show the different states though. Still, I think there are some utilities for generating colors based on image colors, so someone could make a custom task manager and put it on store.kde.org. On Fri, Jun 26,

D29154: Use QWindow overload of QIcon::pixmap

ndavis accepted this revision. ndavis added a comment. Giving this a +1 just for consistency with the kirigami and plasma-framework changes. I can't really test this since I don't have any screens with different DPIs though. REPOSITORY R31 Breeze REVISION DETAIL

D27669: [kstyle] Tools area

ndavis added a comment. The line seems to stop just short of the sidebar: F8339738: Screenshot_20200520_001106.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta,

D27669: [kstyle] Tools area

ndavis added a comment. what are some ways the issue of toolbar colors not being perfectly in sync with titlebar colors could be fixed or worked around? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta,

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

ndavis abandoned this revision. ndavis added a comment. Resuming this on invent REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29439 To: ndavis, #vdg Cc: GB_2, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D27874: Disable the audio stream indicator for IOTM by default

ndavis abandoned this revision. ndavis added a comment. Abandoning this since nobody wanted it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27874 To: ndavis, #vdg, #plasma Cc: gvgeo, ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n,

D24706: [RFC] Change button style

ndavis abandoned this revision. ndavis added a comment. Resuming this on invent REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: mart, ahiemstra, cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, dmenig,

D20569: Use more compact OSD

ndavis accepted this revision. ndavis added a comment. I have no problem with this. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D20569_2 REVISION DETAIL https://phabricator.kde.org/D20569 To: ngraham, #plasma, #vdg, broulik, niccolove, ndavis Cc: ndavis, kori, Armstrong, alexde,

D29264: New tabs for Breeze

ndavis added a comment. Would you mind moving this to GitLab? You'll just need to fork the breeze repo, add your fork as a remote to the existing repo you're working on and push your branch to the fork. For instance, this is what I do for myself: git remote add ndavis_fork

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

ndavis added a comment. wxWidgets is supposed to have GTK3 support since 2.9.4, but Audacity still uses GTK2 for me. https://docs.wxwidgets.org/3.1.3/page_port.html#page_port_wxgtk Audacity also has its own built-in themes and you can't fully use the system theme; you can only use it

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

ndavis added a comment. In D29749#671032 , @ngraham wrote: > 1. There's still GIMP (and IIRC Audacity) when it comes to major GTK2 apps. I'm not saying don't do this, but maybe it's a bit premature? GIMP has its own built-in themes now

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

ndavis added a comment. That's a good point. Is there a way to choose a different default layout based on info about the user's setup? I think choosing layouts based on the user's hardware may be necessary to get defaults that please most people while still being touch friendly in contexts

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

ndavis added a comment. I agree with the size chosen if we are doing a vertical panel, but I can't think of any way to justify this change in a way that I find satisfactory. There's no clear improvement over using a horizontal panel, just tradeoffs. REPOSITORY R119 Plasma Desktop

D29570: Fix some alignments

ndavis added inline comments. INLINE COMMENTS > PowerManagementItem.qml:34 > Layout.fillWidth: true > +Layout.leftMargin: units.smallSpacing > How does this affect RTL layouts? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29570 To:

D29081: [QStyle] Make menu titles look less like menu items

ndavis added a comment. In D29081#665226 , @cblack wrote: > In D29081#665203 , @ndavis wrote: > > > Big +1 to the idea, but this shouldn't use `darker()` because that won't look right in Breeze

D29081: [QStyle] Make menu titles look less like menu items

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Big +1 to the idea, but this shouldn't use `darker()` because that won't look right in Breeze Dark. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29081

D27669: [kstyle] Tools area

ndavis added a comment. Reposting here so that it won't be forgotten. Some windows are lacking the underline: F8288512: Screenshot_20200506_002747.png F8288514: Screenshot_20200506_002908.png For some

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

ndavis added a comment. I'm removing the dependency on the tools area patch because while it is related, this patch doesn't really depend on it and making it depend on that would unnecessarily complicate things. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29439

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ndavis added a comment. I had a look at the documentation for libinput pointer acceleration (https://wayland.freedesktop.org/libinput/doc/latest/pointer-acceleration.html). For anyone following this conversation: - `0` is the default - when greater than `0`, acceleration starts sooner

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

ndavis added a comment. In D29439#663746 , @GB_2 wrote: > Do we still want to ship the old Breeze Classic with Plasma or do we put it in `kde-vdg-extras`? I think there are quite a few people who like the mix of dark header and light content.

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ndavis added a comment. In D29365#663395 , @ngraham wrote: > Of course the problem with a spinbox is that by displaying numbers, it demands some kind of legend or label. What does a value of 100 mean? Does a value of 0 make any sense? etc. The

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

ndavis updated this revision to Diff 81966. ndavis added a comment. Fix some colors REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29439?vs=81963=81966 BRANCH new-colors (branched from master) REVISION DETAIL https://phabricator.kde.org/D29439

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

ndavis updated this revision to Diff 81963. ndavis added a comment. squash commits REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29439?vs=81962=81963 BRANCH new-colors (branched from master) REVISION DETAIL https://phabricator.kde.org/D29439 AFFECTED

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY I also renamed Breeze to Breeze Light because it's very awkward to talk about the Breeze project when

D28888: Fix navigation regressions

ndavis added a comment. Thanks, this fixes the navigation issue after a page has been selected. The main grid view is still annoying though. REPOSITORY R1014 Kirigami Gallery BRANCH cblack/better-navigation (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#639653 , @ndavis wrote: > Do we really still need Breeze Light to be separate from Breeze? I think it would make more sense to have just Breeze Light and Breeze Dark colorschemes (delete Breeze Light, rename

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Forgot to change a few more of the selection colors. I might as well post the updated Breeze Dark version too. F8271896: Breeze10.colors F8271897: BreezeDark10.colors REPOSITORY

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#659952 , @ngraham wrote: > Thanks, that's fixed now. Is the tooltip background supposed to be this grayish color though? > > F8271573: Screenshot_20200429_124914.png

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Oops, that's a leftover bit from when I was testing my changes to the Breeze QStyle. This color scheme is something I've been slowly working on for a while. New version with fixed selection color and darker titlebar: F8271489: Breeze10.colors

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Try this colorscheme for a while and see what you think of it: F8270896: BreezeDark10.colors REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove,

D27669: [kstyle] Tools area

ndavis added a comment. The only remaining problem I can find is this one with certain kinds of menu buttons: F8260819: vokoscreenNG-2020-04-26_00-43-00.mp4 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack,

D28888: Fix navigation regressions

ndavis added a comment. This needs to be rebased REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami Cc: mart, ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27669: [kstyle] Tools area

ndavis added inline comments. INLINE COMMENTS > breezetoolsareamanager.cpp:127 > +auto geoUpdate = [=]() { > +_helper->_invalidateCachedRects = true; > +emit toolbarUpdated(); I misclicked. It's this line with `_helper->_invalidateCachedRects = true;`

D27669: [kstyle] Tools area

ndavis added inline comments. INLINE COMMENTS > ndavis wrote in breezetoolsareamanager.cpp:127 > When I run GDB on `oxygen-demo5`, sometimes it tells me that `oxygen-demo5` > crashes on this line. I'm not sure how to make it happen reliably, but it > usually involves changing QStyles with the

D29012: Fix variable mixup

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Works for me REPOSITORY R31 Breeze BRANCH typo (branched from master) REVISION DETAIL https://phabricator.kde.org/D29012 To: davidre, #breeze, #plasma, ndavis Cc: ndavis,

D29144: [applets/weather] Improve UX for selecting a weather station

ndavis added a comment. Can you also make locations show up as you type so that you don't need a search button? REPOSITORY R114 Plasma Addons BRANCH better-weather-station-selection-ux (branched from master) REVISION DETAIL https://phabricator.kde.org/D29144 To: ngraham, #vdg,

D27669: [kstyle] Tools area

ndavis added a comment. I'm seeing a lot of this message in GDB when I switch from a different QStyle such as Fusion back to Breeze: QBackingStore::endPaint() called with active painter; did you forget to destroy it or call QPainter::end() on it? I also see this sometimes:

D29139: Remove .clang-format

This revision was automatically updated to reflect the committed changes. Closed by commit R161:50bde7c5ba33: Remove .clang-format (authored by ndavis). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29139?vs=81042=81058 REVISION DETAIL

D29139: Remove .clang-format

ndavis created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY It was an ignored file that was committed to the repo at some point. Because it's automatically generated and replaces the version

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. No wait, that would be half a gigabyte of stuff. Maybe not the best idea to zip it up. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#655922 , @ngraham wrote: > I mean, how to fix it with `arc`. :) I don't know what the branch looks like on your end. Maybe just zip up the whole repo and send it to me? REPOSITORY R31 Breeze REVISION

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. The event filter in `breezetoolsareamanager.cpp` already exists in the tools area patch and the other changes are incompatible with the current version of the tools area patch. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To:

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Never mind, I was wrong, I see it in arcpatch-D27669. However, just to see what would happen, I made my arcpatch-D27669 branch the upstream of arcpatch-D28317 and it said that arcpatch-D28317 was behind a commit. Are you sure you've rebased against the tools area

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. It's the change to `kstyle/breezetoolsareamanager.cpp` that causes this patch to fail to apply. That file doesn't exist anywhere. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. the cmake file in `colors/` also needs to be updated for the patch to build. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. This time when I try to apply the patch, it fails. I have the most up to date version of D27669 too. ╭ …/src/kde/workspace/breeze   master  ╰ arc patch D28317 INFO Base commit is not in local repository; trying

D29092: Various fixes to new Cards

ndavis added inline comments. INLINE COMMENTS > sdf.glsl:199 > // This > -const lowp float sdf_default_smoothing = 0.005; > +const lowp float sdf_default_smoothing = 0.4; > I played around with this value and found that 0.625 was pretty decent. It slightly improved the corners in bigscreen

D29092: Various fixes to new Cards

ndavis added a comment. This has a ShadowedRectangle underneath and a transparent Rectangle with a border on top: F8253587: Screenshot_20200422_115104.png Is there nothing that can be done about that? REPOSITORY R169 Kirigami BRANCH

D29092: Various fixes to new Cards

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Much better and thanks! LGTM REPOSITORY R169 Kirigami BRANCH cards_fixes REVISION DETAIL https://phabricator.kde.org/D29092 To: ahiemstra, #kirigami, ndavis Cc: ndavis,

D29092: Various fixes to new Cards

ndavis added a comment. Actually, width does affect the roughness. The corners are at their smoothest when the card is a square. F8253358: Screenshot_20200422_092539.png F8253360: Screenshot_20200422_092453.png

D29092: Various fixes to new Cards

ndavis added a comment. I found something vary curious and I don't know what the cause could be. The corners are smoother when the cards are taller and rougher when they are shorter. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29092 To: ahiemstra, #kirigami

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

ndavis added a comment. Oof, what a sad set of example notifications  REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28989 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D28908: Use the same icon mode calculation for comboboxes as for buttons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Ok, it took me a while to fully understand what this patch does, but it seems to be working fine. REPOSITORY R31 Breeze BRANCH combobox (branched from master) REVISION DETAIL

D28908: Use the same icon mode calculation for comboboxes as for buttons

ndavis added a comment. In D28908#651314 , @davidre wrote: > In D28908#651078 , @ndavis wrote: > > > Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and

D28908: Use the same icon mode calculation for comboboxes as for buttons

ndavis added a comment. Oddly, I can't reproduce the bug this fixes in all comboboxes. KSysGuard's process filtering and tools comboboxes are right next to each other and have different behavior. This causes another problem with all monochrome icons on the Breeze colorscheme though:

D28888: Fix navigation regressions

ndavis added a comment. In D2#649712 , @cblack wrote: > In D2#649710 , @ngraham wrote: > > > Hmm, now the cards collapse into weird pseudo-list-items in the sidebar. Could they just go back

D28873: Add SwipeNavigator component

ndavis added a comment. So are these just all views that run simultaneously like apps on a task bar? What makes this different from tabs? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: ndavis, camiloh, plasma-devel,

D28873: Add SwipeNavigator component

ndavis added a comment. What is the usecase for this? The progress tab's page highlight changes width with the percent of progress, correct? I think it looks wrong like that, unless I'm missing an important bit of context. REPOSITORY R169 Kirigami REVISION DETAIL

D28841: Raise size of default fixed-width font from 9 to 10pt

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R135 Integration for Qt applications in Plasma BRANCH even-bigger-hack (branched from master) REVISION DETAIL https://phabricator.kde.org/D28841 To: ngraham, #vdg,

D28651: Load and use global animation settings

ndavis added a comment. You need to fix the git author info. If you upload a patch via the web UI instead of `arc`, the author info gets messed up. It's still working for me. I also still need to restart apps for changes to the global animation settings to apply. REPOSITORY R31

D28072: [GTK Config] Apply color scheme to GTK3 applications

ndavis added a comment. Works for me. @ngraham, perhaps you forgot to restart `kded5`? I forgot that at first. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH set-colors REVISION DETAIL https://phabricator.kde.org/D28072 To: gikari, cblack, #plasma Cc: ndavis, ngraham, davidre,

D28651: Load and use global animation settings

ndavis added a comment. I don't know enough about KDE configuration management to judge the code, but changing animation speeds in SySe works if I restart apps after the change. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: ngraham,

D28651: Load and use global animation settings

ndavis added a comment. So this makes Breeze respect the global animation speed setting in the Workspace Behavior - > General Behavior KCM? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: ndavis, plasma-devel, #breeze, Orage,

D28646: [Notifications] Sort popups ascending

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Nice usability improvement! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28646 To: broulik, #plasma, #vdg, ndavis Cc: ndavis, plasma-devel, Orage,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D28280#640239 , @ngraham wrote: > Currently there are only two choices, yes. However as mentioned before, one of the goals of this patch

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ndavis added a comment. Why isn't a checkbox better than a combobox here? Aren't there only 2 opposite choices here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28280 To: ngraham, #vdg, #baloo, #plasma Cc: ndavis, bruns, plasma-devel, Orage, LeGast00n,

D27669: [kstyle] Tools area

ndavis added a comment. In D27669#639519 , @ngraham wrote: > While working on D28317 , I noticed something: when a window becomes inactive, the icons change their colors, but only for the parts of the icon

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#639693 , @ngraham wrote: > But would we still have Breeze, Breeze Light, and Breeze Dark Plasma themes? If we're going to get rid of the Breeze color scheme and just have light and dark, it might be a bit odd

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Do we really still need Breeze Light to be separate from Breeze? I think it would make more sense to have just Breeze Light and Breeze Dark. After that, we should refer to all light versions of Breeze as Breeze Light instead of just Breeze. Breeze should then only be

D28461: In sidebar mode show if a module is in default state or not

ndavis added a comment. In D28461#639470 , @ngraham wrote: > So every single KCM will need to be patched to add a settings proper in support of this? Oof. Is there no easier way? Perhaps we could find a way to turn it to our advantage?

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. it succeeds. It probably doesn't need whatever commit it's trying to use. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#639599 , @ngraham wrote: > You don't need to already be on the other branch, just apply this on top of master. If all goes well, `arc` should first apply D27669 , then this

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. When I try to get this patch with `arc patch` on top of the branch for D27669 , git says a cherry pick failed. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#638344 , @ngraham wrote: > @ndavis like this? > > F8206344: Screenshot_20200330_123644.png yes REPOSITORY R31 Breeze REVISION DETAIL

D28461: In sidebar mode show if a module is in default state or not

ndavis added a comment. maybe it would make more sense to add a different way to view non-default settings? like maybe a summary of custom settings. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg

D28461: In sidebar mode show if a module is in default state or not

ndavis added a comment. This is merely an indicator and not a button, right? If so, you should not use `edit-reset` since you cannot actually reset the settings there. I'll try to come up with another indicator. I'm concerned that this indicator will make system settings visually messy.

D27669: [kstyle] Tools area

ndavis added a comment. I've discovered another bug. When you move a window by dragging on an empty area, the hover effect on toolbar buttons stops working. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta,

D28356: Applies the KDE1-style 'Classik' titlebar button icon style to Breeze

ndavis added a comment. In D28356#636362 , @paulm wrote: > > It has been part of the default kde look for many years (for all of oxygen and breeze) and forms a core part of our design brand. It's something where you can spot breeze on the first

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added inline comments. INLINE COMMENTS > breeze.kcfg:36 > > -true > +false > Maybe instead of disabling this, we should make its color red? I like the circle and making it red would be more consistent with our icons. REPOSITORY R31 Breeze REVISION DETAIL

D27669: [kstyle] Tools area

ndavis added a comment. I use a kdesrc-build environment. My process was this: cd breeze arc patch D27669 ninja -C "$( pwd | sed 's:/src/:/build/:' )" install #I use this through a script named kdesrc-ninja and it works well source ~/kde/.setup-env #This makes the

D27669: [kstyle] Tools area

ndavis added a comment. In D27669#634758 , @ngraham wrote: > So I'm still having an issue with the feature um, not working. :( I have it turned on in the Breeze settings but it behaves as if off; that is to say, I see no different appearance

D28211: [applets/systemtray] Make Pin button a bit larger

ndavis added a comment. In D28211#632893 , @ngraham wrote: > The size is actually perfect for being a ToolButton: F8194949: Screenshot_20200323_085422.png > > However yeah, the actual icon size in a

D27874: Disable the audio stream indicator for IOTM by default

ndavis added a comment. In D27874#628714 , @ngraham wrote: > Title needs updating to reflect the current state of the patch, if you'd still like to propose that we do this. I'm still not sure I understand the point. The indicator is already

D28064: [applet/notes] Show a "remove" button on the button row

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. makes sense to me REPOSITORY R114 Plasma Addons BRANCH show-remove-button-too (branched from master) REVISION DETAIL https://phabricator.kde.org/D28064 To: ngraham, #vdg, #plasma,

D27669: [kstyle] Tools area

ndavis added a comment. In D27669#627465 , @davidre wrote: > In D27669#627464 , @ndavis wrote: > > > Do we need to add a Header color set to KColorScheme? > > > How would that help? KIconLoader

D27669: [kstyle] Tools area

ndavis added a comment. Do we need to add a Header color set to KColorScheme? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, manueljlin, niccolove,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ndavis added a comment. @davidedmundson Nate says smallSpacing doesn't work here. Do you know why? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: davidedmundson, ndavis, KonqiDragon, niccolove, The-Feren-OS-Dev,

D27874: Disable the audio stream indicator for IOTM

ndavis updated this revision to Diff 77045. ndavis added a comment. - Use an option instead REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27874?vs=77043=77045 BRANCH disable-audioindicator-iotm (branched from master) REVISION DETAIL

D27874: Disable the audio stream indicator for IOTM

ndavis added a comment. Do we really want a feature that new users have to learn to dodge? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27874 To: ndavis, #vdg, #plasma Cc: ngraham, broulik, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27874: Disable the audio stream indicator for IOTM

ndavis updated this revision to Diff 77043. ndavis added a comment. - Hide audio indicator setting for IOTM REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27874?vs=77040=77043 BRANCH disable-audioindicator-iotm (branched from master) REVISION

D27874: Disable the audio stream indicator for IOTM

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY After having used it for months, it still gets in the way when used with the Icons-only Task

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ndavis added a comment. In D27845#622434 , @KonqiDragon wrote: > Why Show/Hide Desktop icon is so huge? Because icon sizing in panels is a mess. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To:

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

ndavis added a comment. I don't want to turn this into bikeshedding, but I think a size of 42 is better because that raises the size of task manager icons to 32px. 22px is pretty small for an IOTM. With that said, I think something we'll have to work on is finding ways to improve the way

D27807: Changed style of pressed list item to be consistent

ndavis added a subscriber: plasma-devel. ndavis added a comment. It's strange that the plasma-devel mailing list isn't automatically added, even when it's a reviewer group. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove,

D27669: WIP: [kstyle] Tools area

ndavis added a comment. Okular has the same problem as Dolphin. Backtrace: F8143746: okular-20200301-093637.kcrash.txt REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg Cc: davidedmundson,

D27669: WIP: [kstyle] Tools area

ndavis added a comment. It's too hard to tell the difference between active and inactive icons: F8143741: Screenshot_20200301_093349.PNG REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg

  1   2   3   4   5   6   7   >