D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. > I hope you don't mind that. On the contrary, I'm very glad it was picked up and even got to some mass media :) Sure, just ping me for review, I have a vacation in October. REPOSITORY R437 Desktop Sharing REVISION DETAIL

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich In my regularly-irregular wanderings I noticed you already picked up changes from this diff and that's totally okay. Should I close this? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich you didn't change FindSPA, is it ok? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications Cc: zzag, jgrulich, alexeymin, plasma-devel, ragreen, Pitel,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich thanks, I'll definitely use that. Have my hands fullatm but will definitely return to this diff and refresh once have some free time REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich thanks a lot! I'll address these on weekend REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin, #plasma, #kde_applications Cc: zzag, jgrulich, alexeymin, plasma-devel, ragreen,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @alexeymin This is a working version but I plan on adding stuff in the coming weekends. Just wanted to make sure there's someone motivated to review and merge this. Thanks for looking at my diffs. REPOSITORY R437 Desktop Sharing REVISION DETAIL

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. 1. Make sure you have latest versions of KWin, XDG-KDE and Pipewire installed 2. Services should be started by DBus-activation, if that doesn't happen by whatever reason, first start `$ pipewire`, then `$ /usr/lib(exec)/xdg-desktop-portal`, it should in turn start

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich @alexeymin please review new framebuffer approach This is the first draft of the implementation. I intend to add more features and fix review comments in the process. Missing features: - Only knows about first screen for now - Doesn't fail

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias updated this revision to Diff 34665. Kanedias edited the summary of this revision. Kanedias added a comment. Rewrite everything from scratch with Pipewire connectivity in mind REPOSITORY R437 Desktop Sharing CHANGES SINCE LAST UPDATE

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @jgrulich , thanks for the pointers REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin Cc: jgrulich, alexeymin, plasma-devel, ragreen, Pitel, schernikov, ZrenBot, lesliezhai, ali-mohamed,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Ah, that's because I use custom built XDP-KDE executable, installed to prefix instead of /usr REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin Cc: jgrulich, alexeymin, plasma-devel,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Nailed it, XDP just thinks KDE is inferior: XDP: loading /usr/share/xdg-desktop-portal/portals/kde.portal XDP: portal implementation for KDE XDP: portal implementation supports org.freedesktop.impl.portal.Access XDP: portal implementation supports

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Hmm XDG Desktop Portal 0.11 just simply doesn't have ScreenCast interface on DBus... @jgrulich do I need some bleeding edge version or is it not yet in master branch? REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To:

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Thanks for the xml, I was able to pass it to qdbus2cpp. Amusingly, if I just try `auto reply = dbusXdpService->CreateSession(QVariantMap());` (with empty parameter map), the main desktop portal app just segfaults! I mean, not the kde impl one but the main XDG

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a subscriber: jgrulich. Kanedias added a comment. @jgrulich I started to hack together a very simple krfb-with-dbus-with-xdp-kde-with-pipewire... thingie. Now I'm curious, you have `handle` and `session_handle` paths everywhere in Screencast interface inside XDP-KDE source.

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Too late did I realize that I'm making pipewire-based framebuffer, not xdp-kde based! I guess rewiring stuff will take another 3-4 days, sorry :D REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. I've digged through old diff and I must say, many of what's described here will be peeled off. For now we support read-only views, so I'll be focusing on it. REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias,

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. Sure, I'll be updating diff this week, will address concerns raised here REPOSITORY R437 Desktop Sharing REVISION DETAIL https://phabricator.kde.org/D6096 To: Kanedias, davidedmundson, graesslin Cc: alexeymin, plasma-devel, ragreen, schernikov, ZrenBot,

D1230: GBM remote access support for KWin

Kanedias added a comment. I'll take a look once I'm home REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: bcooksley, kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson,

D1230: GBM remote access support for KWin

Kanedias added a comment. @bcooksley this file was merged in D1231 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: bcooksley, kossebau, jgrulich, romangg, ngraham,

D1230: GBM remote access support for KWin

Kanedias added a comment. Done! Thanks for looking this through. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson,

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. - squashed before pushing - fixed all versions to 5.45 Thanks gentlemen, it's was 1 day more for the second birthday of this patch :) REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson,

D1231: Add Remote Access interface to KWayland

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:5116fe0c6345: Add Remote Access interface to KWayland (authored by Kanedias). CHANGED PRIOR TO COMMIT

D1230: GBM remote access support for KWin

Kanedias closed this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, ragreen, schernikov, iodelay,

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30273. Kanedias marked an inline comment as done. Kanedias added a comment. - Merge branch 'master' into gbm-vnc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=30272=30273 BRANCH gbm-vnc REVISION DETAIL

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30272. Kanedias added a comment. Remove already merged changes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=30271=30272 BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1231 AFFECTED FILES

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 30271. Kanedias added a comment. - Implement releasing of client-freed output - Review fixes REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=25976=30271 BRANCH gbm-vnc REVISION DETAIL

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 30189. Kanedias added a comment. Remove override fix REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=30092=30189 BRANCH fix-clang REVISION DETAIL https://phabricator.kde.org/D1230 AFFECTED FILES

D1230: GBM remote access support for KWin

Kanedias added a comment. This makes sense. Thanks, will try with KDecoration master once I'm home REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid,

D1230: GBM remote access support for KWin

Kanedias added a comment. I don't have KDecoration checked out. The problem is much more simple. These functions don't override anything but there's override keyword present where it shouldn't be. The fix is still required for them, regardless of KDecoration status. Any other issues

D1230: GBM remote access support for KWin

Kanedias marked an inline comment as done. Kanedias added a comment. They don't override anything and compile fails for me if they are present. GCC 7.3.1. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc:

D1230: GBM remote access support for KWin

Kanedias requested review of this revision. Kanedias marked an inline comment as done. Kanedias added inline comments. INLINE COMMENTS > romangg wrote in drm_output.h:135 > This gives me an compile error: invalid static_cast from type 'QObject*' to > type 'KWayland::Server::OutputInterface*' >

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 30092. Kanedias added a comment. - Fix clang compilation - Fix QPointer REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=29434=30092 BRANCH fix-clang REVISION DETAIL https://phabricator.kde.org/D1230

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 29434. Kanedias added a comment. Typo REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=29433=29434 BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 AFFECTED FILES

D1230: GBM remote access support for KWin

Kanedias added inline comments. INLINE COMMENTS > romangg wrote in egl_gbm_backend.cpp:160 > Should be the default not directly activated remote funcitonality? And if one > wants to deactivate remote set `KWIN_NO_REMOTE` or something. There's no authentication protocol, so any malicious

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 29433. Kanedias marked 6 inline comments as done. Kanedias added a comment. Review fixes REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=28973=29433 BRANCH gbm-vnc REVISION DETAIL

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. In D1231#224441 , @jtamate wrote: > As I don't see anything related to security in this patch, I have two questions. > > Could anyone with access to server:port manage the server wayland sessions or just create a

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. It will soon be this patch 2nd birthday. Can we speed up things a bit? I've seen this is scheduled for Plasma 5.13, would be good if we have time to test it. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin,

D1230: GBM remote access support for KWin

Kanedias added a comment. Please re-review this and D1231 as I'm starting to work on KRfb support for this and it will be the 3rd patch depending on this. Or suggest reviewers with more spare time so they can look this through. REPOSITORY R108 KWin

D1230: GBM remote access support for KWin

Kanedias marked 2 inline comments as done. Kanedias added a comment. @romangg , I had to recreate it after rebase, cause I don't have force-push. REPOSITORY R108 KWin BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg,

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 28973. Kanedias added a comment. Review comments REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=25979=28973 BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 AFFECTED FILES

D1230: GBM remote access support for KWin

Kanedias added a comment. @graesslin , @davidedmundson , please approve this once again, this was updated numerous times after initial review REPOSITORY R108 KWin BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @graesslin , @davidedmundson , please approve this once again, this was updated numerous times after initial review REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jgrulich,

D1231: Add Remote Access interface to KWayland

Kanedias added a task: T7785: PipeWire support in remote access to KWin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson, romangg Cc: jgrulich, romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel,

D1230: GBM remote access support for KWin

Kanedias added a task: T7785: PipeWire support in remote access to KWin. REPOSITORY R108 KWin BRANCH gbm-vnc REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin,

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 25979. Kanedias added a comment. - Merge branch 'master' into gbm-vnc - Fix compilation on Clang REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=21211=25979 BRANCH gbm-vnc REVISION DETAIL

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 25976. Kanedias edited the test plan for this revision. Kanedias added a comment. - Add RemoteAccess interface to KWayland - Merge branch - Fix compilation warnings uint -> int REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D1230: GBM remote access support for KWin

Kanedias added a comment. Hi @jgrulich! There are actually two sides of this dime. The one that I wanted to take is implementing pipewire server in kded. It will be responsible for converting GBM fds to PW video stream fds and will announce this interface via DBus like Mutter does

D9804: Add BusyIndicator to the styled controls list

Kanedias added a dependent revision: D9708: Add progress loading icon to QtQuick server row. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9804 To: Kanedias, mart Cc: alexeymin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D1230: GBM remote access support for KWin

Kanedias added a comment. @romangg , let's go with following approach: I'll upstream all changes I have left hanging (e.g. https://phabricator.kde.org/D9708) by the end of this week and will try to come up with some PoC work with PipeWire solution this/next weekend. After it is working

D1230: GBM remote access support for KWin

Kanedias added a comment. @ngraham I'm still waiting for a review to land this REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, romangg, #kwin Cc: romangg, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson,

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @ngraham, yes, he didn't review this after changes were made REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: romangg, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu,

D9803: Apply some C++11 niceties, styling consistency

Kanedias closed this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9803: Apply some C++11 niceties, styling consistency

Kanedias updated this revision to Diff 25244. Kanedias added a comment. Rebased REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9803?vs=25198=25244 BRANCH c++11 REVISION DETAIL https://phabricator.kde.org/D9803 AFFECTED

D9804: Add BusyIndicator to the styled controls list

Kanedias added a comment. In https://phabricator.kde.org/D9804#189751, @alexeymin wrote: > Can tier 1 framework depend on other tier 1 framework? Not sure, but qqc2-desktop-style used Kirigami units before this change so we depended on it already. REPOSITORY R858 Qt Quick

D9803: Apply some C++11 niceties, styling consistency

Kanedias added a comment. Will update this today with changes from caching by Alex REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9803: Apply some C++11 niceties, styling consistency

Kanedias marked 3 inline comments as done. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9803: Apply some C++11 niceties, styling consistency

Kanedias updated this revision to Diff 25198. Kanedias added a comment. Fix palette array allocation REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9803?vs=25123=25198 BRANCH c++11 REVISION DETAIL

D9804: Add BusyIndicator to the styled controls list

This revision was automatically updated to reflect the committed changes. Closed by commit R858:d3ae9304298f: Add BusyIndicator to the styled controls list (authored by Kanedias). Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY

D9803: Apply some C++11 niceties, styling consistency

Kanedias added inline comments. INLINE COMMENTS > apol wrote in plasmadesktoptheme.cpp:160 > if you make it `auto` the initializer_list will be used not requiring the > allocation AFAIU. > That said, I wonder if the compiler can unwind a foreach. I didn't quite get it, you mean we can write

D9803: Apply some C++11 niceties, styling consistency

Kanedias edited the summary of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9803: Apply some C++11 niceties, styling consistency

Kanedias updated this revision to Diff 25123. Kanedias added a comment. Apply some C++11 niceties, styling consistency REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9803?vs=25122=25123 BRANCH master REVISION DETAIL

D9803: Apply some C++11 niceties, styling consistency

Kanedias added a reviewer: mart. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9803: Apply some C++11 niceties, styling consistency

Kanedias created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Kanedias requested review of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL

D1231: Add Remote Access interface to KWayland

Kanedias marked 5 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: subdiff, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 21212. Kanedias added a comment. Updated against latest master, fixed review comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=16359=21212 REVISION DETAIL https://phabricator.kde.org/D1231

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 21211. Kanedias marked 2 inline comments as done. Kanedias added a comment. Updated against latest master REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=18859=21211 REVISION DETAIL

D1230: GBM remote access support for KWin

Kanedias added a comment. Fixed review comments REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson, subdiff, #kwin Cc: subdiff, ngraham, alexeymin, aacid, kwin, #kwin, davidedmundson, plasma-devel, bwowk, leezu, ZrenBot,

D1230: GBM remote access support for KWin

Kanedias added a comment. Ok @subdiff, I've got your idea. I'll align my patches with newest sources ASAP, check that they work, then we'll talk about what to do with KDE Daemon and Screen Recorder. I just don't want to spread my efforts too much, maintaining more than one patchset in

D1230: GBM remote access support for KWin

Kanedias added a comment. > On the other side PipeWire is pretty new and its documentation is nearly non-existent. I don't know if with PipeWire it really could work in the way I described above. Your current solution works right now. It might still be an idea if you are interested to check

D1230: GBM remote access support for KWin

Kanedias added a comment. > The thing is I would like to see your solution also be applicable to other apps that need access to the buffer contents, like screen recording tools (SimpleScreenRecorder for example) and so on. If you say KRfb does the heavy-lifting, I assume such a screen

D1231: Add Remote Access interface to KWayland

Kanedias added inline comments. INLINE COMMENTS > subdiff wrote in remote_access_interface.cpp:206 > Can a rogue client do it though? This would crash the server then? > Can a rogue client do it though? This would crash the server then? Yes, I guess so... What would you propose? Should we send

D1230: GBM remote access support for KWin

Kanedias added a comment. In https://phabricator.kde.org/D1230#158795, @subdiff wrote: > Hi Oleg Hi. Haven't been here in a long time. > - Please merge current master. Will do this and fix review comments on weekend (or earlier if I can). > - The RemoteAccessManager

D1230: GBM remote access support for KWin

Kanedias added a comment. In https://phabricator.kde.org/D1230#158542, @ngraham wrote: > With https://phabricator.kde.org/D6186 merged, is this now ready to go in? Yes, just waits for @graesslin's final review :) REPOSITORY R108 KWin REVISION DETAIL

D6096: Add Wayland RemoteAccess capabilities to KRfb

Kanedias added a comment. @alexeymin , yeah, I've seen news about KRfb changes not so long ago. I'll fix this PR after support once remote access is upstreamed, it's quite troublesome to maintain so many changes around. Thanks for comments! P.S. The thing I'm stuck on is keyboard

D1230: GBM remote access support for KWin

Kanedias updated this revision to Diff 18859. Kanedias added a comment. Fixes for review comments, rebased to latest version REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1230?vs=15146=18859 REVISION DETAIL https://phabricator.kde.org/D1230 AFFECTED

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. Gentle reminder REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. Btw, should I bump patches to KWin/KRfb to match this version? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @davidedmundson , @graesslin , I cleaned up fake-input handling, fixed autotests. Tested this manually with patched KWin and KRfb version - all works fine (only one screen though). I'm able to retrieve wl_output from native interface as David suggested.

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 16359. Kanedias added a comment. some -> const modifiers and typos REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=16318=16359 REVISION DETAIL https://phabricator.kde.org/D1231 AFFECTED FILES

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. I'll get rid of the fakeinput-related changes and test it with KRfb tomorrow. @davidedmundson , can you test this with multiple outputs? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc:

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 16318. Kanedias added a comment. Added wl_output reference for buffers as requested by @davidedmundson and @graesslin REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=15553=16318 REVISION DETAIL

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. How do I get ID from wl_output interface? I kinda got how I can get the needed info from DrmOutput instance, but not sure how to compare them on server and client side REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias,

D6186: Implement software cursor in OpenGL backend

This revision was automatically updated to reflect the committed changes. Kanedias marked 2 inline comments as done. Closed by commit R108:247ef43f683b: Implement software cursor in OpenGL backend (authored by Kanedias). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6186: Implement software cursor in OpenGL backend

Kanedias marked 2 inline comments as done. Kanedias added inline comments. INLINE COMMENTS > graesslin wrote in scene_opengl.cpp:682-685 > Instead of adding an empty method you could make it pure virtual That moment when I noticed we have no SceneOpenGL instantiations. Tx! > graesslin wrote in

D6186: Implement software cursor in OpenGL backend

Kanedias updated this revision to Diff 15860. Kanedias marked an inline comment as done. Kanedias added a comment. Review comments fixes REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6186?vs=1=15860 REVISION DETAIL https://phabricator.kde.org/D6186

D6186: Implement software cursor in OpenGL backend

Kanedias added inline comments. INLINE COMMENTS > luebking wrote in scene_opengl.cpp:713 > You still update the cursor texture with every paint() - there should be no > need to hook this signal. > Actually, the patch got much worse: > > a) you're fetching the image and reset the texture with

D6186: Implement software cursor in OpenGL backend

Kanedias marked 3 inline comments as done. Kanedias added a comment. Fixed lazy-init REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6186 To: Kanedias, graesslin, davidedmundson Cc: luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai,

D6186: Implement software cursor in OpenGL backend

Kanedias updated this revision to Diff 1. Kanedias added a comment. Whoops, wrong patch REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6186?vs=15554=1 REVISION DETAIL https://phabricator.kde.org/D6186 AFFECTED FILES scene_opengl.cpp

D6186: Implement software cursor in OpenGL backend

Kanedias updated this revision to Diff 15554. Kanedias added a comment. Fixes for lazy-init (thanks T.L.) REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6186?vs=15397=15554 REVISION DETAIL https://phabricator.kde.org/D6186 AFFECTED FILES

D6186: Implement software cursor in OpenGL backend

Kanedias added inline comments. INLINE COMMENTS > luebking wrote in scene_opengl.cpp:699 > The entire head should probably be in some init function, not in every paint > call. > If you go for a lazy init, you should seekt to prevent double connects (but I > don't know whether

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 15553. Kanedias added a comment. Fixed KWAYLAND -> Kwayland in CmakeLists.txt REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=15125=15553 REVISION DETAIL https://phabricator.kde.org/D1231 AFFECTED FILES

D1231: Add Remote Access interface to KWayland

Kanedias added a comment. @davidedmundson , do we really have nativeResourceForScreen call? AFAIK KWin uses its own QPA, which implements only bits of functionality. We need to have nativeResourceForScreen to be able to pass wl_output, should I patch QPA also, or is there better way?

D6186: Implement software cursor in OpenGL backend

Kanedias marked an inline comment as done. Kanedias added a comment. @graesslin , are you here? Can you look at this submission please if you have time? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6186 To: Kanedias, graesslin, davidedmundson Cc: plasma-devel,

D6186: Implement software cursor in OpenGL backend

Kanedias marked an inline comment as done. Kanedias added a comment. I'm still unsure about cursor damage region (digging through cursor-related signals now) Cursor itself works fine, tested on kms Mesa 17.1.2 amdgpu (and in KRfb session) INLINE COMMENTS > davidedmundson wrote in

D6186: Implement software cursor in OpenGL backend

Kanedias updated this revision to Diff 15397. Kanedias added a comment. Whoops... :) REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6186?vs=15396=15397 REVISION DETAIL https://phabricator.kde.org/D6186 AFFECTED FILES scene_opengl.cpp scene_opengl.h

D6186: Implement software cursor in OpenGL backend

Kanedias updated this revision to Diff 15396. Kanedias added a comment. - Made cursor texture local var with lazy-init - Made changes to support cursor shape update - Added cursor hotspot handling - Removed redundant vbo calls REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D1230: GBM remote access support for KWin

Kanedias added a comment. Added auxiliary patch for mouse cursor in https://phabricator.kde.org/D6186 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D1230 To: Kanedias, graesslin, davidedmundson Cc: kwin, #kwin, davidedmundson, plasma-devel, ZrenBot, spstarr,

D6186: Implement software cursor in OpenGL backend

Kanedias added a comment. Hi Martin, David. This is my first change in OpenGL-related stuff, where I don't yet have firm ground. I've tested this change on DRM session in my vt2 and it works, but I have some concerns, - Is this the correct way of doing such stuff? - Should

D6186: Implement software cursor in OpenGL backend

Kanedias added dependencies: D1230: GBM remote access support for KWin, D1231: Add Remote Access interface to KWayland. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6186 To: Kanedias, graesslin, davidedmundson Cc: plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff,

  1   2   >