Re: Plasma 5.26.3: Breeze is broken

2022-12-01 Thread Rik Mills
On 08/11/2022 17:57, Fabian Vogt wrote:> Hi, > > Am Dienstag, 8. November 2022, 15:28:54 CET schrieb Jonathan Riddell: >> Plasma 5.26.3 is now released https://kde.org/announcements/plasma/5/5.26.3 > > At least breeze has the wrong version in its CMakeLists.txt: > > set(PROJECT_VERSION

Re: Plasma 5.24.2

2022-02-22 Thread Rik Mills
On 22/02/2022 13:56, Jonathan Riddell wrote: > Plasma 5.24.2 is now released > https://kde.org/announcements/plasma/5/5.24.2 > Discover fails to build /<>/libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp: In member function ‘void

Re: Next Plasma LTS?

2022-01-10 Thread Rik Mills
On 10/01/2022 11:28, Marco Martin wrote: > as said in the meeting notes, there is a request from Opensuse and Kubuntu to > do a new Plasma LTS release. > Optimal for them would be 5.24, but a potential problem is that is a quite > feature heavy release, so it may be too buggy for an lts. > >

Re: Next Plasma LTS?

2022-01-10 Thread Rik Mills
On 10/01/2022 11:28, Marco Martin wrote: > Optimal for them would be 5.24, but a potential problem is that is a quite > feature heavy release, so it may be too buggy for an lts. Not so much optimal, but the only possible option that would work for 22.04 LTS

Re: 5.24 as LTS

2021-12-22 Thread Rik Mills
On 22/12/2021 19:28, Jonathan Riddell wrote: > We've had a late request for 5.24 to be an LTS. > > We had previously said the final Plasma 5 release would be the one > before Plasma 6, but there's no immediate sign of a Plasma 6.  > > What do devs think of making 5.24 an LTS? > > Jonathan

Re: Using C++20 in Plasma

2021-08-07 Thread Rik Mills
On 06/08/2021 12:06, Nicolas Fella wrote: > Hi, > > I would like to explore whether it would be feasible from a distribution > POV to use C++20 in Plasma (and other non-Frameworks projects). > > In practical terms this would mean something like requiring gcc 10 or > clang 10 (the exact version

Re: Plasma discover updates page blank (5.20.3, with frameworks 5.74 and Qt 5.15.1`)

2020-12-01 Thread Rik Mills
Qt 5.15 landing once 21.04 development opened. Resulting in skipping 5.75 and going straight to 5.76 when it comes out tomorrow. Fortunately, this is only in the Kubuntu dev release, so not as bad as could have been. > On 11/13/20 6:48 AM, Rik Mills wrote: >> Plasma discover updates page i

Re: Plasma discover updates page blank (5.20.3, with frameworks 5.74 and Qt 5.15.1`)

2020-11-13 Thread Rik Mills
Qt 5.15 landing once 21.04 development opened. Resulting in skipping 5.75 and going straight to 5.76 when it comes out tomorrow. Fortunately, this is only in the Kubuntu dev release, so not as bad as could have been. > On 11/13/20 6:48 AM, Rik Mills wrote: >> Plasma discover updates page i

Plasma discover updates page blank (5.20.3, with frameworks 5.74 and Qt 5.15.1`)

2020-11-13 Thread Rik Mills
Plasma discover updates page is blank when updates exist: Version 5.20.3, with frameworks 5.74 and Qt 5.15.1 Discover updates page: https://i.imgur.com/8LpPCEW.png Error on clicking to navigate to that page: https://i.imgur.com/jVTCCdy.png It has been suggested that official required kirigami

Re: Unannounced new dependency in plasma-desktop

2020-08-08 Thread Rik Mills
On 08/08/2020 12:22, Dan Leinir Turthra Jensen wrote: > On Friday, 7 August 2020 22:55:20 BST Ben Cooksley wrote: >> Hi Plasma Developers, >> >> It appears that in the past 24 hours you have introduced new >> dependencies in the plasma-desktop repository without announcing them >> 2 weeks in

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

2020-05-07 Thread Rik Mills
rikmills added a comment. Is this to land in 5.19? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27845 To: ngraham, #vdg, #plasma Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, The-Feren-OS-Dev, plasma-devel, Orage,

Re: repo freeze tomorrow

2020-04-30 Thread Rik Mills
On 30/04/2020 18:33, Aleix Pol wrote: > Yes, in practice. In practice? What other way is there? Now I check some more they seem very non-optional.

Re: repo freeze tomorrow

2020-04-30 Thread Rik Mills
On 29/04/2020 22:04, David Edmundson wrote: > We have something announced that I'm not sure is on the list. > > Plasma will gain a new repo called kwayland-server. > This is a split of half the code currently in framework. > > Aleix has things prepared, but we haven't done all the steps to

Re: Plasma 5.18 LTS

2020-04-29 Thread Rik Mills
On 29/04/2020 17:22, Jonathan Riddell wrote: > Plasma 5.18 is due to have its .5 release shortly and then we'll move > onto Plasma 5.19 releases.  Plasma 5.18 is an LTS so its translations > will get put into the LTS branch and it'll move to 6 monthly releases > until we decide on another LTS. >

D28710: Make accidental panel and panel widget deletion more difficult

2020-04-16 Thread Rik Mills
rikmills added a comment. In D28710#647340 , @davidedmundson wrote: > We shouldn't be making UX changes on the stable branch I agree. This could make getting the 5.18.5 release accepted as a K/Ubuntu stable release update (SRU) in a few

D27595: Watch for language change events, and forward those to the QML engine

2020-03-28 Thread Rik Mills
rikmills added a comment. In D27595#636640 , @vkrause wrote: > I haven't seen a backtrace for this, but from what I understood from the chat backlog this is triggering a QML bug (?) due to the re-evaluation of qsTr() with 5.12, rather than

D28360: cmake: make xsettingsd check an option

2020-03-28 Thread Rik Mills
rikmills added a comment. In D28360#636615 , @eszlari wrote: > https://packages.ubuntu.com/focal/kde-config-gtk-style > https://src.fedoraproject.org/rpms/kde-gtk-config/blob/master/f/kde-gtk-config.spec >

D27595: Watch for language change events, and forward those to the QML engine

2020-03-27 Thread Rik Mills
rikmills added a comment. git bisect also shows that this crashes the virtual desktop and regional settings KCM in Kubuntu 20.04 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27595 To: vkrause, mart Cc: rikmills, ngraham, apol, plasma-devel, fbampaloukas, GB_2,

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

2020-02-01 Thread Rik Mills
rikmills added a comment. In D27077#604505 , @broulik wrote: > Having Kickoff confirm shutdown could be superfluous as you already had to go through the trouble of opening it, going to "Leave", but for e.g. the lock logout entry or generic "

D27045: [wallpapers] Use more high-quality JPEGs for Next

2020-01-31 Thread Rik Mills
rikmills added a comment. I don't object to bumping the size for this release. However, I do wonder if it might be worth thinking about future guidelines/rules regarding wallpaper maximum sizes after optimisation. REPOSITORY R31 Breeze BRANCH more-hq-next (branched from master)

D21226: search for a default wallpaper in lookandfeel

2020-01-29 Thread Rik Mills
rikmills added a comment. Would this handle the case where an existing look-and-feel package that did NOT specify a wallpaper, then in a new version adds one? And that occurs on a users system the l-n-f package was already active and plasma is long past 1st plasma start. REPOSITORY R120

D26847: Hide irrevelevant default button, code clean and future proofing

2020-01-24 Thread Rik Mills
rikmills added a comment. Fails to build: https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console 00:42:51 /workspace/build/src/usermanager.cpp: In constructor ‘UserManager::UserManager(QWidget*, const QVariantList&)’: 00:42:51

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

2019-12-30 Thread Rik Mills
rikmills added a comment. This does NOT fix BUG: 415666. The distro native sources button is still missing. Git master with this change: F7850103: 230501812c.png Correctly showing sources button before commit

D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors

2019-10-05 Thread Rik Mills
rikmills added a comment. add_compile_definitions requires cmake 3.13, so breaks build in Neon where cmake from Bionic is 3.10 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8626 To: dvogel, broulik, davidedmundson Cc: rikmills, ngraham, asturmlechner,

Re: Plasma 5.12.9 LTS

2019-09-11 Thread Rik Mills
On 10/09/2019 17:21, Jonathan Riddell wrote: > Plasma 5.12.9 LTS > is now released https://www.kde.org/announcements/plasma-5.12.9.php Kwin to fails to build with Qt 5.9. Plasma 5.12 should build with 5.9. /effects/screenshot/screenshot.cpp:110:15: error: ‘const class QImage’ has no member

Re: Plasma 2020 release schedules

2019-07-23 Thread Rik Mills
On 23/07/2019 16:53, Jonathan Riddell wrote: > https://community.kde.org/Schedules/Plasma_5 Has someone made changes to how table formatting is done there, or on the wiki as a whole? That lack of table lines and borked alignment looks dreadful. > Distros, please say if you would like any of

D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present

2019-07-03 Thread Rik Mills
rikmills added a comment. So if XDG_CONFIG_DIRS contains additional locations, this will not work? e.g. in Kubuntu we set up: XDG_CONFIG_DIRS="$XDG_CONFIG_DIRS:/usr/share/kubuntu-default-settings/kf5-settings" REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D22238

D21593: [showdesktop] Reduce the maximum panel icon size

2019-06-05 Thread Rik Mills
rikmills added a comment. This also needs to be applied to the minimizeall widget, as this is the directly (right click) selectable alternative to showdesktop widget, so the icon size change would revert if a user switched the panel widget to this. REPOSITORY R119 Plasma Desktop REVISION

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-05-19 Thread Rik Mills
rikmills added a comment. > ! In D19631#467167 , @filipf wrote: > > Why does it look different than Neon? Seems neon have a settings tweak to force more font Noto (especially for sddm). Cherry picking that... REPOSITORY R120 Plasma

D19631: [sddm-theme/lock screen] Overhaul font sizes

2019-05-19 Thread Rik Mills
rikmills added a comment. Not looking good. F6835091: c0924558f6.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19631 To: rooty, #vdg, #plasma, ngraham, filipf Cc: rikmills, davidedmundson, plasma-devel,

D19821: Fix breeze dialog background with Qt 5.12.2

2019-03-19 Thread Rik Mills
rikmills added a comment. I guess it is very likely, but all the same for the record I will request that this results in a 5.56.2 release of plasma-framework. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt,

D19465: Port to ECM's component/imported target based FindXCB

2019-03-09 Thread Rik Mills
rikmills added a comment. Results in cmake configure build failure on Neon https://build.neon.kde.org/job/bionic_unstable_kde_plasma-desktop_bin_amd64/292/consoleFull REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19465 To: vkrause, apol Cc: rikmills,

D18287: Remove hardcoded /usr/share paths in install

2019-01-16 Thread Rik Mills
rikmills added a comment. Build fails now on Kubuntu Cosim and Disco builds. https://launchpadlibrarian.net/406558385/buildlog_ubuntu-disco-amd64.breeze-gtk_5.14.80+p19.04+git20190117.0641-0_BUILDING.txt.gz > make[3]: Leaving directory

D18244: Check for python-cairo

2019-01-16 Thread Rik Mills
rikmills added a comment. This breaks Neon builds, whereas previously the builds were working as I explicitly had added python3-cairo to the build depends. It is there still, but cmake thinks not. https://build.neon.kde.org/job/bionic_unstable_kde_breeze-gtk_bin_amd64/51/consoleFull

D18005: Include only the largest size for each wallpaper

2019-01-07 Thread Rik Mills
rikmills added a comment. In D18005#387324 , @ngraham wrote: > However, just removing files from the repo doesn't actually remove them from users' machines; their packaging system does that. Perhaps we should alert packagers that for the 5.15

D17359: Fix use of QRegularExpressionMatch

2018-12-26 Thread Rik Mills
rikmills added a comment. I have someone on IRC asking > [12:46] Now got an issue.. Using the Plasma Vault the GUI complains about wrong versions of CryFS and alternatively wrong version of EncFS. I checked with 'apt show cryfs' and 'apt show encfs' and the installed versions are

D17375: Don't automatically refresh if the user already asked apt to do so

2018-12-08 Thread Rik Mills
rikmills added a comment. In D17375#373278 , @ngraham wrote: > That's what I thought. Then it doesn't fully fix 401810, since people not using Kubuntu or Neon will still not have a way to change the update frequency. I don't think this

D17375: Don't automatically refresh if the user already asked apt to do so

2018-12-08 Thread Rik Mills
rikmills added a comment. In D17375#373049 , @ngraham wrote: > This helps for Kubuntu (and Neon ?) users, but what about everyone else? As the original code and this change is apt specific, for non apt distro the updater will continue as

D17375: Don't automatically refresh if the user already asked apt to do so

2018-12-06 Thread Rik Mills
rikmills added a comment. Seems good to me, and a quick test on a stock Kubuntu install gets the updater registering new updates when the system does its own refresh. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17375 To: apol, #kubuntu, sitter,

5.15 New Features notepad

2018-10-19 Thread Rik Mills
On 19/10/2018 13:37, Rik Mills wrote: > notes.kde.org refuses to allow log in Seems to have rectified itself. :)

Re: 5.15 New Features notepad

2018-10-19 Thread Rik Mills
On 19/10/2018 11:18, Jonathan Riddell wrote: > As discussed at the meeting starting the 5.15 new features notepad > early, please add things as you merge them in > https://notes.kde.org/p/plasma_5_15 > > Jonathan > notes.kde.org refuses to allow log in

[ksysguard] [Bug 399637] libksysguard fails to build without QtWebEngine

2018-10-10 Thread Rik Mills
https://bugs.kde.org/show_bug.cgi?id=399637 --- Comment #1 from Rik Mills --- For the record, seeing the same failure on Neon and Kubuntu CI builds of master branch. -- You are receiving this mail because: You are the assignee for the bug.

[ksysguard] [Bug 399637] libksysguard fails to build without QtWebEngine

2018-10-10 Thread Rik Mills
https://bugs.kde.org/show_bug.cgi?id=399637 Rik Mills changed: What|Removed |Added Status|REPORTED|CONFIRMED Ever confirmed|0

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

2018-10-08 Thread Rik Mills
rikmills added a comment. In D16031#339149 , @ngraham wrote: > It's a bit frustrating to spend a lot of time in the phab task (T9658 ) getting consensus on a design, implement it, and then hear, "no, no, major

D15942: Don't drag windows in empty areas from touch/pen events

2018-10-05 Thread Rik Mills
rikmills added a comment. Fails to build on Neon and Kubuntu CI https://build.neon.kde.org/job/bionic_unstable_kde_breeze/71/ 01:20:12 [ 94%] Building CXX object kstyle/CMakeFiles/breeze.dir/breezewindowmanager.cpp.o 01:20:12 kstyle/CMakeFiles/breeze.dir/build.make:982: recipe for

D15717: Fix spelling errors

2018-09-24 Thread Rik Mills
rikmills added a comment. In D15717#330808 , @ngraham wrote: > Landed on master, so the change will show up in KDE Plasma 5.15. See https://community.kde.org/Schedules/Plasma_5 for more information. Why not in 5.14 which also has these

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-20 Thread Rik Mills
rikmills added a comment. In D14869#311997 , @rooty wrote: > P.S. wasn't this problem settled already in T7864 ? No, that's a task on Kubuntu workboard about changing our distro specific defaults.

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Rik Mills
rikmills added a comment. In D14869#309949 , @rkflx wrote: > I fear this will make it better for some people and worse for others, creating nothing but churn. Did you test this with several of said displays? I would agree with that to a

D14869: [RFC] Increase default font sizes by 1 pt

2018-08-16 Thread Rik Mills
rikmills added a comment. Increasing the default font size was suggested for Kubuntu in T7864 I have the same concerns/objections as I did then. As has been mentioned this scales other UI elements like kicker. Having also tested at the time with

D11198: [libbreezecommon] Add box shadow helper

2018-07-16 Thread Rik Mills
rikmills added a comment. In D11198#292783 , @zzag wrote: > @rikmills Should build now. @zzag It does. Thank you REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc:

D13734: Make GConf optional dependency

2018-07-14 Thread Rik Mills
rikmills added a comment. Somehow, in some way, the changes to **src/CMakeLists.txt** are in 5.13 branch, but are missing in master branch. So 5.13 builds ok without gconf, but current master fails to build. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D11198: [libbreezecommon] Add box shadow helper

2018-07-13 Thread Rik Mills
rikmills added a comment. Fails to build from source: https://build.neon.kde.org/job/bionic_unstable_kde_breeze_bin_armhf/44/consoleFull 06:47:17 CMakeFiles/Makefile2:118: recipe for target 'libbreezecommon/CMakeFiles/breezecommon4.dir/all' failed 06:47:17

D13602: Fix tooltip woes

2018-06-22 Thread Rik Mills
rikmills added a comment. I have tested the modified patch on the same environment with Qt 5.10.1 where I found the crash with the previous version in 5.13.0 tars. plasmashell now seems to start without issue on login REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13357: Use logging categories in a few dataengines

2018-06-08 Thread Rik Mills
rikmills added a comment. @davidedmundson Seems so. Thank you. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13357 To: davidedmundson, #plasma, mart Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13357: Use logging categories in a few dataengines

2018-06-07 Thread Rik Mills
rikmills added a comment. Build errors with this: https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.10/44/console https://build.neon.kde.org/job/bionic_unstable_kde_plasma-workspace/102/ https://kci.pangea.pub/job/cosmic_unstable_plasma-workspace/

Re: bugfix in frameworks vital for 5.13

2018-05-15 Thread Rik Mills
On 14/05/18 19:16, Marco Martin wrote: > Hi all, > about https://bugs.kde.org/show_bug.cgi?id=394134 which makes many new kcms > look borked, the problem actually wasn't the upstream qt bug (which is an > issue as well) > but another one which was actually in qqc2-desktop-style > now, since

D10563: Place toolbox in the top right corner of the screen

2018-02-19 Thread Rik Mills
rikmills added a comment. In D10563#209359 , @davidedmundson wrote: > > what "the toolbox' own xml file is ignored > > What xml file? If it's not used, delete it. containments/desktop/package/contents/config/main.xml It

D10429: Disable the title bar separator by default

2018-02-10 Thread Rik Mills
rikmills added a comment. +1 for turning off by default or removing altogether. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10429 To: fvogt, #vdg, #plasma, ngraham Cc: rikmills, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9792: even slimmer scrollbars

2018-01-20 Thread Rik Mills
rikmills added a comment. In https://phabricator.kde.org/D9792#193697, @hpereiradacosta wrote: > In https://phabricator.kde.org/D9792#193473, @rikmills wrote: > > > In Neon and Kubuntu CI with Qt 5.9.3 > > > >

D9792: even slimmer scrollbars

2018-01-19 Thread Rik Mills
rikmills added a comment. In Neon and Kubuntu CI with Qt 5.9.3 https://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/186/console 17:55:15 /workspace/build/kstyle/breezestyle.cpp: In member function ‘virtual bool Breeze::Style::drawScrollBarSliderControl(const

Kwin build failure

2017-11-27 Thread Rik Mills
This morning on stable 5.11 branch in both Neon and Kubuntu CI Thank you https://build.neon.kde.org/job/xenial_stable_plasma_kwin_bin_amd64/241/console 08:06:59 /workspace/build/autotests/integration/decoration_input_test.cpp: In member function ‘void

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

2017-10-24 Thread Rik Mills
rikmills added a comment. I made the same revert to test earlier this morning, and on **brief** testing it seems to have solved the issue, and tests still pass. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D8443 To: fvogt, #plasma, apol Cc:

D8178: Fix editing items in SimpleFavoritesModel

2017-10-08 Thread Rik Mills
rikmills added a comment. Built with the above patch, and on quick testing it seems to resolve the issue for me. I am not a user of activities, so my testing there to make sure existing behaviour on the standard favourites was still the same, may not be as thorough as desirable. REPOSITORY

D7891: expose the colorset for the stylesheet

2017-09-29 Thread Rik Mills
rikmills added a comment. Since this change, polkit-kde-agent-1 fails to build from source with the error: > In file included from /usr/include/KF5/KIconThemes/KIconLoader:1:0, > from /<>/polkit-kde-agent-1-5.10.95+p17.10+git20170929.1419/AuthDialog.cpp:37: >

D7257: Set the QtQuick Controls 1 style name explicitly

2017-08-15 Thread Rik Mills
rikmills added a comment. I don't think it has an effect here, but for completeness just in case, I should mention that both Neon and KDE have a patch to #startkde/startkde.cmake

D7257: Set the QtQuick Controls 1 style name explicitly

2017-08-15 Thread Rik Mills
rikmills added a comment. In https://phabricator.kde.org/D7257#136069, @fvogt wrote: > Does it work with `export QT_QUICK_CONTROLS_1_STYLE=Breeze`? > > I don't know how the style selection of Quick Controls work, maybe someone more knowledgeable in that area could chime in here.

D7257: Set the QtQuick Controls 1 style name explicitly

2017-08-15 Thread Rik Mills
rikmills added a comment. I am seeing this in both Neon dev-unstable edition (Xenial base), and Kubuntu's CI packages (Artful base). Another user is also seeing it in the Kubuntu CI builds. In both I have created a new user and tested under that, which should eliminate any caching

D7257: Set the QtQuick Controls 1 style name explicitly

2017-08-15 Thread Rik Mills
rikmills added a comment. Is this a result of this change? F3863427: d0cb251738.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7257 To: fvogt, #plasma, mart Cc: rikmills, mart, plasma-devel, ZrenBot,

Re: Notice of significant adjustment to KWin

2017-06-09 Thread Rik Mills
Fair enough. I will not poke at that further then. On 09/06/17 21:20, Ben Cooksley wrote: >From my understanding invasive changes were committed without review, > which were similar to changes which had been previously been rejected > in review. > > Regards, > Ben I look forward to good progress

Re: Notice of significant adjustment to KWin

2017-06-09 Thread Rik Mills
Cannot view T6301 (I have a -dev account now), so I am in the dark on the reasons/reasoning for this? Can you elaborate please? On 09/06/17 21:10, Ben Cooksley wrote: > Hi all, > > At the request of the KWin maintainer the KWin repository master > branch has been forcibly rewound to c5861b99

D5910: make shadows work on wayland

2017-06-07 Thread Rik Mills
rikmills added a comment. > ! In https://phabricator.kde.org/D5910#114781, @hpereiradacosta wrote: > Working on fixing it. > Just a couple of ifdef missing. The fix you just pushed seems to have done the trick. Thank you. REPOSITORY R31 Breeze REVISION DETAIL

D5910: make shadows work on wayland

2017-06-07 Thread Rik Mills
rikmills added a comment. This breaks builds on Neon and Kubuntu CI (Qt 5.7.1) http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console 05:10:59 In file included from /workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0, 05:10:59

D5889: Keep QIcon::fromTheme in main thread

2017-06-07 Thread Rik Mills
rikmills added a comment. This breaks build on Neon and Kubuntu CI with Qt 5.7.1 http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console 05:10:59 In file included from /workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0, 05:10:59

D5114: support for high dpi in aurorae

2017-06-04 Thread Rik Mills
rikmills added a comment. In https://phabricator.kde.org/D5114#113943, @luebking wrote: > Just saw this because of a bug report. This one I presume: https://bugs.kde.org/show_bug.cgi?id=380524 The bug affects me on 5.10 (I am comment #1) REPOSITORY R108 KWin REVISION

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-05-12 Thread Rik Mills
This revision was automatically updated to reflect the committed changes. Closed by commit R98:6ac39e82ff06: Set no stepper button for GTK3 scrollbars on gtk >=3.20 (authored by rikmills). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-30 Thread Rik Mills
rikmills added a comment. Checked appearance on 'fixed' Firefox 55 nightly. No apparent regressions with those upstream changes and this change as far as I can see. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D5128 To: rikmills, #plasma Cc:

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-28 Thread Rik Mills
rikmills added a comment. In https://phabricator.kde.org/D5128#98591, @elvisangelaccio wrote: > It seems the upstream firefox bug has been fixed, can you update to commit message? > Anyway +1 for removing the stepper buttons, currently there is an annoying difference between breeze

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-28 Thread Rik Mills
rikmills edited the summary of this revision. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D5128 To: rikmills, #plasma Cc: elvisangelaccio, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-23 Thread Rik Mills
rikmills added a comment. I note that in recent Breeze, the native scrollbar are a fair amount thinner, so maybe a reduction in width here by 2 px may look/match better? e.g. F3154031: a87f589636.png REPOSITORY R98 Breeze for Gtk REVISION

Re: Plasma 5.9.4

2017-03-23 Thread Rik Mills
Re-spun *before* the announcement email @ 14:53 UTC if I recall from IRC. If you grabbed the tarballs beforehand, then yes you may the have ones prior to the respin? On 23/03/17 07:16, Tobias C. Berner wrote: > Hi > > it seems the tarballs were respun after the announcement. Could you in > the

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-22 Thread Rik Mills
rikmills added a reviewer: Plasma. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D5128 To: rikmills, #plasma Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-22 Thread Rik Mills
rikmills created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a workaround to mitigate broken (huge wide) scrollbars in mozilla/Gecko based applications for GTK3 >= 3.20 in versions 52 onwards.

D4956: [Folder View] Lower toolbox when an item is hovered

2017-03-07 Thread Rik Mills
rikmills added a comment. > In https://phabricator.kde.org/D4956#93270, @broulik wrote: > In any way it is an improvement over the status quo. No doubt. Just annoying I can't replicate your result. > It might indeed be beneficial if we place the tool box at the top right corner

D4956: [Folder View] Lower toolbox when an item is hovered

2017-03-07 Thread Rik Mills
rikmills added a comment. In https://phabricator.kde.org/D4956#93275, @broulik wrote: > Are you running plasma-desktop master? There have been many improvements in highlight handling as well as the icon grid layout itself. Just updated and re-applied the patch to make sure.

D4956: [Folder View] Lower toolbox when an item is hovered

2017-03-07 Thread Rik Mills
rikmills added a comment. No, not throwing my mouse cursor at it at all. Starting at: F2753737: c691ba2eef.png then very very very slowly edging towards the toolbox, it triggers about here: F2753741: 80fd4c7b7a.png

D4956: [Folder View] Lower toolbox when an item is hovered

2017-03-06 Thread Rik Mills
rikmills added a comment. Applying this: This seems to work ok when as shown in the video, you have a panel moved to the top of the screen and the pager not moved, so it is partially underneath that panel, shifting the relative location of the icon. However, it does not seem to

Re: plasma-integration/5.9 fails on build.kde.org

2017-01-19 Thread Rik Mills
Reported that issue as: https://bugs.kde.org/show_bug.cgi?id=375290 On 19/01/17 10:00, Rik Mills wrote: > On 18/01/17 17:05, David Edmundson wrote: >> I'm on it. >> >> David > > > Master branch in kubuntu CI now fails with > > /<>/plasma-int

Re: plasma-integration/5.9 fails on build.kde.org

2017-01-19 Thread Rik Mills
On 18/01/17 17:05, David Edmundson wrote: > I'm on it. > > David Master branch in kubuntu CI now fails with /<>/plasma-integration-5.8.5+p17.04+git20170119.0940/src/platformtheme/kdeplatformsystemtrayicon.cpp CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformtheme.cpp.o:

Re: Review Request 129707: Re-symlink duplicate icons weather-fog.svg and weather-overcast.svg

2016-12-26 Thread Rik Mills
: https://git.reviewboard.kde.org/r/129707/diff/ Testing --- Modified source built locally in pbuilder chroot with kubuntu CI package sources. Re-symlinked icons result in dupetest passing and successful build. Thanks, Rik Mills

Review Request 129707: Re-symlink duplicate icons weather-fog.svg and weather-overcast.svg

2016-12-26 Thread Rik Mills
locally in pbuilder chroot with kubuntu CI package sources. Re-symlinked icons result in dupetest passing and successful build. Thanks, Rik Mills

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

2016-10-02 Thread Rik Mills via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=341762 Rik Mills <rik.mill...@gmail.com> changed: What|Removed |Added CC||rik.mill...@gma