broulik added a comment.
Ping.
Also, should we target Plasma/5.6 with that?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1478
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, Plasma, Plasma:
mart added a comment.
+1 from me(provided the commit excludes the osd stuff), would like Martin
taking a final look at this
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1478
EMAIL PREFERENCES
mart added a comment.
In https://phabricator.kde.org/D1478#27445, @colomar wrote:
> Why are those notification even persistent in the first place? If a user
misses the notification, they should notice that the job was finished by the
fact that it's not running anymore.
> Only errors
broulik added a comment.
Please ignore the OSD stuff in the patch :)
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1478
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, Plasma, Plasma: Design,
colomar added a comment.
In https://phabricator.kde.org/D1478#27450, @mck182 wrote:
> So that users may leave long-taking jobs unattended and then click "Open
folder" on the notification or something once they're back and/or the job is
done.
Ah, right, that makes sense.
Not
colomar added a comment.
Why are those notification even persistent in the first place? If a user
misses the notification, they should notice that the job was finished by the
fact that it's not running anymore.
Only errors should be persistent.
REPOSITORY
rPLASMAWORKSPACE Plasma
