[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2017-02-19 Thread Martin Gräßlin
graesslin added a comment. This one is pushed, isn't it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, graesslin, #plasma Cc: andreaska,

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2017-01-09 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > workspaceoptions.cpp:56-58 > +connect(m_ui->showOsd, ::toggled, this, [this] { > +changed(); > +}); why a lambda? It looks like you just could bind it to a signal REPOSITORY R119 Plasma Desktop REVISION DETAIL

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2017-01-09 Thread Kai Uwe Broulik
broulik added a comment. I now used "Visual feedback for status changes" with a tooltip "Show a popup for status changes such as brightness or volume." REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2017-01-09 Thread Kai Uwe Broulik
broulik added a comment. So what text should we go for then? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, graesslin Cc: andreaska,

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2016-09-11 Thread andreaska (Andreas Kainz)
andreaska added a comment. would it help if you add an "screenshot" where you show the information tip and osd? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2016-09-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D1771#50973, @broulik wrote: > Can we have something more concise than "Visual feedback (On-Screen Display) for status changes not triggered via a graphical user interface". Perhaps just "Visual feedback for status changes"?

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2016-09-11 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Can we have something more concise than "Visual feedback (On-Screen Display) for status changes not triggered via a graphical user interface". Perhaps just "Visual feedback for status changes"? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2016-06-22 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Martin is right, OSDs are not only about keyboard shortcuts. They are quite difficult to describe clearly without relying on technical terms, however. Maybe "Visual feedback (On-Screen Display) for status changes not triggered via a graphical user

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2016-06-06 Thread broulik (Kai Uwe Broulik)
broulik added a comment. See https://phabricator.kde.org/D1771 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, graesslin

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2016-06-05 Thread broulik (Kai Uwe Broulik)
broulik added a comment. F143325: Screenshot_20160605_203840.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1771 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: