[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2223#41241, @colomar wrote: > Even in some minutes, quite a few notifications can pile up in the queue if you do lots of operations. > This would only be acceptable if they could all be collapsed into a single notification, but I

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2223#41238, @mart wrote: > if they would auto clear, but still stay for some minutes, i would be fine Even in some minutes, quite a few notifications can pile up in the queue if you do lots of operations. This would only

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread mart (Marco Martin)
mart added a comment. if they would auto clear, but still stay for some minutes, i would be fine REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2223 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. @mart If you started a file transfer job at some point and now you neither have a progress indicator anymore, nor see an error message, what is supposed to have happened other than that it succeeded? Of all the file transfer job, the vast majority will complete

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread mart (Marco Martin)
mart added a comment. (no, don't like it) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2223 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, graesslin Cc: mart,

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread broulik (Kai Uwe Broulik)
broulik added a comment. You do know, except it won't stick around forever (I got the habit of copying files, then clearing the notification history, it's so tedious). If something went wrong you'll either have the persistent error notification or a KIO error dialog anyway... REPOSITORY

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread mart (Marco Martin)
mart added a comment. so i don't know what happened to the files i was copying, meh :( REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2223 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > graesslin wrote in Jobs.qml:88 > why !! !! is the JavaScript-way of casting to a bool, error is the KIO error number. I could do Boolean(error) or error ? true : false if you like. I do a toBool() in the notification action but I'd prefer being

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1 from me (of course, since it was my request ;) ) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2223 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,