[Differential] [Commented On] D2449: small utility to create L packages

mart added inline comments. INLINE COMMENTS > aspotashev wrote in lnflogic.cpp:66 > Double space here in "Plasma Look And Feel". fixed REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES

[Differential] [Commented On] D2449: small utility to create L packages

mart added a comment. https://phabricator.kde.org/D2505 REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: colomar, davidedmundson,

[Differential] [Commented On] D2449: small utility to create L packages

mart added a comment. In https://phabricator.kde.org/D2449#46744, @colomar wrote: > In https://phabricator.kde.org/D2449#46736, @mart wrote: > > > > > > 2. Instant save in an edit field cannot really be done predictably, as the user can never tell exactly when it's saved

[Differential] [Commented On] D2449: small utility to create L packages

colomar added a comment. In https://phabricator.kde.org/D2449#46736, @mart wrote: > > it's instant save, some pieces couldn't be done differently at the moment Hm, I think that's a problem. 1. Instant apply is not a common pattern in KDE software at all and

[Differential] [Commented On] D2449: small utility to create L packages

mart added a comment. In https://phabricator.kde.org/D2449#46735, @colomar wrote: > Thanks! > Feedback: > > - The lineedits should be made long enough to actually hold the whole content (for the comment, maybe a textbox would be better?), because editing in a field which is too

[Differential] [Commented On] D2449: small utility to create L packages

colomar added a comment. Thanks! Feedback: - The lineedits should be made long enough to actually hold the whole content (for the comment, maybe a textbox would be better?), because editing in a field which is too small for the content is really annoying. - How does one save

[Differential] [Commented On] D2449: small utility to create L packages

mart added a comment. http://imgur.com/a/jAKSv REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, #plasma Cc: colomar, davidedmundson,

[Differential] [Commented On] D2449: small utility to create L packages

colomar added a comment. Can you please provide screenshots of the tool? Yes, even developer-centric tools should get a UI review ;) REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES

[Differential] [Commented On] D2449: small utility to create L packages

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in lnflogic.cpp:155 > Edit: This kwin saving stuff is *still* wrong. > > In systemCG (kwinrc) it is "TabBox". > However, in the LnF it is "WindowSwitcher." > > You "fixed" the wrong one. > > You are also missing

[Differential] [Commented On] D2449: small utility to create L packages

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.cpp:70 > UncreatableType * 2 I think in this case it's betterthis form, as i don't want to give an url to it, i just want properties of those instances to be readable REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL

[Differential] [Commented On] D2449: small utility to create L packages

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:43 > If you're going to poke me on IRC to review something, I don't expect to see > FIXMEs that you haven't investigated. ouch, that was actually coming from copy and paste of another application (which i'll have