[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

graesslin added inline comments. INLINE COMMENTS > sebas wrote in compositing.ui:9 > So your change made the window's minimum width more than 300px wider? That > sounds wrong... > > What I mean is to resize the form in designer to the smallest possible size > before you save it there,

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

luebking added inline comments. INLINE COMMENTS > sebas wrote in compositing.ui:9 > So your change made the window's minimum width more than 300px wider? That > sounds wrong... > > What I mean is to resize the form in designer to the smallest possible size > before you save it there, perhaps

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

graesslin added inline comments. INLINE COMMENTS > sebas wrote in options.h:193 > without the is* ? (It's not required by QML, unlike Thomas suggests) Using is in the case of boolean getters is normally correct. This follows the property naming suggestions by Qt. Please see

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

colomar added inline comments. INLINE COMMENTS > compositing.ui:291 > + This brings performance improvement for e.g. games. > + The setting can be overruled by window specific rules. > + window-specific REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

luebking added a comment. They'll unredirect the window. The property is however not mandarory: "The compositing manager MAY bypass compositing for both fullscreen and non-fullscreen windows if bypassing is requested" (the supplemental "but MUST NOT bypass if it would cause differences

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

colomar added a comment. In https://phabricator.kde.org/D2584#48381, @broulik wrote: > Plasma is the only major desktop environment that still supports a non-composited uscase. Unity and Gnome cannot disable it in the first place. Oh, so they just ignore that request from

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

broulik added a comment. Plasma is the only major desktop environment that still supports a non-composited uscase. Unity and Gnome cannot disable it in the first place. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL PREFERENCES

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

colomar added a comment. Actually, I'm not really convinced of this. Blocking compositing is done via an official, cross-desktop API, isn't it? It's not a KWin-specific feature, right? If so, then KWin should not go alone in offering this config option. If I'm an application developer and

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

graesslin added inline comments. INLINE COMMENTS > luebking wrote in compositing.h:63 > The "is" prefix is a QML mandate, right? > > isObeyingCompositorBlockRequests > isCompositorBlockAllowed > > However, afaiu the biggest complaint was that it was broken (due to shadow > deletion) yesno?

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

mart added a comment. yeah, should be "allow applications" even if not 100% correct REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, #vdg

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

graesslin added a comment. F269479: Spectacle.Z21567.png REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,