[Differential] [Commented On] D3616: [Lock Screen / Login] Add "reveal password button"

2016-12-10 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1 for the patch (I don't think the icon is close enough to the login button to be problematic) Also +1 for disabling "show password" buttons in general via Kiosk REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3616 EMAIL

[Differential] [Commented On] D3616: [Lock Screen / Login] Add "reveal password button"

2016-12-07 Thread broulik (Kai Uwe Broulik)
broulik added a comment. One thing we perhaps should do is add a kiosk restriction to globally disable this button everywhere. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3616 EMAIL PREFERENCES

[Differential] [Commented On] D3616: [Lock Screen / Login] Add "reveal password button"

2016-12-07 Thread cfeck (Christoph Feck)
cfeck added a comment. Using that argument, we would have to remove the 'reveal password' option from KPasswordDialog, too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3616 EMAIL PREFERENCES

[Differential] [Commented On] D3616: [Lock Screen / Login] Add "reveal password button"

2016-12-07 Thread subdiff (Roman Gilg)
subdiff added a comment. On one hand: Yea, why not. On the other imagine the following situation: Two people sit in front of the PC, and one of them wants to login to the PC. After entering his password, he accidently hits the "show password" icon (since it's pretty near to the