D17467: digital-clock: Show events on initial expansion for all time zones

2018-12-13 Thread Marcus Behrendt
mbehrendt added inline comments. INLINE COMMENTS > mart wrote in CalendarView.qml:60 > another way you can try is to do it on Component.onCompleted: { } Yes I laready considered that. But when I tried your suggestion, I figured out what the real problem was that the events are initially not

D17467: digital-clock: Show events on initial expansion for all time zones

2018-12-13 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > mbehrendt wrote in CalendarView.qml:60 > No, the model initially seems to be an empty list. another way you can try is to do it on Component.onCompleted: { } REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17467

D17467: digital-clock: Show events on initial expansion for all time zones

2018-12-11 Thread Marcus Behrendt
mbehrendt marked an inline comment as done. mbehrendt added inline comments. INLINE COMMENTS > mart wrote in CalendarView.qml:60 > instead of storing a local hasExpanded, could you just check for > holidaysList.model not being null? No, the model initially seems to be an empty list.