D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham added a comment. In D17906#389914 , @mart wrote: > I wonder if it shouldn't be something in the future eventually part of the theme, I see things like menu font and toolbar font in fonts kcm as something completely obsolete, while those

D17906: [kirigami] Do not use light font styles for headings (2/3)

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e5d392cb79f9: [kirigami] Do not use light font styles for headings (2/3) (authored by filipf, committed by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham added a comment. Yep, will do. We have other diffs for those. REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks, mart Cc: fabianr, rooty, #frameworks,

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. so, if this is pushed, the same thing should happen at the same time to the corresponding plasma components REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma,

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart accepted this revision. mart added a comment. bah, seems very tricky to make it work properly across distributions. to me, it speaks mostly as a failure for us to control the look of our product, due to broken fonts in distros and qt font rendering still buggy, issue that

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. In D17906#389751 , @fabianr wrote: > You are not using the default font, are you? In D17906#389713 , @mart wrote: > uuh, that's the wrong color.. that's

D17906: [kirigami] Do not use light font styles for headings (2/3)

fabianr added a comment. In D17906#388294 , @filipf wrote: > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. > > F6531867: image.png > > F6531893: image.png

D17906: [kirigami] Do not use light font styles for headings (2/3)

fabianr added a comment. The HIG states: "When the visual design calls for an area of exceptional focus, a larger typeface size may be used. In this case use a Light typeface weight to keep the stroke width similar to other styles throughout the interface" I think, if you want to have

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#388803 , @ngraham wrote: > F6531451: Screenshot_20190107_145258.png > In this one, the fact that it's a header is connoted by its much larger font size and wider

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#388294 , @filipf wrote: > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. > > F6531867: image.png > > F6531893: image.png

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham added a comment. F6531451: Screenshot_20190107_145258.png In this one, the fact that it's a header is connoted by its much larger font size and wider character width and spacing. It feels "bigger" in every way than the text beneath it. It

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same problem. F6531867: image.png For me this represented a massive regression, and there's bound to be more people in a similar situation. We can't

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. In D17906#388104 , @rooty wrote: > In D17906#388052 , @mart wrote: > > > can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go

D17906: [kirigami] Do not use light font styles for headings (2/3)

rooty added a comment. In D17906#388052 , @mart wrote: > can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go to levels from 2 onwards where needed smaller and bigger? nope, very much

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. I was actually just going to reply that light titles could work theoretically well with level 1 headings before I saw your last comment. For this to work right, for me it would mean: - certain adjustments for visual hierarchy; big headings must still retain

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go to levels from 2 onwards where needed smaller and bigger? REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. in the end i *may* accept non light titles, even tough i still very much don't like the idea, but what i don't want to never, ever see in any circumstance is bold titles, anything of that will just be reverted. REPOSITORY R169 Kirigami BRANCH no-light-headings

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#385968 , @ngraham wrote: > - **Implementation inconsistency:** Many fonts don't have a dedicated light style, many distros don't ship them if they do, and Qt < 5.12 doesn't use them even if nope, with

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. In D17906#385857 , @filipf wrote: > With the exception of the case of the Windows Store (which does nonetheless manage to achieve some visual hierarchy with different font sizes and colors), others mostly actually have an

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham added a subscriber: rooty. ngraham added a comment. Aesthetics are admittedly subjective, though I must note that pretty much all of VDG is in favor of moving away from light header text for aesthetic reasons. However there are other important technical arguments as well, which I

D17906: [kirigami] Do not use light font styles for headings (2/3)

filipf added a comment. In D17906#385682 , @mart wrote: > I'm very much against this, I think it looks very bad :/ I think the idea to have a light style for big titles is nice and could theoretically work, but in our case unfortunately

D17906: [kirigami] Do not use light font styles for headings (2/3)

abetts added a comment. Goodness, I think this is all about taste. I am more on the side that it looks good. It visually prioritizes hierarchy with labels. @mart Does it just look bad for you or do you think this will cause issues somewhere else? REPOSITORY R169 Kirigami BRANCH

D17906: [kirigami] Do not use light font styles for headings (2/3)

mart added a comment. I'm very much against this, I think it looks very bad :/ REPOSITORY R169 Kirigami BRANCH no-light-headings (branched from master) REVISION DETAIL https://phabricator.kde.org/D17906 To: filipf, ngraham, #plasma, #vdg, #frameworks Cc: mart, plasma-devel,

D17906: [kirigami] Do not use light font styles for headings (2/3)

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Strongly approve for all the reasons given in https://bugs.kde.org/show_bug.cgi?id=402730. Let's wait a bit though to make sure the #plasma