D18018: [Digital Clock] Add ability to change first day of week

mart added a comment. -1 on this in particular +1 for having it system wide REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18018 To: Zren, #plasma Cc: mart, abetts, pino, davidedmundson, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel,

D18018: [Digital Clock] Add ability to change first day of week

Zren added a comment. In D18018#387920 , @davidedmundson wrote: > Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide? https://bugs.kde.org/show_bug.cgi?id=390330#c5 > Just

D18018: [Digital Clock] Add ability to change first day of week

abetts added a comment. +1 How was this not an option ever? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18018 To: Zren, #plasma Cc: abetts, pino, davidedmundson, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18018: [Digital Clock] Add ability to change first day of week

pino added inline comments. INLINE COMMENTS > configCalendar.qml:68 > +model.append({ > +text: i18n("Default"), > +value: -1, this needs a context (using i18nc), otherwise translators have no idea what "Default" means REPOSITORY R120

D18018: [Digital Clock] Add ability to change first day of week

davidedmundson added a comment. Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18018 To: Zren, #plasma Cc: davidedmundson, ngraham,

D18018: [Digital Clock] Add ability to change first day of week

ngraham added inline comments. INLINE COMMENTS > configCalendar.qml:56 > +id: firstDayOfWeekComboBox > +Kirigami.FormData.label: i18n("First day of week:") > +// [-1, 0, 1, 2, 3, 4, 5, 6] // Default = -1, 0..6 = Sun..Sat I'd add a "the" and make this "First

D18018: [Digital Clock] Add ability to change first day of week

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY CCBUG: 390330 The Qt enum can have Sunday value of 0 or 7, so we start the enum at -1 to represent the locale's default value.