D18645: BasicListItem: use specified tint color when transparency is 0

pwegner added a comment. This can be closed; the icons in cloudbrowser are no longer tinted. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18645 To: pwegner, #kirigami, mart Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. I tried to add every single path in the system where there is pkgconfig stuff, but same result, the cloudbrowser folder doesn't get built and there is the invalid command -o message still REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18645

D18645: BasicListItem: use specified tint color when transparency is 0

pwegner added a comment. Sorry for not creating a bug report.. Your build issue might be caused by pkg-config not being able to find moc. You might have to set PKG_CONFIG_LIBDIR / PKG_CONFIG_PATH accordingly. Here is the logic for detecting where moc is:

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. In D18645#456718 , @pwegner wrote: > https://github.com/KDE/kirigami/commit/c0f2a341a4c9e947cbb2ca914ba36a31728b05c4 > > This commit broke my app. It is too big for me to find a bug in there. > The app in question

D18645: BasicListItem: use specified tint color when transparency is 0

pwegner added a comment. https://github.com/KDE/kirigami/commit/c0f2a341a4c9e947cbb2ca914ba36a31728b05c4 This commit broke my app. It is too big for me to find a bug in there. The app in question is available here:

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. so, now the decision when to color an icon and when not should be a bit smarter... is this still necessary? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18645 To: pwegner, #kirigami, mart Cc: plasma-devel, domson, dkardarakos, apol,

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. I think i'll introduce an heuristic to analyze the image and decide if it's monochrome and drop all this transparent nonsense (would make it a bit inefficient as it wuld need to read pixels colors in software but may be justified). locally i was trying with Shannon

D18645: BasicListItem: use specified tint color when transparency is 0

pwegner added a comment. In the current master I get `file:///home/lemourin/.qt/5.12.1/gcc_64/qml/org/kde/kirigami.2/private/GlobalDrawerActionItem.qml:39:5: Unable to assign [undefined] to QColor` (probably related to some other change). Anyway, tinting can be disabled now after your

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. can you try on kirigami master? i did a similar thing the other day with commit 015e1d0ac19e4 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18645 To: pwegner,

D18645: BasicListItem: use specified tint color when transparency is 0

pwegner created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. pwegner requested review of this revision. REVISION SUMMARY This allows to disable icon tinting through setting tint color to transparent. REPOSITORY R169 Kirigami REVISION DETAIL