ognarb updated this revision to Diff 52125.
ognarb marked 2 inline comments as done.
ognarb added a comment.
- use Controls namespace
- use ActionTextField instead of TextField
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18716?vs=51215=52125
BRANCH
ognarb added a comment.
@mart thanks for the review, I don't have enough time this weekend, but I
will start working on it next Tuesday :)
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D18716
To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol,
mart added inline comments.
INLINE COMMENTS
> mart wrote in TextField.qml:106
> text will go under both buttons, in order to avoid that, probably anchors
> should be added to the TextField's contentItem to make space for the buttons.
err, TextField is not a Control, right.
so, it should set
mart added a comment.
also, the name should possibily not conflict with QQC2 TextField, like
ActionTextField or something like that.
INLINE COMMENTS
> TextField.qml:21
> +import QtQuick 2.5
> +import QtQuick.Controls 2.1
> +import org.kde.kirigami 2.4 as Kirigami
always namespace the
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> TextField.qml:74
> + */
> +property QtObject rightAction
> +
I would like those to actually be lists as we do have use cases for more than
one icon
ognarb added inline comments.
INLINE COMMENTS
> TextField.qml:101
> +}
> +icon.name: root.leftAction != null ? root.rightAction.iconName : ""
> +visible: root.leftAction != null && root.leftAction.visible
@mart I'm not sure if it's the right way to convert the icon from
