This revision was automatically updated to reflect the committed changes.
Closed by commit R871:3102b477d03d: CMakeLists: Fix bfd.h include path on
windows (authored by patrickelectric).
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18801?vs=51360=51361
patrickelectric updated this revision to Diff 51360.
patrickelectric added a comment.
Fix Tomaz
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18801?vs=51256=51360
BRANCH
arcpatch-D18801
REVISION DETAIL
https://phabricator.kde.org/D18801
AFFECTED
tcanabrava accepted this revision.
tcanabrava added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:71
> +find_path(BFD_INCLUDE_DIR bfd.h)
> +include_directories("${BFD_INCLUDE_DIR}")
> endif()
you don't need the quotes here.
patrickelectric updated this revision to Diff 51256.
patrickelectric added a comment.
update commit message
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18801?vs=51067=51256
BRANCH
arcpatch-D18801
REVISION DETAIL
https://phabricator.kde.org/D18801
patrickelectric added a comment.
@mart commit message updated.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D18801
To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed,
mart added a comment.
needs longer commit message
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D18801
To: patrickelectric, davidedmundson, tcanabrava, ngraham
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed,
